Re: [Geotools-devel] SchemaCache timeout error

2013-05-23 Thread Andrea Aime
On Thu, May 23, 2013 at 5:48 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: Mauro, your improvements to SchemaCache have also introduced an unanticipated problem triggered by download failure: https://jira.codehaus.org/browse/GEOT-4467 You set a 10 second timeout on connections

Re: [Geotools-devel] SchemaCache timeout error

2013-05-23 Thread Ben Caradoc-Davies
On 23/05/13 14:26, Andrea Aime wrote: On Thu, May 23, 2013 at 5:48 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au mailto:ben.caradoc-dav...@csiro.au wrote: http://www.w3.org/2001/xml.xsd Ah, this one is a nightmare, it's always super-slow to download (I guess because anything XML

Re: [Geotools-devel] SchemaCache timeout error

2013-05-23 Thread Mauro Bartolomeoli
2013/5/23 Andrea Aime andrea.a...@geo-solutions.it On Thu, May 23, 2013 at 5:48 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: Mauro, your improvements to SchemaCache have also introduced an unanticipated problem triggered by download failure:

Re: [Geotools-devel] SchemaCache timeout error

2013-05-23 Thread Mauro Bartolomeoli
2013/5/23 Ben Caradoc-Davies ben.caradoc-dav...@csiro.au On 23/05/13 14:26, Andrea Aime wrote: On Thu, May 23, 2013 at 5:48 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au mailto:Ben.Caradoc-Davies@**csiro.auben.caradoc-dav...@csiro.au wrote: http://www.w3.org/2001/xml.xsd Ah,

Re: [Geotools-devel] SchemaCache timeout error

2013-05-23 Thread Ben Caradoc-Davies
On 23/05/13 15:20, Mauro Bartolomeoli wrote: 2013/5/23 Ben Caradoc-Davies ben.caradoc-dav...@csiro.au mailto:ben.caradoc-dav...@csiro.au On Thu, May 23, 2013 at 5:48 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au mailto:Ben.Caradoc-Davies@__csiro.au

Re: [Geotools-devel] SchemaCache timeout error

2013-05-23 Thread Mauro Bartolomeoli
Hi Ben, (2) Please look at the logic in SchemaCache.startDownload(). Why is it necessary to create an empty file? How should SchemaCache recover when a download fails? Please have a look and recommend a solution. I know you gave this some thought and I do not want to introduce a deadlock or

Re: [Geotools-devel] (E)CQL DE9IM_PATTERN token conflicts with INTEGER token (GEOT-4211)

2013-05-23 Thread Jan De Moerloose
For backward compatibility, it might be an option to change the order of the token evaluations of INTEGER and DE9IM_PATTERN. An DE9IM_PATTERN consisting of all integers is extremely unlikely, so it might be better to change the parser order by putting DE9IM_PATTERN after INTEGER. People that

Re: [Geotools-devel] (E)CQL DE9IM_PATTERN token conflicts with INTEGER token (GEOT-4211)

2013-05-23 Thread Andrea Aime
On Thu, May 23, 2013 at 11:10 AM, Jan De Moerloose jan.demoerlo...@geosparc.com wrote: For backward compatibility, it might be an option to change the order of the token evaluations of INTEGER and DE9IM_PATTERN. An DE9IM_PATTERN consisting of all integers is extremely unlikely, so it might

Re: [Geotools-devel] SLD and Internationalization

2013-05-23 Thread Mauro Bartolomeoli
Hi all, I think I can prepare a patch for this shortly using the last variant proposed by Andrea (I did some testing patching the SLDParser and everything seems to work well). I would use the free text (not included in a value tag) as the default value if no locale is specified. So, something

Re: [Geotools-devel] SLD and Internationalization

2013-05-23 Thread Andrea Aime
On Thu, May 23, 2013 at 11:48 AM, Mauro Bartolomeoli mauro.bartolome...@geo-solutions.it wrote: Hi all, I think I can prepare a patch for this shortly using the last variant proposed by Andrea (I did some testing patching the SLDParser and everything seems to work well). I would use the

[Geotools-devel] H2 and Hatbox in GeoTools

2013-05-23 Thread Vitali Dyachkov
Hello. Simple question: is it so that table in H2 databse may have only 1 geometry column ? Has anyone faced with this restriction? Vitali. -- Try New Relic Now We'll Send You this Cool Shirt New Relic is the only

Re: [Geotools-devel] H2 and Hatbox in GeoTools

2013-05-23 Thread Justin Deoliveira
Hi Vitali, Indeed it does look like it is only possible to create a single hatbox index per table. Although its possible to create a table with multiple geometry columns, the first being the one that receives the index. This is something relatively easily fixable. Could you open a jira ticket

Re: [Geotools-devel] SchemaCache timeout error

2013-05-23 Thread Ben Caradoc-Davies
Mauro, 30 seconds sounds like a generous default. Maybe even 60 seconds for the paranoid? I think your decision to have a timeout is excellent, as a thread could otherwise block indefinitely, which would be very, very bad for a service such as GeoServer. Kind regards, Ben. On 23/05/13

Re: [Geotools-devel] SchemaCache timeout error

2013-05-23 Thread Ben Caradoc-Davies
Mauro, I do not like the exception swallowing in SchemaCache.download(). You changed to original: throw new RuntimeException(e); to return null; in the catch block. While this will result in a failed download and an exception higher up that includes a URL report, precise network or DNS