[Geotools-devel] App-schema module maintainer

2014-10-20 Thread Rini.Angreani
Hi, As some of you may be aware, I am starting my year long hiatus (maybe more) in 2 days. When I return as a part timer, I don't know how much time I will have for GeoServer. Therefore, I am stepping down from app-schema module maintainer role. Ciao for now, and thanks for all your help so

Re: [Geotools-devel] App-schema, xlinks, and curves

2014-07-15 Thread Rini.Angreani
It's also done in gml2/GMLEncodingUtils.GeometryPropertyType_getProperty. Cheers Rini -Original Message- From: Caradoc-Davies, Ben (Mineral Resources, Kensington) Sent: Tuesday, 15 July 2014 12:25 PM To: Andrea Aime Cc: Geotools-Devel list; Angreani, Rini (Mineral Resources, Kensington)

Re: [Geotools-devel] contribution agreement question

2014-01-23 Thread Rini.Angreani
Hi Jody, The trouble is he wasn't working for CSIRO, but I helped review the patches. We cc'ed the manager etc. from the organisation, but didn't get any response (re: contribution agreement). If I modify them, would I be able to submit these files, and put both our names down (with respective

Re: [Geotools-devel] contribution agreement question

2014-01-23 Thread Rini.Angreani
Hi Jody, That sounds sensible. The pull request is under the author's name, and also the reporter in the JIRA ticket. Thanks! Rini From: Jody Garnett [mailto:jody.garn...@gmail.com] Sent: Friday, 24 January 2014 4:11 AM To: Angreani, Rini (CESRE, Kensington) Cc: GeoTools Developers list

[Geotools-devel] contribution agreement question

2014-01-22 Thread Rini.Angreani
Hi, A while back ago Geoff Williams submitted a patch with unit tests. Since the unit tests contained new files, we weren't able to submit them without a contribution agreement signed (and he has since left the organisation). I am working on something related to his patch, and wonder if I

[Geotools-devel] gt-jdbc-oracle test failure

2013-12-19 Thread Rini.Angreani
Hi Andrea, I suspect one of your recent commits broke our build: https://github.com/geotools/geotools/commit/328165b90b7f431ffa7645ee72de84cda3cf6d8a. We build with -Doracle, therefore runs all the tests in gt-jdbc-oracle. Build failure:

[Geotools-devel] CSV support for app-schema

2013-12-05 Thread Rini.Angreani
Hi Jody and list, I am looking at enabling csv outputFormat for complex features. Seeing that you're the module maintainer of gt-csv, I thought of emailing you first. The current intention is to support csv support for flat features (SF0) with portrayal application schemas. For example,

Re: [Geotools-devel] CSV support for app-schema

2013-12-05 Thread Rini.Angreani
Hi Andrea, You're right. I had a quick look, saw gt-csv and assumed it is behind it. So it's just in GeoServer CSVOutputFormat, it should be a lot simpler. Can I submit the patch to you then? Apologies for the confusion. Cheers Rini From: andrea.a...@gmail.com [mailto:andrea.a...@gmail.com] On

Re: [Geotools-devel] uomLabels in gml 3.2

2013-07-18 Thread Rini.Angreani
Thanks Justin. I will create a JIRA issue and assign it to you for review when it's ready. From: Justin Deoliveira [mailto:jdeol...@opengeo.org] Sent: Thursday, 18 July 2013 9:56 PM To: Angreani, Rini (CESRE, Kensington) Cc: Geotools-Devel list Subject: Re: uomLabels in gml 3.2 Hey Rini, This

[Geotools-devel] uomLabels in gml 3.2

2013-07-17 Thread Rini.Angreani
Hi Justin, I am trying to get uomLabels to appear in LineString, based on GML 3.2: http://schemas.opengis.net/gml/3.2.1/geometryBasic0d1d.xsd. (Actually from GML 3.1.0 onwards). I can see if I make changes to AbstractGeometryTypeBinding, it will create the same problem with srsDimension (where

Re: [Geotools-devel] removing xerces dependency

2013-01-30 Thread Rini.Angreani
Hi, I managed to dig the original issue for the test: http://jira.codehaus.org/browse/GEOT-3493. The original behaviour was to swallow the exception and quietly display an empty result. This is not an acceptable behaviour as it would be frustrating for the users to find the configuration

Re: [Geotools-devel] proposal: Separate general complex feature classes from gt-app-schema

2012-12-18 Thread Rini.Angreani
Thanks Niels. I'll take a look later. -Original Message- From: Niels Charlier [mailto:ni...@scitus.be] Sent: Wednesday, 19 December 2012 8:31 AM To: Caradoc-Davies, Ben (CESRE, Kensington) Cc: Jody Garnett; geotools-devel@lists.sourceforge.net; Angreani, Rini (CESRE, Kensington)

Re: [Geotools-devel] WPS with R module

2012-06-06 Thread Rini.Angreani
Hi Andrea, Actually you're right. I should do this in GeoTools (cc-ing geotools devel instead). Originally I thought I'd need a dependency to wps-core, but it's the other way around. Also the classes I'm interested in are covered by GPL-2, therefore forcing a GPL license on my code. Would that

Re: [Geotools-devel] Missing srsName from geometry

2012-06-05 Thread Rini.Angreani
Brett, that's great! Rini From: Brett Walker [mailto:brett.wal...@geometryit.com] Sent: Wednesday, 6 June 2012 11:22 AM To: Angreani, Rini (CESRE, Kensington); geotools-devel@lists.sourceforge.net; s...@lists.csiro.au Cc: g.willia...@bom.gov.au Subject: RE: Missing srsName from geometry Hi

Re: [Geotools-devel] Missing srsName from geometry

2012-06-04 Thread Rini.Angreani
Hi Brett, In AbstractGeometryTypeBinding: public Object getProperty(Object object, QName name) throws Exception { Geometry geometry = (Geometry) object; if (srsName.equals(name.getLocalPart())) { CoordinateReferenceSystem crs =

Re: [Geotools-devel] svn config file missing? hudson fails as result

2012-05-27 Thread Rini.Angreani
Hi, Sorry about that. Can I update source.rst to point to build/subversion/config instead? It’s the latest one. Rini From: Jody Garnett [mailto:jody.garn...@gmail.com] Sent: Monday, 28 May 2012 9:34 AM To: Angreani, Rini (CESRE, Kensington) Cc: GeoTools Developers list Subject: Re:

Re: [Geotools-devel] svn config file missing? hudson fails as result

2012-05-27 Thread Rini.Angreani
Done. Sorry for the inconvenience caused. From: Jody Garnett [mailto:jody.garn...@gmail.com] Sent: Monday, 28 May 2012 10:24 AM To: Angreani, Rini (CESRE, Kensington) Cc: geotools-devel@lists.sourceforge.net Subject: Re: [Geotools-devel] svn config file missing? hudson fails as result Sure! Do

Re: [Geotools-devel] GML3EncodingTest Failing

2012-04-17 Thread Rini.Angreani
Hi, I'm using Windows 7, Java version: 1.6.0_13 with the latest code. I don't see the test failure, so it could be a bug with Java update 24. Cheers Rini -Original Message- From: Caradoc-Davies, Ben (CESRE, Kensington) Sent: Wednesday, 18 April 2012 10:07 AM To: Brett Walker Cc:

Re: [Geotools-devel] Build failed in Hudson: geotools-trunk #4242

2012-01-04 Thread Rini.Angreani
Done. Thanks Justin. From: Justin Deoliveira [mailto:jdeol...@opengeo.org] Sent: Thursday, 5 January 2012 11:30 AM To: Angreani, Rini (CESRE, Kensington) Cc: geotools-devel@lists.sourceforge.net Subject: Re: [Geotools-devel] Build failed in Hudson: geotools-trunk #4242 Works for me rini. Please

Re: [Geotools-devel] polymorphism and rendering

2010-12-20 Thread Rini.Angreani
Thanks Andrea and Gabriel. I think we sorted this out using the XSDElementDeclaration that's smuggled inside the descriptor userData. From the element and the schemas, we can find all the possible substitutions. This is how polymorphic/substituted attributes are encoded :) Cheers Rini

Re: [Geotools-devel] feature validation switch

2010-10-21 Thread Rini.Angreani
Cool. Committed to trunk :). -Original Message- From: Jody Garnett [mailto:jody.garn...@gmail.com] Sent: Thursday, 21 October 2010 4:43 PM To: Angreani, Rini (CESRE, Kensington) Cc: geotools-devel@lists.sourceforge.net Subject: Re: [Geotools-devel] feature validation switch +1 from me

Re: [Geotools-devel] recent changes to property access on the stable branch?

2010-10-20 Thread Rini.Angreani
Thanks Jody. We'll make sure changes to branches are restricted to app-schema, unless really needed, in which case it should be discussed beforehand. From: Jody Garnett [mailto:jody.garn...@gmail.com] Sent: Thursday, 21 October 2010 5:35 AM To: Justin Deoliveira

[Geotools-devel] Nominate Niels Charlier for commit access

2010-10-12 Thread Rini.Angreani
Hi, I'd like to nominate my colleague Niels Charlier for commit access. Niels is part of our team at CSIRO and is covered by CSIRO copyright assignment. He has been working on GeoTools and GeoServer app-schema improvements, and been active with the mailing list discusssions. He contributed a

Re: [Geotools-devel] Mapping an optional element whose attributes are not optional

2010-10-05 Thread Rini.Angreani
You can only use functions to skip the attribute if you use the feature chaining syntax. I said syntax, because you can omit linkField, therefore it's not really chaining it and won't generate the extra joining queries, it only recycles the syntax.

Re: [Geotools-devel] Mapping an optional element whose attributes are not optional

2010-10-05 Thread Rini.Angreani
OK Victor pointed out that your attributes x and y have minOccurs = 0, and that they should be skipped. He actually put in a logic that will skip the parent's attributes if the children are missing (skipped) and the parent itself is nillable. However, this is done after the feature is built,

Re: [Geotools-devel] Mapping an optional element whose attributes are not optional

2010-10-05 Thread Rini.Angreani
Yes actually that'd be a good idea, since there's already validation at the end of creating a complex feature (cleanEmptyElements). It also checks for xlink:href there, so it should cover all our problems. The problem is the validation is called inside AttributeImpl() which is a super class of

Re: [Geotools-devel] Mapping an optional element whose attributes are not optional

2010-10-05 Thread Rini.Angreani
That would be great :-D. I have always thought it's a core code thing that affects everything, so didn't even think of proposing to remove it. :D -Original Message- From: andrea.a...@gmail.com [mailto:andrea.a...@gmail.com] On Behalf Of Andrea Aime Sent: Tuesday, 5 October 2010 5:55

Re: [Geotools-devel] handling of geometry crs

2010-07-29 Thread Rini.Angreani
You're right, I've seen the inconsistencies with userData used as a Map, and otherwise in different places. Anyway, I tried my idea for the simple fix, but it won't work, since it requires more changes in different bindings all over the place. The fix in GML2EncodingUtils I suggested would only

Re: [Geotools-devel] handling of geometry crs

2010-07-29 Thread Rini.Angreani
Hi Jody, You're quite right, apparently the GML spec said that srsName is inherited from enclosing elements. Sorry for not checking earlier. I'll attach the patch then. Thanks Rini -Original Message- From: Jody Garnett [mailto:jody.garn...@gmail.com] Sent: Thursday, 29 July 2010 9:04

Re: [Geotools-devel] handling of geometry crs

2010-07-27 Thread Rini.Angreani
Hi Justin, I like your second idea, and it is actually similar to the patch Jody whipped up (http://jira.codehaus.org/secure/attachment/50280/GML2EncodingUtils.patch). Since AbstractFeatureTypeBinding.getProperties() eventually calls GML2EncodingUtils.getProperties() anyway, we can make the

Re: [Geotools-devel] handling of geometry crs

2010-07-21 Thread Rini.Angreani
Thanks Jody, I didn't think of that before.. It's simple and it would work, and we don't need to fiddle with the bindings. I also realised that the schema was retyped, but during encoding it was using the original schema. It must be something in app-schema causing this, and I will investigate.

Re: [Geotools-devel] handling of geometry crs

2010-07-20 Thread Rini.Angreani
Hi Jody, I thought of creating my own binding as well, etc. After playing around with this today, and came up with a dodgy patch on the binding side, I realised we still need my original patch anyway (and more). I tried it on my test and it doesn't work :( The problem is the JTS tranformer

[Geotools-devel] Nominate Matthew Birks for GeoTools commit access

2010-06-22 Thread Rini.Angreani
I nominate my colleague Matthew Birks for GeoTools commit access. He will only commit with module maintainers approvals. He has already fixed one bug in app-schema, that I reviewed and committed: http://jira.codehaus.org/browse/GEOS-3807

[Geotools-devel] Follow up for GEOT-2627 patch

2010-03-30 Thread Rini.Angreani
Hi Justin, Just following up on my patch review for this bug. I thought you might've missed it during the busy release week. When you have time, please refer to my last comment in: http://jira.codehaus.org/browse/GEOT-2627 and look at the patch. I added the same thing we did for

[Geotools-devel] question about SimpleFeaturePropertyAccessor

2010-03-08 Thread Rini.Angreani
Hi Justin, Since you're the author of the class, I'm wondering if you could help me. In SimpleFeaturePropertyAccessor.canHandle(), it does this: if ( object instanceof SimpleFeature ) { return ((SimpleFeature) object).getAttribute( xpath ) != null; } When we have a null value in the

Re: [Geotools-devel] GEOT-2827: bbox queries for app-schema

2009-11-26 Thread Rini.Angreani
Hi Justin, Thank's for looking at this. I don't think e can be null, because on the very top of the method, it's doing something to it. if ( e instanceof PropertyName ) { name = (PropertyName) e; } It would throw NullPointerException before it gets to the null checking bit. Is it OK to

[Geotools-devel] GEOT-2827: bbox queries for app-schema

2009-11-20 Thread Rini.Angreani
Hi list, I submitted a patch for http://jira.codehaus.org/browse/GEOT-2827 more than a week ago, and it's still unassigned. I'm not sure who the module maintainer is for that module (core filter). It's a one line change, but quite important for bounding box queries in complex features. If you

[Geotools-devel] JIRA issue GEOT-2827

2009-11-11 Thread Rini.Angreani
Hi Jody, I was told you are pretty good with filters and might be able to help reviewing my patch for issue GEOT-2827http://jira.codehaus.org/browse/GEOT-2827. I'm just not sure who the module maintainer is for filters. If you have time, please have a look at it, I just removed one line of code.

Re: [Geotools-devel] Can you have more than one geometry attributes per feature?

2009-11-09 Thread Rini.Angreani
Thank's for clearing that up, guys. Hmm the problem is bigger than I thought. Rini -Original Message- From: Justin Deoliveira [mailto:jdeol...@opengeo.org] Sent: Monday, 9 November 2009 11:07 PM To: Andrea Aime Cc: Angreani, Rini (EM, Kensington); geotools-devel@lists.sourceforge.net

Re: [Geotools-devel] [ExternalEmail] Re: app-schema build time/mem

2009-07-10 Thread Rini.Angreani
I think I found the culprit. I refactored a bunch of tests to run the set up once, it got faster, but not enough. Then I changed all the test mapping files to point to: schemaUrihttp://schemas.opengis.net/GeoSciML/geosciml.xsd /schemaUri Instead of the local schemas in test-resources. Now I can

Re: [Geotools-devel] [ExternalEmail] Re: app-schema build time/mem

2009-07-10 Thread Rini.Angreani
It seems that way. Go ahead and commit your changes first. We have the whole day here still. Cheers Rini -Original Message- From: Gabriel Roldan [mailto:grol...@opengeo.org] Sent: Friday, 10 July 2009 2:16 PM To: Angreani, Rini (EM, Kensington) Cc: Caradoc-Davies, Ben (EM,

Re: [Geotools-devel] [ExternalEmail] Re: app-schema build time/mem

2009-07-10 Thread Rini.Angreani
OK sure. Cheers Rini -Original Message- From: Gabriel Roldan [mailto:grol...@opengeo.org] Sent: Friday, 10 July 2009 2:41 PM To: Angreani, Rini (EM, Kensington) Cc: Caradoc-Davies, Ben (EM, Kensington); geotools-devel@lists.sourceforge.net Subject: Re: [ExternalEmail] Re:

Re: [Geotools-devel] [ExternalEmail] Re: app-schema build time/mem

2009-07-10 Thread Rini.Angreani
I think I know why. The app-schema reader in that test doesn't have an OASIS catalog. I happened to be find that yesterday, while making changes for a different issue. It worked because it didn't need gsml types (it was creating a non-gsml data access). Anyway, I'll look into it. Thank's for

Re: [Geotools-devel] app-schema build time/mem

2009-07-09 Thread Rini.Angreani
Hi Gabriel, Thank you for your help. I will refactor the rest of other tests like that as well. Cheers Rini -Original Message- From: Gabriel Roldan [mailto:grol...@opengeo.org] Sent: Friday, 10 July 2009 4:35 AM To: Geotools-Devel list; Caradoc-Davies, Ben (EM, Kensington);

[Geotools-devel] Vocabulary functions

2009-06-28 Thread Rini.Angreani
Hi Andrea, I have assigned GEOT-2570 for you to review, as you're the module maintainer. The code I changed is: - RecodeFunction, which originally only worked for raster data as the lookup value It's changed so it can be more generic, and can be used for vocabulary function in app-schema

Re: [Geotools-devel] Filtering complex attribute value

2009-06-08 Thread Rini.Angreani
Hello Jody, Thank you for looking at this again. I managed to provide a workaround for my problem, so I closed the issue on JIRA. If this is needed in the future, it can be raised again (and fixed properly). I do agree that multiplicity has to be considered and it needs a lot of thought...

[Geotools-devel] Filtering complex attribute value

2009-06-03 Thread Rini.Angreani
Hi list, I have a problem trying to filter complex attribute value from a complex feature. Ideally, the filter should be unmapped first to its simple feature form, eg. Query: feature type: CGI_TermValue filter: [ gml:name = significant ] [properties: ALL ] Unmapped to this: Query:

Re: [Geotools-devel] Filtering complex attribute value

2009-06-03 Thread Rini.Angreani
Hi Jody, Thank you for your quick response. In app-schema data access, you'd have a simple feature data store, which is mapped into the complex feature data access. When filters are run, the complex attribute form (eg. Gml:name) would then be unmapped to the simple feature expression (ie. The

Re: [Geotools-devel] ReferenceTypeBinding

2009-05-26 Thread Rini.Angreani
Hi Justin, I raised a JIRA issue and attached my patch for this (http://jira.codehaus.org/browse/GEOT-2494.). I just added an encode method for the client properties, and changed the type from Association to Property. Please let me know if it's OK. Cheers Rini -Original Message-

[Geotools-devel] full JIRA account

2009-05-18 Thread Rini.Angreani
Hi, I applied as a Geotools developer on Xircles nearly 2 weeks ago, and it's still pending. Can someone please approve my application so I can edit my JIRA entries? Cheers Rini -- Crystal Reports - New Free Runtime

Re: [Geotools-devel] ReferenceTypeBinding

2009-05-18 Thread Rini.Angreani
Thank you Justin, I think I'll have to change the cast from Association to Property (credit to Ben), as both ComplexAttribute and Association extend from it. I might also have to implement an encode method for this binding. I'll create a JIRA entry when I'm finished with this. -Original

Re: [Geotools-devel] full JIRA account

2009-05-18 Thread Rini.Angreani
Thank's Andrea. That was quick :) -Original Message- From: Andrea Aime [mailto:aa...@opengeo.org] Sent: Monday, 18 May 2009 5:34 PM To: Angreani, Rini (EM, Kensington) Cc: geotools-devel@lists.sourceforge.net Subject: Re: [Geotools-devel] full JIRA account rini.angre...@csiro.au ha

[Geotools-devel] ReferenceTypeBinding

2009-05-15 Thread Rini.Angreani
Hi list, I guess this question goes to Justin, since he's the author of the class. I have a problem with gml:ReferenceType, with a ClassCastException in ReferenceTypeBinding: public Object getProperty(Object object, QName name) throws Exception { Association association = (Association)

Re: [Geotools-devel] GeoTools commit access for Rini Angreani

2009-02-09 Thread Rini.Angreani
Hi Jody, Thank's for the vote. I've completed the contributor agreement and will send it as soon as possible. I think the developers guide is good. The project conventions, especially, have some useful tips that I learnt from. I was tricked into using Jalopy, so it's good that you've updated

[Geotools-devel] missing artifact: 2.6 SNAPSHOT in gt-sql-datastore

2008-11-12 Thread Rini.Angreani
Hi, I found a problem building this package: GeoTools\modules\unsupported\geometryless from trunk. Missing: -- 1) org.geotools:gt-sql-datastore:jar:2.6-SNAPSHOT Try downloading the file manually from the project website. Then, install it using the command: mvn