Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-19 Thread Andrea Aime
Thanks for the feedback. Sorry I missed it, I'm only glancing over mails while I'm away, often from the phone (like just now) Cheers Andrea Il 19/feb/2015 18:37 "Ian Turton" ha scritto: > As i mentioned in the JIRA ticket the problem is in TemporalConvertor > > The whole thing is a mess thst

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-19 Thread Ian Turton
As i mentioned in the JIRA ticket the problem is in TemporalConvertor The whole thing is a mess thst goes back many years from my look at the GeoTools JIRA. Ian On 17:31, Thu, 19 Feb 2015 Andrea Aime wrote: > Hi, > managed to get another 5 minutes peek, the line that is likely to cause > the c

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-19 Thread Andrea Aime
Hi, managed to get another 5 minutes peek, the line that is likely to cause the conversion is this one, RangeCombiner line 260: Object value = evaluate(op.getExpression2(), binding); There is probably a Converter object around that turns a java.util.Date into a java.sql.Date witho

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-19 Thread Andrea Aime
On Thu, Feb 19, 2015 at 6:10 PM, Andrea Aime wrote: > On Thu, Feb 19, 2015 at 5:48 PM, Torben Barsballe < > tbarsba...@boundlessgeo.com> wrote: > >> Andrea - I traced the date throught the debugger and when the >> SimplifyingFilterVisistor is called on the Filter, the java.util.Date is >> cast to

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-19 Thread Andrea Aime
On Thu, Feb 19, 2015 at 5:48 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > Andrea - I traced the date throught the debugger and when the > SimplifyingFilterVisistor is called on the Filter, the java.util.Date is > cast to a java.sql.Date. Since the SQL date has no time component, th

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-19 Thread Torben Barsballe
Andrea - I traced the date throught the debugger and when the SimplifyingFilterVisistor is called on the Filter, the java.util.Date is cast to a java.sql.Date. Since the SQL date has no time component, the time zone information is discarded, and we are left with "2009-27-06" instead of the expected

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-19 Thread Andrea Aime
Hi, quick peek, the fact that we mess with dates and we don't have a good story about them has been well known for a number of years now, see this search over the GeoServer jira: http://jira.codehaus.org/browse/GEOS-4951?jql=project%20%3D%20GEOS%20AND%20status%20%3D%20Open%20AND%20text%20~%20%22dat

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-18 Thread Ben Caradoc-Davies
Done. On 19/02/15 13:20, Torben Barsballe wrote: > Jira created here: > https://jira.codehaus.org/browse/GEOT-5025 > > Do you want to add the results you got (as well as your environment) > > Torben -- Ben Caradoc-Davies Software Engineer Transient Software New Zealand --

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-18 Thread Torben Barsballe
Jira created here: https://jira.codehaus.org/browse/GEOT-5025 Do you want to add the results you got (as well as your environment) Torben On Wed, Feb 18, 2015 at 3:27 PM, Ben Caradoc-Davies wrote: > Torben, > > I can confirm that if I set my local timezone to America/Vancouver, I get > the fol

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-18 Thread Ben Caradoc-Davies
Torben, I can confirm that if I set my local timezone to America/Vancouver, I get the following gt-jdbc-postgis failures: Failed tests: PostgisDateOnlineTest>OnlineTestCase.run:123->JDBCDateOnlineTest.testFiltersByDate:45 expected:<2> but was:<1> PostgisUDTOnlineTest>OnlineTestCase.run:123->

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-18 Thread Ben Caradoc-Davies
Torben, aha, well spotted! I recall similar (non-postgis) failures in the past, for tests that worked only for timezones behind UTC. The solution was to ensure more robust timezone handling in test fixtures and assertions. Causes? (1) As far as I know, nobody regularly runs PostGIS online test

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-18 Thread Torben Barsballe
Thanks for that link Ben. It looks like we are kind of stuck until we get a postgis driver that fufills all our needs. The two Date test failures are unrelated to that issue however. The test case defines: DateFormat df = new SimpleDateFormat("-dd-MM"); df.setTimeZone( TimeZone.getTimeZone("P

Re: [Geotools-devel] GeoTools PostGIS Test failures

2015-02-18 Thread Ben Caradoc-Davies
Torben, please see the discussion in this Jira issue about the various postgres driver versions and the differing failures they cause. https://jira.codehaus.org/browse/GEOT-4636 You might add any new findings to this issue. Kind regards, Ben. On 19/02/15 07:05, Torben Barsballe wrote: > I have

[Geotools-devel] GeoTools PostGIS Test failures

2015-02-18 Thread Torben Barsballe
I have recently been running the Online PostGIS tests, and have run into a number of existing failures: Failed tests: PostgisDateOnlineTest>OnlineTestCase.run:123->JDBCDateOnlineTest.testFiltersByDate:45 expected:<2> but was:<1> PostgisLobOnlineTest>OnlineTestCase.run:123->JDBCLobOnlineTest.test