Okay I sorted out a good way forwards and should be able to commit when Andrea
is ready. Going to pull the same trick used for Query; make MapContext an
actual class; which DefaultMapContext can extend. Does not really solve our
naming issue but does improve readability.
Jody
On 13/06/2010,
On 09/06/10 22:37, Jody Garnett wrote:
Ben I notice you have a FeatureSourceMapLayer - I don't think this is needed
after the refactor; but I have no good way of testing.
Jody, I suspect you are right. This class was introduced as part of the
refactoring to support the DataAccess API. I have
On 14/06/10 13:30, Ben Caradoc-Davies wrote:
If you can replace all instances of FeatureSourceMapLayer with
DefaultMapLayer without
having to instanceof/cast, then it can be removed.
Let me go further: if you can do this, the class *should* be removed. It
was really an interim workaround,
Hi Jody,
A few comments / queries to get started (sorry for the bitty nature of
what follows but I'm multi-mutli-tasking this weekend :)
First up - it's so good to see this becoming reality. It's going to
make many things much easier and cleaner.
In the Layer class, are the the methods for
On 12/06/2010, at 6:53 PM, Michael Bedward wrote:
Hi Jody,
A few comments / queries to get started (sorry for the bitty nature of
what follows but I'm multi-mutli-tasking this weekend :)
No worries thanks for the review; I am slated to commit this weekend. I am
unsure if I should commit
Micheal please check the issue for an updated patch
I have separated out a MapViewport holding the bounds+crs for the map. The map
does retain an internal MapViewport for use in an interactive session. But I
can understand your need to keep one on the side for background rendering; or
to have
Not sure what to be done; maybe I can commit to a branch for you? Or create the
diff in eclipse - oh but you don't use Eclipse :-(
Okay a temporary branch it is - try the following:
- http://svn.osgeo.org/geotools/branches/map-context
I don't really want to switch onto this branch if I can help
Hi Jody,
Thanks for the branch. I've diff'd the changes into my local trunk
sources now. As an aside, I had the same problems doing that as I had
with your patches. Must be a shortcoming of svn diff.
I'm building it all now and will get back to you with comments.
Michael
Took quick look at the proposal, I am +0.
MIght turn into +1 once I have played with the enhancements.
Simone.
---
Ing. Simone Giannecchini
GeoSolutions S.A.S.
Founder - Software Engineer
Via Carignoni 51
55041 Camaiore (LU)
Italy
phone: +39
The goal is not to enhance at this time; simply to cut down on the magic
performed by DefaultMapLayer.
With this in mind do you wish to reconsider +0?
Jody
On 10/06/2010, at 4:23 PM, Simone Giannecchini wrote:
Took quick look at the proposal, I am +0.
MIght turn into +1 once I have played
Hi Jody,
Just tried to apply the patch to today's checkout of trunk but it
fails for me when trying to patch DefaultMapLayer.java
Michael
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day
Let me make the patch again; I am just using a straight svn diff file.patch
Jody
On 10/06/2010, at 5:18 PM, Michael Bedward wrote:
Hi Jody,
Just tried to apply the patch to today's checkout of trunk but it
fails for me when trying to patch DefaultMapLayer.java
Michael
Hi Jody,
Let me make the patch again; I am just using a straight svn diff file.patch
Super - thanks for that.
Michael
--
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE
New patch added; I will lurk on IRC in case you need a hand applying it. Also
added you as a watcher on the issue so you will get notified as it is worked on.
Jody
On 10/06/2010, at 11:14 PM, Michael Bedward wrote:
Hi Jody,
Let me make the patch again; I am just using a straight svn diff
Hi Jody,
Still having problems applying the new patch to my local trunk sources
(see below). I'm heading out for a sunny lunchtime run now (luxury !)
but will try hand-editing the patch rejects when I get back.
Michael
guanaco:clean-trunk michael$ patch -p0 geot-3136-mapcontext.patch
A second patch is now available:
- http://jira.codehaus.org/browse/GEOT-3136
This patch is complete; with DefaultMapLayer using an internal Layer (tested
with Quickstart and ImageLab to confirm functionality).
Ben I notice you have a FeatureSourceMapLayer - I don't think this is needed
after
Jody Garnett wrote:
Proposal is established enough to be voted on; I will be working on this over
several evenings this week with this weekend targeted for the first commit.
- http://docs.codehaus.org/display/GEOTOOLS/MapContext+Refactor
- http://jira.codehaus.org/browse/GEOT-3136 (Initial
That is fine Andrea; it is a long weekend here so if you can review Sunday I
think that gives me time to commit. I mostly want to have the api changes in
place when I do a run of the workshop materials next week.
On the plus side I will have a patch ready for you by then.
Aside: there is also
On 8 June 2010 15:20, Ben Caradoc-Davies wrote:
MapLayerCollection? That is the best I have been able to come up with,
so perhaps Map is not so bad after all ... :-)
I suppose this is an instance of misused mathematical/compsci jargon
finally being used for its original purpose.
I'm a
Michael Bedward wrote:
On 8 June 2010 15:20, Ben Caradoc-Davies wrote:
MapLayerCollection? That is the best I have been able to come up with,
so perhaps Map is not so bad after all ... :-)
I suppose this is an instance of misused mathematical/compsci jargon
finally being used for its
On 8 June 2010 20:22, Andrea Aime wrote:
If we go for a longer name (I also agree Map is not the best choice, also
thinking about code completion mess here) can't we just keep it
named MapContext? :-p
The name comes from an OGC spec like quite a bit of other things in
GT2, so it would be
If we go for a longer name (I also agree Map is not the best choice,
also thinking about code completion mess here) can't we just keep it
named MapContext? :-p
Apparently I should read the entire thread before replying to any single part;
yes I can swap things around
and use MapContext in
Proposal is established enough to be voted on; I will be working on this over
several evenings this week with this weekend targeted for the first commit.
- http://docs.codehaus.org/display/GEOTOOLS/MapContext+Refactor
- http://jira.codehaus.org/browse/GEOT-3136 (Initial patch showing the api;
+1. Changes look sensible.
One suggestion: any chance of calling the Map class something else? It
will cause confusion both in code and in discussion.
Kind regards,
Ben.
On 08/06/10 08:15, Jody Garnett wrote:
Proposal is established enough to be voted on; I will be working on this over
MapLayerCollection? That is the best I have been able to come up with,
so perhaps Map is not so bad after all ... :-)
I suppose this is an instance of misused mathematical/compsci jargon
finally being used for its original purpose.
On 08/06/10 12:44, Jody Garnett wrote:
There is a chance; do
25 matches
Mail list logo
