Re: [Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-11 Thread Ben Caradoc-Davies
OK, I think I have a formal +1 from Jody, support from Andrea (I have taken this as +1, it that OK?), and a week has elapsed. Is the proposal approved? Would you like me to commit the changes and update the developer docs? Kind regards, Ben. Jody Garnett wrote: Got it. Checking that the

Re: [Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-03 Thread Andrea Aime
Ben Caradoc-Davies ha scritto: I propose that an optional key be added to OnlineTestCase to cause test failure on failed connection: http://docs.codehaus.org/display/GEOTOOLS/OnlineTestCase+support+for+failure+on+failed+connection Works for me. Just a minor note, there is one other case in

Re: [Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-03 Thread Ben Caradoc-Davies
Andrea Aime wrote: Ben Caradoc-Davies ha scritto: I propose that an optional key be added to OnlineTestCase to cause test failure on failed connection: http://docs.codehaus.org/display/GEOTOOLS/OnlineTestCase+support+for+failure+on+failed+connection Works for me. Just a minor note, there

Re: [Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-03 Thread Jody Garnett
Read over the proposal; I think this is a case were we can come to a decision without a formal proposal since this just effects us the devel community and the change is not visible to user code. But that is my take on it - we are still sorting out when a proposal is useful and when it is a waste

Re: [Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-03 Thread Ben Caradoc-Davies
Jody Garnett wrote: I think this is a case were we can come to a decision without a formal proposal since this just effects us the devel community and the change is not visible to user code. But that is my take on it - we are still sorting out when a proposal is useful and when it is a

Re: [Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-03 Thread Jody Garnett
Ben Caradoc-Davies wrote: Jody Garnett wrote: I think this is a case were we can come to a decision without a formal proposal since this just effects us the devel community and the change is not visible to user code. But that is my take on it - we are still sorting out when a proposal is

Re: [Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-03 Thread Jody Garnett
Got it. Checking that the proposal says what you mean... you even found the developers guide page that needs to change :-D+1 Jody On Wed, Feb 4, 2009 at 3:04 PM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: Jody Garnett wrote: Hrm you are right; Justin wanted proposals for things

[Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-02 Thread Ben Caradoc-Davies
I propose that an optional key be added to OnlineTestCase to cause test failure on failed connection: http://docs.codehaus.org/display/GEOTOOLS/OnlineTestCase+support+for+failure+on+failed+connection -- Ben Caradoc-Davies ben.caradoc-dav...@csiro.au Software Engineer, CSIRO Exploration and

Re: [Geotools-devel] Proposal: OnlineTestCase support for failure on failed connection

2009-02-02 Thread Jody Garnett
How would that be helpful? I could see throwing a java property to ask the online tests to fail Personally I log the first failed connection message. Ben Caradoc-Davies wrote: I propose that an optional key be added to OnlineTestCase to cause test failure on failed connection: