Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

2018-11-07 Thread Holger Freyther
Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/11580 ) Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

2018-11-07 Thread Holger Freyther
Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/11580 ) Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH .. Patch Set 3: -Verified -Code-Review -- To view, visit ht

Change in osmo-ttcn3-hacks[master]: BSC: log number of expected/seen *CX messages on failure

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11645 ) Change subject: BSC: log number of expected/seen *CX messages on failure .. Patch Set 1: Code-Review-1 The commit description doesn't ma

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 4: > jenkins tests with gcc 6.3.0-18+deb9u1, my gcc is gcc

Change in osmo-ci[master]: ansible: gsm-tester: Add IP addr for umtrx

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11619 ) Change subject: ansible: gsm-tester: Add IP addr for umtrx .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/1161

Change in osmo-ci[master]: ansible: gsm-tester: Support power cycling multiple quad modems

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11628 ) Change subject: ansible: gsm-tester: Support power cycling multiple quad modems .. Patch Set 1: Verified+1 -- To view, visit https://ge

Change in osmo-ci[master]: ansible: gsm-tester: Support power cycling multiple quad modems

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11628 ) Change subject: ansible: gsm-tester: Support power cycling multiple quad modems .. ansible: gsm-tester: Support power cycling mul

Change in osmo-ci[master]: ansible: gsm-tester: prod has now 8 modems attached

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11627 ) Change subject: ansible: gsm-tester: prod has now 8 modems attached .. Set Ready For Review -- To view, visit https://gerrit.osmocom.or

Change in osmo-ci[master]: ansible: gsm-tester: Add IP addr for umtrx

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11619 ) Change subject: ansible: gsm-tester: Add IP addr for umtrx .. ansible: gsm-tester: Add IP addr for umtrx Change-Id: I7fb65e3c337

Change in osmo-ci[master]: ansible: gsm-tester: prod has now 8 modems attached

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11627 ) Change subject: ansible: gsm-tester: prod has now 8 modems attached .. ansible: gsm-tester: prod has now 8 modems attached 4 EC2

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

2018-11-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/9374 ) Change subject: start implementing the TC_paging() PCU test .. Patch Set 4: Please rebase to latest master, add the test to control() and expected_res

Change in osmo-gsm-tester[master]: ms_driver: Fix subject in the header

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11649 ) Change subject: ms_driver: Fix subject in the header .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11649 T

Change in osmo-gsm-tester[master]: ms_driver: Allow to specify env and binary name/path

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11596 ) Change subject: ms_driver: Allow to specify env and binary name/path .. Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.o

Change in osmo-gsm-tester[master]: ms_driver: Switch to process.Process from subprocess

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11597 ) Change subject: ms_driver: Switch to process.Process from subprocess .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osm

Change in osmo-gsm-tester[master]: ms_driver: use the util.Dir and create one dir per instance

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11598 ) Change subject: ms_driver: use the util.Dir and create one dir per instance .. Patch Set 2: Code-Review+2 (1 comment) https://gerrit.os

Change in osmo-gsm-tester[master]: ms_driver: Consult the suite to get the binaries

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11599 ) Change subject: ms_driver: Consult the suite to get the binaries .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom

Change in osmo-gsm-tester[master]: suits: Add an initial test for the ms_driver

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10687 ) Change subject: suits: Add an initial test for the ms_driver .. Patch Set 9: (1 comment) https://gerrit.osmocom.org/#/c/10687/9//COMMIT

Change in osmo-ci[master]: ansible: Wrap distro version number as string for ansible

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11648 ) Change subject: ansible: Wrap distro version number as string for ansible .. Patch Set 1: Code-Review+1 -- To view, visit https://gerri

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11580 ) Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH .. Patch Set 3: Code-Review+2 -- To view, visit https://ge

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

2018-11-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11560 ) Change subject: replace src/* git scripts with a single src/gits .. Patch Set 5: Code-Review-1 (6 comments) gits was not executable in the last pa

Change in osmo-dev[master]: sanitize.opts: add osmo-sip-connector --enable-sanitize

2018-11-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11593 ) Change subject: sanitize.opts: add osmo-sip-connector --enable-sanitize .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

2018-11-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11635 ) Change subject: 2G.deps: add osmo-sip-connector .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11635 To unsubscribe, o

Change in osmo-dev[master]: deps: comment out osmo-trx

2018-11-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11634 ) Change subject: deps: comment out osmo-trx .. Patch Set 1: Code-Review+1 looks good. the best way would probably be adding "--enable-sanitize-tests

Change in osmo-mgw[master]: mgcp_protocol: increase buffer space for codec name in LCO

2018-11-07 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/11466 ) Change subject: mgcp_protocol: increase buffer space for codec name in LCO .. mgcp_protocol: increase buffer space for codec name in LCO T

Change in libosmocore[master]: gsm_29_118: add missing include to header file

2018-11-07 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/11638 ) Change subject: gsm_29_118: add missing include to header file .. gsm_29_118: add missing include to header file The header file gsm_29_11

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerformed template

2018-11-07 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/11607 ) Change subject: BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerformed template .. BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerf

Change in osmo-bsc[master]: LCLS: expand logging to print the name of the mode in use

2018-11-07 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11652 Change subject: LCLS: expand logging to print the name of the mode in use .. LCLS: expand logging to print the name of the mode in use Change-Id: I56b5

Change in osmo-bsc[master]: Make IP address helper accessible via header file

2018-11-07 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11650 Change subject: Make IP address helper accessible via header file .. Make IP address helper accessible via header file Change-Id: I4bc157bf296e28678de6

Change in osmo-bsc[master]: constify rsl_tx_ipacc_*cx() parameters

2018-11-07 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11651 Change subject: constify rsl_tx_ipacc_*cx() parameters .. constify rsl_tx_ipacc_*cx() parameters Change-Id: Ib34c8e3fb51d067581aefa1c80f8be1f6db9512e -

Change in osmo-bsc[master]: LCLS: move mode check into separate function

2018-11-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11551 ) Change subject: LCLS: move mode check into separate function .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11551 To unsubscrib

Change in osmo-bsc[master]: RSL: restructure MDCX functions

2018-11-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11550 ) Change subject: RSL: restructure MDCX functions .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11550 To unsubscribe, or for hel

Change in osmo-bsc[master]: LCLS: explicitly check for mode before closing the loop

2018-11-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11565 ) Change subject: LCLS: explicitly check for mode before closing the loop .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11565 To

Change in osmo-ttcn3-hacks[master]: BSC: log MGCP connection on failure

2018-11-07 Thread Max
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11645 to look at the new patch set (#2). Change subject: BSC: log MGCP connection on failure ..

Change in osmo-ttcn3-hacks[master]: BSC: log MGCP connection number on failure

2018-11-07 Thread Max
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11645 to look at the new patch set (#3). Change subject: BSC: log MGCP connection number on failure ...

Change in libosmocore[master]: Support cipher mode reject with extended cause

2018-11-07 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11601 to look at the new patch set (#3). Change subject: Support cipher mode reject with extended cause .. Support cipher m

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

2018-11-07 Thread Max
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11577 to look at the new patch set (#5). Change subject: Update 3GPP TS 08.08 Cause handling ..

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2018-11-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 4: Code-Review-1 (1 comment) I think you should also update TODO-RELEAS

Change in osmo-ttcn3-hacks[master]: BSC: log MGCP connection number on failure

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11645 ) Change subject: BSC: log MGCP connection number on failure .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1

Change in osmo-bsc[master]: constify rsl_tx_ipacc_*cx() parameters

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11651 ) Change subject: constify rsl_tx_ipacc_*cx() parameters .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11651

Change in osmo-bsc[master]: Make IP address helper accessible via header file

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11650 ) Change subject: Make IP address helper accessible via header file .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in osmo-bsc[master]: LCLS: expand logging to print the name of the mode in use

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11652 ) Change subject: LCLS: expand logging to print the name of the mode in use .. Patch Set 1: Code-Review+2 -- To view, visit https://gerri

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 4: (1 comment) > (1 comment) > > I think you should als

Change in osmo-bsc[master]: constify rsl_tx_ipacc_*cx() parameters

2018-11-07 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11651 ) Change subject: constify rsl_tx_ipacc_*cx() parameters .. constify rsl_tx_ipacc_*cx() parameters Change-Id: Ib34c8e3fb51d067581aefa1c80f8be1f

Change in osmo-bsc[master]: Make IP address helper accessible via header file

2018-11-07 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11650 ) Change subject: Make IP address helper accessible via header file .. Make IP address helper accessible via header file Change-Id: I4bc157bf29

Change in osmo-pcu[master]: deb: add missing copyright file

2018-11-07 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11653 Change subject: deb: add missing copyright file .. deb: add missing copyright file File is imported as-is from current .deb package Change-Id: Ib05480

Change in osmo-bsc[master]: paging: Make default T3113 timeout dynamic

2018-11-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11654 Change subject: paging: Make default T3113 timeout dynamic .. paging: Make default T3113 timeout dynamic Change-Id: I4fb2969b690151415038

Change in libosmocore[master]: Add helper wrapper for BSSAP TLV parsing

2018-11-07 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11655 Change subject: Add helper wrapper for BSSAP TLV parsing .. Add helper wrapper for BSSAP TLV parsing Change-Id: Ib228368901ce90a02a5664f2510593371c7d29

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

2018-11-07 Thread Stefan Sperling
Hello Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9374 to look at the new patch set (#5). Change subject: start implementing the TC_paging() PCU test .. s

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

2018-11-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9374 ) Change subject: start implementing the TC_paging() PCU test .. Patch Set 5: > Patch Set 4: > > Please rebase to latest master, add the tes

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

2018-11-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/9374 ) Change subject: start implementing the TC_paging() PCU test .. Patch Set 5: (1 comment) Would be nice to update comment in PCU_Tests.cfg https://gerr

Change in libosmocore[master]: Add helper wrapper for BSSAP TLV parsing

2018-11-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11655 ) Change subject: Add helper wrapper for BSSAP TLV parsing .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11655 To unsubscribe, o

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #300

2018-11-07 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host sy

Change in osmo-dev[master]: deps: comment out osmo-trx

2018-11-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11634 ) Change subject: deps: comment out osmo-trx .. Patch Set 1: Code-Review-1 Actually... how about adding a comment on top that describes why this was

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-07 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11656 Change subject: use enums consistently instead of falling back to int .. use enums consistently instead of falling back to int The two exi

Change in osmo-dev[master]: deps: comment out osmo-trx

2018-11-07 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11634 to look at the new patch set (#2). Change subject: deps: comment out osmo-trx .. deps: comment out osmo-trx osmo-trx shouldn'

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

2018-11-07 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11635 to look at the new patch set (#2). Change subject: 2G.deps: add osmo-sip-connector .. 2G.deps: add osmo-sip-connector Change-

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11635 ) Change subject: 2G.deps: add osmo-sip-connector .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1163

Change in osmo-dev[master]: deps: comment out osmo-trx

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11634 ) Change subject: deps: comment out osmo-trx .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11634 To

Change in osmo-dev[master]: deps: comment out osmo-trx

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11634 ) Change subject: deps: comment out osmo-trx .. deps: comment out osmo-trx osmo-trx shouldn't run with address sanitizer. But omittin

Change in osmo-dev[master]: 2G.deps: add osmo-sip-connector

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11635 ) Change subject: 2G.deps: add osmo-sip-connector .. 2G.deps: add osmo-sip-connector Change-Id: I30e27e2eb0060889f167417a21894e8e411a

Change in osmo-dev[master]: sanitize.opts: add osmo-sip-connector --enable-sanitize

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11593 ) Change subject: sanitize.opts: add osmo-sip-connector --enable-sanitize .. sanitize.opts: add osmo-sip-connector --enable-sanitize

Change in osmo-dev[master]: sanitize.opts: add osmo-sip-connector --enable-sanitize

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11593 ) Change subject: sanitize.opts: add osmo-sip-connector --enable-sanitize .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit https:/

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

2018-11-07 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11560 to look at the new patch set (#7). Change subject: replace src/* git scripts with a single src/gits .. replace src/* git scrip

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

2018-11-07 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11560 to look at the new patch set (#8). Change subject: replace src/* git scripts with a single src/gits .. replace src/* git scrip

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11560 ) Change subject: replace src/* git scripts with a single src/gits .. Patch Set 7: (3 comments) https://gerrit.osmocom.org/#/c/11560/4/src/g

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11560 ) Change subject: replace src/* git scripts with a single src/gits .. Patch Set 7: Are we through with this now? -- To view, visit https://

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_resp_unsol

2018-11-07 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11604 to look at the new patch set (#2). Change subject: bsc: Introduce test TC_paging_resp_unsol .. bsc:

Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

2018-11-07 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/11657 Change subject: Add ttcn3-bscnat-test docker image .. Add ttcn3-bscnat-test docker image Run the bscnat ttcn3 tests in docker. This uses the osmo-ni

Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

2018-11-07 Thread daniel
daniel has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11657 ) Change subject: Add ttcn3-bscnat-test docker image .. Add ttcn3-bscnat-test docker image Run the bscnat ttcn3 tests in docker. This uses the osmo-nit

Change in osmo-bsc[master]: prevent a NULL pointer dereference in debug_candidate()

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11630 ) Change subject: prevent a NULL pointer dereference in debug_candidate() .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.o

Change in libosmocore[master]: GSUP: introduce new InvokeID Information Element

2018-11-07 Thread Vadim Yanitskiy
Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/11633 ) Change subject: GSUP: introduce new InvokeID Information Element .. Abandoned -- To view, visit https://gerrit.osmocom.org/11633 To unsubscribe, or

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: introduce new InvokeID IE

2018-11-07 Thread Vadim Yanitskiy
Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/11640 ) Change subject: library/GSUP_Types.ttcn: introduce new InvokeID IE .. Abandoned -- To view, visit https://gerrit.osmocom.org/11640 To unsubscribe, o

Change in osmo-bsc[master]: prevent a NULL pointer dereference in debug_candidate()

2018-11-07 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11630 ) Change subject: prevent a NULL pointer dereference in debug_candidate() .. Patch Set 1: Neels, > Related: CID#10 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: remove flush from f_expect_chan_rel

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11658 Change subject: bsc: remove flush from f_expect_chan_rel .. bsc: remove flush from f_expect_chan_rel When we're expecting release, it can be

Change in osmo-ttcn3-hacks[master]: bsc: handle RR Release messages

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11660 Change subject: bsc: handle RR Release messages .. bsc: handle RR Release messages Receive RR Release messages if they happen during lchan r

Change in osmo-ttcn3-hacks[master]: bsc: handle Deact SACCH messages

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11661 Change subject: bsc: handle Deact SACCH messages .. bsc: handle Deact SACCH messages Allow osmo-bsc sending a Deact SACCH messages in most c

Change in osmo-ttcn3-hacks[master]: bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11659 Change subject: bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel .. bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel I

Change in osmo-ttcn3-hacks[master]: disable tcpdump

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11663 Change subject: disable tcpdump .. disable tcpdump Change-Id: I46116df68b2f8c9ca253a9285d0a571904521727 --- M ttcn3-tcpdump-start.sh M ttcn3

Change in osmo-ttcn3-hacks[master]: bsc: check channel release message presence

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11662 Change subject: bsc: check channel release message presence .. bsc: check channel release message presence Instead of vaguely allowing any r

Change in osmo-ttcn3-hacks[master]: disable tcpdump

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/11663 ) Change subject: disable tcpdump .. Abandoned -- To view, visit https://gerrit.osmocom.org/11663 To unsubscribe, or for help writing mail filters, visi

Change in osmo-bsc[master]: fix: send RR Release (e.g. after BSSMAP Clear Cmd)

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11664 Change subject: fix: send RR Release (e.g. after BSSMAP Clear Cmd) .. fix: send RR Release (e.g. after BSSMAP Clear Cmd) After commit [1], t

Change in osmo-bsc[master]: cosmetic: abis_rsl.c: drop uneccesary braces

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11669 Change subject: cosmetic: abis_rsl.c: drop uneccesary braces .. cosmetic: abis_rsl.c: drop uneccesary braces Change-Id: I20a7b160321cf86179c

Change in osmo-bsc[master]: abis_rsl.c: drop unused enum sacch_deact

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11665 Change subject: abis_rsl.c: drop unused enum sacch_deact .. abis_rsl.c: drop unused enum sacch_deact Change-Id: I8a1542e92373d2773699744e7b6

Change in osmo-bsc[master]: lchan release: always Deact SACCH

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11667 Change subject: lchan release: always Deact SACCH .. lchan release: always Deact SACCH If an lchan is being released and had a SACCH active,

Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11668 Change subject: cosmetic: lchan: introduce sub-struct lchan->release.* .. cosmetic: lchan: introduce sub-struct lchan->release.* Put all lch

Change in osmo-bsc[master]: lchan: release in error: fix missing messages / events

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11666 Change subject: lchan: release in error: fix missing messages / events .. lchan: release in error: fix missing messages / events In the case

Change in osmo-bsc[master]: lchan: set cause for 4 instances of release_in_error = true

2018-11-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11670 Change subject: lchan: set cause for 4 instances of release_in_error = true .. lchan: set cause for 4 instances of release_in_error = true M