Change in osmo-bsc[master]: send Immediate Assignment Reject only before Immediate Assignment

2018-11-26 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11940 ) Change subject: send Immediate Assignment Reject only before Immediate Assignment .. Patch Set 2: (2 comments) Oh, it has been already

Change in osmo-msc[master]: libmsc/gsm_04_11.c: refactor RP-DATA header validation

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11915 ) Change subject: libmsc/gsm_04_11.c: refactor RP-DATA header validation .. libmsc/gsm_04_11.c: refactor RP-DATA header validation It'

Change in osmo-msc[master]: libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error}

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11914 ) Change subject: libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error} .. libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_r

Build failed in Jenkins: master-osmo-trx » --with-sse,a2=default,a3=default,osmocom-master-debian9 #694

2018-11-26 Thread jenkins
See Changes: [Pau Espin Pedrol] lms: Use LimeSuite.h log level defines instead of hardcoded values [Pau Espin Pedrol] lms: Apply LMS->

Change in openbsc[master]: bsc-nat: Enable octet-aligned when ensuring mode set

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/6598 ) Change subject: bsc-nat: Enable octet-aligned when ensuring mode set .. Patch Set 4: Code-Review+2 I changed the RFC no in the commit message and re

Change in osmo-msc[master]: libmsc/gsm_04_11.c: refactor RP-DATA header validation

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11915 ) Change subject: libmsc/gsm_04_11.c: refactor RP-DATA header validation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoc

Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11657 ) Change subject: Add ttcn3-bscnat-test docker image .. Add ttcn3-bscnat-test docker image Run the bscnat ttcn3 tests in docker. This

Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11657 ) Change subject: Add ttcn3-bscnat-test docker image .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11657 To unsu

Change in osmo-trx[master]: lms: Apply LMS->OSMO log level conversion

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11902 ) Change subject: lms: Apply LMS->OSMO log level conversion .. lms: Apply LMS->OSMO log level conversion Change-Id: I3a8fbcc7cacebc703

Change in osmo-trx[master]: lms: Use LimeSuite.h log level defines instead of hardcoded values

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11901 ) Change subject: lms: Use LimeSuite.h log level defines instead of hardcoded values .. Patch Set 1: Code-Review+2 -- To view, visit https:/

Change in osmo-trx[master]: lms: Apply LMS->OSMO log level conversion

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11902 ) Change subject: lms: Apply LMS->OSMO log level conversion .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11902

Change in osmo-trx[master]: lms: Use LimeSuite.h log level defines instead of hardcoded values

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11901 ) Change subject: lms: Use LimeSuite.h log level defines instead of hardcoded values .. lms: Use LimeSuite.h log level defines instead

Change in openbsc[master]: bsc-nat: Enable octet-aligned when ensuring mode set

2018-11-26 Thread daniel
daniel has uploaded a new patch set (#3) to the change originally created by Pau Espin Pedrol. ( https://gerrit.osmocom.org/6598 ) Change subject: bsc-nat: Enable octet-aligned when ensuring mode set .. bsc-nat: Enable octet-ali

Change in osmo-bts[master]: bts_model: Allow TS connect to be processed asynchronously

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11931 ) Change subject: bts_model: Allow TS connect to be processed asynchronously .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.o

Change in osmo-bsc[master]: send Immediate Assignment Reject only before Immediate Assignment

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11940 ) Change subject: send Immediate Assignment Reject only before Immediate Assignment .. send Immediate Assignment Reject only before Im

Change in osmo-ttcn3-hacks[master]: BSC_Tests.ttcn: introduce TC_chan_deact_silence

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11939 ) Change subject: BSC_Tests.ttcn: introduce TC_chan_deact_silence .. BSC_Tests.ttcn: introduce TC_chan_deact_silence The idea of this

Change in osmo-ttcn3-hacks[master]: BSC_Tests.ttcn: introduce TC_chan_deact_silence

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11939 ) Change subject: BSC_Tests.ttcn: introduce TC_chan_deact_silence .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/

Change in osmo-bsc[master]: send Immediate Assignment Reject only before Immediate Assignment

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11940 ) Change subject: send Immediate Assignment Reject only before Immediate Assignment .. Patch Set 2: Code-Review+2 -- To view, visit https://

Change in openbsc[master]: bsc-nat: Enable octet-aligned when ensuring mode set

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/6598 ) Change subject: bsc-nat: Enable octet-aligned when ensuring mode set .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/659

Build failed in Jenkins: master-simtrace2 » a1=default,a2=default,a3=default,osmocom-master-debian9 #202

2018-11-26 Thread jenkins
See -- [...truncated 168.35 KB...] 8 0 0 8 8 obj/owhw/dfu_boardver_adc.o 30

Change in osmo-dev[master]: Add expect script: 'vty' for easy access to all vtys

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11811 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Patch Set 2: Code-Review+1 nice. I wouldn't mind at all to add it h

Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11654 ) Change subject: paging: Add VTY options to calculate T3113 timeout dynamically .. Patch Set 4: Code-Review+1 (2 comments) hmm, if stsp als

Change in osmo-ttcn3-hacks[master]: MSC_Test: Test what happens when Paging for SMS is unanswered

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11897 ) Change subject: MSC_Test: Test what happens when Paging for SMS is unanswered .. Patch Set 4: Code-Review+1 (3 comments) https://gerrit.os

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. Patch Set 4: Code-Review-1 (7 comments) I found a few more thi

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 4: Code-Review+1 (3 comments) Another pass, but

Change in osmo-bsc[master]: send Immediate Assignment Reject only before Immediate Assignment

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11940 ) Change subject: send Immediate Assignment Reject only before Immediate Assignment .. send Immediate Assignment Reject only before Immediate A

Change in osmo-bsc[master]: send Immediate Assignment Reject only before Immediate Assignment

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11940 Change subject: send Immediate Assignment Reject only before Immediate Assignment .. send Immediate Assignment Reject only before Immediate

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/armv7l

2018-11-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: 50

Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/armv7l

2018-11-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: sy

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-26 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11932 ) Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/1

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo

Change in python/osmo-python-tests[master]: osmo_ipa: update split_combined docs

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11938 ) Change subject: osmo_ipa: update split_combined docs .. osmo_ipa: update split_combined docs Change-Id: I1cc6dc314fa0f147ab64ad29d9b892c3637a

Change in python/osmo-python-tests[master]: osmo_ipa: update split_combined docs

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11938 ) Change subject: osmo_ipa: update split_combined docs .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11938 To unsubscribe, or fo

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (1 comment) Having said that, I'd very much welcome your patch which would a

Change in osmo-ttcn3-hacks[master]: MSC_Test: Test what happens when Paging for SMS is unanswered

2018-11-26 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded a new patch set (#4) to the change originally created by dexter. ( https://gerrit.osmocom.org/11897 ) Change subject: MSC_Test: Test what happens when Paging for SMS is unanswered .. MSC_Test: Test w

Change in osmo-ttcn3-hacks[master]: MSC_Test: Test what happens when Paging for SMS is unanswered

2018-11-26 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11897 ) Change subject: MSC_Test: Test what happens when Paging for SMS is unanswered .. Patch Set 3: Oh, I am so sorry. I have been manually tes

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/11929/2/osmopy/osm

Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

2018-11-26 Thread Max
Hello Pau Espin Pedrol, daniel, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11909 to look at the new patch set (#4). Change subject: osmo_ctrl.py: properly ignore out-of-order traps ..

Change in osmo-ttcn3-hacks[master]: BSC_Tests.ttcn: introduce TC_chan_deact_silence

2018-11-26 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11939 Change subject: BSC_Tests.ttcn: introduce TC_chan_deact_silence .. BSC_Tests.ttcn: introduce TC_chan_deact_silence The idea of this test c

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py File

Change in osmo-ttcn3-hacks[master]: MSC_Test: Test what happens when Paging for SMS is unanswered

2018-11-26 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded a new patch set (#3) to the change originally created by dexter. ( https://gerrit.osmocom.org/11897 ) Change subject: MSC_Test: Test what happens when Paging for SMS is unanswered .. MSC_Test: Test w

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: > > is it installed in a correct place so that it can b

Change in python/osmo-python-tests[master]: osmo_ipa: add extended checks

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11937 ) Change subject: osmo_ipa: add extended checks .. osmo_ipa: add extended checks Make sure we properly handle None objects. Change-Id: If5ddc0

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11936 To unsubs

Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11909 ) Change subject: osmo_ctrl.py: properly ignore out-of-order traps .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/1192

Change in python/osmo-python-tests[master]: osmo_ipa: add extended checks

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11937 ) Change subject: osmo_ipa: add extended checks .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11937/1/osmopy/o

Change in python/osmo-python-tests[master]: osmo_ipa: update split_combined docs

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11938 ) Change subject: osmo_ipa: update split_combined docs .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11938/1/o

Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add function to skip TRAP messages .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11929 To unsubscribe, o

Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11909 ) Change subject: osmo_ctrl.py: properly ignore out-of-order traps .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11909 To unsubs

Change in python/osmo-python-tests[master]: ctrl: cosmetic cleanup

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11930 ) Change subject: ctrl: cosmetic cleanup .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11930 To unsubscribe, or for help writing

Change in python/osmo-python-tests[master]: osmo_ipa: add extended checks

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11937 Change subject: osmo_ipa: add extended checks .. osmo_ipa: add extended checks Make sure we properly handle None objects. Change-Id: If5ddc04b8a5dc26e

Change in python/osmo-python-tests[master]: osmo_ipa: update split_combined docs

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11938 Change subject: osmo_ipa: update split_combined docs .. osmo_ipa: update split_combined docs Change-Id: I1cc6dc314fa0f147ab64ad29d9b892c3637a51c7 --- M

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/

Change in osmo-gsm-manuals[master]: ctrl: clarify use of id = 0

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11927 ) Change subject: ctrl: clarify use of id = 0 .. ctrl: clarify use of id = 0 Change-Id: Ic00de5023e7a1ec6426a0178778d35b13c337271 --- M common/

Change in osmo-gsm-manuals[master]: ctrl: clarify use of id = 0

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11927 ) Change subject: ctrl: clarify use of id = 0 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11927 To unsubscribe

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-bts[master]: bts-trx: early return on POWERON success

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11905 ) Change subject: bts-trx: early return on POWERON success .. bts-trx: early return on POWERON success Later on it's expected to add m

Change in osmo-mgw[master]: fix osmo-mgw -s; fixes osmo-mgw.service using -s

2018-11-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11925 ) Change subject: fix osmo-mgw -s; fixes osmo-mgw.service using -s .. fix osmo-mgw -s; fixes osmo-mgw.service using -s Even though os

Change in osmo-bts[master]: cosmetic: fix whitespace

2018-11-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11906 ) Change subject: cosmetic: fix whitespace .. cosmetic: fix whitespace Change-Id: Iaa4552844db33fe69da5ed7028dbfa0100c33900 --- M incl

Change in osmo-bts[master]: bts-trx: early return on POWERON success

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11905 ) Change subject: bts-trx: early return on POWERON success .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11905 T

Change in python/osmo-python-tests[master]: ctrl: add optional TRAP-skipping parameter to split_combined()

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add optional TRAP-skipping parameter to split_combined() .. Patch Set 1: In my opinion this is not the best approa

Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11909 ) Change subject: osmo_ctrl.py: properly ignore out-of-order traps .. Patch Set 2: Code-Review+1 See my comment in previous commit. -- T

Change in python/osmo-python-tests[master]: ctrl: add optional TRAP-skipping parameter to split_combined()

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 ) Change subject: ctrl: add optional TRAP-skipping parameter to split_combined() .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/

Change in python/osmo-python-tests[master]: ctrl: introduce constant for TRAP id

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11928 ) Change subject: ctrl: introduce constant for TRAP id .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11928 T

Change in python/osmo-python-tests[master]: ctrl: introduce constant for TRAP id

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11928 ) Change subject: ctrl: introduce constant for TRAP id .. ctrl: introduce constant for TRAP id Use it for TRAP message parsing and generation.

Change in openbsc[master]: bsc-nat: Enable octet-aligned when ensuring mode set

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/6598 ) Change subject: bsc-nat: Enable octet-aligned when ensuring mode set .. Patch Set 2: Code-Review+1 (1 comment) Looks good to me, can you change the

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11936 Change subject: Move common Trap-related code into separate file .. Move common Trap-related code into separate file The ctrl2cgi.py is heavily based u

Change in osmo-trx[master]: lms: Apply LMS->OSMO log level conversion

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11902 ) Change subject: lms: Apply LMS->OSMO log level conversion .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11902 To unsu

Change in python/osmo-python-tests[master]: ctrl: cosmetic cleanup

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11930 ) Change subject: ctrl: cosmetic cleanup .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11930/1/scripts/osmo_ctrl.py File

Change in libosmocore[master]: ctrl: use #define for TRAP id

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11926 ) Change subject: ctrl: use #define for TRAP id .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11926/1/src/ctrl/control_if.c File src/ct

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-26 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11932 to look at the new patch set (#2). Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT .

Change in osmo-bts[master]: cosmetic: fix whitespace

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11906 ) Change subject: cosmetic: fix whitespace .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11906 To unsubscribe, or for h

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11932 ) Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/1

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11932 ) Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/

Change in python/osmo-python-tests[master]: ctrl2cgi: remove unused function

2018-11-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11935 ) Change subject: ctrl2cgi: remove unused function .. ctrl2cgi: remove unused function Change-Id: I1bff680b301b06e3b178d59bdcb86c4773ad9296 ---

Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

2018-11-26 Thread daniel
daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/11934 ) Change subject: ctrl2cgi: explicitly ignore arguments to lambda function .. ctrl2cgi: explicitly ignore arguments to lambda function Make

Change in python/osmo-python-tests[master]: ctrl2cgi: log traps via debug facility

2018-11-26 Thread daniel
daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/11933 ) Change subject: ctrl2cgi: log traps via debug facility .. ctrl2cgi: log traps via debug facility Change-Id: I21ff593be420a374a00073953c925

Change in python/osmo-python-tests[master]: ctrl2cgi: remove unused function

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11935 ) Change subject: ctrl2cgi: remove unused function .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11935 To un

Change in python/osmo-python-tests[master]: ctrl2cgi: log traps via debug facility

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11933 ) Change subject: ctrl2cgi: log traps via debug facility .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11933

Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11934 ) Change subject: ctrl2cgi: explicitly ignore arguments to lambda function .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit

Change in osmo-bts[master]: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11904 ) Change subject: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK .. rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK

Change in osmo-bts[master]: rsl: Log lchan state during dynts PDCH->TCH

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11903 ) Change subject: rsl: Log lchan state during dynts PDCH->TCH .. rsl: Log lchan state during dynts PDCH->TCH Change-Id: Iee5ac0550

Change in python/osmo-python-tests[master]: ctrl2cgi: remove unused function

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11935 Change subject: ctrl2cgi: remove unused function .. ctrl2cgi: remove unused function Change-Id: I1bff680b301b06e3b178d59bdcb86c4773ad9296 --- M scripts

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-26 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11932 ) Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT .. Patch Set 1: Code-Review-1 (5 comments) https://gerrit.osm

Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11934 ) Change subject: ctrl2cgi: explicitly ignore arguments to lambda function .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/

Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11934 ) Change subject: ctrl2cgi: explicitly ignore arguments to lambda function .. Patch Set 2: (1 comment) python tends to defer errors to the very last mo

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-26 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11932 ) Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/1

Change in python/osmo-python-tests[master]: ctrl2cgi: log traps via debug facility

2018-11-26 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11933 ) Change subject: ctrl2cgi: log traps via debug facility .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11933 To unsubsc

Change in osmo-bts[master]: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11904 ) Change subject: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoc

Change in osmo-bts[master]: rsl: Log lchan state during dynts PDCH->TCH

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11903 ) Change subject: rsl: Log lchan state during dynts PDCH->TCH .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1190

Change in osmo-bts[master]: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11932 ) Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.o

Change in libosmocore[master]: ctrl: print textual error on IPA parsing failure

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11910 ) Change subject: ctrl: print textual error on IPA parsing failure .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11934 ) Change subject: ctrl2cgi: explicitly ignore arguments to lambda function .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmoc

Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11934 ) Change subject: ctrl2cgi: explicitly ignore arguments to lambda function .. Patch Set 2: See updated version. -- To view, visit https://gerrit.osmoc

Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11934 ) Change subject: ctrl2cgi: explicitly ignore arguments to lambda function .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11934 T

Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11934 Change subject: ctrl2cgi: explicitly ignore arguments to lambda function .. ctrl2cgi: explicitly ignore arguments to lambda function Change-Id: I440353

Change in python/osmo-python-tests[master]: ctrl2cgi: log traps via debug facility

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11933 ) Change subject: ctrl2cgi: log traps via debug facility .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11933

Change in python/osmo-python-tests[master]: ctrl2cgi: log traps via debug facility

2018-11-26 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11933 to look at the new patch set (#2). Change subject: ctrl2cgi: log traps via debug facility .. ctrl2cgi: log traps via

  1   2   >