Change in python/osmo-python-tests[master]: ctrl2cgi: update shared helper

2019-01-08 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/12473 ) Change subject: ctrl2cgi: update shared helper .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12473 To unsubscribe, or

Change in python/osmo-python-tests[master]: ctrl2cgi: update shared helper

2019-01-08 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12473 ) Change subject: ctrl2cgi: update shared helper .. ctrl2cgi: update shared helper * split hash generation into simpler functions * move them i

Change in libosmocore[master]: add osmo_mi_name(), for MI-to-string like "IMSI-123456"

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12468 ) Change subject: add osmo_mi_name(), for MI-to-string like "IMSI-123456" .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12468/3/src/gsm/gs

Change in osmo-msc[master]: Add SGs Interface

2019-01-08 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing m

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-08 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12478 Change subject: VLR: send CHECK-IMEI to EIR/HLR .. VLR: send CHECK-IMEI to EIR/HLR When check-imei-req is enabled in the VTY config, do not accept I

Change in osmo-msc[master]: msc_vty.c: make check-imei-rqd configurable

2019-01-08 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12302 to look at the new patch set (#2). Change subject: msc_vty.c: make check-imei-rqd configurable .. msc_vty.c: make che

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-08 Thread osmith
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR .. VLR: send CHECK-IMEI to EIR/HLR When check-imei-req is enabled in the VTY config, do not accept IM

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-08 Thread osmith
osmith has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR .. VLR: send CHECK-IMEI to EIR/HLR When check-imei-req is enabled in the VTY config, do not accept IM

Change in osmo-msc[master]: msc_vty.c: make check-imei-rqd configurable

2019-01-08 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12302 to look at the new patch set (#3). Change subject: msc_vty.c: make check-imei-rqd configurable .. msc_vty.c: make che

Change in osmo-msc[master]: Store subscriber's cell identity

2019-01-08 Thread Max
Hello Stefan Sperling, Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11746 to look at the new patch set (#4). Change subject: Store subscriber's cell identity ..

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-08 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12478 to look at the new patch set (#4). Change subject: VLR: send CHECK-IMEI to EIR/HLR .. VLR: send CHECK-IMEI to EIR/HLR

Change in osmo-msc[master]: msc_vty.c: make check-imei-rqd configurable

2019-01-08 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12302 to look at the new patch set (#4). Change subject: msc_vty.c: make check-imei-rqd configurable .. msc_vty.c: make che

Change in osmo-msc[master]: libmsc/gsm_04_80.c: HACK: reimplement GSM 04.08 RELEASE COMPLETE

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11991 ) Change subject: libmsc/gsm_04_80.c: HACK: reimplement GSM 04.08 RELEASE COMPLETE .. Patch Set 4: Code-Review-1 It's good that it's posted as a referen

Change in osmo-msc[master]: VLR: vlr_subscr_{, msisdn_or_}name: const vsub arg

2019-01-08 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12480 Change subject: VLR: vlr_subscr_{,msisdn_or_}name: const vsub arg .. VLR: vlr_subscr_{,msisdn_or_}name: const vsub arg Make the vsub argument of bot

Change in osmo-msc[master]: vlr_core.h: remove duplicate declarations

2019-01-08 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12479 Change subject: vlr_core.h: remove duplicate declarations .. vlr_core.h: remove duplicate declarations Remove vlr_subscr_name() and vlr_subscr_alloc

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-08 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12478 to look at the new patch set (#6). Change subject: VLR: send CHECK-IMEI to EIR/HLR .. VLR: send CHECK-IMEI to EIR/HLR

Change in python/osmo-python-tests[master]: Add initial version of asyncio trap2cgi script

2019-01-08 Thread Max
Hello Vadim Yanitskiy, daniel, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12476 to look at the new patch set (#3). Change subject: Add initial version of asyncio trap2cgi script .

Change in osmo-msc[master]: gsm_04_08: Fix nullpointer deref

2019-01-08 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12481 Change subject: gsm_04_08: Fix nullpointer deref .. gsm_04_08: Fix nullpointer deref The pointers conn, conn->vsub and conn->vsub->last_tuple are ch

Change in osmo-msc[master]: VLR: vlr_subscr_{, msisdn_or_}name: const vsub arg

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12480 ) Change subject: VLR: vlr_subscr_{,msisdn_or_}name: const vsub arg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12480 To

Change in osmo-msc[master]: vlr_core.h: remove duplicate declarations

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12479 ) Change subject: vlr_core.h: remove duplicate declarations .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12479 To unsubsc

Change in osmo-msc[master]: gsm_04_08: Fix nullpointer deref

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12481 ) Change subject: gsm_04_08: Fix nullpointer deref .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12481 To unsubscribe, or

Change in osmo-msc[master]: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11920 ) Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP .. Patch Set 12: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11920

Change in osmo-bsc[master]: paging: fix nullpointer deref

2019-01-08 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12482 Change subject: paging: fix nullpointer deref .. paging: fix nullpointer deref In theroy the finction T_def_get_entry() may return a nullpointer. In

Change in osmo-msc[master]: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP

2019-01-08 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11920 ) Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP .. Patch Set 12: > Patch Set 12: Code-Review-1 Sorry, but I don't t

Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12470 ) Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12470/1/tests/msc_v

Change in osmo-msc[master]: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11920 ) Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP .. Patch Set 12: > Is there any rule in Osmocom that we have to use 'const' every

Change in libosmocore[master]: LCLS: don't encode incorrect values

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12375 ) Change subject: LCLS: don't encode incorrect values .. Patch Set 2: (1 comment) Addressed in latest revision. https://gerrit.osmocom.org/#/c/12375/1

Change in osmo-msc[master]: Store subscriber's cell identity

2019-01-08 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11746 ) Change subject: Store subscriber's cell identity .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11746/4//COMMIT_MSG Commit M

Change in osmo-msc[master]: Store subscriber's cell identity

2019-01-08 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11746 ) Change subject: Store subscriber's cell identity .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11746/4/src/libmsc/iucs.c Fi

Change in osmo-msc[master]: Add SGs Interface

2019-01-08 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 29: (4 comments) https://gerrit.osmocom.org/#/c/11642/29/include/osmocom/msc/ran_conn.h F

Change in libosmocore[master]: msgb: fix debug print

2019-01-08 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12484 Change subject: msgb: fix debug print .. msgb: fix debug print Since osmo_hexdump() use static buffers we can't re-use pointers to it after subsequent

Change in libosmocore[master]: LCLS: add status parameter to Assignment Completed message

2019-01-08 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12483 Change subject: LCLS: add status parameter to Assignment Completed message .. LCLS: add status parameter to Assignment Completed message * add gsm0808_

Change in libosmocore[master]: LCLS: add status parameter to Assignment Completed message

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12483 ) Change subject: LCLS: add status parameter to Assignment Completed message .. Patch Set 2: This change is ready for review. -- To view, visit https:

Change in libosmocore[master]: add osmo_lu_type_names[], osmo_lu_type_name()

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12469 ) Change subject: add osmo_lu_type_names[], osmo_lu_type_name() .. add osmo_lu_type_names[], osmo_lu_type_name() Move lupd_names[] fr

Change in libosmocore[master]: add osmo_mi_name(), for MI-to-string like "IMSI-123456"

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12468 ) Change subject: add osmo_mi_name(), for MI-to-string like "IMSI-123456" .. add osmo_mi_name(), for MI-to-string like "IMSI-123456"

Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12470 ) Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12470/1/

Change in osmo-bsc[master]: use mgcp-client configured endpoint domain name

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12358 ) Change subject: use mgcp-client configured endpoint domain name .. use mgcp-client configured endpoint domain name Rationale: readi

Change in python/osmo-python-tests[master]: Add initial version of asyncio trap2cgi script

2019-01-08 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/12476 ) Change subject: Add initial version of asyncio trap2cgi script .. Patch Set 3: Can you also change debian/rules so the new service file is correctl

Change in osmo-msc[master]: use mgcp-client configured endpoint domain name

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12361 ) Change subject: use mgcp-client configured endpoint domain name .. use mgcp-client configured endpoint domain name Rationale: readi

Change in osmo-bsc[master]: LCLS: constify helper parameters

2019-01-08 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12485 Change subject: LCLS: constify helper parameters .. LCLS: constify helper parameters Related: OS#2487 Change-Id: I341f4ea172432b94e8e96919926a5fb6870c2

Change in osmo-bsc[master]: LCLS: use libosmocore function to add status

2019-01-08 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12486 Change subject: LCLS: use libosmocore function to add status .. LCLS: use libosmocore function to add status * use gsm0808_create_ass_compl2() to add B

Change in python/osmo-python-tests[master]: Add initial version of asyncio trap2cgi script

2019-01-08 Thread Max
Hello Vadim Yanitskiy, daniel, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12476 to look at the new patch set (#4). Change subject: Add initial version of asyncio trap2cgi script .

Change in python/osmo-python-tests[master]: deb: fix wrong changelog date

2019-01-08 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12487 Change subject: deb: fix wrong changelog date .. deb: fix wrong changelog date Issue was discovered with lintian - likely a copy-paste error. Change-I

Change in python/osmo-python-tests[master]: Add initial version of asyncio trap2cgi script

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12476 ) Change subject: Add initial version of asyncio trap2cgi script .. Patch Set 4: > Can you also change debian/rules so the new service file is correctly

Change in osmo-msc[master]: Log MI type on request failure

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12365 ) Change subject: Log MI type on request failure .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/12365 T

Change in python/osmo-python-tests[master]: Add initial version of asyncio trap2cgi script

2019-01-08 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/12476 ) Change subject: Add initial version of asyncio trap2cgi script .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12476 To

Change in libosmocore[master]: Cosmetic: GSUP: note "on wire" for imei_result

2019-01-08 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12488 Change subject: Cosmetic: GSUP: note "on wire" for imei_result .. Cosmetic: GSUP: note "on wire" for imei_result Note that OSMO_GSUP_IMEI_RESULT_ACK

Change in osmo-msc[master]: Add SGs Interface

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 29: Code-Review-1 (35 comments) Haven't managed to read everything yet. so far... https://

Change in osmo-msc[master]: gsm_04_08: Fix nullpointer deref

2019-01-08 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12481 ) Change subject: gsm_04_08: Fix nullpointer deref .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12481 To un

Change in libosmocore[master]: msgb: fix debug print

2019-01-08 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12484 ) Change subject: msgb: fix debug print .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12484/1/src/msgb.c File src/msgb.c:

Change in osmo-trx[master]: convolve: Remove support for step, offset parameters

2019-01-08 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12415 ) Change subject: convolve: Remove support for step, offset parameters .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osm

Change in osmo-trx[master]: tests: Rework the convolve_test

2019-01-08 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12416 ) Change subject: tests: Rework the convolve_test .. Patch Set 4: (3 comments) https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52

Change in osmo-trx[master]: arm/convolve: Fix the vfp4 real convolution for h_len=12

2019-01-08 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12417 ) Change subject: arm/convolve: Fix the vfp4 real convolution for h_len=12 .. Patch Set 4: Code-Review+1 I guess you tested by running the

Change in osmo-trx[master]: tests: Re-enable the convolve_test by default

2019-01-08 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12418 ) Change subject: tests: Re-enable the convolve_test by default .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.or

Change in libosmocore[master]: msgb: fix debug print

2019-01-08 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12484 ) Change subject: msgb: fix debug print .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12484/1/src/msgb.c File src/msgb.c: https://gerrit

Change in libosmocore[master]: msgb: fix debug print

2019-01-08 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12484 ) Change subject: msgb: fix debug print .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12484 To unsubscribe,

Change in osmo-msc[master]: refactor log ctx for vlr_subscr and ran_conn

2019-01-08 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12402 to look at the new patch set (#9). Change subject: refactor log ctx for vlr_subscr and ran_conn .. refa

Change in osmo-trx[master]: convolve: Remove support for step, offset parameters

2019-01-08 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12415 ) Change subject: convolve: Remove support for step, offset parameters .. Patch Set 1: Code-Review+1 (3 comments) Looks fine, just a few c