A similar issue happens in terms of rendering time if you look at a giant
change set, the caching seems pretty minimal on a lot of the rendering
steps in gitlab.
On Fri, Jan 11, 2019 at 11:05 AM Richard Eisenberg
wrote:
>
>
> On Jan 11, 2019, at 4:49 AM, Simon Peyton Jones
> wrote:
>
> When I t
> On Jan 11, 2019, at 4:49 AM, Simon Peyton Jones wrote:
>
> When I try that, it starts by displaying the code from the file. No rotating
> circles or anything. But if I wait ten seconds, suddenly the comments appear.
> So:
> rendering seems terribly slow
> there is no indication that it i
y to see the
recent changes.
How sad!
Simon
From: Richard Eisenberg
Sent: 10 January 2019 19:05
To: Ben Gamari
Cc: Simon Peyton Jones ; Evan Laforge
; ghc-devs
Subject: Re: Reviews
While we're whinging:
- I'm looking at the Discussion page for an MR
(https://gitlab.haskell
displays a kind of skeleton page with horizontal grey bars that
flash occasionally. Then it renders.
Simon
From: Richard Eisenberg
Sent: 10 January 2019 19:05
To: Ben Gamari
Cc: Simon Peyton Jones ; Evan Laforge
; ghc-devs
Subject: Re: Reviews
While we're whinging:
-
While we're whinging:
- I'm looking at the Discussion page for an MR
(https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904) and I see a
comment Simon made, beginning with "No, I am not!". I wanted a bit more
context. So I click on the filename above the Discussion and am warped to the
Simon Peyton Jones writes:
> | Another issue is that apparently GitLab still sends one email per comment
> | instead of one comment per batch. This will evidently be fixed in GitLab
> | 11.6 [1].
>
> yes that is TERRIBLE. When does 11.6 land?
>
It is the next release. I will poke our contact
Simon Peyton Jones writes:
> To return to the original question, how do I add an overall comment for a
> (multi-comment) review?
>
Unfortunately you can only add an overall comment separate from the
multi-comment review. I have inquired [1] about the status of this
feature with upstream.
Cheers
i
| Sent: 10 January 2019 17:46
| To: Simon Peyton Jones ; Evan Laforge
|
| Cc: ghc-devs
| Subject: RE: Reviews
|
| Simon Peyton Jones via ghc-devs writes:
|
| > | > When submitting a review, I often want to add an overall comment,
| > | not related to a particular line of
Simon Peyton Jones via ghc-devs writes:
> | > When submitting a review, I often want to add an overall comment, not
> | related to a particular line of code? How do I do that?
> |
> | I do that by going back to the "Discussion" tab and adding something at the
> | bottom.
>
> But alas then
To return to the original question, how do I add an overall comment for a
(multi-comment) review?
Simon
| -Original Message-
| From: Ben Gamari
| Sent: 10 January 2019 17:41
| To: Evan Laforge ; Simon Peyton Jones
|
| Cc: ghc-devs
| Subject: Re: Reviews
|
| Evan Laforge
Evan Laforge writes:
> On Tue, Jan 8, 2019 at 8:54 PM Simon Peyton Jones
> wrote:
>> | > When submitting a review, I often want to add an overall comment, not
>> | related to a particular line of code? How do I do that?
>> |
>> | I do that by going back to the "Discussion" tab and adding s
On Tue, Jan 8, 2019 at 8:54 PM Simon Peyton Jones wrote:
> | > When submitting a review, I often want to add an overall comment, not
> | related to a particular line of code? How do I do that?
> |
> | I do that by going back to the "Discussion" tab and adding something at the
> | bottom.
>
>
landing as a single email.
It becomes a separate, disconnected comment.
Simon
| -Original Message-
| From: Evan Laforge
| Sent: 08 January 2019 12:48
| To: Simon Peyton Jones
| Cc: ghc-devs
| Subject: Re: Reviews
|
| On Tue, Jan 8, 2019 at 6:01 PM Simon Peyton Jones via gh
On Tue, Jan 8, 2019 at 6:01 PM Simon Peyton Jones via ghc-devs
wrote:
>
> When reviewing a MR, I sometimes want to look at (and even add comments to)
> code that isn’t displayed in the MR window. With Phab there was a “show 20
> more lines” link, and even “show the whole file”. How do I do tha
14 matches
Mail list logo
