Re: [PATCH v2 00/21]

Nguyễn Thái Ngọc Duy writes: > Changes since v1: > > - fopen_or_warn() and warn_on_fopen_errors() are introduced. The >latter's name is probably not great... > - A new patch (first one) to convert a bunch to using xfopen() > - Fix test failure on Windows, found by

Re: [PATCH v2 04/21] wrapper.c: add warn_on_fopen_errors()

Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > dir.c | 3 +-- > git-compat-util.h | 2 ++ > wrapper.c | 10 ++ > 3 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/dir.c b/dir.c >

Re: Bug report: Git Stash; spelling mistake of stash followed by a yes prints character 'y' infinite times.

Jeff King writes: >> 4. Now git says git: 'stahs' is not a git command. See 'git --help'. >> >> Did you mean this? >> >> stash > > After this step git exits, and you're back at your shell prompt... Perhaps the suggestion message should be rephrased not to sound like it is

Re: [PATCH 0/5] Abide by our own rules regarding line endings

Johannes Schindelin writes: > For starters, those files include shell scripts: the most prevalent > shell interpreter in use (and certainly used in Git for Windows) is > Bash, and Bash does not handle CR/LF line endings gracefully. Good to know. I am not sure if it

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

Johannes Schindelin writes: >> If 'git-rebase--interactive.sh' is bound to be replaced, I could >> just shrink this to the Documentation cleanup (patches 4 and 5) >> and rework the rest on top of your new implementation. > > I kind of hoped that Junio would chime in

Re: Proposal for missing blob support in Git repos

Jonathan Tan writes: > I see the semantics as "don't write what you already have", where > "have" means what you have in local storage, but if you extend "have" > to what upstream has, then yes, you're right that this changes > (ignoring shallow clones). > > This does

Re: [PATCH v2 23/25] name-rev: avoid leaking memory in the `deref` case

Johannes Schindelin writes: > Hi Junio, > > On Mon, 1 May 2017, Junio C Hamano wrote: > >> Junio C Hamano writes: >> >> > Johannes Schindelin writes: >> > >> >> diff --git a/builtin/name-rev.c b/builtin/name-rev.c >>

Re: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS

On 05/03, Samuel Lijin wrote: > On Wed, May 3, 2017 at 12:14 PM, Stefan Beller wrote: > > On Wed, May 3, 2017 at 4:31 AM, Samuel Lijin wrote: > >> > >> Just to throw out an example, I'm relatively new to the codebase (I've > >> been lurking on the mailing

Re: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS

On 05/03, Junio C Hamano wrote: > Duy Nguyen writes: > > >>> In the long run we may want to drop the macros guarded by > >>> NO_THE_INDEX_COMPATIBILITY_MACROS. This converts a couple of them. > >> > >> Why? > > > > Well.. why did you add NO_THE_INDEX_COMP... in the first

Re: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS

Duy Nguyen writes: >>> In the long run we may want to drop the macros guarded by >>> NO_THE_INDEX_COMPATIBILITY_MACROS. This converts a couple of them. >> >> Why? > > Well.. why did you add NO_THE_INDEX_COMP... in the first place? ;-) j/k That was to mark the code that

Re: [PATCH] send-email: new option to walkaround email server limits

For the list, in plain text: IIUC, they use the date received to sort. I think this might stem from a historical cruft: emails sometimes took non-trivial amounts of time to transit, back in the old days. MUAs (especially web-based ones) probably did not want to violate user expectation by placing

Re: [PATCH] i18n: remove i18n from tag reflog message

Jean-Noël AVILA writes: > Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit : >> Jean-Noel Avila writes: >> > The building of the reflog message is using strbuf, which is not >> > friendly with internationalization frameworks. No other reflog >>

Re: [PATCH] i18n: remove i18n from tag reflog message

Jean-Noël AVILA writes: > Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit : >> Jean-Noel Avila writes: >> > The building of the reflog message is using strbuf, which is not >> > friendly with internationalization frameworks. No other reflog >>

Re: [PATCH] send-email: new option to walkaround email server limits

Ævar Arnfjörð Bjarmason writes: > It makes sense to have a configurable delay for git-send-email > unrelated to this option, I'd use a facility like that. > > A lot of mail clients just sort based on date/msgid or whatever not > date/subject, so the rapid-fire output of

Re: [PATCH v2 00/53] object_id part 8

On Mon, May 01, 2017 at 02:28:53AM +, brian m. carlson wrote: > This is the eighth series of patches to convert unsigned char [20] to > struct object_id. This series converts lookup_commit, lookup_blob, > lookup_tree, lookup_tag, and finally parse_object to struct object_id. I've made the

Re: [PATCH v2 02/53] Clean up outstanding object_id transforms.

On Tue, May 02, 2017 at 11:05:14AM -0700, Brandon Williams wrote: > On 05/01, brian m. carlson wrote: > > - if (!logobj && commit_reflog->recno >= 0 && > > is_null_sha1(reflog->ooid.hash)) { > > + if (!logobj && commit_reflog->recno >= 0 && is_null_oid(>ooid)) > > { > > Not relevant to this

[PATCH] archive-tar: fix a sparse 'constant too large' warning

Commit dddbad728c ("timestamp_t: a new data type for timestamps", 26-04-2017) introduced a new typedef 'timestamp_t', as a synonym for an unsigned long, which was used at the time to represent timestamps in git. A later commit 28f4aee3fb ("use uintmax_t for timestamps", 26-04-2017) changed the

Re: [PATCH v2 03/53] Convert struct cache_tree to use struct object_id

On Tue, May 02, 2017 at 11:13:08AM -0700, Brandon Williams wrote: > Should this 20 be converted to GIT_{SHA1,MAX}_RAWSZ? I know this is a > generated patch so maybe this is addressed, or will be addressed later? Since this is a purely mechanical patch, I plan on addressing it later. I'll

Re: [PATCH v2 11/53] fast-import: convert to struct object_id

On Mon, May 01, 2017 at 06:27:58PM -0400, Jeff King wrote: > If you have 40 hex digits, then you have 20 hex pairs. But delimiting > them all takes only 19 slashes, since they only go in between pairs[1]. > > So the fully expanded formula is: > > GIT_MAX_HEXSZ + (1) actual hex

Re: [PATCH v2 39/53] refs/files-backend: convert many internals to struct object_id

On Mon, May 01, 2017 at 04:24:23PM -0700, Jonathan Tan wrote: > On 04/30/2017 07:29 PM, brian m. carlson wrote: > > - if (line->len <= 42) > > + if (!line->len) > > return NULL; > > I would omit this check - parse_oid_hex already exits early if the first > character is NUL. (The

Incorrect handling of interactive rebases with root flag

If I run an interactive rebase on a branch without the --root flag, git does not modify (change the hash, etc.) any initial commits that are being "pick"ed in the same order. However, if I use --root, every single commit is modified. Here's an example: * Old (immediately after running "git

[PATCH v2] travis-ci: retry if Git for Windows CI returns HTTP error 502 or 503

The Git for Windows CI web app sometimes returns HTTP errors of "502 bad gateway" or "503 service unavailable" [1]. We also need to check the HTTP content because the GfW web app seems to pass through (error) results from other Azure calls with HTTP code 200. Wait a little and retry the request if

Re: [PATCH 00/10] RFC Partial Clone and Fetch

Hi, Jonathan Tan wrote: > The binary search to lookup a packfile offset from a .idx file > (which involves disk reads) would take longer for all lookups (not > just lookups for missing blobs) - I think I prefer keeping the lists > separate, to avoid pessimizing the (likely) usual case where the

[PATCH v2 2/3] read-tree -m: make error message for merging 0 trees less smart aleck

"git read-tree -m" requires a tree argument to name the tree to be merged in. Git uses a cutesy error message to say so and why: $ git read-tree -m warning: read-tree: emptying the index with no arguments is deprecated; use --empty fatal: just how do you expect me to merge 0

[PATCH v2 3/3] git-filter-branch: make the error msg when missing branch more open

git-filter-branch requires the specification of a branch by one way or another. If no branch appears to have been specified, we know the user got the usage wrong but we don't know what they were trying to do --- e.g. maybe they specified the ref to rewrite but in the wrong place. The safest

[PATCH v2 1/3] usability: don't ask questions if no reply is required

There has been a bug report by a corporate user that stated that "spelling mistake of stash followed by a yes prints character 'y' infinite times." This analysis was false. When the spelling of a command contains errors, the git program tries to help the user by providing candidates which are

Re: [PATCH v3 12/25] split_commit_in_progress(): fix memory leak

Am 02.05.2017 um 18:02 schrieb Johannes Schindelin: Reported via Coverity. Signed-off-by: Johannes Schindelin --- wt-status.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/wt-status.c b/wt-status.c index 0a6e16dbe0f..1f3f6bcb980 100644

Re: [PATCH 00/10] RFC Partial Clone and Fetch

On 05/03/2017 09:38 AM, Jeff Hostetler wrote: On 3/8/2017 1:50 PM, g...@jeffhostetler.com wrote: From: Jeff Hostetler [RFC] Partial Clone and Fetch = [...] E. Unresolved Thoughts == *TODO* The server should optionally

Re: git-clone --config order & fetching extra refs during initial clone

On Wed, May 03, 2017 at 04:42:58PM +0200, SZEDER Gábor wrote: > write_refspec_config() nicely encapsulates writing the proper fetch > refspec configuration according to the given command line options. Of > course these options are already known right at the start, so solely > in this regard we

Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

Hi, Stefan Beller wrote: > On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder wrote: >> Is there e.g. a build farm where we can check for this kind of thing >> more systematically on supported platforms? > > There is the OpenSuse build farm that provides builds for all kinds

Re: Cloning a custom refspec does not work as expected

On Wed, May 03, 2017 at 02:16:47PM +0200, Sebastian Schuberth wrote: > I'd assume that this would work: > > $ git clone -c > remote.origin.fetch=+refs/changes/*:refs/remotes/origin/changes/* > https://gerrit.googlesource.com/git-repo > > In fact, this *does* add the custom refs correct to

Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder wrote: > > Is there e.g. a build farm where we can check for this kind of thing > more systematically on supported platforms? There is the OpenSuse build farm that provides builds for all kinds of linux distributions, though

Re: [PATCH v3 01/25] mingw: avoid memory leak when splitting PATH

Am 02.05.2017 um 18:00 schrieb Johannes Schindelin: In the (admittedly, concocted) case that PATH consists only of colons, we would leak the duplicated string. Nit: It's about semicolons, right? At least that's what get_path_split is searching for. Or is there some kind of translation going

Re: [PATCH v3 02/25] winansi: avoid use of uninitialized value

Am 02.05.2017 um 18:01 schrieb Johannes Schindelin: When stdout is not connected to a Win32 console, we incorrectly used an uninitialized value for the "plain" character attributes. Detected by Coverity. Signed-off-by: Johannes Schindelin --- compat/winansi.c | 2

Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

Ævar Arnfjörð Bjarmason wrote: > Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX. > > Since commit 2f8952250a ("regex: add regexec_buf() that can work on a > non NUL-terminated string", 2016-09-21) git has errored out at > compile-time if the regular expression library doesn't

Re: [PATCH v3] l10n: de.po: update German translation

On Mi, 03 Mai 2017, Ralf Thielow wrote: > Ref or Reference is translated as "Referenz" while > Rev or Revision is translated as "Commit" so I think > the translation is correct. Oh right. I also noticed that sometimes complete sentences were used and sometimes not. It would be nice to have a

Re: [PATCH 3/4] read-tree.c: rework UI when merging no trees

Le mercredi 3 mai 2017, 10:04:01 CEST Jonathan Nieder a écrit : > Hi, > > Jean-Noel Avila wrote: > > Subject: read-tree.c: rework UI when merging no trees > > nit: this is about user-facing behavior, not an implementation detail, > so the part before the colon can be the command that changed >

Re: [PATCH 2/4] usability: fix am and checkout for nevermind questions

Le mercredi 3 mai 2017 09:51:58 CEST, vous avez écrit : > Jean-Noel Avila wrote: > > Subject: usability: fix am and checkout for nevermind questions > > > > Signed-off-by: Jean-Noel Avila > > Thanks for working on improving Git's UX. I agree with the goal in > general (we

Re: [PATCH 1/7] t7300: skip untracked dirs containing ignored files

On Wed, May 3, 2017 at 11:26 AM, Samuel Lijin wrote: > On Wed, May 3, 2017 at 1:19 PM, Stefan Beller wrote: >> On Tue, May 2, 2017 at 8:29 PM, Samuel Lijin wrote: >>> If git sees a directory which contains only untracked and ignored >>>

Re: [PATCH 00/10] RFC Partial Clone and Fetch

Hi, Jeff Hostetler wrote: > On 3/8/2017 1:50 PM, g...@jeffhostetler.com wrote: >> [RFC] Partial Clone and Fetch >> = >> [...] >> E. Unresolved Thoughts >> == >> >> *TODO* The server should optionally return (in a side-band?) a list >> of the blobs

Re: Cloning a custom refspec does not work as expected

On Wed, May 3, 2017 at 5:16 AM, Sebastian Schuberth wrote: > Hi, > > I'm trying to clone a custom ref, avoiding the need to init && fetch > manually. From reading [1] which says: > > "Set a configuration variable in the newly-created repository; this > takes effect

Re: [PATCH 1/7] t7300: skip untracked dirs containing ignored files

On Wed, May 3, 2017 at 1:19 PM, Stefan Beller wrote: > On Tue, May 2, 2017 at 8:29 PM, Samuel Lijin wrote: >> If git sees a directory which contains only untracked and ignored >> files, clean -d should not remove that directory. > > Yes that states a fact;

Re: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS

On Wed, May 3, 2017 at 12:14 PM, Stefan Beller wrote: > On Wed, May 3, 2017 at 4:31 AM, Samuel Lijin wrote: >> >> Just to throw out an example, I'm relatively new to the codebase (I've >> been lurking on the mailing list for a few months now) and for a >>

Re: [PATCH 1/7] t7300: skip untracked dirs containing ignored files

On Tue, May 2, 2017 at 8:29 PM, Samuel Lijin wrote: > If git sees a directory which contains only untracked and ignored > files, clean -d should not remove that directory. Yes that states a fact; it is not clear why we want to have this test here and now. (Is it testing for a

Re: [PATCH 3/7] dir: add method to check if a dir_entry lexically contains another

On Tue, May 2, 2017 at 8:29 PM, Samuel Lijin wrote: > Introduce a method that allows us to check if one dir_entry corresponds > to a path which contains the path corresponding to another dir_entry. > --- > dir.c | 8 > 1 file changed, 8 insertions(+) > > diff --git

Re: [PATCH 1/4] usability: don't ask questions if no reply is required

Le mercredi 3 mai 2017, 09:47:44 CEST Jonathan Nieder a écrit : > Hi, > > Jean-Noel Avila wrote: > > As described in the bug report at > > > > https://github.com/git/git-scm.com/issues/999 > > External issue tracker URLs have been known to change or disappear and > we try to make commit

Re: [PATCH v4] l10n: de.po: update German translation

Hi Ralf, thanks again for your work! > > #: ref-filter.c:565 > -#, fuzzy, c-format > +#, c-format > msgid "format: %%(then) atom used after %%(else)" > -msgstr "Format: %%(end) Atom fehlt" > +msgstr "format: %%(then) nach %%(else) verwendet" > Is there a "Atom" missing? "format: %%(then)

Re: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS

On Wed, May 3, 2017 at 4:31 AM, Samuel Lijin wrote: > On Tue, May 2, 2017 at 9:05 AM, Jeff Hostetler wrote: >> >> >> On 5/2/2017 12:17 AM, Stefan Beller wrote: >>> >>> On Mon, May 1, 2017 at 6:36 PM, Junio C Hamano wrote:

Re: [PATCH 4/4] git-filter-branch: be assertative on dying message

Hi, Jean-Noel Avila wrote: > Signed-off-by: Jean-Noel Avila As with the previous patches, this is a good place to put the motivation for the patch. > --- > git-filter-branch.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/git-filter-branch.sh

Re: [PATCH 3/4] read-tree.c: rework UI when merging no trees

Hi, Jean-Noel Avila wrote: > Subject: read-tree.c: rework UI when merging no trees nit: this is about user-facing behavior, not an implementation detail, so the part before the colon can be the command that changed (read-tree:). nit: the word "rework" is dangerous in a commit message in the

Re: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS

On Wed, May 3, 2017 at 3:27 AM, Duy Nguyen wrote: > On Tue, May 2, 2017 at 8:36 AM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> This applies to origin/master. >>> >>> For better readability and understandability for newcomers

Re: [PATCH 1/4] usability: don't ask questions if no reply is required

+cc rashmipa...@gmail.com On Wed, May 3, 2017 at 9:47 AM, Jonathan Nieder wrote: > Hi, > > Jean-Noel Avila wrote: > >> As described in the bug report at >> >> https://github.com/git/git-scm.com/issues/999 > > External issue tracker URLs have been known to change or disappear

Re: [PATCH 2/4] usability: fix am and checkout for nevermind questions

Jean-Noel Avila wrote: > Subject: usability: fix am and checkout for nevermind questions > > Signed-off-by: Jean-Noel Avila Thanks for working on improving Git's UX. I agree with the goal in general (we should not gratuitously surprise users) but I think I lack context for

Re: [PATCH 1/4] usability: don't ask questions if no reply is required

Hi, Jean-Noel Avila wrote: > As described in the bug report at > > https://github.com/git/git-scm.com/issues/999 External issue tracker URLs have been known to change or disappear and we try to make commit messages self-contained instead of relying on them. It is common to put a

[PATCH v4] l10n: de.po: update German translation

Translate 96 new messages came from git.pot update in dfc182b (l10n: git.pot: v2.13.0 round 1 (96 new, 37 removed)). Signed-off-by: Ralf Thielow --- po/de.po | 323 --- 1 file changed, 142 insertions(+), 181

Re: [PATCH v3] l10n: de.po: update German translation

Am 3. Mai 2017 um 14:38 schrieb Christian Brabandt : > Hallo Ralf! > > Ralf Thielow schrieb am Dienstag, den 02. Mai 2017: > >> @@ -1260,6 +1260,8 @@ msgstr "Speicher verbraucht" >> #: config.c:191 >> msgid "relative config include conditionals must come from files" >> msgstr

Re: [PATCH] i18n: remove i18n from tag reflog message

Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit : > Jean-Noel Avila writes: > > The building of the reflog message is using strbuf, which is not > > friendly with internationalization frameworks. No other reflog > > messages are translated right now and switching

Re: [PATCH 00/10] RFC Partial Clone and Fetch

On 3/8/2017 1:50 PM, g...@jeffhostetler.com wrote: From: Jeff Hostetler [RFC] Partial Clone and Fetch = [...] E. Unresolved Thoughts == *TODO* The server should optionally return (in a side-band?) a list of the blobs

[PATCH 4/4] git-filter-branch: be assertative on dying message

Signed-off-by: Jean-Noel Avila --- git-filter-branch.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-filter-branch.sh b/git-filter-branch.sh index 2b8cdba15..dd3a605d0 100755 --- a/git-filter-branch.sh +++ b/git-filter-branch.sh @@ -239,7 +239,7 @@

[PATCH 3/4] read-tree.c: rework UI when merging no trees

The initial test was inherited from a previous commit, but it is no longer needed, given the following switch case. Moreover, the question sentence ending the program has been replace by an assertative one. Signed-off-by: Jean-Noel Avila --- builtin/read-tree.c | 5 +++-- 1

[PATCH 2/4] usability: fix am and checkout for nevermind questions

Signed-off-by: Jean-Noel Avila --- builtin/am.c | 4 ++-- builtin/checkout.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/am.c b/builtin/am.c index a95dd8b4e..f5afa438d 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -1312,7 +1312,7 @@

[PATCH 1/4] usability: don't ask questions if no reply is required

As described in the bug report at https://github.com/git/git-scm.com/issues/999 the user was disconcerted by the question asked by the program not requiring a reply from the user. To improve the general usability of the Git suite, The following rule was applied: if the sentence * appears in a

Re: [PATCH v2 21/21] t1308: add a test case on open a config directory

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > We don't support config-as-a-directory (maybe someday we will?). Make > sure we consistently fail in this case, which should happen on platforms > where fopen() returns non-NULL if FREAD_READS_DIRECTORIES is > defined. > > Signed-off-by:

Re: [PATCH v2 20/21] config.c: handle error on failing to fopen()

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > In the first case, we already correctly return -1 if fopen() fails to > open. But we should report something so people know what's wrong. > > In the second case, config_file == NULL does not necessarily mean "no > config file". Bail out

Re: [PATCH v2 15/21] rerere.c: report correct errno

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > diff --git a/rerere.c b/rerere.c > index 971bfedfb2..c26c29f87a 100644 > --- a/rerere.c > +++ b/rerere.c > @@ -484,13 +484,14 @@ static int handle_file(const char *path, unsigned char > *sha1, const char *output > io.input =

Re: [PATCH v2 13/21] remote.c: report error on failure to fopen()

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > There's plenty of error() in this code to safely assume --quiet is not a > concern. > > t5512 needs update because if we check the path 'refs*master' (i.e. the > asterisk is part of the path) then we'll get an EINVAL error. So the

Re: [PATCH v2 10/21] log: report errno on failure to fopen() a file

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy I do think that this merits a one-line explanation why you do not use fopen_or_warn() here. > diff --git a/builtin/log.c b/builtin/log.c > index b3b10cc1ed..26d6a3cf14 100644 > ---

Re: [PATCH v2 09/21] blame: report error on open if graft_file is a directory

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/blame.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/builtin/blame.c b/builtin/blame.c > index 07506a3e45..1648b396dc 100644 > ---

Re: [PATCH v2 08/21] bisect: report on fopen() error

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > The main thing to catch here is when fopen() is called on a > directory. It's safe even without this change because a few lines > earlier we do check if "filename" is a regular file. > > Regardless, let's stay on the safe side in case

Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)

[Just replying to you & Duy in the same mail, easier] On Wed, May 3, 2017 at 11:45 AM, Johannes Schindelin wrote: > Hi Ævar, > > On Tue, 2 May 2017, Ævar Arnfjörð Bjarmason wrote: > >> On Tue, May 2, 2017 at 6:05 PM, Johannes Schindelin >>

Re: [PATCH v2 06/21] attr.c: use fopen_or_warn()

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy As commented about warn_on_fopen_errors(), I do not see a benefit in separating the introduction of this small function from the individual files' changes to use it. Let's bring it

Re: [PATCH v2 04/21] wrapper.c: add warn_on_fopen_errors()

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy This commit message is a bit empty. How about: In many places, Git warns about an inaccessible file after a fopen() failed. To discern these cases from other cases

Re: [PATCH v2 02/21] clone: use xfopen() instead of fopen()

Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > This code uses the result FILE pointer right away without the NULL > check. Let's use xfopen() and die if we could not open the file. That's > still better than crashing, > > Signed-off-by: Nguyễn Thái Ngọc Duy While

Re: git-clone --config order & fetching extra refs during initial clone

Cc'ing Ævar because of his work on 'clone --no-tags'. On Wed, Mar 15, 2017 at 6:08 PM, Jeff King wrote: > On Sat, Mar 11, 2017 at 01:41:34AM +0100, SZEDER Gábor wrote: >> > Though if I'm bikeshedding, I'd probably have written the whole thing >> > with an argv_array and avoided

Re: CYGWIN git cannot install python packages with pip

Hi, On Wed, 3 May 2017, ankostis wrote: > On 3 May 2017 11:47, Johannes Schindelin wrote: > > On Tue, 2 May 2017, ankostis wrote: > > > >> On Windows, with Cygwin-git 02.12.2-1 the python command: > >> [...] > > > > You forgot to mention what python/pip you use (is

Re: [PATCH 0/5] Abide by our own rules regarding line endings

Hi Jonathan, On Tue, 2 May 2017, Jonathan Nieder wrote: > Johannes Schindelin wrote: > > > Over the past decade, there have been a couple of attempts to remedy the > [...] > > I'm intentionally skimming this cover letter, since anything important > it says needs to also be in the commit

Re God Bless You and Happy Easter!

Hello My Dear, This is my second mail but No response,from you Why? regarding my Easter Donation Gift" Reminding notice/ this is to inform you that i am still in the hospital bed taking a medical treatments because of my Old age illness.Please i need your urgent answer/ i want to know if you

[PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX. Since commit 2f8952250a ("regex: add regexec_buf() that can work on a non NUL-terminated string", 2016-09-21) git has errored out at compile-time if the regular expression library doesn't support REG_STARTEND. While looking through

Re: [PATCH v3] l10n: de.po: update German translation

Hallo Ralf! Ralf Thielow schrieb am Dienstag, den 02. Mai 2017: > @@ -1260,6 +1260,8 @@ msgstr "Speicher verbraucht" > #: config.c:191 > msgid "relative config include conditionals must come from files" > msgstr "" > +"Bedingungen für das Einbinden von Konfigurationen aus relativen Pfaden >

Antw: Re: Terrible bad performance for it blame --date=iso -C -C master --

>>> Samuel Lijin schrieb am 03.05.2017 um 09:12 in Nachricht

Cloning a custom refspec does not work as expected

Hi, I'm trying to clone a custom ref, avoiding the need to init && fetch manually. From reading [1] which says: "Set a configuration variable in the newly-created repository; this takes effect immediately after the repository is initialized, but before the remote history is fetched or any files

[no subject]

hs

Re: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS

On Tue, May 2, 2017 at 9:05 AM, Jeff Hostetler wrote: > > > On 5/2/2017 12:17 AM, Stefan Beller wrote: >> >> On Mon, May 1, 2017 at 6:36 PM, Junio C Hamano wrote: >>> >>> Stefan Beller writes: >>> This applies to origin/master.

Re: [PATCH v3 0/6] rebase -i: add config to abbreviate command-names

Hi Liam, On Tue, 2 May 2017, Liam Beguin wrote: > On Tue, 2017-05-02 at 17:48 +0200, Johannes Schindelin wrote: > > > I offered a couple of comments, my biggest one probably being that > > this patch series is crossing paths with my patch series that tries to > > move more functionality out of

Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)

On Wed, May 3, 2017 at 4:45 PM, Johannes Schindelin wrote: >> So it makes sense to give our downstream distributors a nudge to >> switch over to it. Some contributor (i.e. me) was not happy with this nudging though. The other day I switched to some branch

Re: RFA: untracked cache vs git reset --hard

On Wed, May 3, 2017 at 5:27 PM, Johannes Schindelin wrote: > Hi all, > > I have a problem and would like to solicit advice how to fix it. > > The untracked cache has made a real difference on rather large > repositories with tons of directories, and it is really,

RFA: untracked cache vs git reset --hard

Hi all, I have a problem and would like to solicit advice how to fix it. The untracked cache has made a real difference on rather large repositories with tons of directories, and it is really, really useful. But. One innocuous `git reset --hard` will just blow it away. How? reset_index() calls

Re: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS

On Tue, May 2, 2017 at 8:36 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> This applies to origin/master. >> >> For better readability and understandability for newcomers it is a good idea >> to not offer 2 APIs doing the same thing with on being

Re: CYGWIN git cannot install python packages with pip

On 3 May 2017 11:47, Johannes Schindelin wrote: > On Tue, 2 May 2017, ankostis wrote: > >> On Windows, with Cygwin-git 02.12.2-1 the python command: >> [...] > > You forgot to mention what python/pip you use (is it the Cygwin one, or a > standalone one?). Intentional?

[PATCH v2 21/21] t1308: add a test case on open a config directory

We don't support config-as-a-directory (maybe someday we will?). Make sure we consistently fail in this case, which should happen on platforms where fopen() returns non-NULL if FREAD_READS_DIRECTORIES is defined. Signed-off-by: Nguyễn Thái Ngọc Duy --- t/t1308-config-set.sh |

[PATCH v2 20/21] config.c: handle error on failing to fopen()

In the first case, we already correctly return -1 if fopen() fails to open. But we should report something so people know what's wrong. In the second case, config_file == NULL does not necessarily mean "no config file". Bail out if needed. Signed-off-by: Nguyễn Thái Ngọc Duy

[PATCH v2 17/21] server-info: report error on failure to fopen()

Signed-off-by: Nguyễn Thái Ngọc Duy --- server-info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server-info.c b/server-info.c index f6c1a3dfb0..e01ac154a8 100644 --- a/server-info.c +++ b/server-info.c @@ -133,7 +133,7 @@ static int

[PATCH v2 15/21] rerere.c: report correct errno

In the first case, we should have reported the reason fopen() fails. In the second case, fclose() might change errno but we want to report fopen() failure. Signed-off-by: Nguyễn Thái Ngọc Duy --- rerere.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 18/21] wt-status.c: report error on failure to fopen()

Signed-off-by: Nguyễn Thái Ngọc Duy --- wt-status.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/wt-status.c b/wt-status.c index 0375484962..cdf9f5eed2 100644 --- a/wt-status.c +++ b/wt-status.c @@ -1065,7 +1065,8 @@ static void

[PATCH v2 19/21] xdiff-interface.c: report errno on failure to stat() or fopen()

Signed-off-by: Nguyễn Thái Ngọc Duy --- xdiff-interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xdiff-interface.c b/xdiff-interface.c index 060038c2d6..d3f78ca2a7 100644 --- a/xdiff-interface.c +++ b/xdiff-interface.c @@ -164,9 +164,9 @@ int

[PATCH v2 14/21] rerere.c: report error on failure to fopen()

Signed-off-by: Nguyễn Thái Ngọc Duy --- rerere.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rerere.c b/rerere.c index 3bd55caf3b..971bfedfb2 100644 --- a/rerere.c +++ b/rerere.c @@ -200,7 +200,7 @@ static struct rerere_id *new_rerere_id(unsigned char

[PATCH v2 16/21] sequencer.c: report error on failure to fopen()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sequencer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sequencer.c b/sequencer.c index 10c3b4ff81..11b5c7c114 100644 --- a/sequencer.c +++ b/sequencer.c @@ -897,8 +897,8 @@ static void

[PATCH v2 13/21] remote.c: report error on failure to fopen()

There's plenty of error() in this code to safely assume --quiet is not a concern. t5512 needs update because if we check the path 'refs*master' (i.e. the asterisk is part of the path) then we'll get an EINVAL error. Signed-off-by: Nguyễn Thái Ngọc Duy --- remote.c

[PATCH v2 12/21] commit.c: report error on failure to fopen() the graft file

Suppressing the error (because the command requires --quiet) is not a concern because we already call error() just a couple lines down. Signed-off-by: Nguyễn Thái Ngọc Duy --- commit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/commit.c b/commit.c

[PATCH v2 09/21] blame: report error on open if graft_file is a directory

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/blame.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/builtin/blame.c b/builtin/blame.c index 07506a3e45..1648b396dc 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -2071,10 +2071,12 @@ static int

  1   2   >