test bare repository for unit tests

Hi. I want to the test-repo-git under https://github.com/apache/maven-wagon/tree/master/wagon-providers/wagon-scm/src/test/resources/ just like test-repo-cvs and test-repo-svn Which configuation options would suit that? I think core.compression 0 for human readable diffs. also, I need to force

Re: Git should preserve modification times at least on request

On Tue, Feb 20, 2018 at 2:05 PM, Peter Backes wrote: > Hi Jeff, > > On Tue, Feb 20, 2018 at 04:16:34PM -0500, Jeff King wrote: >> I think there are some references buried somewhere in that wiki, but did >> you look at any of the third-party tools that store file metadata

Re: Duplicate safecrlf warning for racily clean index entry

On Wed, 2018-02-21 at 08:53 +0100, Torsten Bögershausen wrote: > I don't hava a pointer, but what should happen ? > 2 warnings for 2 "git add" should be OK, I think. > > 1 warning is part of the optimization, that Git does to handle > hundrets and thousands of files efficciently. > > Is the 1/2

Re: [PATCH v2 5/9] t3701: add failing test for pathological context lines

On 19/02/18 11:29, Phillip Wood wrote: From: Phillip Wood When a hunk is skipped by add -i the offsets of subsequent hunks are not adjusted to account for any missing insertions due to the skipped hunk. Most of the time this does not matter as apply uses the context

Re: Why git-revert doesn't invoke the pre-commit and the commit-msg hooks?

2018-02-20 15:00 GMT-03:00 Junio C Hamano : > It would make more sense (if we were to add > an option to run any hook we currently do not run to the command) to > run pre-revert/revert-msg hooks instead, and then people who happen > to want to do the same thing in these hooks

Re: Duplicate safecrlf warning for racily clean index entry

On Tue, 2018-02-20 at 08:42 -0500, Matt McCutchen wrote: > In either case, if "git update-index --refresh" (or "git status") is > run before "git add", then "git add" does not print the warning. On > the other hand, if line endings in the working tree file are changed, > then git shows the file

Re: Question about get_cached_commit_buffer()

On 2/20/2018 5:57 PM, Jeff King wrote: On Tue, Feb 20, 2018 at 05:12:50PM -0500, Derrick Stolee wrote: In rev-list, the "--header" option outputs a value and expects the buffer to be cached. It outputs the header info only if get_cached_commit_buffer() returns a non-null buffer, giving

Re: Git should preserve modification times at least on request

On Wed, Feb 21, 2018 at 10:33:05PM +0100, Ævar Arnfjörð Bjarmason wrote: > This sounds like a sensible job for a git import tool, i.e. import a > target directory into git, and instead of 'git add'-ing the whole thing > it would look at the mtimes, sort files by mtime, then add them in order > and

Proposal

Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: Question about get_cached_commit_buffer()

On Wed, Feb 21, 2018 at 02:22:05PM -0800, Junio C Hamano wrote: > > I think that repeating the oid is intentional; the point is to dump how > > the traversal code is hitting the endpoints, even if we do so multiple > > times. > > > > The --oneline behavior just looks like a bug. I think --format

What's cooking in git.git (Feb 2018, #03; Wed, 21)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. You can find the changes

Re: test bare repository for unit tests

On Wed, Feb 21 2018, Basin Ilya jotted: > Hi. > I want to the test-repo-git under > https://github.com/apache/maven-wagon/tree/master/wagon-providers/wagon-scm/src/test/resources/ > just like test-repo-cvs and test-repo-svn > > Which configuation options would suit that? > I think

Re: Question about get_cached_commit_buffer()

Jeff King writes: > Out of curiosity, do you actually use --show-all for anything? Absolutely not. I'd actually love it if I could say "not anymore" instead, but I haven't had an opportunity to debug the revision traversal code for quite some time so I do not even remember when

Re: [PATCHv3 00/27] Moving global state into the repository object (part 1)

On Tue, Feb 20, 2018 at 5:54 PM, Stefan Beller wrote: > v3: > * reverted back to use the repository for most of the functions > (including unduplicating 'ignore_env') > * rebased on master again (I lost that state when doing v2, as > I did both rebase as well as conversion

Re: [PATCH 15/27] sha1_file: allow prepare_alt_odb to handle arbitrary repositories

On Tue, 20 Feb 2018 17:54:18 -0800 Stefan Beller wrote: > -void prepare_alt_odb_the_repository(void) > +void prepare_alt_odb(struct repository *r) > { > - const char *alt; > - > - if (the_repository->objects.alt_odb_tail) > + if (r->objects.alt_odb_tail) >

Re: [PATCH 08/27] pack: move approximate object count to object store

On 02/20, Stefan Beller wrote: > The approximate_object_count() function maintains a rough count of > objects in a repository to estimate how long object name abbreviates > should be. Object names are scoped to a repository and the > appropriate length may differ by repository, so the object

Re: [PATCH 24/27] sha1_file: allow open_sha1_file to handle arbitrary repositories

On Tue, 20 Feb 2018 17:54:27 -0800 Stefan Beller wrote: > Signed-off-by: Stefan Beller > Signed-off-by: Jonathan Nieder Reviewed-by: Jonathan Tan

Proposal

Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: [PATCH v3 14/35] connect: request remote refs using v2

On Tue, 6 Feb 2018 17:12:51 -0800 Brandon Williams wrote: > +extern struct ref **get_remote_refs(int fd_out, struct packet_reader *reader, > + struct ref **list, int for_push, > + const struct argv_array

Re: bug in HTTP protocol spec

> On Feb 21, 2018, at 2:15 PM, Jeff King wrote: > > Thanks, I agree the document is buggy. Do you want to submit a patch? Will this do? Note I am not sure what the story is behind that `version 1` element, whether it's supposed to go before or after the null packet or if there

RE: Git should preserve modification times at least on request

On February 21, 2018 6:13 PM, Peter Backes wrote: > On Wed, Feb 21, 2018 at 11:44:13PM +0100, Ævar Arnfjörð Bjarmason wrote: > > If it were added as a first-level feature to git it would present a > > lot of UX confusion. E.g. you run "git add" and it'll be showing the > > mtime somehow, or you

Bug: git log: boundary commits do not respect order (e.g. date-order, topo-order) 2

When using git log, boundary commits (ie, those commits added by specifying --boundary) do not respect the order (e.g., --date-order, --topo-order). Consider the following commit history, where number indicates the order of the commit timestamps: 0125 <--A \ \

Re: [PATCH 07/27] pack: move prepare_packed_git_run_once to object store

On Tue, 20 Feb 2018 17:54:10 -0800 Stefan Beller wrote: > Each repository's object store can be initialized independently, so > they must not share a run_once variable. > > Signed-off-by: Stefan Beller > Signed-off-by: Jonathan Nieder

Re: [PATCH 14/27] sha1_file: allow link_alt_odb_entries to handle arbitrary repositories

On 02/20, Stefan Beller wrote: > Actually this also allows read_info_alternates and link_alt_odb_entry to > handle arbitrary repositories, but link_alt_odb_entries is the most > interesting function in this set of functions, hence the commit subject. > > These functions span a strongly connected

Re: bug in HTTP protocol spec

On Wed, Feb 21, 2018 at 10:29:35AM -0800, Dorian Taylor wrote: > I didn’t get an insight until I ran with GIT_TRACE_PACKET=true on a > known-good remote (i.e. GitHub), that the null packet-line `` has to > follow the service line. This is not reflected in the example here: > >

Re: [PATCH v3 16/35] transport: convert transport_get_remote_refs to take a list of ref patterns

On Tue, 6 Feb 2018 17:12:53 -0800 Brandon Williams wrote: > -const struct ref *transport_get_remote_refs(struct transport *transport) > +const struct ref *transport_get_remote_refs(struct transport *transport, > + const struct

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

On Wed, Feb 21, 2018 at 03:22:02PM -0800, Stefan Beller wrote: > > Subject: [PATCH] commit: drop uses of get_cached_commit_buffer() > > --- > > builtin/rev-list.c | 2 +- > > log-tree.c | 3 --- > > 2 files changed, 1 insertion(+), 4 deletions(-) > > Now if we'd get around to rewrite

Bug: git log: boundary commits do not respect order (e.g. date-order, topo-order)

When using git log, boundary commits (ie, those commits added by specifying --boundary) do not respect the order (e.g., --date-order, --topo-order). Consider the following commit history, where number indicates the order of the commit timestamps: 0125 <--A \ \

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

On Wed, Feb 21, 2018 at 02:19:17PM -0500, Derrick Stolee wrote: > > These behaviors are undocumented, untested, and unlikely to be > > expected by users or other software attempting to parse this output. > > > > Helped-by: Jeff King > > Signed-off-by: Derrick Stolee

Re: [PATCH 04/26] upload-pack: convert to a builtin

Jonathan Nieder writes: > For defense in depth, it would be comforting if the git wrapper had > some understanding of "don't support --help in handle_builtin when > invoked as a dashed command". That is, I don't expect that anyone has > been relying on > > git-add

Re: [PATCH v3 20/35] upload-pack: introduce fetch server command

On Tue, 6 Feb 2018 17:12:57 -0800 Brandon Williams wrote: > +want > + Indicates to the server an object which the client wants to > + retrieve. Mention that the client can "want" anything even if not advertised by the server (like uploadpack.allowanysha1inwant).

Re: [PATCH] revision: drop --show-all option

On Wed, Feb 21, 2018 at 3:27 PM, Jeff King wrote: > > We'll skip the usual deprecation period because this was > explicitly a debugging aid that was never documented. Ack. I don't think I've used it since, and probably nobody else ever used it. Linus

Re: [PATCH v3 35/35] remote-curl: don't request v2 when pushing

On Tue, 6 Feb 2018 17:13:12 -0800 Brandon Williams wrote: > +test_expect_success 'push with http:// and a config of v2 does not request > v2' ' > + # Till v2 for push is designed, make sure that if a client has > + # protocol.version configured to use v2, that the

Re: [PATCH v3 0/3] Add "git rebase --show-current-patch"

Nguyễn Thái Ngọc Duy writes: > Compared to v2: > > - the potential loss of errno before it's printed out in builtin/am.c > is fixed. > - keep update_ref() in sequencer.c non-fatal like this rest > - rename ORIG_COMMIT to REBASE_HEAD > > Interdiff: This round hasn't seen

Re: [PATCH 09/27] sha1_file: add raw_object_store argument to alt_odb_usable

On Tue, 20 Feb 2018 17:54:12 -0800 Stefan Beller wrote: > Add a raw_object_store to alt_odb_usable to be more specific about which > repository to act on. The choice of the repository is delegated to its > only caller link_alt_odb_entry. > > Signed-off-by: Stefan Beller

Re: [PATCH 03/27] object-store: move alt_odb_list and alt_odb_tail to object store

On 02/20, Stefan Beller wrote: > In a process with multiple repositories open, alternates should be > associated to a single repository and not shared globally. Move > alt_odb_list and alt_odb_tail into the_repository and adjust callers > to reflect this. > > Now that the alternative object data

Re: [PATCH 04/27] object-store: free alt_odb_list

On 02/20, Stefan Beller wrote: > Free the memory and reset alt_odb_{list, tail} to NULL. Good to see memory leaks being avoided (well they will be on other repository objects) > > Signed-off-by: Stefan Beller > --- > object.c | 17 + > 1 file changed, 17

Re: Question about get_cached_commit_buffer()

Jeff King writes: > I think that repeating the oid is intentional; the point is to dump how > the traversal code is hitting the endpoints, even if we do so multiple > times. > > The --oneline behavior just looks like a bug. I think --format is broken > with --show-all, too (it

Re: [PATCH v3 15/35] transport: convert get_refs_list to take a list of ref patterns

On Tue, 6 Feb 2018 17:12:52 -0800 Brandon Williams wrote: > @@ -21,7 +22,8 @@ struct transport_vtable { >* the ref without a huge amount of effort, it should store it >* in the ref's old_sha1 field; otherwise it should be all 0. >**/ > - struct ref

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

> Subject: [PATCH] commit: drop uses of get_cached_commit_buffer() > --- > builtin/rev-list.c | 2 +- > log-tree.c | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) Now if we'd get around to rewrite pretty.c as well, we could make it static, giving a stronger reason of not using

Re: Bug: git log: boundary commits do not respect order (e.g. date-order, topo-order)

TYPO IN EXPECTED OUTPUT. To avoid inevitable confusion, creating new thread "Bug: git log: boundary commits do not respect order (e.g. date-order, topo-order) 2". DON'T REPLY TO THIS MESSAGE. Instead reply to the new message On Wed, Feb 21, 2018 at 6:28 PM, Josh Tepper

Re: [PATCH v3 30/35] remote-curl: create copy of the service name

On Tue, 6 Feb 2018 17:13:07 -0800 Brandon Williams wrote: > Make a copy of the service name being requested instead of relying on > the buffer pointed to by the passed in 'const char *' to remain > unchanged. > > Signed-off-by: Brandon Williams Probably

Re: [PATCH 19/27] sha1_file: add repository argument to map_sha1_file_1

On Tue, 20 Feb 2018 17:54:22 -0800 Stefan Beller wrote: > Add a repository argument to allow the map_sha1_file_1 caller to be > more specific about which repository to act on. This is a small > mechanical change; it doesn't change the implementation to handle > repositories

Re: Git should preserve modification times at least on request

On Wed, Feb 21, 2018 at 06:58:34PM -0500, Randall S. Becker wrote: > May I suggest storing the date/time in UTC+0 in all cases. I can see > potential issues a couple of times a year where holes exist. I cannot even > fathom what would happen on a merge or edit of history. I consider storing the

Re: [PATCH v2 0/3] Re: t7006: add tests for how git config paginates

Thanks. The entire thing looked reasonable. Will replace.

Re: Git should preserve modification times at least on request

On Wed, Feb 21, 2018 at 11:44:13PM +0100, Ævar Arnfjörð Bjarmason wrote: > If it were added as a first-level feature to git it would present a lot > of UX confusion. E.g. you run "git add" and it'll be showing the mtime > somehow, or you get a formatted patch over E-Mail and it doesn't only >

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

On Wed, Feb 21, 2018 at 02:17:11PM -0500, Derrick Stolee wrote: > The get_cached_commit_buffer() method provides access to the buffer > loaded for a struct commit, if it was ever loadead and was not freed. > > Two places use this to inform how to output information about commits. > > log-tree.c

[PATCH] revision: drop --show-all option

On Wed, Feb 21, 2018 at 03:03:18PM -0800, Junio C Hamano wrote: > > So what I'm wondering is whether we should consider just ripping it out > > (but I'm OK with keeping it, as once the commit-buffer stuff is fixed, > > it's probably not hurting anybody). > > I see no problem in removing it.

Re: [PATCH v5 00/17] document & test fetch pruning & add fetch.pruneTags

Ævar Arnfjörð Bjarmason writes: > Here's a v5 (correct subject line this time!). Many thanks to Eric for > a thorough review. We haven't seen any comments on this round. Is everybody happy? I do not have a strong opinion on the new feature, either for or against. I didn't

Re: [PATCH 22/27] sha1_file: allow sha1_file_name to handle arbitrary repositories

On Tue, 20 Feb 2018 17:54:25 -0800 Stefan Beller wrote: > Signed-off-by: Stefan Beller > Signed-off-by: Jonathan Nieder Reviewed-by: Jonathan Tan > -void sha1_file_name_the_repository(struct strbuf *buf,

Re: [PATCH 06/27] object-store: close all packs upon clearing the object store

On 02/20, Stefan Beller wrote: > Signed-off-by: Stefan Beller Straight forward change, looks good. > --- > builtin/am.c | 2 +- > builtin/clone.c| 2 +- > builtin/fetch.c| 2 +- > builtin/merge.c| 2 +- > builtin/receive-pack.c | 2 +- >

Re: bug in HTTP protocol spec

> On Feb 21, 2018, at 9:37 PM, Jonathan Nieder wrote: > > Thanks for writing it. > > Do you mind if we forge your sign-off? (See Documentation/SubmittingPatches > item '(5) Certify your work' for details about what this means.) Sure, or I can just re-paste:

Re: test bare repository for unit tests

Hi. git-fast-export would work too, but it creates an additional step. I don't commit to the model repo during tests, but I do commit when I want to modify the tests. So far, I configured core.compression=0 and gc.auto=0, created the .gitattributes inside the bare repo dir containing one line:

Re: [PATCH v3 08/35] connect: discover protocol version outside of get_remote_heads

On Tue, 6 Feb 2018 17:12:45 -0800 Brandon Williams wrote: > - get_remote_heads(fd[0], NULL, 0, , 0, NULL, ); > + > + packet_reader_init(, fd[0], NULL, 0, > +PACKET_READ_CHOMP_NEWLINE | > +PACKET_READ_GENTLE_ON_EOF); > +

Proposal

Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: [PATCH v3 12/35] serve: introduce git-serve

On Tue, 6 Feb 2018 17:12:49 -0800 Brandon Williams wrote: > .gitignore | 1 + > Documentation/technical/protocol-v2.txt | 114 +++ > Makefile| 2 + > builtin.h | 1 +

Re: Git should preserve modification times at least on request

On Wed, Feb 21 2018, Peter Backes jotted: > On Wed, Feb 21, 2018 at 10:33:05PM +0100, Ævar Arnfjörð Bjarmason wrote: >> This sounds like a sensible job for a git import tool, i.e. import a >> target directory into git, and instead of 'git add'-ing the whole thing >> it would look at the mtimes,

Proposal

Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: [PATCH v3 24/35] connect: refactor git_connect to only get the protocol version once

On Tue, 6 Feb 2018 17:13:01 -0800 Brandon Williams wrote: > Instead of having each builtin transport asking for which protocol > version the user has configured in 'protocol.version' by calling > `get_protocol_version_config()` multiple times, factor this logic out > so there

Re: [PATCH v3 28/35] transport-helper: introduce stateless-connect

On Tue, 6 Feb 2018 17:13:05 -0800 Brandon Williams wrote: > Introduce the transport-helper capability 'stateless-connect'. This > capability indicates that the transport-helper can be requested to run > the 'stateless-connect' command which should attempt to make a >

Re: [PATCH 16/27] sha1_file: add repository argument to sha1_file_name

On 02/20, Stefan Beller wrote: > Add a repository argument to allow sha1_file_name callers to be more > specific about which repository to handle. This is a small mechanical > change; it doesn't change the implementation to handle repositories > other than the_repository yet. > > As with the

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

On 2/21/2018 6:13 PM, Jeff King wrote: On Wed, Feb 21, 2018 at 02:17:11PM -0500, Derrick Stolee wrote: The get_cached_commit_buffer() method provides access to the buffer loaded for a struct commit, if it was ever loadead and was not freed. Two places use this to inform how to output

Bug Report: git status triggers a file change event

On Windows 10, git version 2.16.2.windows.1, running the command git status will trigger a file change event to file C:\myPath\.git "Attributes changed." This causes problems when using scripts that detect file changes such as tsc -w (Typescript compiler) and using softwares that regularly

Re: Bug Report: git status triggers a file change event

+git-for-windows Hi, Raining Chain wrote: > On Windows 10, git version 2.16.2.windows.1, running the command > > git status > > will trigger a file change event to file C:\myPath\.git "Attributes changed." > > This causes problems when using scripts that detect file changes such > as tsc -w

Re: bug in HTTP protocol spec

(+cc: bmwill@, who is working on protocol v2) Hi, Dorian Taylor wrote: > On Feb 21, 2018, at 2:15 PM, Jeff King wrote: >> Thanks, I agree the document is buggy. Do you want to submit a patch? > > Will this do? Thanks for writing it. Do you mind if we forge your sign-off? (See

Re: [PATCH 13/27] sha1_file: add repository argument to prepare_alt_odb

Hi, Stefan Beller wrote: > See previous patch for explanation. > > While at it, move the declaration to object-store.h, > where it should be easier to find. Which declaration? It looks like prepare_alt_odb is already in object-store.h. [...] > --- a/builtin/fsck.c > +++ b/builtin/fsck.c > @@

Re: [PATCH 17/27] sha1_file: add repository argument to stat_sha1_file

Hi, Stefan Beller wrote: > Add a repository argument to allow the stat_sha1_file caller to be > more specific about which repository to act on. This is a small > mechanical change; it doesn't change the implementation to handle > repositories other than the_repository yet. > > As with the

Re: [PATCH v4 12/13] commit-graph: read only from specific pack-indexes

On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: > > Teach git-commit-graph to inspect the objects only in a certain list > of pack-indexes within the given pack directory. This allows updating > the commit graph iteratively, since we add all commits stored in a >

Proposal

Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Investment Project

Hello, I have a business proposal i would like to discuss with you, reply if you are interested for more info. Thank You. Ms. Melisa Mehmet My Skype ID: ms.melisameh...@hotmail.com WhatsApp": +90 534 716 2603

Re: [PATCH v3 32/35] http: allow providing extra headers for http requests

On Tue, 6 Feb 2018 17:13:09 -0800 Brandon Williams wrote: > @@ -172,6 +172,8 @@ struct http_get_options { >* for details. >*/ > struct strbuf *base_url; > + > + struct string_list *extra_headers; Document this? For example: If not NULL,

Re: [PATCH 00/36] object_id part 12

On Wed, Feb 21, 2018 at 10:47:19AM -0800, Junio C Hamano wrote: > "brian m. carlson" writes: > > > This is the twelfth in a series of patches to convert from unsigned char > > [20] to struct object_id. This series is based on next. > > > > Included in this series

Re: [PATCH 02/27] object-store: migrate alternates struct and functions from cache.h

On 02/20, Stefan Beller wrote: > Migrate the struct alternate_object_database and all its related > functions to the object store as these functions are easier found in > that header. The migration is just a verbatim copy, no need to > include the object store header at any C file, because cache.h

Re: What's cooking in git.git (Feb 2018, #03; Wed, 21)

On 02/21, Junio C Hamano wrote: > * bw/c-plus-plus (2018-02-14) 38 commits > - fixup! diff: rename 'this' variables > - replace: rename 'new' variables > - trailer: rename 'template' variables > - tempfile: rename 'template' variables > - wrapper: rename 'template' variables > - environment:

Re: [PATCH v3 0/3] Add "git rebase --show-current-patch"

Junio C Hamano wrote: >> Compared to v2: >> - the potential loss of errno before it's printed out in builtin/am.c >> is fixed. >> - keep update_ref() in sequencer.c non-fatal like this rest >> - rename ORIG_COMMIT to REBASE_HEAD >> Interdiff: > This round hasn't seen any

Re: [PATCH 26/27] sha1_file: allow map_sha1_file to handle arbitrary repositories

Stefan Beller wrote: > Signed-off-by: Stefan Beller > Signed-off-by: Jonathan Nieder > --- > object-store.h | 3 +-- > sha1_file.c| 5 +++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Thanks: this is short and simple, making my life as a

Re: [PATCH 21/27] sha1_file: add repository argument to sha1_loose_object_info

Hi, Stefan Beller wrote: > Add a repository argument to allow the sha1_loose_object_info caller > to be more specific about which repository to act on. This is a small > mechanical change; it doesn't change the implementation to handle > repositories other than the_repository yet. > > As with

Re: [PATCH 01/27] repository: introduce raw object store field

Hi, Stefan Beller wrote: > The raw object store field will contain any objects needed for > access to objects in a given repository. > > This patch introduces the raw object store and populates it with the > `objectdir`, which used to be part of the repository struct. > > As the struct gains

Re: [PATCH 05/27] object-store: move packed_git and packed_git_mru to object store

Hi, Stefan Beller wrote: > In a process with multiple repositories open, packfile accessors > should be associated to a single repository and not shared globally. > Move packed_git and packed_git_mru into the_repository and adjust > callers to reflect this. > > Patch generated by > > 1. Moving

Re: [PATCH 2/2] ref-filter: get rid of goto

2018-02-21 20:41 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Get rid of goto command in ref-filter for better readability. >> >> Signed-off-by: Olga Telezhnaia >> Mentored-by: Christian Couder

[PATCH] t: send verbose test-helper output to fd 4

This is a repost of the two patches from: https://public-inbox.org/git/20180209185710.ga23...@sigill.intra.peff.net/ (now just one patch, since sg/test-i18ngrep graduated and we can do it all in one step). The idea got positive feedback, but nobody commented on patches and I didn't see them in

Re: [PATCH v2 4/9] t3701: don't hard code sha1 hash values

Phillip Wood writes: > Keeping the permission bits makes sense (I'd not thought of them when > I created the patch) as we want to check that the file has the correct > permissions. As for the all-zero object name, is it really worth > leaving it in - if a file has been

RE: Stackdump from stash save on Windows 10 64-bit

Hi Tim, I re-Cc:ed the Git mailing list, as I do not like the pressure of being the only one you ask for help. On Wed, 21 Feb 2018, Tim Mayo wrote: > > Can you please test with v2.16.2 > > Is there a built version somewhere .. or do I have to build it myself? Yes, official Git for Windows

Re: [PATCH] t/known-leaky: add list of known-leaky test scripts

Martin Ågren writes: > On 19 February 2018 at 22:29, Jeff King wrote: > ... >> Or alternatively, we could just not bother with checking this into the >> repository, and it becomes a local thing for people interested in >> leak-testing. What's the value in

Re: [PATCH v2 4/9] t3701: don't hard code sha1 hash values

On 20/02/18 17:39, Junio C Hamano wrote: Phillip Wood writes: From: Phillip Wood Purge the index lines from diffs so we're not hard coding sha1 hash values in the expected output. The motivation of this patch is clear, but all-zero

Re: [PATCH v2 3/9] t3701: use test_write_lines and write_script

On 20/02/18 17:19, Junio C Hamano wrote: Eric Sunshine writes: test_expect_success 'setup fake editor' ' - echo "#!$SHELL_PATH" >fake_editor.sh && - cat >>fake_editor.sh <<-\EOF && + FAKE_EDITOR="$(pwd)/fake-editor.sh" && + write_script

[ANNOUNCE] Git Rev News edition 36

Hi everyone, The 36th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/02/21/edition-36/ Thanks a lot to all the contributors! Enjoy, Christian, Jakub, Markus and Gabriel.

Re: [PATCH 2/2] ref-filter: get rid of goto

Olga Telezhnaya writes: > Get rid of goto command in ref-filter for better readability. > > Signed-off-by: Olga Telezhnaia > Mentored-by: Christian Couder > Mentored by: Jeff King > --- >

Re: [PATCH v7 0/7] convert: add support for different encodings

> On 16 Feb 2018, at 19:55, Junio C Hamano wrote: > > Jeff King writes: > >> So a full proposal would support both cases: "check this out in the >> local platform's preferred encoding" and "always check this out in >> _this_ encoding". And Lars's proposal is

Re: Duplicate safecrlf warning for racily clean index entry

Matt McCutchen writes: > ... may be an important optimization.) If the line endings are changed > without changing the size or post-conversion content, then no unstaged > change is reported. It does not appear that git saves the pre- > conversion content. Correct. The

Re: [PATCH 1/2] ref-filter: get rid of duplicate code

Olga Telezhnaya writes: > Make one function from 2 duplicate pieces and invoke it twice. > > Signed-off-by: Olga Telezhnaia > Mentored-by: Christian Couder > Mentored by: Jeff King > --- >

Re: [PATCH 00/36] object_id part 12

"brian m. carlson" writes: > This is the twelfth in a series of patches to convert from unsigned char > [20] to struct object_id. This series is based on next. > > Included in this series are conversions for find_unique_abbrev and > lookup_replace_object, as well

[PATCH v2 2/3] config: respect `pager.config` in list/get-mode only

Similar to de121ffe5 (tag: respect `pager.tag` in list-mode only, 2017-08-02), use the DELAY_PAGER_CONFIG-mechanism to only respect `pager.config` when we are listing or "get"ing config. We have several getters and some are guaranteed to give at most one line of output. Paging all getters

Re: [PATCH v4 03/13] commit-graph: create git-commit-graph builtin

Junio C Hamano writes: > Derrick Stolee writes: > >> +int cmd_commit_graph(int argc, const char **argv, const char *prefix) >> +{ >> +static struct option builtin_commit_graph_options[] = { >> +{ OPTION_STRING, 'p', "object-dir", _dir, >> +

[PATCH] commit: drop uses of get_cached_commit_buffer()

The get_cached_commit_buffer() method provides access to the buffer loaded for a struct commit, if it was ever loadead and was not freed. Two places use this to inform how to output information about commits. log-tree.c uses this method to short-circuit the output of commit information when the

Re: [PATCH v4 01/13] commit-graph: add format document

On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: > Add document specifying the binary format for commit graphs. This > format allows for: > > * New versions. > * New hash functions and hash lengths. > * Optional extensions. > > Basic header information is followed by a

Re: [PATCH v3 00/35] protocol version 2

On 02/06, Brandon Williams wrote: > Changes in v3: > * There were some comments about how the protocol should be designed >stateless first. I've made this change and instead of having to >supply the `stateless-rpc=true` capability to force stateless >behavior, the protocol just

[PATCH v2 0/3] Re: t7006: add tests for how git config paginates

This is v2 of my series to teach `git config` to only respect `pager.config` when listing configuration, then changing the default to "on". Thanks to Duy and Junio for feedback on the first version. Based on Duy's feeback, I've changed the approach to more carefully divide the various getters

Re: [PATCH v4 01/13] commit-graph: add format document

On 2/21/2018 2:23 PM, Stefan Beller wrote: On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: +In order to allow extensions that add extra data to the graph, we organize +the body into "chunks" and provide a binary lookup table at the beginning +of the body. The header

[PATCH v2 1/3] t7006: add tests for how git config paginates

The next couple of commits will change how `git config` handles `pager.config`, similar to how de121ffe5 (tag: respect `pager.tag` in list-mode only, 2017-08-02) and ff1e72483 (tag: change default of `pager.tag` to "on", 2017-08-02) changed `git tag`. Similar work has also been done to `git

  1   2   >