jorgecarleitao commented on pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#issuecomment-723399529
Also, I very much agree with @carols10cents that we need a methodology to
compare arrays with granularity :)
--
nevi-me commented on a change in pull request #8541:
URL: https://github.com/apache/arrow/pull/8541#discussion_r519115194
##
File path: rust/arrow/src/array/equal/structure.rs
##
@@ -0,0 +1,59 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
lidavidm closed pull request #8554:
URL: https://github.com/apache/arrow/pull/8554
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
lidavidm commented on a change in pull request #8554:
URL: https://github.com/apache/arrow/pull/8554#discussion_r519050438
##
File path:
java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Ap
lidavidm commented on pull request #8554:
URL: https://github.com/apache/arrow/pull/8554#issuecomment-723341323
Will merge on green.
This is an automated message from the Apache Git Service.
To respond to the message, please
jduo commented on a change in pull request #8554:
URL: https://github.com/apache/arrow/pull/8554#discussion_r519049014
##
File path:
java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache
jduo commented on a change in pull request #8554:
URL: https://github.com/apache/arrow/pull/8554#discussion_r519047132
##
File path:
java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache
jduo commented on a change in pull request #8554:
URL: https://github.com/apache/arrow/pull/8554#discussion_r519046814
##
File path:
java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache
jduo commented on a change in pull request #8554:
URL: https://github.com/apache/arrow/pull/8554#discussion_r519045924
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/client/ClientCookieMiddleware.java
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Ap
jhorstmann commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723326224
When I introduced this initially in [ARROW-10040][1] one feedback was that
big endian was not supported yet anyway so it would not be necessary to worry
about that now. I think
jhorstmann commented on a change in pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#discussion_r519025720
##
File path: rust/arrow/src/util/bit_slice_iterator.rs
##
@@ -0,0 +1,368 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
jhorstmann commented on a change in pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#discussion_r519019958
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -152,9 +152,21 @@ where
let data_chunks = data.chunks_exact(64);
jhorstmann commented on a change in pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#discussion_r519016891
##
File path: rust/arrow/src/array/data.rs
##
@@ -211,57 +211,66 @@ impl ArrayData {
impl PartialEq for ArrayData {
fn eq(&self, other: &Self) ->
jhorstmann commented on a change in pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#discussion_r519016891
##
File path: rust/arrow/src/array/data.rs
##
@@ -211,57 +211,66 @@ impl ArrayData {
impl PartialEq for ArrayData {
fn eq(&self, other: &Self) ->
jhorstmann commented on a change in pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#discussion_r519014044
##
File path: rust/arrow/src/array/data.rs
##
@@ -211,57 +211,66 @@ impl ArrayData {
impl PartialEq for ArrayData {
fn eq(&self, other: &Self) ->
jhorstmann commented on a change in pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#discussion_r519011669
##
File path: rust/arrow/src/array/data.rs
##
@@ -211,57 +211,66 @@ impl ArrayData {
impl PartialEq for ArrayData {
fn eq(&self, other: &Self) ->
jhorstmann commented on a change in pull request #8571:
URL: https://github.com/apache/arrow/pull/8571#discussion_r518997813
##
File path: rust/arrow-flight/Cargo.toml
##
@@ -27,7 +27,10 @@ license = "Apache-2.0"
[dependencies]
arrow = { path = "../arrow", version = "3.0.0-
vertexclique edited a comment on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723261667
> So my feedback here is that it is not clear to me what this PR is trying
to accomplish (aka answer the question of why make the changes in this pr) and
thus it is no
drusso commented on a change in pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#discussion_r518991852
##
File path: rust/datafusion/src/physical_plan/distinct_expressions.rs
##
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+
carols10cents commented on a change in pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#discussion_r518973664
##
File path: rust/arrow/src/array/data.rs
##
@@ -211,57 +211,66 @@ impl ArrayData {
impl PartialEq for ArrayData {
fn eq(&self, other: &Self)
vertexclique edited a comment on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723261667
> So my feedback here is that it is not clear to me what this PR is trying
to accomplish (aka answer the question of why make the changes in this pr) and
thus it is no
alamb commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723268680
> but as you can see I have committed the exact tests in d6e4744 with the
co-authoring feature to make it cumulative effort.
Thank you!
I think with the additional test
xhochy commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723268532
@github-actions autotune everything
This is an automated message from the Apache Git Service.
To respond to
drusso commented on a change in pull request #8556:
URL: https://github.com/apache/arrow/pull/8556#discussion_r518962602
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -195,15 +217,21 @@ where
let null_slice = null_buf.data_mut();
-let new_values: Vec =
alamb commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723261686
fyi @jhorstmann this PR likely would cause conflicts with
https://github.com/apache/arrow/pull/8571 -- I wonder if you have any opinions
on how to proceed
---
vertexclique commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723261667
> So my feedback here is that it is not clear to me what this PR is trying
to accomplish (aka answer the question of why make the changes in this pr) and
thus it is not clear
alamb commented on a change in pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#discussion_r518961426
##
File path: rust/arrow/src/buffer.rs
##
@@ -259,16 +260,20 @@ impl Buffer {
/// Returns a slice of this buffer starting at a certain bit offset.
/
alamb commented on a change in pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#discussion_r518949715
##
File path: rust/arrow/src/array/data.rs
##
@@ -211,57 +211,66 @@ impl ArrayData {
impl PartialEq for ArrayData {
fn eq(&self, other: &Self) -> bool
github-actions[bot] commented on pull request #8606:
URL: https://github.com/apache/arrow/pull/8606#issuecomment-723248595
https://issues.apache.org/jira/browse/ARROW-10510
This is an automated message from the Apache Git Ser
carols10cents edited a comment on pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#issuecomment-723248048
@jorgecarleitao @nevi-me @alamb I've just force pushed an alternative
solution to this problem that doesn't change `BufferData`'s `PartialEq`
implementation, and I've
carols10cents commented on pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#issuecomment-723248048
@jorgecarleitao @nevi-me @alamb I've just force pushed an alternative
solution to this problem that doesn't change `BufferData`'s `PartialEq`
implementation, and I've added
drusso opened a new pull request #8606:
URL: https://github.com/apache/arrow/pull/8606
[ARROW-10510](https://issues.apache.org/jira/browse/ARROW-10510)
This change adds benchmarks for `COUNT(DISTINCT)` queries. This is a small
follow-up to [ARROW-10043](https://issues.apache.org/jira
jduo commented on a change in pull request #8554:
URL: https://github.com/apache/arrow/pull/8554#discussion_r518941906
##
File path:
java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache
alamb commented on a change in pull request #8556:
URL: https://github.com/apache/arrow/pull/8556#discussion_r518934329
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -195,15 +217,21 @@ where
let null_slice = null_buf.data_mut();
-let new_values: Vec =
drusso commented on a change in pull request #8556:
URL: https://github.com/apache/arrow/pull/8556#discussion_r518926998
##
File path: rust/arrow/src/compute/util.rs
##
@@ -100,41 +99,55 @@ pub(super) fn compare_option_bitmap(
/// Where a list array has indices `[0,2,5,10]`, t
drusso commented on a change in pull request #8556:
URL: https://github.com/apache/arrow/pull/8556#discussion_r518923411
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -195,15 +217,21 @@ where
let null_slice = null_buf.data_mut();
-let new_values: Vec =
drusso commented on a change in pull request #8556:
URL: https://github.com/apache/arrow/pull/8556#discussion_r518923411
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -195,15 +217,21 @@ where
let null_slice = null_buf.data_mut();
-let new_values: Vec =
emkornfield commented on pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#issuecomment-723209194
I think we should maybe have the any naming changes/migration to new class
be a separate PR. If that isn't too much effort.
-
kiszk edited a comment on pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#issuecomment-723179677
I see. I will rename this class name and keep the current
`UnsafeDirectLittleEndian`, which will extend the new class, as `@deprecated`
like
[this](https://github.com/apache
kiszk commented on pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#issuecomment-723179677
I see. I will rename this class name and keep `UnsafeDirectLittleEndian` as
`@deprecated` like
[this](https://github.com/apache/arrow/blob/master/java/memory/memory-netty/src/main/j
kiszk edited a comment on pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#issuecomment-723179677
I see. I will rename this class name and keep the current
`UnsafeDirectLittleEndian` as `@deprecated` like
[this](https://github.com/apache/arrow/blob/master/java/memory/memo
BryanCutler edited a comment on pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#issuecomment-723173844
I also think the classes mentioned above should be renamed to
"***NativeEndian", but I think `UnsafeDirectLittleEndian` is public so we need
to be careful about that. I
BryanCutler commented on pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#issuecomment-723173844
I also think the classes mentioned above should be renamed to
"***NativeEndian", but I think `UnsafeDirectLittleEndian` is public so we need
to be careful about that. Is there
BryanCutler commented on a change in pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#discussion_r518862408
##
File path:
java/memory/memory-netty/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java
##
@@ -60,9 +59,6 @@
private UnsafeDirectLittle
jhorstmann commented on a change in pull request #8571:
URL: https://github.com/apache/arrow/pull/8571#discussion_r518830136
##
File path: rust/arrow/src/util/bit_chunk_iterator.rs
##
@@ -55,48 +58,52 @@ impl<'a> BitChunks<'a> {
pub struct BitChunkIterator<'a> {
buffer: &
jhorstmann commented on a change in pull request #8571:
URL: https://github.com/apache/arrow/pull/8571#discussion_r518825331
##
File path: rust/arrow-flight/Cargo.toml
##
@@ -27,7 +27,10 @@ license = "Apache-2.0"
[dependencies]
arrow = { path = "../arrow", version = "3.0.0-
alamb commented on pull request #8560:
URL: https://github.com/apache/arrow/pull/8560#issuecomment-723116861
Is it the case that "UB" means "Undefined Behavior"?
This is an automated message from the Apache Git Service.
To re
xhochy commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723115884
Sorry for the close/open noise but otherwise Github Actions doesn't seem to
start here.
This is an automated messa
xhochy closed pull request #8604:
URL: https://github.com/apache/arrow/pull/8604
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xhochy closed pull request #8580:
URL: https://github.com/apache/arrow/pull/8580
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb edited a comment on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723114191
So my feedback here is that it is not clear to me what this PR is trying to
accomplish (aka answer the question of *why* make the changes in this PR) and
thus it is not clear
alamb commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723114191
So my feedback here is that it is not clear to me what this PR is trying to
accomplish (aka answer the question of *why* make the changes in this PR) and
thus it is not clear how to
github-actions[bot] commented on pull request #8605:
URL: https://github.com/apache/arrow/pull/8605#issuecomment-723111282
https://issues.apache.org/jira/browse/ARROW-10508
This is an automated message from the Apache Git Ser
xhochy commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723109834
@github-actions autotune everything
This is an automated message from the Apache Git Service.
To respond to the mes
xhochy closed pull request #8604:
URL: https://github.com/apache/arrow/pull/8604
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Kopilov opened a new pull request #8605:
URL: https://github.com/apache/arrow/pull/8605
Hope this would be enough
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
github-actions[bot] commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723105246
https://issues.apache.org/jira/browse/ARROW-10509
This is an automated message from the Apache Git Ser
github-actions[bot] commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723103690
Revision: 6bb07b77f45081ffd32bb211ec1938e85c97f778
Submitted crossbow builds: [ursa-labs/crossbow @
actions-695](https://github.com/ursa-labs/crossbow/branches/a
xhochy commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723103218
This has been broken in the latest nightly builds of the `r-arrow` conda
packages on Windows.
This is an automated
xhochy commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723102829
@github-actions crossbow submit conda-win-*
This is an automated message from the Apache Git Service.
To respond to
jonkeane commented on a change in pull request #8579:
URL: https://github.com/apache/arrow/pull/8579#discussion_r518776855
##
File path: r/tests/testthat/test-Table.R
##
@@ -179,10 +183,34 @@ test_that("[[<- assignment", {
# can use $
tab$new <- NULL
expect_null(as.vec
alamb commented on a change in pull request #8571:
URL: https://github.com/apache/arrow/pull/8571#discussion_r518757983
##
File path: rust/arrow-flight/Cargo.toml
##
@@ -27,7 +27,10 @@ license = "Apache-2.0"
[dependencies]
arrow = { path = "../arrow", version = "3.0.0-SNAPS
vertexclique commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723092434
This PR solves that problem intrinsically. Yes, it is a conflict.
This is an automated message from the Apach
lidavidm commented on pull request #8572:
URL: https://github.com/apache/arrow/pull/8572#issuecomment-723090365
Thanks @kylepbit!
This is an automated message from the Apache Git Service.
To respond to the message, please log
lidavidm closed pull request #8572:
URL: https://github.com/apache/arrow/pull/8572
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723088094
It seems like https://github.com/apache/arrow/pull/8571 may conflict with
this PR as well
This is an automated mess
vertexclique commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-723077892
I am going to change the whole data fusion tests to take machine epsilon
into consideration. Didn't see that coming.
vertexclique commented on a change in pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#discussion_r518741098
##
File path: rust/arrow/src/buffer.rs
##
@@ -259,16 +260,20 @@ impl Buffer {
/// Returns a slice of this buffer starting at a certain bit offset.
github-actions[bot] commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723074150
Revision: 6bb07b77f45081ffd32bb211ec1938e85c97f778
Submitted crossbow builds: [ursa-labs/crossbow @
actions-694](https://github.com/ursa-labs/crossbow/branches/a
xhochy commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723073340
@github-actions submit conda-win-vs2017-py37
This is an automated message from the Apache Git Service.
To respond t
xhochy commented on pull request #8604:
URL: https://github.com/apache/arrow/pull/8604#issuecomment-723073420
@github-actions crossbow submit conda-win-vs2017-py37
This is an automated message from the Apache Git Service.
To
xhochy opened a new pull request #8604:
URL: https://github.com/apache/arrow/pull/8604
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb commented on a change in pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#discussion_r518733998
##
File path: rust/arrow/src/buffer.rs
##
@@ -402,19 +407,27 @@ where
let mut result =
MutableBuffer::new(ceil(len_in_bits, 8)).with_bitset(len_
alamb commented on a change in pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#discussion_r518730329
##
File path: rust/arrow/src/util/bit_slice_iterator.rs
##
@@ -0,0 +1,210 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-723025807
Ah -- got it. 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on
emkornfield commented on pull request #8589:
URL: https://github.com/apache/arrow/pull/8589#issuecomment-722939001
Okay, I'm done pushing. @chrisavl I think the new API should make the
change for parquet_writer smaller (and probably more efficient). See unit
tests added for intended usag
jorgecarleitao commented on pull request #8541:
URL: https://github.com/apache/arrow/pull/8541#issuecomment-722936811
I have simplified this code further to allow the compiler to optimize out
some functions. The code is now 10-40% faster compared to current master. I
updated the descriptio
77 matches
Mail list logo
