[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #849: Fix csv writing of timestamps to show timezone.

2021-11-06 Thread GitBox
codecov-commenter edited a comment on pull request #849: URL: https://github.com/apache/arrow-rs/pull/849#issuecomment-950077830 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/849?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow-datafusion] xudong963 edited a comment on issue #1262: test `create_external_table_with_timestamps` failed locally

2021-11-06 Thread GitBox
xudong963 edited a comment on issue #1262: URL: https://github.com/apache/arrow-datafusion/issues/1262#issuecomment-962550180 FYI, yesterday, the test was normal locally. Today, I rebased master and it failed, there are two new commits, https://github.com/apache/arrow-datafusion/pull/1243

[GitHub] [arrow-datafusion] xudong963 commented on issue #1262: test `create_external_table_with_timestamps` failed locally

2021-11-06 Thread GitBox
xudong963 commented on issue #1262: URL: https://github.com/apache/arrow-datafusion/issues/1262#issuecomment-962550180 FYI, yesterday, the test was normal locally. Today, I rebased master and it failed, there are two new commits, https://github.com/apache/arrow-datafusion/pull/1243, http

[GitHub] [arrow-datafusion] xudong963 opened a new issue #1262: test `create_external_table_with_timestamps` failed locally

2021-11-06 Thread GitBox
xudong963 opened a new issue #1262: URL: https://github.com/apache/arrow-datafusion/issues/1262 **Describe the bug** `create_external_table_with_timestamps` failed locally, but CI seems normal. **To Reproduce** Steps to reproduce the behavior: **Expected behavior** ```

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1261: Dataframe supports except and update readme

2021-11-06 Thread GitBox
xudong963 commented on pull request #1261: URL: https://github.com/apache/arrow-datafusion/pull/1261#issuecomment-962544967 > @xudong963 looks like tests are failing Yes, after https://github.com/apache/arrow-datafusion/pull/1259 merging, I'll rebase this PR and the test will pass.

[GitHub] [arrow-datafusion] houqp commented on pull request #1223: Add support of HDFS as remote object store

2021-11-06 Thread GitBox
houqp commented on pull request #1223: URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962536841 @yahoNanJing I agree with you that pooling these extensions into a single namespace would be better than splitting into personal namespaces. I started a discussion thread

[GitHub] [arrow-datafusion] houqp closed issue #1213: Support CREATE TABLE AS SELECT ... in datafusion-cli

2021-11-06 Thread GitBox
houqp closed issue #1213: URL: https://github.com/apache/arrow-datafusion/issues/1213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] houqp merged pull request #1243: Add support for `create table as` via MemTable

2021-11-06 Thread GitBox
houqp merged pull request #1243: URL: https://github.com/apache/arrow-datafusion/pull/1243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1259: Implement EXCEPT & EXCEPT DISTINCT

2021-11-06 Thread GitBox
houqp commented on a change in pull request #1259: URL: https://github.com/apache/arrow-datafusion/pull/1259#discussion_r744178530 ## File path: datafusion/src/sql/planner.rs ## @@ -195,26 +195,42 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { } => {

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1258: DataFrame supports intersect and update readme

2021-11-06 Thread GitBox
houqp commented on a change in pull request #1258: URL: https://github.com/apache/arrow-datafusion/pull/1258#discussion_r744178212 ## File path: datafusion/src/execution/dataframe_impl.rs ## @@ -231,6 +231,29 @@ impl DataFrame for DataFrameImpl { .build()?,

[GitHub] [arrow] kou commented on pull request #11634: ARROW-14623: [Packaging][Java] Upload not only .jar but also .pom

2021-11-06 Thread GitBox
kou commented on pull request #11634: URL: https://github.com/apache/arrow/pull/11634#issuecomment-962519642 https://github.com/ursacomputing/crossbow/releases/tag/actions-1097-github-java-jars has both .jar and .pom but version number are 7.0.0-SNAPSHOT not 7.0.0.dev63. We need `{no_rc_s

[GitHub] [arrow] github-actions[bot] commented on pull request #11634: ARROW-14623: [Packaging][Java] Upload not only .jar but also .pom

2021-11-06 Thread GitBox
github-actions[bot] commented on pull request #11634: URL: https://github.com/apache/arrow/pull/11634#issuecomment-962509667 Revision: 69277a18e2b7ec83a126ffb9dcfbb56834d087d8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1097](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] kou commented on pull request #11634: ARROW-14623: [Packaging][Java] Upload not only .jar but also .pom

2021-11-06 Thread GitBox
kou commented on pull request #11634: URL: https://github.com/apache/arrow/pull/11634#issuecomment-962509590 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow-datafusion] alamb commented on pull request #1237: ignore case of `with header row` in sql when creating external table

2021-11-06 Thread GitBox
alamb commented on pull request #1237: URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-962506298 If @Dandandan doesn't have anything to add I'll plan to merge this PR tomorrow -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-datafusion] alamb commented on issue #1248: Optimized `RecordBatch` for constant columns

2021-11-06 Thread GitBox
alamb commented on issue #1248: URL: https://github.com/apache/arrow-datafusion/issues/1248#issuecomment-962506200 Another thing to contemplate is support for RLE (aka store runs of repeated values) A A A B B B B --> (A, 3) (B, 4) -- This is an

[GitHub] [arrow-datafusion] alamb commented on issue #440: Future of experimental optimizer datafusion-tokomak

2021-11-06 Thread GitBox
alamb commented on issue #440: URL: https://github.com/apache/arrow-datafusion/issues/440#issuecomment-962505988 Thank you for the update @pjmore -- sounds like some great progress -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow-datafusion] pjmore commented on issue #440: Future of experimental optimizer datafusion-tokomak

2021-11-06 Thread GitBox
pjmore commented on issue #440: URL: https://github.com/apache/arrow-datafusion/issues/440#issuecomment-962503478 Some good and bad news on this front. The Tokomak optimization pass combined with a predicate pushdown pass and a filter<-cross join to filter<-inner join pass is able to hand

[GitHub] [arrow] ursabot edited a comment on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11625: URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586 Benchmark runs are scheduled for baseline = ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender = 412da89146f2366925abda86d34c49d25a78b294. 412da89146f2366925abda86d3

[GitHub] [arrow] vitalybuka commented on pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
vitalybuka commented on pull request #11633: URL: https://github.com/apache/arrow/pull/11633#issuecomment-962501788 > > Constructor of global in one module uses a global from another module, which is not constructed yet. > > Which one is that, concretely? global kDefaultJoinOp

[GitHub] [arrow] ianmcook commented on issue #11622: Python 3.10 wheel

2021-11-06 Thread GitBox
ianmcook commented on issue #11622: URL: https://github.com/apache/arrow/issues/11622#issuecomment-962500444 Oh, I see now that Python 3.10 is not included on this list on PyPI. @kszucs can we fix that? ![5EEF41C3-F7F3-4514-BBBA-8952028AF643](https://user-images.githubusercontent.com/28

[GitHub] [arrow] ursabot edited a comment on pull request #11630: ARROW-14619: [Ruby] Use no @ openssl Homebrew package for pkg-config

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11630: URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413753 Benchmark runs are scheduled for baseline = b1c0aa3971f2b169d208d615b7ce7dee5cde7307 and contender = ae808e0fabc3698d8a84b3e542c9470c95d1af16. ae808e0fabc3698d8a84b3e542

[GitHub] [arrow-datafusion] houqp merged pull request #1255: use arrow 6.1.0

2021-11-06 Thread GitBox
houqp merged pull request #1255: URL: https://github.com/apache/arrow-datafusion/pull/1255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] houqp commented on pull request #1261: Dataframe supports except and update readme

2021-11-06 Thread GitBox
houqp commented on pull request #1261: URL: https://github.com/apache/arrow-datafusion/pull/1261#issuecomment-962482844 @xudong963 looks like tests are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [arrow] pitrou commented on pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
pitrou commented on pull request #11633: URL: https://github.com/apache/arrow/pull/11633#issuecomment-962481463 > Constructor of global in one module uses a global from another module, which is not constructed yet. Which one is that, concretely? -- This is an automated message fr

[GitHub] [arrow] vitalybuka commented on a change in pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
vitalybuka commented on a change in pull request #11633: URL: https://github.com/apache/arrow/pull/11633#discussion_r744146939 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -1153,7 +1153,10 @@ class TableSorter { // --

[GitHub] [arrow] vitalybuka commented on a change in pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
vitalybuka commented on a change in pull request #11633: URL: https://github.com/apache/arrow/pull/11633#discussion_r744146893 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -4617,7 +4617,10 @@ const FunctionDoc binary_join_element_wise_doc( "emit a nu

[GitHub] [arrow] vitalybuka commented on pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
vitalybuka commented on pull request #11633: URL: https://github.com/apache/arrow/pull/11633#issuecomment-962479084 > > This is an error when there are cross-compilation units on static initializated variables where there is no guaranteed order. > > It seems those variables are priva

[GitHub] [arrow] pitrou commented on pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
pitrou commented on pull request #11633: URL: https://github.com/apache/arrow/pull/11633#issuecomment-962477331 > This is an error when there are cross-compilation units on static initializated variables where there is no guaranteed order. It seems those variables are private, no? So

[GitHub] [arrow-datafusion] houqp commented on pull request #1253: create datafusion 6.0.0, ballista 0.6.0 and python 0.4.0 releases

2021-11-06 Thread GitBox
houqp commented on pull request #1253: URL: https://github.com/apache/arrow-datafusion/pull/1253#issuecomment-962476971 > Do you plan a release blog? I would love to help make one. Please go ahead @alamb ! I won't have time to do this until the release has been cut and voted. We can

[GitHub] [arrow] save-buffer commented on a change in pull request #11579: ARROW-13643: [C++][Compute] Implement outer join with support for residual predicates

2021-11-06 Thread GitBox
save-buffer commented on a change in pull request #11579: URL: https://github.com/apache/arrow/pull/11579#discussion_r744142025 ## File path: cpp/src/arrow/compute/exec/hash_join.h ## @@ -56,19 +56,36 @@ class ARROW_EXPORT HashJoinSchema { const

[GitHub] [arrow] ursabot edited a comment on pull request #11629: ARROW-14618: [Release] Add missing AlmaLinux artifacts URL to vote email template

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11629: URL: https://github.com/apache/arrow/pull/11629#issuecomment-962373375 Benchmark runs are scheduled for baseline = e73821d11ed4bf979188bce496df9aa6885b2db4 and contender = b1c0aa3971f2b169d208d615b7ce7dee5cde7307. b1c0aa3971f2b169d208d615b7

[GitHub] [arrow-datafusion] xudong963 edited a comment on issue #1082: Implement the rest of Set Operators: INTERSECT, EXCEPT, etc

2021-11-06 Thread GitBox
xudong963 edited a comment on issue #1082: URL: https://github.com/apache/arrow-datafusion/issues/1082#issuecomment-962469260 All related PRs have finished, after merging, the issue can be closed. Thanks again for your help! @alamb @Dandandan @houqp -- This is an automated message from

[GitHub] [arrow] emkornfield commented on pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
emkornfield commented on pull request #11633: URL: https://github.com/apache/arrow/pull/11633#issuecomment-962469324 > Can you explain quickly what the "initialization order fiasco" is about? So that we don't make the same error later? This is an error when there are cross-compilatio

[GitHub] [arrow-datafusion] xudong963 commented on issue #1082: Implement the rest of Set Operators: INTERSECT, EXCEPT, etc

2021-11-06 Thread GitBox
xudong963 commented on issue #1082: URL: https://github.com/apache/arrow-datafusion/issues/1082#issuecomment-962469260 All related PRs have finished, after merging, the issue can be closed. Thanks for your help! @alamb @Dandandan @houqp -- This is an automated message from the Apache G

[GitHub] [arrow-datafusion] xudong963 opened a new pull request #1261: Dataframe supports except and update readme

2021-11-06 Thread GitBox
xudong963 opened a new pull request #1261: URL: https://github.com/apache/arrow-datafusion/pull/1261 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/1082 # Rationale for this change # What changes are included in th

[GitHub] [arrow] ursabot edited a comment on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11625: URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586 Benchmark runs are scheduled for baseline = ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender = 412da89146f2366925abda86d34c49d25a78b294. 412da89146f2366925abda86d3

[GitHub] [arrow-datafusion] Jimexist edited a comment on issue #1248: Optimized `RecordBatch` for constant columns

2021-11-06 Thread GitBox
Jimexist edited a comment on issue #1248: URL: https://github.com/apache/arrow-datafusion/issues/1248#issuecomment-962463921 > Perhaps we could build something like DFRecordBatch akin to DFSchema (aka wrap the arrow RecordBatch with methods that allow the columns to be ColumnarValue)

[GitHub] [arrow-datafusion] Jimexist edited a comment on issue #1248: Optimized `RecordBatch` for constant columns

2021-11-06 Thread GitBox
Jimexist edited a comment on issue #1248: URL: https://github.com/apache/arrow-datafusion/issues/1248#issuecomment-962463921 > Perhaps we could build something like DFRecordBatch akin to DFSchema (aka wrap the arrow RecordBatch with methods that allow the columns to be ColumnarValue)

[GitHub] [arrow-datafusion] Jimexist commented on issue #1248: Optimized `RecordBatch` for constant columns

2021-11-06 Thread GitBox
Jimexist commented on issue #1248: URL: https://github.com/apache/arrow-datafusion/issues/1248#issuecomment-962463921 > Perhaps we could build something like DFRecordBatch akin to DFSchema (aka wrap the arrow RecordBatch with methods that allow the columns to be ColumnarValue) I'm

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1260: coercing to add more unit tests

2021-11-06 Thread GitBox
Jimexist opened a new pull request #1260: URL: https://github.com/apache/arrow-datafusion/pull/1260 # Which issue does this PR close? Closes #. # Rationale for this change coercing to add more unit tests # What changes are included in this PR? # Are th

[GitHub] [arrow] ursabot edited a comment on pull request #11618: ARROW-14601: [JAVA] fix the comment for timestamp sec

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11618: URL: https://github.com/apache/arrow/pull/11618#issuecomment-962296887 Benchmark runs are scheduled for baseline = da1868b6ff2d3de5d8b52f79361ed57a311bbd5f and contender = e73821d11ed4bf979188bce496df9aa6885b2db4. e73821d11ed4bf979188bce496

[GitHub] [arrow] ursabot edited a comment on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11625: URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586 Benchmark runs are scheduled for baseline = ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender = 412da89146f2366925abda86d34c49d25a78b294. 412da89146f2366925abda86d3

[GitHub] [arrow] lidavidm commented on a change in pull request #11623: ARROW-14583: [C++] Handle empty chunked arrays in Take, empty datasets in GroupByNode

2021-11-06 Thread GitBox
lidavidm commented on a change in pull request #11623: URL: https://github.com/apache/arrow/pull/11623#discussion_r744128125 ## File path: cpp/src/arrow/compute/kernels/vector_selection.cc ## @@ -2013,8 +2013,13 @@ Result> TakeCA(const ChunkedArray& values, // TODO Case 3

[GitHub] [arrow] ursabot commented on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

2021-11-06 Thread GitBox
ursabot commented on pull request #11625: URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586 Benchmark runs are scheduled for baseline = ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender = 412da89146f2366925abda86d34c49d25a78b294. 412da89146f2366925abda86d34c49d25

[GitHub] [arrow] lidavidm closed pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

2021-11-06 Thread GitBox
lidavidm closed pull request #11625: URL: https://github.com/apache/arrow/pull/11625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1259: Implement EXCEPT & EXCEPT DISTINCT

2021-11-06 Thread GitBox
xudong963 commented on pull request #1259: URL: https://github.com/apache/arrow-datafusion/pull/1259#issuecomment-962454505 PTAL, thanks❤️ @alamb @houqp @Dandandan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-datafusion] xudong963 opened a new pull request #1259: Implement EXCEPT & EXCEPT DISTINCT

2021-11-06 Thread GitBox
xudong963 opened a new pull request #1259: URL: https://github.com/apache/arrow-datafusion/pull/1259 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/1082 # Rationale for this change # What changes are included in th

[GitHub] [arrow-datafusion] lichuan6 commented on pull request #1237: ignore case of `with header row` in sql when creating external table

2021-11-06 Thread GitBox
lichuan6 commented on pull request #1237: URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-962452247 Hi, @Dandandan Could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [arrow-datafusion] woodsmur removed a comment on pull request #1237: ignore case of `with header row` in sql when creating external table

2021-11-06 Thread GitBox
woodsmur removed a comment on pull request #1237: URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-962451866 @Dandandan Could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow-datafusion] woodsmur commented on pull request #1237: ignore case of `with header row` in sql when creating external table

2021-11-06 Thread GitBox
woodsmur commented on pull request #1237: URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-962451866 @Dandandan Could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow-datafusion] Jimexist merged pull request #1256: numerical_coercion pattern match optimize

2021-11-06 Thread GitBox
Jimexist merged pull request #1256: URL: https://github.com/apache/arrow-datafusion/pull/1256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

[GitHub] [arrow] ursabot edited a comment on pull request #11627: ARROW-14616: [C++] Fix build errors on master

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11627: URL: https://github.com/apache/arrow/pull/11627#issuecomment-962241492 Benchmark runs are scheduled for baseline = fe92778cff3b4823eea5c105b4678e65fe7ea928 and contender = da1868b6ff2d3de5d8b52f79361ed57a311bbd5f. da1868b6ff2d3de5d8b52f7936

[GitHub] [arrow-datafusion] xudong963 edited a comment on pull request #1258: DataFrame supports intersect and update readme

2021-11-06 Thread GitBox
xudong963 edited a comment on pull request #1258: URL: https://github.com/apache/arrow-datafusion/pull/1258#issuecomment-962448643 Make DataFrame users have the `intersect` feature and Update the README. PTAL❤️ @alamb @houqp @Dandandan -- This is an automated message from the Apache G

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1258: DataFrame supports intersect and update readme

2021-11-06 Thread GitBox
xudong963 commented on pull request #1258: URL: https://github.com/apache/arrow-datafusion/pull/1258#issuecomment-962448643 Make DataFrame users have the `intersect` feature and Update the README. PTAL @alamb @houqp @Dandandan -- This is an automated message from the Apache Git Servic

[GitHub] [arrow-datafusion] xudong963 opened a new pull request #1258: DataFrame supports intersect and update readme

2021-11-06 Thread GitBox
xudong963 opened a new pull request #1258: URL: https://github.com/apache/arrow-datafusion/pull/1258 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/1082 # Rationale for this change # What changes are included in th

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #810: Validate arguments to ArrayData::new and null bit buffer and buffers

2021-11-06 Thread GitBox
codecov-commenter edited a comment on pull request #810: URL: https://github.com/apache/arrow-rs/pull/810#issuecomment-931735295 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[GitHub] [arrow] ursabot edited a comment on pull request #11630: ARROW-14619: [Ruby] Use no @ openssl Homebrew package for pkg-config

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11630: URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413753 Benchmark runs are scheduled for baseline = b1c0aa3971f2b169d208d615b7ce7dee5cde7307 and contender = ae808e0fabc3698d8a84b3e542c9470c95d1af16. ae808e0fabc3698d8a84b3e542

[GitHub] [arrow-datafusion] alamb commented on issue #1082: Implement the rest of Set Operators: INTERSECT, EXCEPT, etc

2021-11-06 Thread GitBox
alamb commented on issue #1082: URL: https://github.com/apache/arrow-datafusion/issues/1082#issuecomment-962444079 Reopening as github API got a little too excited -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-datafusion] xudong963 opened a new issue #1082: Implement the rest of Set Operators: INTERSECT, EXCEPT, etc

2021-11-06 Thread GitBox
xudong963 opened a new issue #1082: URL: https://github.com/apache/arrow-datafusion/issues/1082 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** - [x] INTERSECT - [x] INTERSECT ALL - [ ] EXCEPT - [ ] EXCEPT ALL

[GitHub] [arrow-datafusion] Jimexist commented on pull request #1251: fix 1250, add editor support for datafusion cli with validation

2021-11-06 Thread GitBox
Jimexist commented on pull request #1251: URL: https://github.com/apache/arrow-datafusion/pull/1251#issuecomment-962442943 > I read the code and played around with this and it was very cool 👍 > > Can't wait to see something like SQL autocompletion 😍 > > I wonder if it would be

[GitHub] [arrow-datafusion] Jimexist merged pull request #1251: fix 1250, add editor support for datafusion cli with validation

2021-11-06 Thread GitBox
Jimexist merged pull request #1251: URL: https://github.com/apache/arrow-datafusion/pull/1251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

[GitHub] [arrow-datafusion] Jimexist closed issue #1250: datafusion cli to add sql statement validation editor support

2021-11-06 Thread GitBox
Jimexist closed issue #1250: URL: https://github.com/apache/arrow-datafusion/issues/1250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-un

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11632: ARROW-14620: [Python] Missing bindings for existing_data_behavior makes it impossible to maintain old behavior

2021-11-06 Thread GitBox
jorisvandenbossche commented on a change in pull request #11632: URL: https://github.com/apache/arrow/pull/11632#discussion_r744116947 ## File path: python/pyarrow/dataset.py ## @@ -798,6 +799,18 @@ def write_dataset(data, base_dir, basename_template=None, format=None,

[GitHub] [arrow-datafusion] xudong963 commented on issue #1082: Implement the rest of Set Operators: INTERSECT, EXCEPT, etc

2021-11-06 Thread GitBox
xudong963 commented on issue #1082: URL: https://github.com/apache/arrow-datafusion/issues/1082#issuecomment-962438419 The issue needs to reopen, there are other things to do, such as `Expect` support. @alamb -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [arrow] niyue commented on pull request #11635: ARROW-11549: [C++][Gandiva] Fix issues with FilterCacheKey caused by ToString() not distinguishing null and 'null'

2021-11-06 Thread GitBox
niyue commented on pull request #11635: URL: https://github.com/apache/arrow/pull/11635#issuecomment-962438090 @KirillLykov @projjal could you please help to review? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] github-actions[bot] commented on pull request #11635: ARROW-11549: [C++][Gandiva] Fix issues with FilterCacheKey caused by ToString() not distinguishing null and 'null'

2021-11-06 Thread GitBox
github-actions[bot] commented on pull request #11635: URL: https://github.com/apache/arrow/pull/11635#issuecomment-962437919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] niyue opened a new pull request #11635: ARROW-11549: [C++][Gandiva] Fix issues with FilterCacheKey caused by ToString() not distinguishing null and 'null'

2021-11-06 Thread GitBox
niyue opened a new pull request #11635: URL: https://github.com/apache/arrow/pull/11635 This is the same fix as https://github.com/apache/arrow/pull/9453 The previous PR (https://github.com/apache/arrow/pull/9453) got stale and cannot be merged, and I simply copied the modification i

[GitHub] [arrow] ursabot edited a comment on pull request #11577: ARROW-14515: [R] Add clang sanitizer to crossbow

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11577: URL: https://github.com/apache/arrow/pull/11577#issuecomment-962229986 Benchmark runs are scheduled for baseline = e907a9f0786cbc5869ed35b0a6cbfa946d89a419 and contender = fe92778cff3b4823eea5c105b4678e65fe7ea928. fe92778cff3b4823eea5c105b4

[GitHub] [arrow-datafusion] alamb closed issue #1082: Implement the rest of Set Operators: INTERSECT, EXCEPT, etc

2021-11-06 Thread GitBox
alamb closed issue #1082: URL: https://github.com/apache/arrow-datafusion/issues/1082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb merged pull request #1135: Implement INTERSECT & INTERSECT DISTINCT

2021-11-06 Thread GitBox
alamb merged pull request #1135: URL: https://github.com/apache/arrow-datafusion/pull/1135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1135: Implement INTERSECT & INTERSECT DISTINCT

2021-11-06 Thread GitBox
alamb commented on pull request #1135: URL: https://github.com/apache/arrow-datafusion/pull/1135#issuecomment-962433666 Will merge when tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] ursabot edited a comment on pull request #11629: ARROW-14618: [Release] Add missing AlmaLinux artifacts URL to vote email template

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11629: URL: https://github.com/apache/arrow/pull/11629#issuecomment-962373375 Benchmark runs are scheduled for baseline = e73821d11ed4bf979188bce496df9aa6885b2db4 and contender = b1c0aa3971f2b169d208d615b7ce7dee5cde7307. b1c0aa3971f2b169d208d615b7

[GitHub] [arrow] zhztheplayer commented on pull request #10883: ARROW-7272: [C++][Java] JNI bridge between RecordBatch and VectorSchemaRoot

2021-11-06 Thread GitBox
zhztheplayer commented on pull request #10883: URL: https://github.com/apache/arrow/pull/10883#issuecomment-962433180 > @zhztheplayer sorry for the delay here, did you get a chance to update this to the C-FFI usage? Sorry, haven't got chance to work on it yet. I will try to see if I

[GitHub] [arrow-datafusion] alamb commented on pull request #1251: fix 1250, add editor support for datafusion cli with validation

2021-11-06 Thread GitBox
alamb commented on pull request #1251: URL: https://github.com/apache/arrow-datafusion/pull/1251#issuecomment-962431683 I started playing around with this locally -- it is very cool. Going to review it now more carefully -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow-datafusion] alamb commented on pull request #1223: Add support of HDFS as remote object store

2021-11-06 Thread GitBox
alamb commented on pull request #1223: URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962431574 > I also prefer to have source/sink connectors such as S3 and HDFS in separate repo or even in separate org for fast iterations. I think the separate org for fast i

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1135: Implement INTERSECT & INTERSECT DISTINCT

2021-11-06 Thread GitBox
xudong963 commented on a change in pull request #1135: URL: https://github.com/apache/arrow-datafusion/pull/1135#discussion_r744109782 ## File path: datafusion/src/physical_plan/hash_join.rs ## @@ -120,6 +120,8 @@ pub struct HashJoinExec { metrics: ExecutionPlanMetricsSet,

[GitHub] [arrow] pitrou commented on pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
pitrou commented on pull request #11633: URL: https://github.com/apache/arrow/pull/11633#issuecomment-962429676 cc @emkornfield -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [arrow] pitrou commented on a change in pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
pitrou commented on a change in pull request #11633: URL: https://github.com/apache/arrow/pull/11633#discussion_r744108614 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -1153,7 +1153,10 @@ class TableSorter { // --

[GitHub] [arrow] pitrou commented on a change in pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
pitrou commented on a change in pull request #11633: URL: https://github.com/apache/arrow/pull/11633#discussion_r744108374 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -4617,7 +4617,10 @@ const FunctionDoc binary_join_element_wise_doc( "emit a null (

[GitHub] [arrow] pitrou commented on pull request #11633: ARROW-14622: [C++] Fix initialization-order-fiasco reports

2021-11-06 Thread GitBox
pitrou commented on pull request #11633: URL: https://github.com/apache/arrow/pull/11633#issuecomment-962429245 Can you explain quickly what the "initialization order fiasco" is about? So that we don't make the same error later? -- This is an automated message from the Apache Git Service

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1253: create datafusion 6.0.0, ballista 0.6.0 and python 0.4.0 releases

2021-11-06 Thread GitBox
alamb commented on a change in pull request #1253: URL: https://github.com/apache/arrow-datafusion/pull/1253#discussion_r744107341 ## File path: datafusion/CHANGELOG.md ## @@ -17,10 +17,183 @@ under the License. --> -For older versions, see [apache/arrow/CHANGELOG.md](ht

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #1135: Implement INTERSECT & INTERSECT DISTINCT

2021-11-06 Thread GitBox
Dandandan commented on a change in pull request #1135: URL: https://github.com/apache/arrow-datafusion/pull/1135#discussion_r744107457 ## File path: datafusion/src/physical_plan/hash_join.rs ## @@ -120,6 +120,8 @@ pub struct HashJoinExec { metrics: ExecutionPlanMetricsSet,

[GitHub] [arrow-rs] alamb closed issue #879: MIRI check is failing on master

2021-11-06 Thread GitBox
alamb closed issue #879: URL: https://github.com/apache/arrow-rs/issues/879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arr

[GitHub] [arrow-rs] alamb merged pull request #922: Automatically retry failed MIRI runs to work around intermittent failures

2021-11-06 Thread GitBox
alamb merged pull request #922: URL: https://github.com/apache/arrow-rs/pull/922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [arrow-datafusion] alamb commented on issue #890: Release Datafusion 6.0.0

2021-11-06 Thread GitBox
alamb commented on issue #890: URL: https://github.com/apache/arrow-datafusion/issues/890#issuecomment-962427203 FYI see https://github.com/apache/arrow-datafusion/pull/1253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow-datafusion] alamb commented on issue #1244: Should not fold a non-constant expression when it is not clear to do so

2021-11-06 Thread GitBox
alamb commented on issue #1244: URL: https://github.com/apache/arrow-datafusion/issues/1244#issuecomment-962427128 👍 FWIW I think handling `NULL`s correctly is the single hardest thing in databases (at least the thing that is the most fraught with strange corner cases). The fact we are d

[GitHub] [arrow] ursabot edited a comment on pull request #11592: ARROW-14227: [R] Implement lubridate is.* methods

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11592: URL: https://github.com/apache/arrow/pull/11592#issuecomment-962179421 Benchmark runs are scheduled for baseline = 230afef57f0ccc2135ced23093bac4298d5ba9e4 and contender = e907a9f0786cbc5869ed35b0a6cbfa946d89a419. e907a9f0786cbc5869ed35b0a6

[GitHub] [arrow] ursabot edited a comment on pull request #11618: ARROW-14601: [JAVA] fix the comment for timestamp sec

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11618: URL: https://github.com/apache/arrow/pull/11618#issuecomment-962296887 Benchmark runs are scheduled for baseline = da1868b6ff2d3de5d8b52f79361ed57a311bbd5f and contender = e73821d11ed4bf979188bce496df9aa6885b2db4. e73821d11ed4bf979188bce496

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #1223: Add support of HDFS as remote object store

2021-11-06 Thread GitBox
yjshen edited a comment on pull request #1223: URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962417090 FYI. Apache Pulsar has a separate repo for connectors https://github.com/apache/pulsar-connectors and a hub hosting all ecosystem repos https://hub.streamnative.i

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1257: binary expression should simplify when either operant is null

2021-11-06 Thread GitBox
Jimexist opened a new pull request #1257: URL: https://github.com/apache/arrow-datafusion/pull/1257 # Which issue does this PR close? Closes #. # Rationale for this change binary expression should simplify when either operant is null # What changes are in

[GitHub] [arrow-datafusion] yjshen commented on pull request #1223: Add support of HDFS as remote object store

2021-11-06 Thread GitBox
yjshen commented on pull request #1223: URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962417090 FYI. Apache Pulsar has a separate repo for connectors https://github.com/apache/pulsar-connectors and a hub hosting all reference repos https://hub.streamnative.io/.

[GitHub] [arrow-datafusion] yjshen commented on pull request #1223: Add support of HDFS as remote object store

2021-11-06 Thread GitBox
yjshen commented on pull request #1223: URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962416192 I also prefer to have source/sink connectors such as S3 and HDFS in separate repo or even in separate org for fast iterations. Adding links for these connectors in DataF

[GitHub] [arrow] ursabot edited a comment on pull request #11630: ARROW-14619: [Ruby] Use no @ openssl Homebrew package for pkg-config

2021-11-06 Thread GitBox
ursabot edited a comment on pull request #11630: URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413753 Benchmark runs are scheduled for baseline = b1c0aa3971f2b169d208d615b7ce7dee5cde7307 and contender = ae808e0fabc3698d8a84b3e542c9470c95d1af16. ae808e0fabc3698d8a84b3e542

[GitHub] [arrow] ursabot commented on pull request #11630: ARROW-14619: [Ruby] Use no @ openssl Homebrew package for pkg-config

2021-11-06 Thread GitBox
ursabot commented on pull request #11630: URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413753 Benchmark runs are scheduled for baseline = b1c0aa3971f2b169d208d615b7ce7dee5cde7307 and contender = ae808e0fabc3698d8a84b3e542c9470c95d1af16. ae808e0fabc3698d8a84b3e542c9470c9

[GitHub] [arrow] kou closed pull request #11630: ARROW-14619: [Ruby] Use no @ openssl Homebrew package for pkg-config

2021-11-06 Thread GitBox
kou closed pull request #11630: URL: https://github.com/apache/arrow/pull/11630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] github-actions[bot] commented on pull request #11634: ARROW-14623: [Packaging][Java] Upload not only .jar but also .pom

2021-11-06 Thread GitBox
github-actions[bot] commented on pull request #11634: URL: https://github.com/apache/arrow/pull/11634#issuecomment-962413448 Revision: 4f69aec5cf7f295a43c7e270dc88443d0818927d Submitted crossbow builds: [ursacomputing/crossbow @ actions-1096](https://github.com/ursacomputing/crossbow

[GitHub] [arrow] kou commented on pull request #11634: ARROW-14623: [Packaging][Java] Upload not only .jar but also .pom

2021-11-06 Thread GitBox
kou commented on pull request #11634: URL: https://github.com/apache/arrow/pull/11634#issuecomment-962413354 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] kou commented on pull request #11630: ARROW-14619: [Ruby] Use no @ openssl Homebrew package for pkg-config

2021-11-06 Thread GitBox
kou commented on pull request #11630: URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413302 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [arrow] kou edited a comment on pull request #11634: ARROW-14623: [Packaging][Java] Upload not only .jar but also .pom

2021-11-06 Thread GitBox
kou edited a comment on pull request #11634: URL: https://github.com/apache/arrow/pull/11634#issuecomment-962413118 @kszucs If we cut 6.0.1 RC1, I want to include this. (It's not a blocker of 6.0.1 RC0.) -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [arrow] kou commented on pull request #11634: ARROW-14623: [Packaging][Java] Upload not only .jar but also .pom

2021-11-06 Thread GitBox
kou commented on pull request #11634: URL: https://github.com/apache/arrow/pull/11634#issuecomment-962413118 @kszucs If we cut 6.0.1 RC1, I want to include this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

  1   2   >