codecov-commenter edited a comment on pull request #849:
URL: https://github.com/apache/arrow-rs/pull/849#issuecomment-950077830
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/849?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
xudong963 edited a comment on issue #1262:
URL:
https://github.com/apache/arrow-datafusion/issues/1262#issuecomment-962550180
FYI, yesterday, the test was normal locally. Today, I rebased master and it
failed, there are two new commits,
https://github.com/apache/arrow-datafusion/pull/1243
xudong963 commented on issue #1262:
URL:
https://github.com/apache/arrow-datafusion/issues/1262#issuecomment-962550180
FYI, yesterday, the test was normal locally. Today, I rebased master and it
failed, there are two new commits,
https://github.com/apache/arrow-datafusion/pull/1243,
http
xudong963 opened a new issue #1262:
URL: https://github.com/apache/arrow-datafusion/issues/1262
**Describe the bug**
`create_external_table_with_timestamps` failed locally, but CI seems normal.
**To Reproduce**
Steps to reproduce the behavior:
**Expected behavior**
```
xudong963 commented on pull request #1261:
URL: https://github.com/apache/arrow-datafusion/pull/1261#issuecomment-962544967
> @xudong963 looks like tests are failing
Yes, after https://github.com/apache/arrow-datafusion/pull/1259 merging,
I'll rebase this PR and the test will pass.
houqp commented on pull request #1223:
URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962536841
@yahoNanJing I agree with you that pooling these extensions into a single
namespace would be better than splitting into personal namespaces. I started a
discussion thread
houqp closed issue #1213:
URL: https://github.com/apache/arrow-datafusion/issues/1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
houqp merged pull request #1243:
URL: https://github.com/apache/arrow-datafusion/pull/1243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
houqp commented on a change in pull request #1259:
URL: https://github.com/apache/arrow-datafusion/pull/1259#discussion_r744178530
##
File path: datafusion/src/sql/planner.rs
##
@@ -195,26 +195,42 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
} => {
houqp commented on a change in pull request #1258:
URL: https://github.com/apache/arrow-datafusion/pull/1258#discussion_r744178212
##
File path: datafusion/src/execution/dataframe_impl.rs
##
@@ -231,6 +231,29 @@ impl DataFrame for DataFrameImpl {
.build()?,
kou commented on pull request #11634:
URL: https://github.com/apache/arrow/pull/11634#issuecomment-962519642
https://github.com/ursacomputing/crossbow/releases/tag/actions-1097-github-java-jars
has both .jar and .pom but version number are 7.0.0-SNAPSHOT not 7.0.0.dev63.
We need `{no_rc_s
github-actions[bot] commented on pull request #11634:
URL: https://github.com/apache/arrow/pull/11634#issuecomment-962509667
Revision: 69277a18e2b7ec83a126ffb9dcfbb56834d087d8
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1097](https://github.com/ursacomputing/crossbow
kou commented on pull request #11634:
URL: https://github.com/apache/arrow/pull/11634#issuecomment-962509590
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
alamb commented on pull request #1237:
URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-962506298
If @Dandandan doesn't have anything to add I'll plan to merge this PR
tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message,
alamb commented on issue #1248:
URL:
https://github.com/apache/arrow-datafusion/issues/1248#issuecomment-962506200
Another thing to contemplate is support for RLE (aka store runs of repeated
values)
A
A
A
B
B
B
B
-->
(A, 3)
(B, 4)
--
This is an
alamb commented on issue #440:
URL:
https://github.com/apache/arrow-datafusion/issues/440#issuecomment-962505988
Thank you for the update @pjmore -- sounds like some great progress
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
pjmore commented on issue #440:
URL:
https://github.com/apache/arrow-datafusion/issues/440#issuecomment-962503478
Some good and bad news on this front. The Tokomak optimization pass combined
with a predicate pushdown pass and a filter<-cross join to filter<-inner join
pass is able to hand
ursabot edited a comment on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586
Benchmark runs are scheduled for baseline =
ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender =
412da89146f2366925abda86d34c49d25a78b294.
412da89146f2366925abda86d3
vitalybuka commented on pull request #11633:
URL: https://github.com/apache/arrow/pull/11633#issuecomment-962501788
> > Constructor of global in one module uses a global from another module,
which is not constructed yet.
>
> Which one is that, concretely?
global kDefaultJoinOp
ianmcook commented on issue #11622:
URL: https://github.com/apache/arrow/issues/11622#issuecomment-962500444
Oh, I see now that Python 3.10 is not included on this list on PyPI. @kszucs
can we fix that?

Jimexist edited a comment on issue #1248:
URL:
https://github.com/apache/arrow-datafusion/issues/1248#issuecomment-962463921
> Perhaps we could build something like DFRecordBatch akin to DFSchema (aka
wrap the arrow RecordBatch with methods that allow the columns to be
ColumnarValue)
Jimexist commented on issue #1248:
URL:
https://github.com/apache/arrow-datafusion/issues/1248#issuecomment-962463921
> Perhaps we could build something like DFRecordBatch akin to DFSchema (aka
wrap the arrow RecordBatch with methods that allow the columns to be
ColumnarValue)
I'm
Jimexist opened a new pull request #1260:
URL: https://github.com/apache/arrow-datafusion/pull/1260
# Which issue does this PR close?
Closes #.
# Rationale for this change
coercing to add more unit tests
# What changes are included in this PR?
# Are th
ursabot edited a comment on pull request #11618:
URL: https://github.com/apache/arrow/pull/11618#issuecomment-962296887
Benchmark runs are scheduled for baseline =
da1868b6ff2d3de5d8b52f79361ed57a311bbd5f and contender =
e73821d11ed4bf979188bce496df9aa6885b2db4.
e73821d11ed4bf979188bce496
ursabot edited a comment on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586
Benchmark runs are scheduled for baseline =
ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender =
412da89146f2366925abda86d34c49d25a78b294.
412da89146f2366925abda86d3
lidavidm commented on a change in pull request #11623:
URL: https://github.com/apache/arrow/pull/11623#discussion_r744128125
##
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##
@@ -2013,8 +2013,13 @@ Result> TakeCA(const
ChunkedArray& values,
// TODO Case 3
ursabot commented on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586
Benchmark runs are scheduled for baseline =
ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender =
412da89146f2366925abda86d34c49d25a78b294.
412da89146f2366925abda86d34c49d25
lidavidm closed pull request #11625:
URL: https://github.com/apache/arrow/pull/11625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
xudong963 commented on pull request #1259:
URL: https://github.com/apache/arrow-datafusion/pull/1259#issuecomment-962454505
PTAL, thanks❤️ @alamb @houqp @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xudong963 opened a new pull request #1259:
URL: https://github.com/apache/arrow-datafusion/pull/1259
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/1082
# Rationale for this change
# What changes are included in th
lichuan6 commented on pull request #1237:
URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-962452247
Hi, @Dandandan Could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
woodsmur removed a comment on pull request #1237:
URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-962451866
@Dandandan Could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
woodsmur commented on pull request #1237:
URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-962451866
@Dandandan Could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
Jimexist merged pull request #1256:
URL: https://github.com/apache/arrow-datafusion/pull/1256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gith
ursabot edited a comment on pull request #11627:
URL: https://github.com/apache/arrow/pull/11627#issuecomment-962241492
Benchmark runs are scheduled for baseline =
fe92778cff3b4823eea5c105b4678e65fe7ea928 and contender =
da1868b6ff2d3de5d8b52f79361ed57a311bbd5f.
da1868b6ff2d3de5d8b52f7936
xudong963 edited a comment on pull request #1258:
URL: https://github.com/apache/arrow-datafusion/pull/1258#issuecomment-962448643
Make DataFrame users have the `intersect` feature and Update the README.
PTAL❤️ @alamb @houqp @Dandandan
--
This is an automated message from the Apache G
xudong963 commented on pull request #1258:
URL: https://github.com/apache/arrow-datafusion/pull/1258#issuecomment-962448643
Make DataFrame users have the `intersect` feature and Update the README.
PTAL @alamb @houqp @Dandandan
--
This is an automated message from the Apache Git Servic
xudong963 opened a new pull request #1258:
URL: https://github.com/apache/arrow-datafusion/pull/1258
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/1082
# Rationale for this change
# What changes are included in th
codecov-commenter edited a comment on pull request #810:
URL: https://github.com/apache/arrow-rs/pull/810#issuecomment-931735295
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
ursabot edited a comment on pull request #11630:
URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413753
Benchmark runs are scheduled for baseline =
b1c0aa3971f2b169d208d615b7ce7dee5cde7307 and contender =
ae808e0fabc3698d8a84b3e542c9470c95d1af16.
ae808e0fabc3698d8a84b3e542
alamb commented on issue #1082:
URL:
https://github.com/apache/arrow-datafusion/issues/1082#issuecomment-962444079
Reopening as github API got a little too excited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xudong963 opened a new issue #1082:
URL: https://github.com/apache/arrow-datafusion/issues/1082
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
- [x] INTERSECT
- [x] INTERSECT ALL
- [ ] EXCEPT
- [ ] EXCEPT ALL
Jimexist commented on pull request #1251:
URL: https://github.com/apache/arrow-datafusion/pull/1251#issuecomment-962442943
> I read the code and played around with this and it was very cool 👍
>
> Can't wait to see something like SQL autocompletion 😍
>
> I wonder if it would be
Jimexist merged pull request #1251:
URL: https://github.com/apache/arrow-datafusion/pull/1251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gith
Jimexist closed issue #1250:
URL: https://github.com/apache/arrow-datafusion/issues/1250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-un
jorisvandenbossche commented on a change in pull request #11632:
URL: https://github.com/apache/arrow/pull/11632#discussion_r744116947
##
File path: python/pyarrow/dataset.py
##
@@ -798,6 +799,18 @@ def write_dataset(data, base_dir, basename_template=None,
format=None,
xudong963 commented on issue #1082:
URL:
https://github.com/apache/arrow-datafusion/issues/1082#issuecomment-962438419
The issue needs to reopen, there are other things to do, such as `Expect`
support. @alamb
--
This is an automated message from the Apache Git Service.
To respond to th
niyue commented on pull request #11635:
URL: https://github.com/apache/arrow/pull/11635#issuecomment-962438090
@KirillLykov @projjal could you please help to review? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
github-actions[bot] commented on pull request #11635:
URL: https://github.com/apache/arrow/pull/11635#issuecomment-962437919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
niyue opened a new pull request #11635:
URL: https://github.com/apache/arrow/pull/11635
This is the same fix as https://github.com/apache/arrow/pull/9453
The previous PR (https://github.com/apache/arrow/pull/9453) got stale and
cannot be merged, and I simply copied the modification i
ursabot edited a comment on pull request #11577:
URL: https://github.com/apache/arrow/pull/11577#issuecomment-962229986
Benchmark runs are scheduled for baseline =
e907a9f0786cbc5869ed35b0a6cbfa946d89a419 and contender =
fe92778cff3b4823eea5c105b4678e65fe7ea928.
fe92778cff3b4823eea5c105b4
alamb closed issue #1082:
URL: https://github.com/apache/arrow-datafusion/issues/1082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
alamb merged pull request #1135:
URL: https://github.com/apache/arrow-datafusion/pull/1135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
alamb commented on pull request #1135:
URL: https://github.com/apache/arrow-datafusion/pull/1135#issuecomment-962433666
Will merge when tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ursabot edited a comment on pull request #11629:
URL: https://github.com/apache/arrow/pull/11629#issuecomment-962373375
Benchmark runs are scheduled for baseline =
e73821d11ed4bf979188bce496df9aa6885b2db4 and contender =
b1c0aa3971f2b169d208d615b7ce7dee5cde7307.
b1c0aa3971f2b169d208d615b7
zhztheplayer commented on pull request #10883:
URL: https://github.com/apache/arrow/pull/10883#issuecomment-962433180
> @zhztheplayer sorry for the delay here, did you get a chance to update
this to the C-FFI usage?
Sorry, haven't got chance to work on it yet. I will try to see if I
alamb commented on pull request #1251:
URL: https://github.com/apache/arrow-datafusion/pull/1251#issuecomment-962431683
I started playing around with this locally -- it is very cool. Going to
review it now more carefully
--
This is an automated message from the Apache Git Service.
To res
alamb commented on pull request #1223:
URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962431574
> I also prefer to have source/sink connectors such as S3 and HDFS in
separate repo or even in separate org for fast iterations.
I think the separate org for fast i
xudong963 commented on a change in pull request #1135:
URL: https://github.com/apache/arrow-datafusion/pull/1135#discussion_r744109782
##
File path: datafusion/src/physical_plan/hash_join.rs
##
@@ -120,6 +120,8 @@ pub struct HashJoinExec {
metrics: ExecutionPlanMetricsSet,
pitrou commented on pull request #11633:
URL: https://github.com/apache/arrow/pull/11633#issuecomment-962429676
cc @emkornfield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
pitrou commented on a change in pull request #11633:
URL: https://github.com/apache/arrow/pull/11633#discussion_r744108614
##
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##
@@ -1153,7 +1153,10 @@ class TableSorter {
// --
pitrou commented on a change in pull request #11633:
URL: https://github.com/apache/arrow/pull/11633#discussion_r744108374
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -4617,7 +4617,10 @@ const FunctionDoc binary_join_element_wise_doc(
"emit a null (
pitrou commented on pull request #11633:
URL: https://github.com/apache/arrow/pull/11633#issuecomment-962429245
Can you explain quickly what the "initialization order fiasco" is about? So
that we don't make the same error later?
--
This is an automated message from the Apache Git Service
alamb commented on a change in pull request #1253:
URL: https://github.com/apache/arrow-datafusion/pull/1253#discussion_r744107341
##
File path: datafusion/CHANGELOG.md
##
@@ -17,10 +17,183 @@
under the License.
-->
-For older versions, see
[apache/arrow/CHANGELOG.md](ht
Dandandan commented on a change in pull request #1135:
URL: https://github.com/apache/arrow-datafusion/pull/1135#discussion_r744107457
##
File path: datafusion/src/physical_plan/hash_join.rs
##
@@ -120,6 +120,8 @@ pub struct HashJoinExec {
metrics: ExecutionPlanMetricsSet,
alamb closed issue #879:
URL: https://github.com/apache/arrow-rs/issues/879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arr
alamb merged pull request #922:
URL: https://github.com/apache/arrow-rs/pull/922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr..
alamb commented on issue #890:
URL:
https://github.com/apache/arrow-datafusion/issues/890#issuecomment-962427203
FYI see https://github.com/apache/arrow-datafusion/pull/1253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
alamb commented on issue #1244:
URL:
https://github.com/apache/arrow-datafusion/issues/1244#issuecomment-962427128
👍 FWIW I think handling `NULL`s correctly is the single hardest thing in
databases (at least the thing that is the most fraught with strange corner
cases). The fact we are d
ursabot edited a comment on pull request #11592:
URL: https://github.com/apache/arrow/pull/11592#issuecomment-962179421
Benchmark runs are scheduled for baseline =
230afef57f0ccc2135ced23093bac4298d5ba9e4 and contender =
e907a9f0786cbc5869ed35b0a6cbfa946d89a419.
e907a9f0786cbc5869ed35b0a6
ursabot edited a comment on pull request #11618:
URL: https://github.com/apache/arrow/pull/11618#issuecomment-962296887
Benchmark runs are scheduled for baseline =
da1868b6ff2d3de5d8b52f79361ed57a311bbd5f and contender =
e73821d11ed4bf979188bce496df9aa6885b2db4.
e73821d11ed4bf979188bce496
yjshen edited a comment on pull request #1223:
URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962417090
FYI. Apache Pulsar has a separate repo for connectors
https://github.com/apache/pulsar-connectors and a hub hosting all ecosystem
repos https://hub.streamnative.i
Jimexist opened a new pull request #1257:
URL: https://github.com/apache/arrow-datafusion/pull/1257
# Which issue does this PR close?
Closes #.
# Rationale for this change
binary expression should simplify when either operant is null
# What changes are in
yjshen commented on pull request #1223:
URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962417090
FYI. Apache Pulsar has a separate repo for connectors
https://github.com/apache/pulsar-connectors and a hub hosting all reference
repos https://hub.streamnative.io/.
yjshen commented on pull request #1223:
URL: https://github.com/apache/arrow-datafusion/pull/1223#issuecomment-962416192
I also prefer to have source/sink connectors such as S3 and HDFS in separate
repo or even in separate org for fast iterations. Adding links for these
connectors in DataF
ursabot edited a comment on pull request #11630:
URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413753
Benchmark runs are scheduled for baseline =
b1c0aa3971f2b169d208d615b7ce7dee5cde7307 and contender =
ae808e0fabc3698d8a84b3e542c9470c95d1af16.
ae808e0fabc3698d8a84b3e542
ursabot commented on pull request #11630:
URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413753
Benchmark runs are scheduled for baseline =
b1c0aa3971f2b169d208d615b7ce7dee5cde7307 and contender =
ae808e0fabc3698d8a84b3e542c9470c95d1af16.
ae808e0fabc3698d8a84b3e542c9470c9
kou closed pull request #11630:
URL: https://github.com/apache/arrow/pull/11630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
github-actions[bot] commented on pull request #11634:
URL: https://github.com/apache/arrow/pull/11634#issuecomment-962413448
Revision: 4f69aec5cf7f295a43c7e270dc88443d0818927d
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1096](https://github.com/ursacomputing/crossbow
kou commented on pull request #11634:
URL: https://github.com/apache/arrow/pull/11634#issuecomment-962413354
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
kou commented on pull request #11630:
URL: https://github.com/apache/arrow/pull/11630#issuecomment-962413302
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
kou edited a comment on pull request #11634:
URL: https://github.com/apache/arrow/pull/11634#issuecomment-962413118
@kszucs If we cut 6.0.1 RC1, I want to include this. (It's not a blocker of
6.0.1 RC0.)
--
This is an automated message from the Apache Git Service.
To respond to the messa
kou commented on pull request #11634:
URL: https://github.com/apache/arrow/pull/11634#issuecomment-962413118
@kszucs If we cut 6.0.1 RC1, I want to include this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
1 - 100 of 111 matches
Mail list logo