wangfenjin edited a comment on issue #1323:
URL: https://github.com/apache/arrow-rs/issues/1323#issuecomment-1042579629
@nevi-me I checked your code, the idea is to have a to_sql() method for
LogicalPlan. I think it's a good idea, actually yesterday I also try to read
datafusion's codebase
e-dard commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808759307
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (ASF
zhixingheyi-tian commented on pull request #11763:
URL: https://github.com/apache/arrow/pull/11763#issuecomment-1042660467
@pitrou @jorisvandenbossche
Now all CI passed.
gsserge commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808744019
##
File path: arrow/src/csv/writer.rs
##
@@ -97,6 +97,7 @@ pub struct Writer {
/// The object to write to
writer: csv_crate::Writer,
/// C
gsserge opened a new issue #1328:
URL: https://github.com/apache/arrow-rs/issues/1328
Discovered in
https://github.com/apache/arrow-rs/pull/1324#discussion_r808432375
The delimiter can be correctly configured via `WriterBuilder`.
`WriterBuilder::build()` constructs the `Writer` in-l
codecov-commenter commented on pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#issuecomment-1042643832
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
gsserge commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808734662
##
File path: arrow/src/csv/reader.rs
##
@@ -1055,6 +1056,7 @@ pub struct ReaderBuilder {
/// The default batch size when using the `ReaderBuilder`
gsserge opened a new issue #1327:
URL: https://github.com/apache/arrow-rs/issues/1327
Discovered in
https://github.com/apache/arrow-rs/pull/1324#discussion_r808432653
`ReaderBuilder` for cvs has the `bounds` field, which is supposed to be
configured via builder and then passed to `R
codecov-commenter commented on pull request #1326:
URL: https://github.com/apache/arrow-rs/pull/1326#issuecomment-1042635166
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Ted-Jiang edited a comment on pull request #1841:
URL:
https://github.com/apache/arrow-datafusion/pull/1841#issuecomment-1042631149
> * I wonder if/how this gets things closer to being able to do distinct on
compressed data (in DF's case on dictionary encoded columns). The problem (as I
u
gsserge commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808726012
##
File path: arrow/src/ipc/writer.rs
##
@@ -535,6 +535,7 @@ pub struct StreamWriter {
/// IPC write options
write_options: IpcWriteOptions,
Ted-Jiang edited a comment on pull request #1841:
URL:
https://github.com/apache/arrow-datafusion/pull/1841#issuecomment-1042631149
> * I wonder if/how this gets things closer to being able to do distinct on
compressed data (in DF's case on dictionary encoded columns). The problem (as I
u
Ted-Jiang commented on pull request #1841:
URL:
https://github.com/apache/arrow-datafusion/pull/1841#issuecomment-1042631149
> * I wonder if/how this gets things closer to being able to do distinct on
compressed data (in DF's case on dictionary encoded columns). The problem (as I
unde
seddonm1 commented on issue #1323:
URL: https://github.com/apache/arrow-rs/issues/1323#issuecomment-1042627182
I have an implementation of datafusion querying directly against postgres I
can share. It too uses the catalog but it allows joining a postgres table to a
parquet table to now a p
viirya commented on a change in pull request #1326:
URL: https://github.com/apache/arrow-rs/pull/1326#discussion_r808721121
##
File path: arrow/src/compute/kernels/comparison.rs
##
@@ -4790,5 +4848,12 @@ mod tests {
result.unwrap(),
BooleanArray::from(
viirya opened a new pull request #1326:
URL: https://github.com/apache/arrow-rs/pull/1326
# Which issue does this PR close?
Closes #1201.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-fac
Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808719933
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (
Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808719208
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (
Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808702220
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (
Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808705218
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (
shanisolomon commented on a change in pull request #1322:
URL: https://github.com/apache/arrow-rs/pull/1322#discussion_r808711613
##
File path: parquet/src/file/metadata.rs
##
@@ -467,6 +469,17 @@ impl ColumnChunkMetaData {
self.statistics.as_ref()
}
+/// Re
Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808705218
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (
Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808702220
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (
Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808701903
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (
Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r808701903
##
File path: datafusion/src/physical_plan/expressions/bitmap_distinct.rs
##
@@ -0,0 +1,233 @@
+// Licensed to the Apache Software Foundation (
Ted-Jiang edited a comment on issue #1823:
URL:
https://github.com/apache/arrow-datafusion/issues/1823#issuecomment-1042597079
Hi @e-dard Thanks a lot for your info! What an admirable work in IOx.
I have done some test above，there is 2x boost for `croaring-rs` than
`roaring-rs`.
and
Ted-Jiang commented on issue #1823:
URL:
https://github.com/apache/arrow-datafusion/issues/1823#issuecomment-1042597079
@e-dard Thanks a lot for your info! What an admirable work in IOX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jimexist merged pull request #1843:
URL: https://github.com/apache/arrow-datafusion/pull/1843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gith
Jimexist closed issue #1844:
URL: https://github.com/apache/arrow-datafusion/issues/1844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-un
kou commented on issue #284:
URL: https://github.com/apache/arrow-julia/issues/284#issuecomment-1042585103
> To reduce the overhead for releases, could the Julia release process be
folded into the releases for https://github.com/apache/arrow?
@domoritz Thanks for your comment! But th
kou commented on issue #284:
URL: https://github.com/apache/arrow-julia/issues/284#issuecomment-1042583219
My understanding that we have 2 problems to be fixed:
1. Extra release work
2. Current maintainers/developers don't have write access to
apache/arrow-julia
Right?
wangfenjin commented on issue #1323:
URL: https://github.com/apache/arrow-rs/issues/1323#issuecomment-1042579629
@nevi-me I checked your code, the idea is to have a to_sql() method for
LogicalPlan. I think it's a good idea, actually yesterday I also try to read
datafusion's codebase to fin
cyb70289 closed pull request #12196:
URL: https://github.com/apache/arrow/pull/12196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
cyb70289 commented on pull request #12196:
URL: https://github.com/apache/arrow/pull/12196#issuecomment-1042576911
Close this PR. Prefer https://github.com/apache/arrow/pull/12442.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
github-actions[bot] commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042536407
Revision: 87bdd53eb3236c527352e3f182f68d32d6b42096
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1644](https://github.com/ursacomputing/crossbo
westonpace commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042533278
@github-actions crossbow submit test-ubuntu-*-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
github-actions[bot] commented on pull request #12446:
URL: https://github.com/apache/arrow/pull/12446#issuecomment-1042532226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
westonpace opened a new pull request #12446:
URL: https://github.com/apache/arrow/pull/12446
Ubuntu 18.04 does not have a new enough version of protobuf to use the
engine module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
cyb70289 commented on a change in pull request #12426:
URL: https://github.com/apache/arrow/pull/12426#discussion_r808625398
##
File path: cpp/src/arrow/csv/options.h
##
@@ -194,6 +194,9 @@ struct ARROW_EXPORT WriteOptions {
/// This number can impact performance.
int32_t
cyb70289 commented on a change in pull request #12426:
URL: https://github.com/apache/arrow/pull/12426#discussion_r808622146
##
File path: python/pyarrow/includes/libarrow.pxd
##
@@ -1713,6 +1713,7 @@ cdef extern from "arrow/csv/api.h" namespace "arrow::csv"
nogil:
cdef c
cyb70289 commented on a change in pull request #12426:
URL: https://github.com/apache/arrow/pull/12426#discussion_r808621398
##
File path: cpp/src/arrow/csv/writer_test.cc
##
@@ -233,7 +241,15 @@ std::vector GenerateTestCases() {
reject_structural_params({"0123456789", n
github-actions[bot] commented on pull request #12445:
URL: https://github.com/apache/arrow/pull/12445#issuecomment-1042510620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pachadotdev opened a new pull request #12445:
URL: https://github.com/apache/arrow/pull/12445
TODOs:
Convert cheat sheet to PDF and hide slide #1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cyb70289 commented on a change in pull request #12426:
URL: https://github.com/apache/arrow/pull/12426#discussion_r808618899
##
File path: cpp/src/arrow/csv/options.cc
##
@@ -73,6 +73,9 @@ Status ReadOptions::Validate() const {
WriteOptions WriteOptions::Defaults() { return Wr
pachadotdev closed pull request #11012:
URL: https://github.com/apache/arrow/pull/11012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-uns
ursabot edited a comment on pull request #12366:
URL: https://github.com/apache/arrow/pull/12366#issuecomment-1042463484
Benchmark runs are scheduled for baseline =
ee9354db75d24914f19ec6bbac43093026f66b8e and contender =
3ce4f81de79e7808c329b20b46924230e9aaa3cb.
3ce4f81de79e7808c329b20b4
github-actions[bot] commented on pull request #12444:
URL: https://github.com/apache/arrow/pull/12444#issuecomment-1042505535
https://issues.apache.org/jira/browse/ARROW-15709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
westonpace commented on pull request #12444:
URL: https://github.com/apache/arrow/pull/12444#issuecomment-1042504363
This is blocking conbench and is a minor change so I'll push on green CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ursabot edited a comment on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1042307000
Benchmark runs are scheduled for baseline =
e4e866fe6d222900262aed77274f46713bd89e9f and contender =
ee9354db75d24914f19ec6bbac43093026f66b8e.
ee9354db75d24914f19ec6bba
ursabot edited a comment on pull request #12369:
URL: https://github.com/apache/arrow/pull/12369#issuecomment-1042056679
Benchmark runs are scheduled for baseline =
3a8e409385c8455e6c80b867c5730965a501d113 and contender =
e4e866fe6d222900262aed77274f46713bd89e9f.
e4e866fe6d222900262aed772
ursabot edited a comment on pull request #12430:
URL: https://github.com/apache/arrow/pull/12430#issuecomment-1041892779
Benchmark runs are scheduled for baseline =
d97640c9127ca591ce11715d9194a5d26e76e68a and contender =
3a8e409385c8455e6c80b867c5730965a501d113.
3a8e409385c8455e6c80b867c
baumgold commented on issue #285:
URL: https://github.com/apache/arrow-julia/issues/285#issuecomment-1042490814
Related to #258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
baumgold commented on issue #285:
URL: https://github.com/apache/arrow-julia/issues/285#issuecomment-1042488559
As a work-around all nullable types can be converted to use Missing instead
of Nothing, which seems to allow Python to read the Arrow files generated by
Arrow.jl. The issue is n
ursabot edited a comment on pull request #12141:
URL: https://github.com/apache/arrow/pull/12141#issuecomment-1041820828
Benchmark runs are scheduled for baseline =
1b9e76c6b07d557249a949c7c98d00997513d5cc and contender =
d97640c9127ca591ce11715d9194a5d26e76e68a.
d97640c9127ca591ce11715d9
ursabot edited a comment on pull request #12414:
URL: https://github.com/apache/arrow/pull/12414#issuecomment-1041572550
Benchmark runs are scheduled for baseline =
4f890abe1df27712e6001cbfe27b0ec4c21de8f1 and contender =
1b9e76c6b07d557249a949c7c98d00997513d5cc.
1b9e76c6b07d557249a949c7c
domoritz edited a comment on issue #284:
URL: https://github.com/apache/arrow-julia/issues/284#issuecomment-1042480283
Just adding two cents from the Arrow JS perspective. We are also a small
developer group (3 contributors) working on Arrow in bursts and in no way full
time. Overall, I'd
domoritz commented on issue #284:
URL: https://github.com/apache/arrow-julia/issues/284#issuecomment-1042480283
Just adding two cents from the Arrow JS perspective. We are also a small
developer group (3 contributors) working on Arrow in bursts and in no way full
time. Overall, I'd say tha
zhixingheyi-tian edited a comment on pull request #11763:
URL: https://github.com/apache/arrow/pull/11763#issuecomment-1042475058
> I couldn't push changes to this PR so I have submitted another one in
#12441.
Why didn't push directly? If need other minor change , I can continue doin
ursabot edited a comment on pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#issuecomment-1041551621
Benchmark runs are scheduled for baseline =
07db461daad60792f7bffea4532e2ed813c2f7b8 and contender =
4f890abe1df27712e6001cbfe27b0ec4c21de8f1.
4f890abe1df27712e6001cbfe
zhixingheyi-tian commented on pull request #11763:
URL: https://github.com/apache/arrow/pull/11763#issuecomment-1042475058
> I couldn't push changes to this PR so I have submitted another one in
#12441.
Why didn't push directly? If need other minor change , I can continue doing。
ursabot edited a comment on pull request #12399:
URL: https://github.com/apache/arrow/pull/12399#issuecomment-1041512655
Benchmark runs are scheduled for baseline =
12490eb7a39cb2ceab87f0c1b9183dfe7ffd1507 and contender =
07db461daad60792f7bffea4532e2ed813c2f7b8.
07db461daad60792f7bffea45
wesm commented on issue #284:
URL: https://github.com/apache/arrow-julia/issues/284#issuecomment-1042470001
It is often customary to grant commit access to the major contributors that
are party to a large code donation through the IP clearance process. For
example, many people become commi
ursabot edited a comment on pull request #12434:
URL: https://github.com/apache/arrow/pull/12434#issuecomment-1041433837
Benchmark runs are scheduled for baseline =
a935c81b595d24179e115d64cda944efa93aa0e0 and contender =
12490eb7a39cb2ceab87f0c1b9183dfe7ffd1507.
12490eb7a39cb2ceab87f0c1b
ursabot edited a comment on pull request #12366:
URL: https://github.com/apache/arrow/pull/12366#issuecomment-1042463484
Benchmark runs are scheduled for baseline =
ee9354db75d24914f19ec6bbac43093026f66b8e and contender =
3ce4f81de79e7808c329b20b46924230e9aaa3cb.
3ce4f81de79e7808c329b20b4
ursabot edited a comment on pull request #12279:
URL: https://github.com/apache/arrow/pull/12279#issuecomment-1041030773
Benchmark runs are scheduled for baseline =
f8689a12bb7e4ee9861456c1629637bbf8d5d11c and contender =
a935c81b595d24179e115d64cda944efa93aa0e0.
a935c81b595d24179e115d64c
ursabot commented on pull request #12366:
URL: https://github.com/apache/arrow/pull/12366#issuecomment-1042463484
Benchmark runs are scheduled for baseline =
ee9354db75d24914f19ec6bbac43093026f66b8e and contender =
3ce4f81de79e7808c329b20b46924230e9aaa3cb.
3ce4f81de79e7808c329b20b46924230
github-actions[bot] commented on pull request #12443:
URL: https://github.com/apache/arrow/pull/12443#issuecomment-1042461603
Revision: 2e5d51150e9d827f4f5b27d79a9fc680b4d91040
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1643](https://github.com/ursacomputing/crossbo
github-actions[bot] commented on pull request #12443:
URL: https://github.com/apache/arrow/pull/12443#issuecomment-1042460763
https://issues.apache.org/jira/browse/ARROW-15708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
jonkeane commented on pull request #12443:
URL: https://github.com/apache/arrow/pull/12443#issuecomment-1042460864
@github-actions crossbow submit test-fedora-r-clang-sanitizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ursabot edited a comment on pull request #12410:
URL: https://github.com/apache/arrow/pull/12410#issuecomment-1040944528
Benchmark runs are scheduled for baseline =
96785665eff453aa4e5fc87a8ee5d047b9526869 and contender =
f8689a12bb7e4ee9861456c1629637bbf8d5d11c.
f8689a12bb7e4ee9861456c16
jonkeane closed pull request #12366:
URL: https://github.com/apache/arrow/pull/12366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
NarayanB commented on issue #12416:
URL: https://github.com/apache/arrow/issues/12416#issuecomment-1042444840
I'm not using table.to_pandas() at all. Polars csv has method to convert df
to table. I'm directly writing pq.write_to_dataset method on that table. I will
prepare a simple example
matthewmturner commented on issue #1836:
URL:
https://github.com/apache/arrow-datafusion/issues/1836#issuecomment-1042422114
@returnString thanks for your work to enable this! it's going to be very
helpful on these next steps.
One question, what would be an example of an implementer
ursabot edited a comment on pull request #12403:
URL: https://github.com/apache/arrow/pull/12403#issuecomment-1040680589
Benchmark runs are scheduled for baseline =
3873f632952370688bfd087e0624f96f3d5b5b56 and contender =
96785665eff453aa4e5fc87a8ee5d047b9526869.
96785665eff453aa4e5fc87a8
dhruv9vats commented on a change in pull request #12368:
URL: https://github.com/apache/arrow/pull/12368#discussion_r808502128
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc
##
@@ -2460,6 +2461,294 @@ TEST(GroupBy, Distinct) {
}
}
+TEST(GroupBy, OneMis
lidavidm commented on a change in pull request #12368:
URL: https://github.com/apache/arrow/pull/12368#discussion_r808501334
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc
##
@@ -2460,6 +2461,294 @@ TEST(GroupBy, Distinct) {
}
}
+TEST(GroupBy, OneMiscT
lidavidm edited a comment on pull request #12442:
URL: https://github.com/apache/arrow/pull/12442#issuecomment-1042347532
TODOs
- [ ] Split this PR into two parts: one to enable separate transports
(ARROW-15282), one to implement a UCX transport
- [ ] Refactor the Flight tests so
dhruv9vats commented on a change in pull request #12368:
URL: https://github.com/apache/arrow/pull/12368#discussion_r808498087
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc
##
@@ -2460,6 +2461,294 @@ TEST(GroupBy, Distinct) {
}
}
+TEST(GroupBy, OneMis
gsserge commented on pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#issuecomment-1042359938
Cool that enabling this lint reveals real issues, so it is actually very
beneficial for everyone to be careful with `allow`'s and use them sparingly.
However, I'd prefer not t
gsserge commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808491994
##
File path: arrow/src/csv/writer.rs
##
@@ -97,6 +97,7 @@ pub struct Writer {
/// The object to write to
writer: csv_crate::Writer,
/// C
lidavidm edited a comment on pull request #12442:
URL: https://github.com/apache/arrow/pull/12442#issuecomment-1042347532
TODOs
- [ ] Split this PR into two parts: one to enable separate transports
(ARROW-15282), one to implement a UCX transport
- [ ] Refactor the Flight tests so
alamb commented on issue #1304:
URL: https://github.com/apache/arrow-rs/issues/1304#issuecomment-1042353305
https://github.com/apache/arrow-rs/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb opened a new pull request #1325:
URL: https://github.com/apache/arrow-rs/pull/1325
re #1304
See rendered version
https://github.com/alamb/arrow-rs/blob/alamb/prepare_for_10.0.0_release/CHANGELOG.md
There are some very nice performance improvements from @tustvold , some
GavinRay97 commented on issue #1323:
URL: https://github.com/apache/arrow-rs/issues/1323#issuecomment-1042351739
@nevi-me That link is super interesting, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lidavidm commented on pull request #12368:
URL: https://github.com/apache/arrow/pull/12368#issuecomment-1042351840
For MakeOffsetsValues: another JIRA should suffice if you want to do that
later
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
lidavidm commented on a change in pull request #12368:
URL: https://github.com/apache/arrow/pull/12368#discussion_r808489192
##
File path: cpp/src/arrow/testing/matchers.h
##
@@ -61,6 +61,65 @@ class PointeesEqualMatcher {
// Useful in conjunction with other googletest matcher
lidavidm commented on a change in pull request #12368:
URL: https://github.com/apache/arrow/pull/12368#discussion_r808483788
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc
##
@@ -2460,6 +2461,294 @@ TEST(GroupBy, Distinct) {
}
}
+TEST(GroupBy, OneMiscT
lidavidm edited a comment on pull request #12442:
URL: https://github.com/apache/arrow/pull/12442#issuecomment-1042347532
TODOs
- [ ] Split this PR into two parts: one to enable separate transports
(ARROW-15282), one to implement a UCX transport
- [ ] Refactor the Flight tests so
github-actions[bot] commented on pull request #12442:
URL: https://github.com/apache/arrow/pull/12442#issuecomment-1042347666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lidavidm commented on pull request #12442:
URL: https://github.com/apache/arrow/pull/12442#issuecomment-1042347532
TODOs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lidavidm opened a new pull request #12442:
URL: https://github.com/apache/arrow/pull/12442
Not yet ready to review; this is to track progress publicly. TODO list below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gsserge commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808483707
##
File path: arrow/src/csv/reader.rs
##
@@ -1055,6 +1056,7 @@ pub struct ReaderBuilder {
/// The default batch size when using the `ReaderBuilder`
dhruv9vats commented on a change in pull request #12368:
URL: https://github.com/apache/arrow/pull/12368#discussion_r808479628
##
File path: cpp/src/arrow/testing/matchers.h
##
@@ -61,6 +61,65 @@ class PointeesEqualMatcher {
// Useful in conjunction with other googletest match
Dandandan commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808432653
##
File path: arrow/src/csv/reader.rs
##
@@ -1055,6 +1056,7 @@ pub struct ReaderBuilder {
/// The default batch size when using the `ReaderBuilder
gsserge commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808462958
##
File path: arrow/src/ipc/writer.rs
##
@@ -535,6 +535,7 @@ pub struct StreamWriter {
/// IPC write options
write_options: IpcWriteOptions,
alamb commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808461410
##
File path: arrow/src/ipc/writer.rs
##
@@ -535,6 +535,7 @@ pub struct StreamWriter {
/// IPC write options
write_options: IpcWriteOptions,
ursabot edited a comment on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1042307000
Benchmark runs are scheduled for baseline =
e4e866fe6d222900262aed77274f46713bd89e9f and contender =
ee9354db75d24914f19ec6bbac43093026f66b8e.
ee9354db75d24914f19ec6bba
ursabot commented on pull request #12436:
URL: https://github.com/apache/arrow/pull/12436#issuecomment-1042307000
Benchmark runs are scheduled for baseline =
e4e866fe6d222900262aed77274f46713bd89e9f and contender =
ee9354db75d24914f19ec6bbac43093026f66b8e.
ee9354db75d24914f19ec6bbac430930
kszucs closed pull request #12436:
URL: https://github.com/apache/arrow/pull/12436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
nevi-me commented on issue #1323:
URL: https://github.com/apache/arrow-rs/issues/1323#issuecomment-1042297168
> I'm primarily interested in making it possible for services/projects that
can talk to PG to be able to talk to IOx, where IOx really means Datafusion. My
approach has been to imp
1 - 100 of 306 matches
Mail list logo
