[GitHub] [arrow] AlenkaF closed pull request #14040: ARROW-17612: [Benchmarks] Failing benchmarks on macos-arm

2022-09-07 Thread GitBox
AlenkaF closed pull request #14040: ARROW-17612: [Benchmarks] Failing benchmarks on macos-arm URL: https://github.com/apache/arrow/pull/14040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow] AlenkaF commented on pull request #14040: ARROW-17612: [Benchmarks] Failing benchmarks on macos-arm

2022-09-07 Thread GitBox
AlenkaF commented on PR #14040: URL: https://github.com/apache/arrow/pull/14040#issuecomment-1240293625 There is currently a workaround in the buildkite setup to avoid the import error, see [buildkite/benchmark/utils.sh](https://github.com/voltrondata-labs/arrow-benchmarks-ci/commit/14ef68d

[GitHub] [arrow-datafusion] HaoYang670 commented on issue #3315: Review use of panic in `datafusion-sql` crate

2022-09-07 Thread GitBox
HaoYang670 commented on issue #3315: URL: https://github.com/apache/arrow-datafusion/issues/3315#issuecomment-1240278718 I'd like to pick this to get familiar with the sql code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] rtpsw commented on a diff in pull request #13880: ARROW-17412: [C++] AsofJoin multiple keys and types

2022-09-07 Thread GitBox
rtpsw commented on code in PR #13880: URL: https://github.com/apache/arrow/pull/13880#discussion_r965533028 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -222,46 +387,60 @@ class InputState { // latest_time and latest_ref_row to the value that immediately pass the

[GitHub] [arrow] rtpsw commented on a diff in pull request #13880: ARROW-17412: [C++] AsofJoin multiple keys and types

2022-09-07 Thread GitBox
rtpsw commented on code in PR #13880: URL: https://github.com/apache/arrow/pull/13880#discussion_r965531866 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -294,10 +473,22 @@ class InputState { // Index of the time col col_index_t time_col_index_; // Index of the

[GitHub] [arrow-rs] jinyius commented on issue #47: [Parquet] Too many open files (os error 24)

2022-09-07 Thread GitBox
jinyius commented on issue #47: URL: https://github.com/apache/arrow-rs/issues/47#issuecomment-1240208208 any update here as it's been a year? i can provide some test parquet files that triggers this issue if that helps. -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow-datafusion-python] andygrove merged pull request #47: [DataFrame] - Add with_column_renamed funcation for dataframe

2022-09-07 Thread GitBox
andygrove merged PR #47: URL: https://github.com/apache/arrow-datafusion-python/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [arrow-datafusion-python] andygrove closed issue #6: Add `with_column` and `with_column_renamed` to DataFrame

2022-09-07 Thread GitBox
andygrove closed issue #6: Add `with_column` and `with_column_renamed` to DataFrame URL: https://github.com/apache/arrow-datafusion-python/issues/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow-datafusion-python] andygrove merged pull request #49: [SessionContext] - Add register_udaf_fun funcation for session context

2022-09-07 Thread GitBox
andygrove merged PR #49: URL: https://github.com/apache/arrow-datafusion-python/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [arrow-datafusion-python] andygrove merged pull request #50: [SessionContext] - Add session_id funcation for session context

2022-09-07 Thread GitBox
andygrove merged PR #50: URL: https://github.com/apache/arrow-datafusion-python/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [arrow-datafusion] ursabot commented on pull request #3341: Replace panic in `datafusion-expr` crate

2022-09-07 Thread GitBox
ursabot commented on PR #3341: URL: https://github.com/apache/arrow-datafusion/pull/3341#issuecomment-1240169805 Benchmark runs are scheduled for baseline = 30fce22dffe70e8c2359f4aa9f9bb2c5d2758cc2 and contender = e6378f40ebc004ff63128eb6c0f59b6242479ea7. e6378f40ebc004ff63128eb6c0f59b624

[GitHub] [arrow-datafusion] andygrove merged pull request #3341: Replace panic in `datafusion-expr` crate

2022-09-07 Thread GitBox
andygrove merged PR #3341: URL: https://github.com/apache/arrow-datafusion/pull/3341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-datafusion] andygrove closed issue #3312: Review use of panic in `datafusion-expr` crate

2022-09-07 Thread GitBox
andygrove closed issue #3312: Review use of panic in `datafusion-expr` crate URL: https://github.com/apache/arrow-datafusion/issues/3312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [arrow] vibhatha commented on a diff in pull request #13401: ARROW-16855: [C++] Adding Read Relation ToProto

2022-09-07 Thread GitBox
vibhatha commented on code in PR #13401: URL: https://github.com/apache/arrow/pull/13401#discussion_r965463633 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -421,5 +433,144 @@ Result FromProto(const substrait::Rel& rel, const ExtensionSet& rel.DebugString

[GitHub] [arrow-datafusion-python] andygrove merged pull request #37: [DataFrame] - Add repartition funcation for dataframe

2022-09-07 Thread GitBox
andygrove merged PR #37: URL: https://github.com/apache/arrow-datafusion-python/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [arrow-datafusion-python] andygrove closed issue #30: Add Python binding for `DataFrame::repartition`

2022-09-07 Thread GitBox
andygrove closed issue #30: Add Python binding for `DataFrame::repartition` URL: https://github.com/apache/arrow-datafusion-python/issues/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow] ursabot commented on pull request #14067: ARROW-17646: [Go][CI] Switch C Data to use cgo.Handle (bumps to Go1.17)

2022-09-07 Thread GitBox
ursabot commented on PR #14067: URL: https://github.com/apache/arrow/pull/14067#issuecomment-1240164552 Benchmark runs are scheduled for baseline = d123277bf0a261cc9fc479a376ac9420a9420eea and contender = 47314c3999d7b7a7f9167c6ed6793da756c411a1. 47314c3999d7b7a7f9167c6ed6793da756c411a1 is

[GitHub] [arrow-datafusion-python] andygrove closed issue #41: README file points to wrong repository

2022-09-07 Thread GitBox
andygrove closed issue #41: README file points to wrong repository URL: https://github.com/apache/arrow-datafusion-python/issues/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [arrow-datafusion-python] andygrove merged pull request #44: [Doc] - Fix readme git repo url

2022-09-07 Thread GitBox
andygrove merged PR #44: URL: https://github.com/apache/arrow-datafusion-python/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [arrow-datafusion-python] andygrove closed issue #29: Add Python binding for `DataFrame::distinct`

2022-09-07 Thread GitBox
andygrove closed issue #29: Add Python binding for `DataFrame::distinct` URL: https://github.com/apache/arrow-datafusion-python/issues/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-datafusion-python] andygrove merged pull request #34: [DataFrame] - Add DataFrame::distinct binding

2022-09-07 Thread GitBox
andygrove merged PR #34: URL: https://github.com/apache/arrow-datafusion-python/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [arrow-datafusion-python] andygrove commented on pull request #34: [DataFrame] - Add DataFrame::distinct binding

2022-09-07 Thread GitBox
andygrove commented on PR #34: URL: https://github.com/apache/arrow-datafusion-python/pull/34#issuecomment-1240161963 Thanks @francis-du! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow-ballista] andygrove closed issue #165: No scheduler logs when deployed to k8s

2022-09-07 Thread GitBox
andygrove closed issue #165: No scheduler logs when deployed to k8s URL: https://github.com/apache/arrow-ballista/issues/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow-ballista] andygrove merged pull request #187: [MINOR] Add log info in stdout

2022-09-07 Thread GitBox
andygrove merged PR #187: URL: https://github.com/apache/arrow-ballista/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow] icexelloss commented on pull request #13880: ARROW-17412: [C++] AsofJoin multiple keys and types

2022-09-07 Thread GitBox
icexelloss commented on PR #13880: URL: https://github.com/apache/arrow/pull/13880#issuecomment-1240150329 @rtpsw I left some question since the code looks a bit from the last time I looked. Otherwise looks good to me. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [arrow] icexelloss commented on a diff in pull request #13880: ARROW-17412: [C++] AsofJoin multiple keys and types

2022-09-07 Thread GitBox
icexelloss commented on code in PR #13880: URL: https://github.com/apache/arrow/pull/13880#discussion_r965450019 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -222,46 +387,60 @@ class InputState { // latest_time and latest_ref_row to the value that immediately pass t

[GitHub] [arrow] icexelloss commented on a diff in pull request #13880: ARROW-17412: [C++] AsofJoin multiple keys and types

2022-09-07 Thread GitBox
icexelloss commented on code in PR #13880: URL: https://github.com/apache/arrow/pull/13880#discussion_r965448559 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -294,10 +473,22 @@ class InputState { // Index of the time col col_index_t time_col_index_; // Index o

[GitHub] [arrow] vibhatha commented on pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
vibhatha commented on PR #14071: URL: https://github.com/apache/arrow/pull/14071#issuecomment-1240144919 @drin I added a few comments and suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] vibhatha commented on a diff in pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
vibhatha commented on code in PR #14071: URL: https://github.com/apache/arrow/pull/14071#discussion_r965446228 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -52,159 +55,239 @@ Status CheckRelCommon(const RelMessage& rel) { return Status::OK(); } -Result Fro

[GitHub] [arrow] vibhatha commented on a diff in pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
vibhatha commented on code in PR #14071: URL: https://github.com/apache/arrow/pull/14071#discussion_r965445985 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -52,159 +55,239 @@ Status CheckRelCommon(const RelMessage& rel) { return Status::OK(); } -Result Fro

[GitHub] [arrow] vibhatha commented on a diff in pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
vibhatha commented on code in PR #14071: URL: https://github.com/apache/arrow/pull/14071#discussion_r965443813 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -52,159 +55,239 @@ Status CheckRelCommon(const RelMessage& rel) { return Status::OK(); } -Result Fro

[GitHub] [arrow] vibhatha commented on a diff in pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
vibhatha commented on code in PR #14071: URL: https://github.com/apache/arrow/pull/14071#discussion_r965443558 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -52,159 +55,239 @@ Status CheckRelCommon(const RelMessage& rel) { return Status::OK(); } -Result Fro

[GitHub] [arrow] vibhatha commented on a diff in pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
vibhatha commented on code in PR #14071: URL: https://github.com/apache/arrow/pull/14071#discussion_r965440777 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -52,159 +55,239 @@ Status CheckRelCommon(const RelMessage& rel) { return Status::OK(); } -Result Fro

[GitHub] [arrow] ZMZ91 commented on a diff in pull request #13838: ARROW-17382: [C++] open_dataset doesn't ignore BOM in csv file when header's with quotes

2022-09-07 Thread GitBox
ZMZ91 commented on code in PR #13838: URL: https://github.com/apache/arrow/pull/13838#discussion_r965431298 ## cpp/src/arrow/dataset/file_csv.cc: ## @@ -196,6 +196,11 @@ static inline Future> OpenReaderAsync( auto reader_fut = DeferNotOk(input->io_context().executor()->Submi

[GitHub] [arrow] ursabot commented on pull request #14056: ARROW-17600: [Go] Implement Casting for Nested types

2022-09-07 Thread GitBox
ursabot commented on PR #14056: URL: https://github.com/apache/arrow/pull/14056#issuecomment-1240082289 Benchmark runs are scheduled for baseline = 21491ec0fa5fad2eb20bfedb3a19873f08e7e895 and contender = d123277bf0a261cc9fc479a376ac9420a9420eea. d123277bf0a261cc9fc479a376ac9420a9420eea is

[GitHub] [arrow] paleolimbot commented on a diff in pull request #13985: ARROW-17462: [R] Cast scalars to type of field in Expression building

2022-09-07 Thread GitBox
paleolimbot commented on code in PR #13985: URL: https://github.com/apache/arrow/pull/13985#discussion_r965412506 ## r/R/expression.R: ## @@ -210,21 +213,20 @@ build_expr <- function(FUN, } if (FUN == "%in%") { # Special-case %in%, which is different from the Array fu

[GitHub] [arrow] vibhatha commented on a diff in pull request #13401: ARROW-16855: [C++] Adding Read Relation ToProto

2022-09-07 Thread GitBox
vibhatha commented on code in PR #13401: URL: https://github.com/apache/arrow/pull/13401#discussion_r965410625 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -162,36 +170,40 @@ Result FromProto(const substrait::Rel& rel, const ExtensionSet& }

[GitHub] [arrow-datafusion] ursabot commented on pull request #3389: minor: remove redundant code.

2022-09-07 Thread GitBox
ursabot commented on PR #3389: URL: https://github.com/apache/arrow-datafusion/pull/3389#issuecomment-1240070262 Benchmark runs are scheduled for baseline = 0084aeb686b318cbdb49cab00cb8f15c9f520d1e and contender = 30fce22dffe70e8c2359f4aa9f9bb2c5d2758cc2. 30fce22dffe70e8c2359f4aa9f9bb2c5d

[GitHub] [arrow-datafusion] andygrove merged pull request #3389: minor: remove redundant code.

2022-09-07 Thread GitBox
andygrove merged PR #3389: URL: https://github.com/apache/arrow-datafusion/pull/3389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow] vibhatha commented on a diff in pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
vibhatha commented on code in PR #14071: URL: https://github.com/apache/arrow/pull/14071#discussion_r965407330 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -52,159 +55,239 @@ Status CheckRelCommon(const RelMessage& rel) { return Status::OK(); } -Result Fro

[GitHub] [arrow] vibhatha commented on a diff in pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
vibhatha commented on code in PR #14071: URL: https://github.com/apache/arrow/pull/14071#discussion_r965403621 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -52,159 +55,239 @@ Status CheckRelCommon(const RelMessage& rel) { return Status::OK(); } -Result Fro

[GitHub] [arrow] westonpace commented on a diff in pull request #13401: ARROW-16855: [C++] Adding Read Relation ToProto

2022-09-07 Thread GitBox
westonpace commented on code in PR #13401: URL: https://github.com/apache/arrow/pull/13401#discussion_r96539 ## cpp/src/arrow/engine/substrait/plan_internal.h: ## @@ -51,5 +53,17 @@ Result GetExtensionSetFromPlan( const substrait::Plan& plan, const ExtensionIdRegis

[GitHub] [arrow-rs] ursabot commented on pull request #2673: Support building comparator for dictionaries of primitive integer values

2022-09-07 Thread GitBox
ursabot commented on PR #2673: URL: https://github.com/apache/arrow-rs/pull/2673#issuecomment-1240046283 Benchmark runs are scheduled for baseline = c25d16e082a218276a2303d4ab0a1cfb53b8c6ac and contender = df4906d76992e26b7b196c1680755ca360272650. df4906d76992e26b7b196c1680755ca360272650 i

[GitHub] [arrow-rs] viirya merged pull request #2673: Support building comparator for dictionaries of primitive integer values

2022-09-07 Thread GitBox
viirya merged PR #2673: URL: https://github.com/apache/arrow-rs/pull/2673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apach

[GitHub] [arrow-rs] viirya commented on pull request #2673: Support building comparator for dictionaries of primitive integer values

2022-09-07 Thread GitBox
viirya commented on PR #2673: URL: https://github.com/apache/arrow-rs/pull/2673#issuecomment-1240040426 Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [arrow-rs] viirya closed issue #2672: Support building comparator for dictionaries of primitive integer values

2022-09-07 Thread GitBox
viirya closed issue #2672: Support building comparator for dictionaries of primitive integer values URL: https://github.com/apache/arrow-rs/issues/2672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow-rs] viirya commented on pull request #2673: Support building comparator for dictionaries of primitive integer values

2022-09-07 Thread GitBox
viirya commented on PR #2673: URL: https://github.com/apache/arrow-rs/pull/2673#issuecomment-1240031819 Go build has some issue. It should be unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow-datafusion] ursabot commented on pull request #3279: Add show external tables

2022-09-07 Thread GitBox
ursabot commented on PR #3279: URL: https://github.com/apache/arrow-datafusion/pull/3279#issuecomment-1240029763 Benchmark runs are scheduled for baseline = 7c04964fee0210411f02bf3938aefe7773710e42 and contender = 0084aeb686b318cbdb49cab00cb8f15c9f520d1e. 0084aeb686b318cbdb49cab00cb8f15c9

[GitHub] [arrow-datafusion] andygrove closed issue #2848: Implement "SHOW CREATE TABLE" for external tables

2022-09-07 Thread GitBox
andygrove closed issue #2848: Implement "SHOW CREATE TABLE" for external tables URL: https://github.com/apache/arrow-datafusion/issues/2848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow-datafusion] andygrove merged pull request #3279: Add show external tables

2022-09-07 Thread GitBox
andygrove merged PR #3279: URL: https://github.com/apache/arrow-datafusion/pull/3279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-datafusion] andygrove commented on pull request #3365: Review use of panic in datafusion-proto crate

2022-09-07 Thread GitBox
andygrove commented on PR #3365: URL: https://github.com/apache/arrow-datafusion/pull/3365#issuecomment-1240026403 @avantgardnerio I know you fixed a json proto build issue recently. Could you take a look at this PR to make sure you are happy with it? -- This is an automated message from

[GitHub] [arrow] drin commented on pull request #13390: ARROW-16424: [C++] Update uri_path parsing in FromProto

2022-09-07 Thread GitBox
drin commented on PR #13390: URL: https://github.com/apache/arrow/pull/13390#issuecomment-1240021655 I was trying to extend this PR, but rebasing made it complicated, so I opened a new one. The reviews I mainly see here are regarding getting the file extension from the Uri. In #14071

[GitHub] [arrow-adbc] zeroshade commented on pull request #112: fix runs-on for go.yml workflow

2022-09-07 Thread GitBox
zeroshade commented on PR #112: URL: https://github.com/apache/arrow-adbc/pull/112#issuecomment-1240019809 i'll give it a shot, if you haven't noticed, macos is going to be the death of me over here lol -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [arrow-adbc] lidavidm commented on pull request #112: fix runs-on for go.yml workflow

2022-09-07 Thread GitBox
lidavidm commented on PR #112: URL: https://github.com/apache/arrow-adbc/pull/112#issuecomment-1240018258 It _should_ just be DYLD_LIBRARY_PATH…you may need to add `$CONDA_PREFIX/lib` to that path though? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [arrow-adbc] zeroshade commented on pull request #112: fix runs-on for go.yml workflow

2022-09-07 Thread GitBox
zeroshade commented on PR #112: URL: https://github.com/apache/arrow-adbc/pull/112#issuecomment-1240017168 @lidavidm Do you have any idea what env var i'm missing that macos isn't able to find `libadbc_driver_sqlite.dylib` with `dlopen`? -- This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #14071: URL: https://github.com/apache/arrow/pull/14071#issuecomment-1240015661 https://issues.apache.org/jira/browse/ARROW-16424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] drin opened a new pull request, #14071: ARROW-16424: [C++] Use Uri to parse substrait ReadRel file path

2022-09-07 Thread GitBox
drin opened a new pull request, #14071: URL: https://github.com/apache/arrow/pull/14071 A PR to subsume #13390 I tried to add on to #13390, but then I rebased and now it seems really complicated to add to that PR. This PR primarily uses `Uri` to parse file URIs extracted from

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2673: Support building comparator for dictionaries of primitive integer values

2022-09-07 Thread GitBox
viirya commented on code in PR #2673: URL: https://github.com/apache/arrow-rs/pull/2673#discussion_r965374780 ## arrow/src/array/ord.rs: ## @@ -101,6 +126,27 @@ where }) } +macro_rules! cmp_dict_primitive { Review Comment: Changed it to a generic function. -- Thi

[GitHub] [arrow] github-actions[bot] commented on pull request #14070: ARROW-17448:[R] Fix cloud storage paths in some documentation

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #14070: URL: https://github.com/apache/arrow/pull/14070#issuecomment-1239994566 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #14070: ARROW-17448:[R] Fix cloud storage paths in some documentation

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #14070: URL: https://github.com/apache/arrow/pull/14070#issuecomment-1239994515 https://issues.apache.org/jira/browse/ARROW-17448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] boshek opened a new pull request, #14070: ARROW-17448:[R] Fix cloud storage paths in some documentation

2022-09-07 Thread GitBox
boshek opened a new pull request, #14070: URL: https://github.com/apache/arrow/pull/14070 This PR fixes some paths that weren't working in the vignettes for both gcs and aws. ``` r library(arrow, warn.conflicts = FALSE) ## aws aws <- s3_bucket("voltrondata-labs-datas

[GitHub] [arrow] ursabot commented on pull request #13973: ARROW-17525: [Java] Read ORC files using NativeDatasetFactory

2022-09-07 Thread GitBox
ursabot commented on PR #13973: URL: https://github.com/apache/arrow/pull/13973#issuecomment-1239986760 Benchmark runs are scheduled for baseline = c586b9fe459ead3bf151de9a87e1ca51d49a5687 and contender = 21491ec0fa5fad2eb20bfedb3a19873f08e7e895. 21491ec0fa5fad2eb20bfedb3a19873f08e7e895 is

[GitHub] [arrow] zeroshade merged pull request #14067: ARROW-17646: [Go][CI] Switch C Data to use cgo.Handle (bumps to Go1.17)

2022-09-07 Thread GitBox
zeroshade merged PR #14067: URL: https://github.com/apache/arrow/pull/14067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow-rs] askoa commented on pull request #2678: Skip RowSelectors with zero rows

2022-09-07 Thread GitBox
askoa commented on PR #2678: URL: https://github.com/apache/arrow-rs/pull/2678#issuecomment-1239983768 > I think it would be nice to have a fully reproducible test, the fuzz tests are really there to find gaps in test coverage not to serve as it. I created a test borrowing heavily fro

[GitHub] [arrow-rs] tustvold commented on pull request #2678: Skip RowSelectors with zero rows

2022-09-07 Thread GitBox
tustvold commented on PR #2678: URL: https://github.com/apache/arrow-rs/pull/2678#issuecomment-1239978336 I think it would be nice to have a fully reproducible test, the fuzz tests are really there to find gaps in test coverage not to serve as it. -- This is an automated message from the

[GitHub] [arrow-rs] sunchao commented on a diff in pull request #2673: Support building comparator for dictionaries of primitive integer values

2022-09-07 Thread GitBox
sunchao commented on code in PR #2673: URL: https://github.com/apache/arrow-rs/pull/2673#discussion_r965350779 ## arrow/src/array/ord.rs: ## @@ -101,6 +126,27 @@ where }) } +macro_rules! cmp_dict_primitive { Review Comment: could we use a method here? seems the only

[GitHub] [arrow-rs] askoa commented on pull request #2678: Skip RowSelectors with zero rows

2022-09-07 Thread GitBox
askoa commented on PR #2678: URL: https://github.com/apache/arrow-rs/pull/2678#issuecomment-1239969041 > Could we possibly get a test of this Is it okay if I modify the test `test_fuzz_async_reader_selection` to include zero `RowSelector`s -- This is an automated message from the A

[GitHub] [arrow-datafusion] andygrove commented on issue #3390: Make type coercion rule more robust

2022-09-07 Thread GitBox
andygrove commented on issue #3390: URL: https://github.com/apache/arrow-datafusion/issues/3390#issuecomment-1239967862 Also happens in common_sub_expression_eliminate: ``` Skipping optimizer rule common_sub_expression_eliminate due to unexpected error: Error during planning: 'Tim

[GitHub] [arrow] github-actions[bot] commented on pull request #14066: ARROW-17604: [Docs][Java] Make it more obvious that --add-opens is required

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #14066: URL: https://github.com/apache/arrow/pull/14066#issuecomment-1239960898 Revision: c73a3b9887bfed342941b5f35a51fb79b8e667de Submitted crossbow builds: [ursacomputing/crossbow @ actions-963cb1f0ad](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] lidavidm commented on pull request #14066: ARROW-17604: [Docs][Java] Make it more obvious that --add-opens is required

2022-09-07 Thread GitBox
lidavidm commented on PR #14066: URL: https://github.com/apache/arrow/pull/14066#issuecomment-1239959608 @github-actions crossbow submit *java* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] comphead commented on pull request #3365: Review use of panic in datafusion-proto crate

2022-09-07 Thread GitBox
comphead commented on PR #3365: URL: https://github.com/apache/arrow-datafusion/pull/3365#issuecomment-1239940613 Sorry guys, I probably generated more commits than expected, the reason being is cargo check gives me not the same results as CI, even after cleaning the cache -- This is an

[GitHub] [arrow] zeroshade merged pull request #14056: ARROW-17600: [Go] Implement Casting for Nested types

2022-09-07 Thread GitBox
zeroshade merged PR #14056: URL: https://github.com/apache/arrow/pull/14056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow] zeroshade commented on a diff in pull request #14056: ARROW-17600: [Go] Implement Casting for Nested types

2022-09-07 Thread GitBox
zeroshade commented on code in PR #14056: URL: https://github.com/apache/arrow/pull/14056#discussion_r965298986 ## go/arrow/array/struct.go: ## @@ -36,6 +36,37 @@ type Struct struct { fields []arrow.Array } +// NewStructArray constructs a new Struct Array out of the c

[GitHub] [arrow] nealrichardson commented on a diff in pull request #13985: ARROW-17462: [R] Cast scalars to type of field in Expression building

2022-09-07 Thread GitBox
nealrichardson commented on code in PR #13985: URL: https://github.com/apache/arrow/pull/13985#discussion_r965298014 ## r/R/expression.R: ## @@ -210,21 +213,20 @@ build_expr <- function(FUN, } if (FUN == "%in%") { # Special-case %in%, which is different from the Array

[GitHub] [arrow] zeroshade commented on pull request #14026: ARROW-17584: [Go] Use unsafe.Slice from Go 1.17

2022-09-07 Thread GitBox
zeroshade commented on PR #14026: URL: https://github.com/apache/arrow/pull/14026#issuecomment-1239880081 @tschaub I figured out the issue. If you look at the original versions, we ensured that the capacity was `h.Cap/(nbytes)` and Len was `h.Len/(nbytes)` In your implementation here

[GitHub] [arrow] igor-suhorukov commented on pull request #13973: ARROW-17525: [Java] Read ORC files using NativeDatasetFactory

2022-09-07 Thread GitBox
igor-suhorukov commented on PR #13973: URL: https://github.com/apache/arrow/pull/13973#issuecomment-1239873727 Thank you @lidavidm and @davisusanibar Yes, looks like by CI log details -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] lidavidm commented on pull request #14054: MINOR: [C++] ARROW_TESTING implies ARROW_JSON

2022-09-07 Thread GitBox
lidavidm commented on PR #14054: URL: https://github.com/apache/arrow/pull/14054#issuecomment-1239863794 Integration test is failing, see #14069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] github-actions[bot] commented on pull request #14069: ARROW-17645: [CI] Get conda-integration building again

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #14069: URL: https://github.com/apache/arrow/pull/14069#issuecomment-1239860834 https://issues.apache.org/jira/browse/ARROW-17645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #14069: ARROW-17645: [CI] Get conda-integration building again

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #14069: URL: https://github.com/apache/arrow/pull/14069#issuecomment-1239860893 :warning: Ticket **has no components in JIRA**, make sure you assign one. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow] lidavidm merged pull request #13973: ARROW-17525: [Java] Read ORC files using NativeDatasetFactory

2022-09-07 Thread GitBox
lidavidm merged PR #13973: URL: https://github.com/apache/arrow/pull/13973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[GitHub] [arrow] lidavidm commented on pull request #13973: ARROW-17525: [Java] Read ORC files using NativeDatasetFactory

2022-09-07 Thread GitBox
lidavidm commented on PR #13973: URL: https://github.com/apache/arrow/pull/13973#issuecomment-1239845562 Integration test failure should be unrelated, see #14069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] lidavidm commented on a diff in pull request #13973: ARROW-17525: [Java] Read ORC files using NativeDatasetFactory

2022-09-07 Thread GitBox
lidavidm commented on code in PR #13973: URL: https://github.com/apache/arrow/pull/13973#discussion_r965248473 ## java/dataset/pom.xml: ## @@ -109,6 +109,38 @@ jackson-databind test + +org.apache.arrow.orc +arro

[GitHub] [arrow-rs] askoa opened a new pull request, #2678: Skip RowSelectors with zero rows

2022-09-07 Thread GitBox
askoa opened a new pull request, #2678: URL: https://github.com/apache/arrow-rs/pull/2678 # Which issue does this PR close? Closes #2669 # Are there any user-facing changes? no user-facing or breaking changes. -- This is an automated message from the Apache Git Se

[GitHub] [arrow] igor-suhorukov commented on a diff in pull request #13973: ARROW-17525: [Java] Read ORC files using NativeDatasetFactory

2022-09-07 Thread GitBox
igor-suhorukov commented on code in PR #13973: URL: https://github.com/apache/arrow/pull/13973#discussion_r965245125 ## java/dataset/pom.xml: ## @@ -109,6 +109,38 @@ jackson-databind test + +org.apache.arrow.orc +

[GitHub] [arrow] lidavidm commented on a diff in pull request #14043: ARROW-17613: [C++] Add function execution API for a preconfigured kernel

2022-09-07 Thread GitBox
lidavidm commented on code in PR #14043: URL: https://github.com/apache/arrow/pull/14043#discussion_r965240623 ## cpp/src/arrow/compute/function.h: ## @@ -225,6 +233,15 @@ class ARROW_EXPORT Function { /// required by the kernel. virtual Result DispatchBest(std::vector* va

[GitHub] [arrow-rs] viirya commented on pull request #2673: Support building comparator for dictionaries of primitive integer values

2022-09-07 Thread GitBox
viirya commented on PR #2673: URL: https://github.com/apache/arrow-rs/pull/2673#issuecomment-1239839090 This is needed to extend dictionary support coverage of sorting kernel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] drin commented on issue #14068: parquet.dll : libcrypto-3-x64.dll missing module

2022-09-07 Thread GitBox
drin commented on issue #14068: URL: https://github.com/apache/arrow/issues/14068#issuecomment-1239835006 sorry, I think I'm actually no help here, but maybe the context is helpful for someone who knows more :( -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] lidavidm commented on a diff in pull request #13986: ARROW-17052: [C++][Python][FlightRPC] expose flight structures serialize

2022-09-07 Thread GitBox
lidavidm commented on code in PR #13986: URL: https://github.com/apache/arrow/pull/13986#discussion_r965234157 ## python/pyarrow/_flight.pyx: ## @@ -360,13 +410,16 @@ cdef class BasicAuth(_Weakrefable): @staticmethod def deserialize(serialized): auth = BasicAu

[GitHub] [arrow] drin commented on issue #14068: parquet.dll : libcrypto-3-x64.dll missing module

2022-09-07 Thread GitBox
drin commented on issue #14068: URL: https://github.com/apache/arrow/issues/14068#issuecomment-1239830293 For reference: ```bash otool -L /usr/local/arrow-dev/lib/libparquet.dylib /usr/local/arrow-dev/lib/libparquet.dylib: /usr/local/arrow-dev/lib/libparquet.900.dylib

[GitHub] [arrow] drin commented on issue #14068: parquet.dll : libcrypto-3-x64.dll missing module

2022-09-07 Thread GitBox
drin commented on issue #14068: URL: https://github.com/apache/arrow/issues/14068#issuecomment-1239829048 that being said, I believe my parquet library also looks for libcrypto, so... maybe this flag doesn't help with that -- This is an automated message from the Apache Git Service. To re

[GitHub] [arrow] drin commented on issue #14068: parquet.dll : libcrypto-3-x64.dll missing module

2022-09-07 Thread GitBox
drin commented on issue #14068: URL: https://github.com/apache/arrow/issues/14068#issuecomment-1239826674 does your cmake log show that variable being correctly interpreted? I just checked the CMakeLists.txt file and didn't see anything about MSVC that is special cased that would be r

[GitHub] [arrow] lidavidm commented on a diff in pull request #13986: ARROW-17052: [C++][Python][FlightRPC] expose flight structures serialize

2022-09-07 Thread GitBox
lidavidm commented on code in PR #13986: URL: https://github.com/apache/arrow/pull/13986#discussion_r965232014 ## python/pyarrow/_flight.pyx: ## @@ -289,6 +289,33 @@ cdef class Action(_Weakrefable): type(action))) return ( action).action +def seri

[GitHub] [arrow] nealrichardson commented on a diff in pull request #13854: ARROW-17386: [R] strptime tests not robust across platforms

2022-09-07 Thread GitBox
nealrichardson commented on code in PR #13854: URL: https://github.com/apache/arrow/pull/13854#discussion_r965230822 ## r/tests/testthat/test-dplyr-funcs-datetime.R: ## @@ -155,6 +179,98 @@ test_that("strptime", { # RE2 library (not available on Windows with R 3.6) skip_if

[GitHub] [arrow] lidavidm commented on pull request #13986: ARROW-17052: [C++][Python][FlightRPC] expose flight structures serialize

2022-09-07 Thread GitBox
lidavidm commented on PR #13986: URL: https://github.com/apache/arrow/pull/13986#issuecomment-1239824225 Those jobs tend tend to be flaky, if there's not a test failure, it's usually fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] nealrichardson commented on a diff in pull request #13854: ARROW-17386: [R] strptime tests not robust across platforms

2022-09-07 Thread GitBox
nealrichardson commented on code in PR #13854: URL: https://github.com/apache/arrow/pull/13854#discussion_r965230235 ## r/tests/testthat/test-dplyr-funcs-datetime.R: ## @@ -155,6 +179,98 @@ test_that("strptime", { # RE2 library (not available on Windows with R 3.6) skip_if

[GitHub] [arrow] lidavidm commented on a diff in pull request #14056: ARROW-17600: [Go] Implement Casting for Nested types

2022-09-07 Thread GitBox
lidavidm commented on code in PR #14056: URL: https://github.com/apache/arrow/pull/14056#discussion_r965221897 ## ci/scripts/go_test.sh: ## @@ -19,12 +19,20 @@ set -ex +# simplistic semver comparison +verlte() { +[ "$1" = "`echo -e "$1\n$2" | sort -V | head -n1`" ] Rev

[GitHub] [arrow] github-actions[bot] commented on pull request #14067: ARROW-17646: [Go][CI] Switch C Data to use cgo.Handle (bumps to Go1.17)

2022-09-07 Thread GitBox
github-actions[bot] commented on PR #14067: URL: https://github.com/apache/arrow/pull/14067#issuecomment-1239820358 https://issues.apache.org/jira/browse/ARROW-17646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] lidavidm commented on a diff in pull request #13973: ARROW-17525: [Java] Read ORC files using NativeDatasetFactory

2022-09-07 Thread GitBox
lidavidm commented on code in PR #13973: URL: https://github.com/apache/arrow/pull/13973#discussion_r965217957 ## java/dataset/pom.xml: ## @@ -109,6 +109,38 @@ jackson-databind test + +org.apache.arrow.orc +arro

[GitHub] [arrow-datafusion] iajoiner commented on a diff in pull request #3341: Replace panic in `datafusion-expr` crate

2022-09-07 Thread GitBox
iajoiner commented on code in PR #3341: URL: https://github.com/apache/arrow-datafusion/pull/3341#discussion_r965215913 ## datafusion/expr/src/logical_plan/builder.rs: ## @@ -605,14 +605,12 @@ impl LogicalPlanBuilder { let mut join_on: Vec<(Column, Column)> = vec![];

[GitHub] [arrow] ursabot commented on pull request #14035: ARROW-17519: [R] RTools35 job is failing

2022-09-07 Thread GitBox
ursabot commented on PR #14035: URL: https://github.com/apache/arrow/pull/14035#issuecomment-1239799600 Benchmark runs are scheduled for baseline = ff3aa3b7bb31c679892d19ff74d67563b986828f and contender = c586b9fe459ead3bf151de9a87e1ca51d49a5687. c586b9fe459ead3bf151de9a87e1ca51d49a5687 is

  1   2   3   >