Re: [PR] Recursive CTEs: Stage 3 - add execution support [arrow-datafusion]

2024-01-11 Thread via GitHub
matthewgapp commented on code in PR #8840: URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1449896278 ## datafusion/sqllogictest/test_files/cte.slt: ## @@ -19,3 +19,221 @@ query II select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,

Re: [PR] Recursive CTEs: Stage 3 - add execution support [arrow-datafusion]

2024-01-11 Thread via GitHub
matthewgapp commented on code in PR #8840: URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1449893839 ## datafusion/sqllogictest/test_files/cte.slt: ## @@ -19,3 +19,221 @@ query II select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,

Re: [PR] Change ScalarValue::Struct to ArrayRef [arrow-datafusion]

2024-01-11 Thread via GitHub
mustafasrepo commented on code in PR #7893: URL: https://github.com/apache/arrow-datafusion/pull/7893#discussion_r1449886112 ## datafusion/physical-expr/src/aggregate/array_agg_ordered.rs: ## @@ -308,18 +319,30 @@ impl OrderSensitiveArrayAggAccumulator { let fields = or

[PR] Recursive CTEs: Stage 3 - add execution support [arrow-datafusion]

2024-01-11 Thread via GitHub
matthewgapp opened a new pull request, #8840: URL: https://github.com/apache/arrow-datafusion/pull/8840 WIP. Adds execution support to recursive CTEs ### Todos - [ ] Fill out docs and cleanup. Add more tests. ## Which issue does this PR close? Closes #.

Re: [PR] support `stride` in `array_slice` [arrow-datafusion]

2024-01-11 Thread via GitHub
Weijun-H commented on code in PR #8829: URL: https://github.com/apache/arrow-datafusion/pull/8829#discussion_r1449883269 ## datafusion/sqllogictest/test_files/array.slt: ## @@ -1214,6 +1214,19 @@ select array_slice(make_array(1, 2, 3, 4, 5), 2, 4), array_slice(make_array('h',

Re: [PR] support `stride` in `array_slice` [arrow-datafusion]

2024-01-11 Thread via GitHub
Weijun-H commented on code in PR #8829: URL: https://github.com/apache/arrow-datafusion/pull/8829#discussion_r1449883269 ## datafusion/sqllogictest/test_files/array.slt: ## @@ -1214,6 +1214,19 @@ select array_slice(make_array(1, 2, 3, 4, 5), 2, 4), array_slice(make_array('h',

[PR] Recursive CTEs: Stage 2 - add support for sql -> logical plan generation [arrow-datafusion]

2024-01-11 Thread via GitHub
matthewgapp opened a new pull request, #8839: URL: https://github.com/apache/arrow-datafusion/pull/8839 This PR implements sql -> logical plan generation support for Recursive CTEs. ### Todos - [ ] Fill out docs and cleanup. Add more tests. ## Which issue does this PR clo

Re: [PR] GH-39427: [GLib] Update script and documentation [arrow]

2024-01-11 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #39428: URL: https://github.com/apache/arrow/pull/39428#issuecomment-1888470663 After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 04afe3f017668d7fbd74301717ce467394e216d7. There was 1 b

Re: [I] [R] test-r-rhub-ubuntu-gcc-release-latest fails at the build stage [arrow]

2024-01-11 Thread via GitHub
assignUser commented on issue #38667: URL: https://github.com/apache/arrow/issues/38667#issuecomment-1888404713 Duplicate of #39523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] [CI][R] test-r-rhub-debian-gcc-devel-lto-latest fails not being able to install Arrow [arrow]

2024-01-11 Thread via GitHub
assignUser commented on issue #39424: URL: https://github.com/apache/arrow/issues/39424#issuecomment-1888403857 Ah sorry I missed this: #39523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] GH-39523: [R] Don't override explicitly set NOT_CRAN=false when on dev version [arrow]

2024-01-11 Thread via GitHub
assignUser merged PR #39524: URL: https://github.com/apache/arrow/pull/39524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.ap

Re: [PR] fix: don't extract common sub expr in `CASE WHEN` clause [arrow-datafusion]

2024-01-11 Thread via GitHub
liukun4515 commented on PR #8833: URL: https://github.com/apache/arrow-datafusion/pull/8833#issuecomment-1888391548 > cc @liukun4515 thanks @haohuaijin I will help to review this pr this week. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] throw Divide by zero error when use case when [arrow-datafusion]

2024-01-11 Thread via GitHub
liukun4515 commented on issue #8814: URL: https://github.com/apache/arrow-datafusion/issues/8814#issuecomment-1888390989 thanks for @dhamotharan-ps @haohuaijin I will help to review your pr this week. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] GH-39489: [C++][Parquet] Revert #39491 and add timestamp behavior to doc [arrow]

2024-01-11 Thread via GitHub
mapleFU commented on PR #39571: URL: https://github.com/apache/arrow/pull/39571#issuecomment-1888384481 I'm also ok to adding flags here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Add `NULL` in list simplifications [arrow-datafusion]

2024-01-11 Thread via GitHub
Ted-Jiang commented on issue #8688: URL: https://github.com/apache/arrow-datafusion/issues/8688#issuecomment-1888374334 > > I would like to take a look at this. > > Thank you ! > > > If my understanding is correct, the first case i.e. `SELECT .. WHERE NULL IN (…)` would simpli

Re: [I] Add `NULL` in list simplifications [arrow-datafusion]

2024-01-11 Thread via GitHub
Ted-Jiang commented on issue #8688: URL: https://github.com/apache/arrow-datafusion/issues/8688#issuecomment-1888374141 > ```sql > select x IN (NULL, 2) from t; > ``` Thanks for explain this! 👍 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] GH-20339: [C++] Add residual filter support to swiss join [arrow]

2024-01-11 Thread via GitHub
zanmato1984 commented on PR #39487: URL: https://github.com/apache/arrow/pull/39487#issuecomment-1888359186 Hi @vibhatha , I've updated the tests and the PR is ready for review. PTAL. Thanks. cc @westonpace -- This is an automated message from the Apache Git Service. To respond to

Re: [I] parquet: Allow disabling embed `ARROW_SCHEMA_META_KEY` added by the `ArrowWriter` [arrow-rs]

2024-01-11 Thread via GitHub
evenyag commented on issue #5296: URL: https://github.com/apache/arrow-rs/issues/5296#issuecomment-1888355793 I would like to have a try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] (signal: 11, SIGSEGV: invalid memory reference) reported during release verification [arrow-datafusion]

2024-01-11 Thread via GitHub
waynexia commented on issue #5145: URL: https://github.com/apache/arrow-datafusion/issues/5145#issuecomment-1888354208 No. I haven't seen it for the recent month. I think we can close this issue -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] (signal: 11, SIGSEGV: invalid memory reference) reported during release verification [arrow-datafusion]

2024-01-11 Thread via GitHub
waynexia closed issue #5145: (signal: 11, SIGSEGV: invalid memory reference) reported during release verification URL: https://github.com/apache/arrow-datafusion/issues/5145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] fix: don't extract common sub expr in `CASE WHEN` clause [arrow-datafusion]

2024-01-11 Thread via GitHub
haohuaijin commented on code in PR #8833: URL: https://github.com/apache/arrow-datafusion/pull/8833#discussion_r1449739710 ## datafusion/optimizer/src/utils.rs: ## @@ -92,6 +94,21 @@ pub fn log_plan(description: &str, plan: &LogicalPlan) { trace!("{description}::\n{}\n", pl

Re: [PR] GH-39523: [R] Don't override explicitly set NOT_CRAN=false when on dev version [arrow]

2024-01-11 Thread via GitHub
kou commented on code in PR #39524: URL: https://github.com/apache/arrow/pull/39524#discussion_r1449739483 ## r/tools/nixlibs.R: ## @@ -860,7 +860,8 @@ if (is_release) { VERSION <- VERSION[1, 1:3] arrow_repo <- paste0(getOption("arrow.repo", sprintf("https://apache.jfrog.

Re: [PR] GH-39523: [R] Don't override explicitly set NOT_CRAN=false when on dev version [arrow]

2024-01-11 Thread via GitHub
assignUser commented on code in PR #39524: URL: https://github.com/apache/arrow/pull/39524#discussion_r1449727336 ## r/tools/nixlibs.R: ## @@ -860,7 +860,8 @@ if (is_release) { VERSION <- VERSION[1, 1:3] arrow_repo <- paste0(getOption("arrow.repo", sprintf("https://apache

Re: [PR] GH-23221: [C++] Add support for building with Emscripten [arrow]

2024-01-11 Thread via GitHub
kou commented on code in PR #37821: URL: https://github.com/apache/arrow/pull/37821#discussion_r1449695994 ## cpp/cmake_modules/ThirdpartyToolchain.cmake: ## @@ -1349,6 +1366,13 @@ macro(build_snappy) set(SNAPPY_PATCH_COMMAND) endif() + if(CMAKE_SYSTEM_NAME STREQUAL "

Re: [PR] GH-39270: [C++] Avoid creating memory manager instance for every buffer view/copy [arrow]

2024-01-11 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #39271: URL: https://github.com/apache/arrow/pull/39271#issuecomment-1888339857 After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2132cb361c386ab25d72b4990772ca6e5c31312c. There were no

Re: [PR] Support Parquet Byte Stream Split Encoding [arrow-rs]

2024-01-11 Thread via GitHub
mwlon commented on PR #5293: URL: https://github.com/apache/arrow-rs/pull/5293#issuecomment-1888334697 Updated the readme -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Support Parquet Byte Stream Split Encoding [arrow-rs]

2024-01-11 Thread via GitHub
mwlon commented on code in PR #5293: URL: https://github.com/apache/arrow-rs/pull/5293#discussion_r1449719002 ## parquet/src/encodings/decoding.rs: ## @@ -1760,6 +1786,29 @@ mod tests { test_delta_byte_array_decode(data); } +#[test] +fn test_byte_stream_s

Re: [PR] Support Parquet Byte Stream Split Encoding [arrow-rs]

2024-01-11 Thread via GitHub
mwlon commented on code in PR #5293: URL: https://github.com/apache/arrow-rs/pull/5293#discussion_r1449718873 ## parquet/src/arrow/arrow_reader/mod.rs: ## @@ -1390,6 +1397,43 @@ mod tests { assert!(col.value(2).is_nan()); } +#[test] +fn test_read_float32_

Re: [PR] Port tests in timestamp.rs to sqllogictest [arrow-datafusion]

2024-01-11 Thread via GitHub
caicancai commented on PR #8818: URL: https://github.com/apache/arrow-datafusion/pull/8818#issuecomment-1888317129 > I think `now` can still be ported, its not stable value, but we can do it quasi stable like > > ``` > select now() = current_time > ``` > > or > >

[I] Add support for more fused boolean operations [arrow-rs]

2024-01-11 Thread via GitHub
RTEnzyme opened a new issue, #5297: URL: https://github.com/apache/arrow-rs/issues/5297 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** From issue in arrow-datafusion: https://github.com/apache/arrow-datafusion/issues/8816#iss

Re: [PR] Add support for recursive CTEs [arrow-datafusion]

2024-01-11 Thread via GitHub
jonahgao commented on code in PR #7581: URL: https://github.com/apache/arrow-datafusion/pull/7581#discussion_r1449683297 ## datafusion/expr/src/logical_plan/plan.rs: ## @@ -112,6 +112,8 @@ pub enum LogicalPlan { /// produces 0 or 1 row. This is used to implement SQL `SELECT

Re: [PR] GH-39523: [R] Don't override explicitly set NOT_CRAN=false when on dev version [arrow]

2024-01-11 Thread via GitHub
kou commented on code in PR #39524: URL: https://github.com/apache/arrow/pull/39524#discussion_r1449625106 ## r/tools/nixlibs.R: ## @@ -860,7 +860,8 @@ if (is_release) { VERSION <- VERSION[1, 1:3] arrow_repo <- paste0(getOption("arrow.repo", sprintf("https://apache.jfrog.

Re: [PR] GH-38470: [CI][Integration] Install jpype and build JNI c-data to run integration tests [arrow]

2024-01-11 Thread via GitHub
kou merged PR #39502: URL: https://github.com/apache/arrow/pull/39502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] feat(go/adbc/driver/snowflake): Add support for table constraints when calling GetObjects [arrow-adbc]

2024-01-11 Thread via GitHub
ryan-syed commented on code in PR #1455: URL: https://github.com/apache/arrow-adbc/pull/1455#discussion_r1449590543 ## go/adbc/driver/snowflake/connection.go: ## @@ -640,7 +639,8 @@ func (c *cnxn) getColumnsMetadata(ctx context.Context, matchingCatalogNames []st

Re: [PR] feat(go/adbc/driver/snowflake): Add support for table constraints when calling GetObjects [arrow-adbc]

2024-01-11 Thread via GitHub
ryan-syed commented on code in PR #1455: URL: https://github.com/apache/arrow-adbc/pull/1455#discussion_r1449598871 ## go/adbc/driver/snowflake/connection_test.go: ## @@ -276,30 +320,45 @@ func TestPrepareColumnsSQL(t *testing.T) { tableType := [2]string{"BASE TABLE", "V

Re: [PR] feat(go/adbc/driver/snowflake): Add support for table constraints when calling GetObjects [arrow-adbc]

2024-01-11 Thread via GitHub
ryan-syed commented on code in PR #1455: URL: https://github.com/apache/arrow-adbc/pull/1455#discussion_r1449590543 ## go/adbc/driver/snowflake/connection.go: ## @@ -640,7 +639,8 @@ func (c *cnxn) getColumnsMetadata(ctx context.Context, matchingCatalogNames []st

Re: [PR] feat(go/adbc/driver/snowflake): Add support for table constraints when calling GetObjects [arrow-adbc]

2024-01-11 Thread via GitHub
ryan-syed commented on code in PR #1455: URL: https://github.com/apache/arrow-adbc/pull/1455#discussion_r1449575911 ## go/adbc/driver/snowflake/connection.go: ## @@ -701,10 +701,16 @@ func prepareTablesSQL(matchingCatalogNames []string, catalog *string, dbSchema *

Re: [PR] feat(go/adbc/driver/snowflake): Add support for table constraints when calling GetObjects [arrow-adbc]

2024-01-11 Thread via GitHub
ryan-syed commented on code in PR #1455: URL: https://github.com/apache/arrow-adbc/pull/1455#discussion_r1449590543 ## go/adbc/driver/snowflake/connection.go: ## @@ -640,7 +639,8 @@ func (c *cnxn) getColumnsMetadata(ctx context.Context, matchingCatalogNames []st

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888218123 Revision: adddef992c0dab8de761c9aae33161a86abd3896 Submitted crossbow builds: [ursacomputing/crossbow @ actions-afc7321c5c](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888216389 @github-actions crossbow submit *java-jars* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Implement specialized accumulator for Uft8/LargeUtf8/Binary/LargeBinary [arrow-datafusion]

2024-01-11 Thread via GitHub
jayzhan211 commented on code in PR #8827: URL: https://github.com/apache/arrow-datafusion/pull/8827#discussion_r1449584066 ## datafusion/physical-plan/src/aggregates/group_values/binary.rs: ## @@ -0,0 +1,258 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

Re: [I] Add support for recursive CTEs [arrow-datafusion]

2024-01-11 Thread via GitHub
matthewgapp commented on issue #462: URL: https://github.com/apache/arrow-datafusion/issues/462#issuecomment-1888183053 Per the conversation in #7581, I'll break down #7581 into, roughly, the following PRs - [ ] Add a config flag to enable/disable CTE support, default to disable - #

[PR] feat(go/adbc/driver/snowflake): Add support for table constraints when calling GetObjects [arrow-adbc]

2024-01-11 Thread via GitHub
vleslief-ms opened a new pull request, #1455: URL: https://github.com/apache/arrow-adbc/pull/1455 When Snowflake Go driver calls GetObjects against tables and columns, it will now also return table constraints (name and type) if any are found related to the table. The tables and colu

Re: [I] `array_contains` returning unexpected values with column parameter [arrow-datafusion]

2024-01-11 Thread via GitHub
nevi-me closed issue #6972: `array_contains` returning unexpected values with column parameter URL: https://github.com/apache/arrow-datafusion/issues/6972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] `array_contains` returning unexpected values with column parameter [arrow-datafusion]

2024-01-11 Thread via GitHub
nevi-me commented on issue #6972: URL: https://github.com/apache/arrow-datafusion/issues/6972#issuecomment-1888159185 We've confirmed that `array_has_all` meets our needs. We can close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888152142 Revision: 9bd98869e63a2722fd8fd8d3275fec33f38f5202 Submitted crossbow builds: [ursacomputing/crossbow @ actions-3e14461dbf](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888147640 @github-actions crossbow submit *java-jars* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add support for recursive CTEs [arrow-datafusion]

2024-01-11 Thread via GitHub
matthewgapp commented on code in PR #7581: URL: https://github.com/apache/arrow-datafusion/pull/7581#discussion_r1449537689 ## datafusion/expr/src/logical_plan/plan.rs: ## @@ -112,6 +112,8 @@ pub enum LogicalPlan { /// produces 0 or 1 row. This is used to implement SQL `SEL

Re: [PR] GH-39552: [Go] inclusion of option to use replacer when creating csv strings with go library [arrow]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #39576: URL: https://github.com/apache/arrow/pull/39576#issuecomment-1888135438 :warning: GitHub issue #39552 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-39552: [Go] inclusion of option to use replacer when creating csv strings with go library [arrow]

2024-01-11 Thread via GitHub
janiodev opened a new pull request, #39576: URL: https://github.com/apache/arrow/pull/39576 Rationale for this change Make it possible to remove unwanted characters from strings What changes are included in this PR? Add new function to optionally setup a replacer in csv Writer

Re: [PR] GH-38962: [C++] Fix spelling (array) [arrow]

2024-01-11 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #38963: URL: https://github.com/apache/arrow/pull/38963#issuecomment-1888116243 After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 30c4e157a920981a853352ea2c24473496c7e595. There were no

Re: [I] Make `parquet` support optional [arrow-datafusion]

2024-01-11 Thread via GitHub
fudini commented on issue #7653: URL: https://github.com/apache/arrow-datafusion/issues/7653#issuecomment-1888113919 > > Maybe this issue needs reopening because it no longer compiles without default features with following error: > > @fudini -- thanks for the report. Can you provide

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888111578 This is failing the integration test currently because it cannot find the native library: https://github.com/ursacomputing/crossbow/actions/runs/7495454991/job/20405564594#step:6:9647 -

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888092301 Revision: bdd20976eb3feada5a8428d36413af361334934a Submitted crossbow builds: [ursacomputing/crossbow @ actions-9fffcab690](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888091674 Revision: bdd20976eb3feada5a8428d36413af361334934a Submitted crossbow builds: [ursacomputing/crossbow @ actions-b574f45b93](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888090200 @github-actions crossbow submit *java-jars* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888088963 @github-actions crossbow submit *java-jars* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[I] Eliminating multi-column sort when major column is a one-to-one and monotonic expression [arrow-datafusion]

2024-01-11 Thread via GitHub
suremarc opened a new issue, #8838: URL: https://github.com/apache/arrow-datafusion/issues/8838 ### Describe the bug DataFusion is unable to eliminate multi-column sorts when the major column is a one-to-one and monotonic expression of a sorted input column: * In certain cases when

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888071687 Revision: a732962e1b4685305dadbc10f2d818cdb79fdacd Submitted crossbow builds: [ursacomputing/crossbow @ actions-5865817143](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888068519 @github-actions crossbow submit *java-jars* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] GH-39574: [Go] Enable PollFlightInfo in Flight RPC [arrow]

2024-01-11 Thread via GitHub
lidavidm opened a new pull request, #39575: URL: https://github.com/apache/arrow/pull/39575 ### Rationale for this change It's impossible to use the current bindings with PollFlightInfo. ### What changes are included in this PR? Add new methods that expose PollFli

Re: [PR] Fix ApproxPercentileCont signature [arrow-datafusion]

2024-01-11 Thread via GitHub
joroKr21 commented on code in PR #8825: URL: https://github.com/apache/arrow-datafusion/pull/8825#discussion_r1449459738 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -95,6 +95,9 @@ SELECT approx_percentile_cont(c3, 0.95, c1) FROM aggregate_test_100 statement erro

[PR] Added a Simple Quick Start & Dev Containe [arrow-ballista]

2024-01-11 Thread via GitHub
Butch78 opened a new pull request, #954: URL: https://github.com/apache/arrow-ballista/pull/954 The rationale for this change: To simplify the onboarding process for new developers and enhance the development environment consistency, I've created a simple quick-start file. I mainly based

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888042469 Revision: 35f7cbaf1f4efc4742dcc931acd125ad3ff0e8e4 Submitted crossbow builds: [ursacomputing/crossbow @ actions-e879fe00cc](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888039805 @github-actions crossbow submit *java-jars* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] [C++][Parquet] Segmentation fault reading modular encrypted Parquet dataset over 2^15 rows [arrow]

2024-01-11 Thread via GitHub
tolleybot commented on issue #39444: URL: https://github.com/apache/arrow/issues/39444#issuecomment-1888017682 I created this simple C++ program that recreates the issue. I found that if I hardcoded the batch size as follows the problem never occurs. Optionally if you set the number of th

Re: [PR] Simplify physical expression creation API (not require schema) [arrow-datafusion]

2024-01-11 Thread via GitHub
comphead commented on code in PR #8823: URL: https://github.com/apache/arrow-datafusion/pull/8823#discussion_r1449431657 ## datafusion/physical-expr/src/planner.rs: ## @@ -43,29 +43,17 @@ use std::sync::Arc; /// * `e` - The logical expression /// * `input_dfschema` - The DataF

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888014735 @github-action crossbow submit *java-jars* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888010573 @github-action crossbow *submit* *java-jars* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] GH-39001: [Java] Modularize remaining modules [arrow]

2024-01-11 Thread via GitHub
jduo commented on PR #39221: URL: https://github.com/apache/arrow/pull/39221#issuecomment-1888010166 > FYI for testing runing the java-jars job might be useful. You can start it by commenting `@github-action crossbow submit java-jars` Thanks, I'll run that now. -- This is an automa

Re: [PR] Simplify physical expression creation API (not require schema) [arrow-datafusion]

2024-01-11 Thread via GitHub
viirya commented on code in PR #8823: URL: https://github.com/apache/arrow-datafusion/pull/8823#discussion_r1449422452 ## datafusion/physical-expr/src/planner.rs: ## @@ -43,29 +43,17 @@ use std::sync::Arc; /// * `e` - The logical expression /// * `input_dfschema` - The DataFus

Re: [PR] Simplify physical expression creation API (not require schema) [arrow-datafusion]

2024-01-11 Thread via GitHub
comphead commented on code in PR #8823: URL: https://github.com/apache/arrow-datafusion/pull/8823#discussion_r1449412953 ## datafusion/physical-expr/src/planner.rs: ## @@ -43,29 +43,17 @@ use std::sync::Arc; /// * `e` - The logical expression /// * `input_dfschema` - The DataF

Re: [I] Unable to get schema from PyCapsule provided ArrowArrayStream [arrow]

2024-01-11 Thread via GitHub
WillAyd commented on issue #39572: URL: https://github.com/apache/arrow/issues/39572#issuecomment-1887981650 This is user error. `if (!stream->get_schema(stream, &schema)) {` was the wrong condition - sorry for the false alarm! -- This is an automated message from the Apache Git Service.

Re: [PR] Simplify physical expression creation API (not require schema) [arrow-datafusion]

2024-01-11 Thread via GitHub
viirya commented on code in PR #8823: URL: https://github.com/apache/arrow-datafusion/pull/8823#discussion_r1449406767 ## datafusion/physical-expr/src/planner.rs: ## @@ -43,29 +43,17 @@ use std::sync::Arc; /// * `e` - The logical expression /// * `input_dfschema` - The DataFus

Re: [PR] Simplify physical expression creation API (not require schema) [arrow-datafusion]

2024-01-11 Thread via GitHub
viirya commented on code in PR #8823: URL: https://github.com/apache/arrow-datafusion/pull/8823#discussion_r1449406044 ## datafusion/physical-expr/src/planner.rs: ## @@ -43,29 +43,17 @@ use std::sync::Arc; /// * `e` - The logical expression /// * `input_dfschema` - The DataFus

Re: [PR] [CI] Refactor CI builders [arrow-datafusion]

2024-01-11 Thread via GitHub
comphead merged PR #8826: URL: https://github.com/apache/arrow-datafusion/pull/8826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

Re: [PR] Minor: Improve `datafusion-proto` documentation [arrow-datafusion]

2024-01-11 Thread via GitHub
comphead merged PR #8822: URL: https://github.com/apache/arrow-datafusion/pull/8822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

Re: [I] Parquet Modular Encryption support [arrow-rs]

2024-01-11 Thread via GitHub
tustvold commented on issue #3511: URL: https://github.com/apache/arrow-rs/issues/3511#issuecomment-1887963781 Thank you, I'm happy to review code, especially if it is well tested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Document usage of SessionConfig [arrow-datafusion]

2024-01-11 Thread via GitHub
wjones127 closed issue #8770: Document usage of SessionConfig URL: https://github.com/apache/arrow-datafusion/issues/8770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] docs: document SessionConfig [arrow-datafusion]

2024-01-11 Thread via GitHub
wjones127 merged PR #8771: URL: https://github.com/apache/arrow-datafusion/pull/8771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] chore(ci): Integrate Python into more CI workflows [arrow-nanoarrow]

2024-01-11 Thread via GitHub
codecov-commenter commented on PR #359: URL: https://github.com/apache/arrow-nanoarrow/pull/359#issuecomment-1887932806 ## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/359?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_t

[PR] chore(ci): Integration Python into more CI workflows [arrow-nanoarrow]

2024-01-11 Thread via GitHub
paleolimbot opened a new pull request, #359: URL: https://github.com/apache/arrow-nanoarrow/pull/359 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] [Bug] docker compose up -d error on building failed to calculate checksum [arrow-ballista]

2024-01-11 Thread via GitHub
Butch78 commented on issue #891: URL: https://github.com/apache/arrow-ballista/issues/891#issuecomment-1887928748 Unfortunately, I am having the same error: ``` failed to solve: failed to compute cache key: failed to calculate checksum of ref 62e32em3sauehttq0ma2lrz8f::vpscv3ywbjvn

Re: [PR] Recursive CTEs: Stage 1 - add config flag [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb commented on PR #8828: URL: https://github.com/apache/arrow-datafusion/pull/8828#issuecomment-1887926900 Thanks @matthewgapp -- what would you think about filing a ticket with the implementation plan described in https://github.com/apache/arrow-datafusion/pull/7581#issuecomment-1886

Re: [PR] Minor: typo in `arrays.slt` [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb merged PR #8831: URL: https://github.com/apache/arrow-datafusion/pull/8831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

Re: [PR] fix(r/adbcdrivermanager): Use std::vector instead of std::basic_string [arrow-adbc]

2024-01-11 Thread via GitHub
paleolimbot merged PR #1453: URL: https://github.com/apache/arrow-adbc/pull/1453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

Re: [PR] Change ScalarValue::Struct to ArrayRef [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb commented on code in PR #7893: URL: https://github.com/apache/arrow-datafusion/pull/7893#discussion_r1449363796 ## datafusion/physical-expr/src/aggregate/array_agg_ordered.rs: ## @@ -308,18 +319,30 @@ impl OrderSensitiveArrayAggAccumulator { let fields = ordering_

Re: [PR] Minor: Improve `datafusion-proto` documentation [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb commented on code in PR #8822: URL: https://github.com/apache/arrow-datafusion/pull/8822#discussion_r1449362416 ## datafusion/proto/README.md: ## @@ -17,11 +17,35 @@ under the License. --> -# DataFusion Proto +# Apache Arrow DataFusion Proto Review Comment: Good

Re: [PR] docs: document SessionConfig [arrow-datafusion]

2024-01-11 Thread via GitHub
wjones127 commented on code in PR #8771: URL: https://github.com/apache/arrow-datafusion/pull/8771#discussion_r1449360320 ## datafusion/execution/src/config.rs: ## @@ -24,7 +24,66 @@ use std::{ use datafusion_common::{config::ConfigOptions, Result, ScalarValue}; -/// Config

Re: [PR] docs: document SessionConfig [arrow-datafusion]

2024-01-11 Thread via GitHub
wjones127 commented on code in PR #8771: URL: https://github.com/apache/arrow-datafusion/pull/8771#discussion_r1449360006 ## datafusion/execution/src/config.rs: ## @@ -24,7 +24,66 @@ use std::{ use datafusion_common::{config::ConfigOptions, Result, ScalarValue}; -/// Config

Re: [PR] feat: support `array_resize` [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb merged PR #8744: URL: https://github.com/apache/arrow-datafusion/pull/8744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

Re: [I] Implement `array_resize` function [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb closed issue #7194: Implement `array_resize` function URL: https://github.com/apache/arrow-datafusion/issues/7194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Remove unused array_expression.rs and `SUPPORTED_ARRAY_TYPES` [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb merged PR #8807: URL: https://github.com/apache/arrow-datafusion/pull/8807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

Re: [PR] Fix ApproxPercentileCont signature [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb commented on code in PR #8825: URL: https://github.com/apache/arrow-datafusion/pull/8825#discussion_r1449353140 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -95,6 +95,9 @@ SELECT approx_percentile_cont(c3, 0.95, c1) FROM aggregate_test_100 statement error D

Re: [PR] [CI] Refactor CI builders [arrow-datafusion]

2024-01-11 Thread via GitHub
comphead commented on code in PR #8826: URL: https://github.com/apache/arrow-datafusion/pull/8826#discussion_r1449346634 ## .github/actions/setup-rust-runtime/action.yaml: ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[I] [CI] Investigate stack overflow errors on TPC-DS queries [arrow-datafusion]

2024-01-11 Thread via GitHub
comphead opened a new issue, #8837: URL: https://github.com/apache/arrow-datafusion/issues/8837 ### Is your feature request related to a problem or challenge? In Datafusion CI builds we spontaneously hit the Rust stack overflow errors on TPC-DS queries. The most notorious is ```

Re: [PR] WIP: Dummy PR to check maint-15.0.0 status [arrow]

2024-01-11 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #39545: URL: https://github.com/apache/arrow/pull/39545#issuecomment-1887881894 Thanks for your patience. Conbench analyzed the 6 benchmarking runs that have been run so far on PR commit b5d26f833c5dfa1494adecccbcc9181bd31e3787. There were 2

Re: [PR] [CI] Refactor CI builders [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb commented on code in PR #8826: URL: https://github.com/apache/arrow-datafusion/pull/8826#discussion_r1449337626 ## .github/actions/setup-windows-builder/action.yaml: ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

Re: [I] (signal: 11, SIGSEGV: invalid memory reference) reported during release verification [arrow-datafusion]

2024-01-11 Thread via GitHub
alamb commented on issue #5145: URL: https://github.com/apache/arrow-datafusion/issues/5145#issuecomment-1887877232 Have we seen this issue recently 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Parquet Modular Encryption support [arrow-rs]

2024-01-11 Thread via GitHub
bhoberman commented on issue #3511: URL: https://github.com/apache/arrow-rs/issues/3511#issuecomment-1887874477 Thanks for the quick response! Parquet encryption uses two extremely standard primitives (which ring has perfectly fine implementations of). In principle, the encryption step is a

  1   2   3   4   >