[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r648045038 ## File path: r/R/util.R ## @@ -139,3 +139,42 @@ attr(is_writable_table, "fail") <- function(call, env){ ) } +#' Take an object of length 1 and re

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r647568522 ## File path: r/R/util.R ## @@ -110,3 +110,36 @@ handle_embedded_nul_error <- function(e) { } stop(e) } + +#' Take an object of length 1 and repe

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r636043288 ## File path: r/R/util.R ## @@ -110,3 +110,36 @@ handle_embedded_nul_error <- function(e) { } stop(e) } + +#' Take an object of length 1 and repe

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r635854937 ## File path: r/R/table.R ## @@ -175,12 +175,17 @@ Table$create <- function(..., schema = NULL) { return(dplyr::group_by(out, !!!dplyr::groups(dots

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r635433846 ## File path: r/tests/testthat/test-RecordBatch.R ## @@ -415,14 +414,42 @@ test_that("record_batch() handles null type (ARROW-7064)", { expect_equiv

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r634139678 ## File path: r/tests/testthat/test-RecordBatch.R ## @@ -415,14 +414,42 @@ test_that("record_batch() handles null type (ARROW-7064)", { expect_equiv

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r633857420 ## File path: r/tests/testthat/test-RecordBatch.R ## @@ -415,14 +414,42 @@ test_that("record_batch() handles null type (ARROW-7064)", { expect_equiv

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r633851616 ## File path: r/R/util.R ## @@ -110,3 +110,21 @@ handle_embedded_nul_error <- function(e) { } stop(e) } + +#' Take an object of length 1 and repe

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r633850677 ## File path: r/R/record-batch.R ## @@ -161,7 +161,18 @@ RecordBatch$create <- function(..., schema = NULL) { out <- RecordBatch__from_arrays(schem

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r632754954 ## File path: r/R/record-batch.R ## @@ -161,7 +161,18 @@ RecordBatch$create <- function(..., schema = NULL) { out <- RecordBatch__from_arrays(schem

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r632750639 ## File path: r/R/record-batch.R ## @@ -161,7 +161,18 @@ RecordBatch$create <- function(..., schema = NULL) { out <- RecordBatch__from_arrays(schem

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r630048707 ## File path: r/R/record-batch.R ## @@ -161,6 +161,17 @@ RecordBatch$create <- function(..., schema = NULL) { out <- RecordBatch__from_arrays(schem

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r629572528 ## File path: r/R/table.R ## @@ -175,6 +175,17 @@ Table$create <- function(..., schema = NULL) { return(dplyr::group_by(out, !!!dplyr::groups(dots[

[GitHub] [arrow] thisisnic commented on a change in pull request #10269: ARROW-11705: [R] Support scalar value recycling in RecordBatch/Table$create()

thisisnic commented on a change in pull request #10269: URL: https://github.com/apache/arrow/pull/10269#discussion_r629115855 ## File path: r/R/table.R ## @@ -175,6 +175,16 @@ Table$create <- function(..., schema = NULL) { return(dplyr::group_by(out, !!!dplyr::groups(dots[