piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655325323
Run XVR_Flink PostCommit
This is an automated message from the Apache Git Service.
To respond to the mess
piotr-szuberski removed a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-654260584
This is an automated message from the Apache Git Service.
To respond to the message, please log on
piotr-szuberski removed a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655317727
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to
piotr-szuberski removed a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-654901927
This is an automated message from the Apache Git Service.
To respond to the message, please log on
piotr-szuberski removed a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-654860333
This is an automated message from the Apache Git Service.
To respond to the message, please log on
piotr-szuberski removed a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-654647958
This is an automated message from the Apache Git Service.
To respond to the message, please log on
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655321777
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655317727
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
pabloem commented on a change in pull request #12151:
URL: https://github.com/apache/beam/pull/12151#discussion_r451303970
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeBatchServiceConfig.java
##
@@ -0,0 +1,120 @@
+/*
+ *
pabloem commented on a change in pull request #12151:
URL: https://github.com/apache/beam/pull/12151#discussion_r451303970
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeBatchServiceConfig.java
##
@@ -0,0 +1,120 @@
+/*
+ *
pabloem commented on a change in pull request #12151:
URL: https://github.com/apache/beam/pull/12151#discussion_r451294464
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##
@@ -684,14 +819,61 @@ private void checkArguments(
pabloem commented on a change in pull request #12151:
URL: https://github.com/apache/beam/pull/12151#discussion_r451286482
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##
@@ -644,6 +747,26 @@ public void populateDisplayDa
y1chi commented on pull request #12191:
URL: https://github.com/apache/beam/pull/12191#issuecomment-655296773
R: @aaltay
CC: @jaketf
This is an automated message from the Apache Git Service.
To respond to the message, pl
pabloem commented on pull request #12151:
URL: https://github.com/apache/beam/pull/12151#issuecomment-655286584
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #12151:
URL: https://github.com/apache/beam/pull/12151#issuecomment-655286374
sorry! Yes, I'll take a look..
This is an automated message from the Apache Git Service.
To respond to the messag
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655260089
Run Samza ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message,
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655259903
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the mes
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655257992
Run Java_Examples_Dataflow PreCommit
This is an automated message from the Apache Git Service.
To respond to th
lukecwik edited a comment on pull request #12192:
URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038
R: @robertwb @chamikaramj
Progress reporting needs to be able to see which window out of how many are
being processed. Splitting needs to be able to see which wind
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655248020
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lukecwik closed pull request #12192:
URL: https://github.com/apache/beam/pull/12192
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tvalentyn opened a new pull request #12194:
URL: https://github.com/apache/beam/pull/12194
You can run many tests automatically using
release/src/main/scripts/mass_comment.py.
This is an automated message from the Apache Git
bamnet commented on pull request #12193:
URL: https://github.com/apache/beam/pull/12193#issuecomment-655241403
R: @lostluck
/fyi @ibzib
This is an automated message from the Apache Git Service.
To respond to the messag
lukecwik edited a comment on pull request #12192:
URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038
R: @robertwb @chamikaramj
Progress reporting needs to be able to see which window out of how many are
being processed. Splitting needs to be able to see which wind
danielxjd commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451244400
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##
@@ -893,6 +906,19 @@ pub
bamnet opened a new pull request #12193:
URL: https://github.com/apache/beam/pull/12193
If the region flag is unset, attempt to extract a region from
$CLOUDSDK_COMPUTE_REGION and the gcloud SDK.
This mirrors the
[Java](https://github.com/apache/beam/blob/64e69d68f85903d94170fa2efc5a
lukecwik commented on a change in pull request #12192:
URL: https://github.com/apache/beam/pull/12192#discussion_r451243088
##
File path: sdks/python/apache_beam/runners/direct/sdf_direct_runner.py
##
@@ -464,19 +461,15 @@ def initiate_checkpoint():
with self._checkpoint
lukecwik edited a comment on pull request #12192:
URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038
R: @robertwb @chamikaramj
Style-wise does it make sense to use the `kwargs` to pass these through or
should I continue to make them explicit like the `restriction_
lukecwik commented on a change in pull request #12192:
URL: https://github.com/apache/beam/pull/12192#discussion_r451242979
##
File path: sdks/python/apache_beam/runners/direct/sdf_direct_runner.py
##
@@ -507,7 +500,6 @@ def initiate_checkpoint():
if self._max_num_output
lukecwik commented on pull request #12192:
URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038
R: @robertwb @chamikaramj
Style-wise does it make sense to use the `kwargs` to pass these through or
should I continue to make them explicit like the `restriction_tracker
chamikaramj commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451242654
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##
@@ -893,6 +906,19 @@ p
lukecwik opened a new pull request #12192:
URL: https://github.com/apache/beam/pull/12192
To be able to have the windowing optimization stay within the
PerWindowInvoker, I needed to have it control the creation of the watermark
estimator and the restriction tracker thus I supply the restri
danielxjd commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451241677
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##
@@ -893,6 +903,20 @@ pub
udim commented on a change in pull request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r451233193
##
File path: sdks/python/apache_beam/typehints/decorators.py
##
@@ -378,6 +378,56 @@ def has_simple_output_type(self):
self.output_types and len(sel
chamikaramj commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451237362
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##
@@ -893,6 +903,20 @@ p
y1chi opened a new pull request #12191:
URL: https://github.com/apache/beam/pull/12191
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
jaketf commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-655219973
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
robertwb commented on pull request #11963:
URL: https://github.com/apache/beam/pull/11963#issuecomment-655215071
R: @TheNeuralBit This is ready for review.
This is an automated message from the Apache Git Service.
To respond
aaltay commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655211272
> > Oh I see now. I tried to fix this issue by adding `drop_defaults=true`
but we explicitly don't drop the default value for ValueProvider arguments:
> >
https://github.com/ap
aaltay commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655209912
> Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but
we explicitly don't drop the default value for ValueProvider arguments:
>
>
https://github.com/
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655207778
Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but
we explicitly don't drop the default value for ValueProvider arguments:
https://github.com/apache/
danielxjd commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451213408
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##
@@ -893,6 +903,20 @@ pub
lukecwik commented on pull request #12184:
URL: https://github.com/apache/beam/pull/12184#issuecomment-655203055
LGTM?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jaketf commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-655202173
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
KevinGG commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-655194772
> left just two comments. Please respond (address if you think it's worth
addressing) - and we can merge
Thanks, @pabloem ! I've made corresponding changes.
-
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655192320
Looks like the CI failure is actually another flake due to BEAM-10006. It
can be replicated reliably locally with
```
$ pytest
apache_beam/runners/portability/fn_a
aaltay commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655189985
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
robertwb merged pull request #12182:
URL: https://github.com/apache/beam/pull/12182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #12128:
URL: https://github.com/apache/beam/pull/12128#issuecomment-655188903
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
chamikaramj commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451179908
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##
@@ -793,6 +795,14 @@ p
TheNeuralBit commented on a change in pull request #12132:
URL: https://github.com/apache/beam/pull/12132#discussion_r451186550
##
File path: sdks/python/tox.ini
##
@@ -287,3 +287,12 @@ deps =
commands =
yapf --version
time yapf --diff --parallel --recursive apache_beam
chamikaramj commented on a change in pull request #12164:
URL: https://github.com/apache/beam/pull/12164#discussion_r451184245
##
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##
@@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):
TheNeuralBit commented on a change in pull request #12132:
URL: https://github.com/apache/beam/pull/12132#discussion_r451181865
##
File path: sdks/python/tox.ini
##
@@ -287,3 +287,12 @@ deps =
commands =
yapf --version
time yapf --diff --parallel --recursive apache_beam
TheNeuralBit merged pull request #12067:
URL: https://github.com/apache/beam/pull/12067
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robinyqiu commented on pull request #11456:
URL: https://github.com/apache/beam/pull/11456#issuecomment-655169701
cc: @robinyqiu @ZijieSong946
This is an automated message from the Apache Git Service.
To respond to the messa
annaqin418 commented on pull request #12157:
URL: https://github.com/apache/beam/pull/12157#issuecomment-655169602
R: @robertwb
This PR is still a while from being ready, but just wanted to tag you as
well in my progress.
---
robertwb merged pull request #12186:
URL: https://github.com/apache/beam/pull/12186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kennknowles merged pull request #12162:
URL: https://github.com/apache/beam/pull/12162
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
amaliujia merged pull request #12169:
URL: https://github.com/apache/beam/pull/12169
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on a change in pull request #12107:
URL: https://github.com/apache/beam/pull/12107#discussion_r448112826
##
File path: sdks/python/apache_beam/runners/interactive/utils.py
##
@@ -204,3 +205,23 @@ def run_within_progress_indicator(*args, **kwargs):
retur
pabloem commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-655161085
left just two comments. Please respond (address if you think it's worth
addressing) - and we can merge
This is a
y1chi commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-655160801
@jaketf the integration tests seem to be flaky and breaks postcommit
sometimes, I opened https://issues.apache.org/jira/browse/BEAM-10419 do you
mind take a look?
---
chamikaramj commented on pull request #12188:
URL: https://github.com/apache/beam/pull/12188#issuecomment-655159675
cc: @davidwrede
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-655155939
Took a look and confirmed that x-lang KafkaIO works with this change. LGTM
from me.
This is an automated mes
robertwb commented on pull request #12186:
URL: https://github.com/apache/beam/pull/12186#issuecomment-655145852
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
jaketf commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-655145391
I have some level of access but I need additional permissions to modify IAM
This is an automated message from the
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655122687
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
piotr-szuberski removed a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655122687
Run XVR_Spark PostCommitRun XVR_Spark PostCommit
This is an automated message from the Apache Git
lukecwik commented on a change in pull request #12184:
URL: https://github.com/apache/beam/pull/12184#discussion_r451123739
##
File path:
sdks/java/io/rabbitmq/src/test/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIOTest.java
##
@@ -196,59 +200,74 @@ private void doExchangeTes
lukecwik merged pull request #12089:
URL: https://github.com/apache/beam/pull/12089
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lukecwik commented on a change in pull request #12089:
URL: https://github.com/apache/beam/pull/12089#discussion_r451120512
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
##
@@ -410,13 +417,22 @@ public Read w
pabloem merged pull request #12190:
URL: https://github.com/apache/beam/pull/12190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
pabloem commented on pull request #12190:
URL: https://github.com/apache/beam/pull/12190#issuecomment-655092319
Thanks! LGTM. I'll merge after website precommit passes
This is an automated message from the Apache Git Service.
aaltay commented on pull request #12128:
URL: https://github.com/apache/beam/pull/12128#issuecomment-655091453
> Optional comments:
>
> * is there an associated BEAM jira issue that can be used for the commit?
> * consider adding this to the CHANGES.md.
Done. Thank you!
--
ceh commented on pull request #12190:
URL: https://github.com/apache/beam/pull/12190#issuecomment-655090603
R: @aaltay, @pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log
rohdesamuel commented on pull request #12182:
URL: https://github.com/apache/beam/pull/12182#issuecomment-655090706
LGTM, thanks for the cleanup!
This is an automated message from the Apache Git Service.
To respond to the mes
ceh opened a new pull request #12190:
URL: https://github.com/apache/beam/pull/12190
Fix a couple of minor typos in the programming guide.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easil
TheNeuralBit merged pull request #12090:
URL: https://github.com/apache/beam/pull/12090
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
aaltay commented on pull request #12128:
URL: https://github.com/apache/beam/pull/12128#issuecomment-655085033
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
tvalentyn merged pull request #12180:
URL: https://github.com/apache/beam/pull/12180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #12183:
URL: https://github.com/apache/beam/pull/12183#issuecomment-655066457
Thanks @lastomato !
This is an automated message from the Apache Git Service.
To respond to the message, please l
pabloem merged pull request #12183:
URL: https://github.com/apache/beam/pull/12183
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
pabloem commented on a change in pull request #12143:
URL: https://github.com/apache/beam/pull/12143#discussion_r451078998
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowOperationContext.java
##
@@ -194,6 +
pabloem commented on pull request #12143:
URL: https://github.com/apache/beam/pull/12143#issuecomment-655059029
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
robertwb commented on pull request #12186:
URL: https://github.com/apache/beam/pull/12186#issuecomment-655056238
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
apilloud merged pull request #12159:
URL: https://github.com/apache/beam/pull/12159
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #12128:
URL: https://github.com/apache/beam/pull/12128#issuecomment-655056227
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
TheNeuralBit commented on pull request #12090:
URL: https://github.com/apache/beam/pull/12090#issuecomment-655052483
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
davidyan74 commented on pull request #12143:
URL: https://github.com/apache/beam/pull/12143#issuecomment-655047439
Looks like another test failed and looks unrelated again. @pabloem Do you
think this PR could make the tests more flaky?
aaltay commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r451063093
##
File path: .github/workflows/cancel.yml
##
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review comment:
chamikaramj commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-655044889
LGTM. Thanks. Could yo resolve the conflict ?
Also, can we trigger tests from here to see if this works or are there more
missing pieces ?
---
tvalentyn commented on pull request #12179:
URL: https://github.com/apache/beam/pull/12179#issuecomment-655039855
cc: @robertwb @angoenka re:
https://github.com/apache/beam/pull/12179#issuecomment-654548592.
Do we need an AI to suppress such errors?
tvalentyn commented on pull request #12179:
URL: https://github.com/apache/beam/pull/12179#issuecomment-655038045
If this happened during interpreter shutdown perhaps all bets are off?
This is an automated message from the A
chamikaramj commented on pull request #11919:
URL: https://github.com/apache/beam/pull/11919#issuecomment-655035073
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, pleas
pabloem commented on pull request #12183:
URL: https://github.com/apache/beam/pull/12183#issuecomment-655011572
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #12143:
URL: https://github.com/apache/beam/pull/12143#issuecomment-655011390
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #12183:
URL: https://github.com/apache/beam/pull/12183#issuecomment-655011463
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, p
pabloem commented on pull request #12086:
URL: https://github.com/apache/beam/pull/12086#issuecomment-655006468
My bad. Heejong and I discussed it via chat last week. I forgot to add the
LGTM when I merged.
On Tue, Jul 7, 2020, 9:36 AM Ahmet Altay wrote:
> Folks just checki
robertwb commented on pull request #12186:
URL: https://github.com/apache/beam/pull/12186#issuecomment-655002473
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
robertwb commented on pull request #12186:
URL: https://github.com/apache/beam/pull/12186#issuecomment-655002395
This did come up in a test flake.
This is an automated message from the Apache Git Service.
To respond to the m
1 - 100 of 133 matches
Mail list logo