[GitHub] [beam] TheNeuralBit commented on a change in pull request #13341: Avoid unnecessary shuffling for single-input elementwise operations.

2020-11-16 Thread GitBox
TheNeuralBit commented on a change in pull request #13341: URL: https://github.com/apache/beam/pull/13341#discussion_r524484614 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -1917,9 +1918,12 @@ def func(df, *args, **kwargs): '__i%s__' % base,

[GitHub] [beam] KevinGG commented on a change in pull request #13335: [BEAM-10921]: Fix BEAM-10921 and underlying issues

2020-11-16 Thread GitBox
KevinGG commented on a change in pull request #13335: URL: https://github.com/apache/beam/pull/13335#discussion_r524478709 ## File path: sdks/python/apache_beam/runners/interactive/interactive_environment.py ## @@ -510,11 +529,10 @@ def track_user_pipelines(self):

[GitHub] [beam] boyuanzz commented on a change in pull request #13026: [WIP] [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
boyuanzz commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524484370 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] boyuanzz commented on pull request #13344: [BEAM-11263] Java cleanUpDockerImages now force removes container images.

2020-11-16 Thread GitBox
boyuanzz commented on pull request #13344: URL: https://github.com/apache/beam/pull/13344#issuecomment-728243326 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] KevinGG commented on a change in pull request #13335: [BEAM-10921]: Fix BEAM-10921 and underlying issues

2020-11-16 Thread GitBox
KevinGG commented on a change in pull request #13335: URL: https://github.com/apache/beam/pull/13335#discussion_r524478709 ## File path: sdks/python/apache_beam/runners/interactive/interactive_environment.py ## @@ -510,11 +529,10 @@ def track_user_pipelines(self):

[GitHub] [beam] TheNeuralBit commented on pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-11-16 Thread GitBox
TheNeuralBit commented on pull request #12611: URL: https://github.com/apache/beam/pull/12611#issuecomment-728234466 Looks good, merging now. Thanks for all your work on this @piotr-szuberski :) This is an automated message

[GitHub] [beam] TheNeuralBit merged pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-11-16 Thread GitBox
TheNeuralBit merged pull request #12611: URL: https://github.com/apache/beam/pull/12611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-11-16 Thread GitBox
TheNeuralBit commented on a change in pull request #12611: URL: https://github.com/apache/beam/pull/12611#discussion_r524471761 ## File path: sdks/python/apache_beam/io/gcp/spanner.py ## @@ -0,0 +1,635 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-11-16 Thread GitBox
TheNeuralBit commented on a change in pull request #12611: URL: https://github.com/apache/beam/pull/12611#discussion_r524468664 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/StructUtils.java ## @@ -0,0 +1,380 @@ +/* + *

[GitHub] [beam] iemejia commented on pull request #13352: [BEAM-8615 BEAM-8569 BEAM-7937] Add hadoop 3 compatibility tests

2020-11-16 Thread GitBox
iemejia commented on pull request #13352: URL: https://github.com/apache/beam/pull/13352#issuecomment-728219821 This deserves a mention in the CHANGES.md release notes, so don't hesitate to open a PR for this too. This is

[GitHub] [beam] TheNeuralBit commented on pull request #13341: Avoid unnecessary shuffling for single-input elementwise operations.

2020-11-16 Thread GitBox
TheNeuralBit commented on pull request #13341: URL: https://github.com/apache/beam/pull/13341#issuecomment-728215583 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] piotr-szuberski commented on pull request #13352: [BEAM-8615 BEAM-8569 BEAM-7937] Add hadoop 3 compatibility tests

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13352: URL: https://github.com/apache/beam/pull/13352#issuecomment-728214918 > LGTM > > Fantastic! I am really happy to see this one in. Gives me so much more confidence on future changes compatibility! Glad to hear that! :)

[GitHub] [beam] tvalentyn merged pull request #13349: [BEAM-9980] use constants of python versions in PythonTestProperties.groovy

2020-11-16 Thread GitBox
tvalentyn merged pull request #13349: URL: https://github.com/apache/beam/pull/13349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] tvalentyn merged pull request #13337: Add trigger commands for Direct, Spark XVR Postcommits.

2020-11-16 Thread GitBox
tvalentyn merged pull request #13337: URL: https://github.com/apache/beam/pull/13337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] tysonjh commented on pull request #12416: Update google-api-services versions.

2020-11-16 Thread GitBox
tysonjh commented on pull request #12416: URL: https://github.com/apache/beam/pull/12416#issuecomment-728201724 > @tysonjh Hey, Seems like this commit breaks my code. Building my code, I get a `NoSuchMethodError` over `setOrderingKey`/`getOrderingKey` for the `pubsubMessage` (the

[GitHub] [beam] tysonjh edited a comment on pull request #13128: [BEAM-11265] Update quickstart-java.md

2020-11-16 Thread GitBox
tysonjh edited a comment on pull request #13128: URL: https://github.com/apache/beam/pull/13128#issuecomment-728196383 > > Java precommit - I think this is a flaky test : "org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testAllAttemptedMetrics". @tysonjh @kennknowles - could

[GitHub] [beam] TheNeuralBit commented on a change in pull request #13345: [BEAM-4136] Keep strong reference to loggers to avoid potential NPE

2020-11-16 Thread GitBox
TheNeuralBit commented on a change in pull request #13345: URL: https://github.com/apache/beam/pull/13345#discussion_r524431127 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java ## @@ -146,20 +147,25 @@ public void

[GitHub] [beam] tysonjh commented on pull request #13128: [BEAM-11265] Update quickstart-java.md

2020-11-16 Thread GitBox
tysonjh commented on pull request #13128: URL: https://github.com/apache/beam/pull/13128#issuecomment-728196383 > > Java precommit - I think this is a flaky test : "org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testAllAttemptedMetrics". @tysonjh @kennknowles - could we

[GitHub] [beam] tysonjh commented on pull request #13128: [BEAM-11265] Update quickstart-java.md

2020-11-16 Thread GitBox
tysonjh commented on pull request #13128: URL: https://github.com/apache/beam/pull/13128#issuecomment-728191942 > Java precommit - I think this is a flaky test : "org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testAllAttemptedMetrics". @tysonjh @kennknowles - could we

[GitHub] [beam] aromanenko-dev commented on a change in pull request #13026: [WIP] [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
aromanenko-dev commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524416279 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] rosetn commented on a change in pull request #13326: [BEAM-10480] Update SDF programming guide

2020-11-16 Thread GitBox
rosetn commented on a change in pull request #13326: URL: https://github.com/apache/beam/pull/13326#discussion_r524389224 ## File path: website/www/site/content/en/documentation/programming-guide.md ## @@ -5188,16 +5188,60 @@ restriction pairs. 12.1.1. A basic SDF

[GitHub] [beam] lazylynx commented on pull request #13337: Add trigger commands for Direct, Spark XVR Postcommits.

2020-11-16 Thread GitBox
lazylynx commented on pull request #13337: URL: https://github.com/apache/beam/pull/13337#issuecomment-728163435 @tvalentyn LGTM, Thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] allenpradeep commented on pull request #12255: [BEAM-9910]Add mutation byte counters to SpannerIO.write

2020-11-16 Thread GitBox
allenpradeep commented on pull request #12255: URL: https://github.com/apache/beam/pull/12255#issuecomment-728161911 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] suztomo commented on a change in pull request #13342: [BEAM-11260][BEAM-11261] Remove inappropriate assumptions about repo from linkage check script

2020-11-16 Thread GitBox
suztomo commented on a change in pull request #13342: URL: https://github.com/apache/beam/pull/13342#discussion_r524373408 ## File path: sdks/java/build-tools/beam-linkage-check.sh ## @@ -36,46 +36,60 @@ set -o pipefail set -e # These default artifacts are common causes of

[GitHub] [beam] suztomo commented on a change in pull request #13342: [BEAM-11260][BEAM-11261] Remove inappropriate assumptions about repo from linkage check script

2020-11-16 Thread GitBox
suztomo commented on a change in pull request #13342: URL: https://github.com/apache/beam/pull/13342#discussion_r524361509 ## File path: sdks/java/build-tools/beam-linkage-check.sh ## @@ -36,46 +36,60 @@ set -o pipefail set -e # These default artifacts are common causes of

[GitHub] [beam] piotr-szuberski commented on a change in pull request #13026: [WIP] [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524364352 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] je-ik commented on a change in pull request #13353: [BEAM-11267] Remove unecessary reshuffle for stateful ParDo after key…

2020-11-16 Thread GitBox
je-ik commented on a change in pull request #13353: URL: https://github.com/apache/beam/pull/13353#discussion_r524333570 ## File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTranslationContext.java ## @@ -84,6 +85,17 @@ public void

[GitHub] [beam] dmvk opened a new pull request #13353: [BEAM-11267] Remove unecessary reshuffle for stateful ParDo after key…

2020-11-16 Thread GitBox
dmvk opened a new pull request #13353: URL: https://github.com/apache/beam/pull/13353 https://issues.apache.org/jira/browse/BEAM-11267 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] piotr-szuberski commented on pull request #13352: [BEAM-8615 BEAM-8569 BEAM-7937] Add hadoop 3 compatibility tests

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13352: URL: https://github.com/apache/beam/pull/13352#issuecomment-728035522 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #13352: [BEAM-8615 BEAM-8569 BEAM-7937] Add hadoop 3 compatibility tests

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13352: URL: https://github.com/apache/beam/pull/13352#issuecomment-728030089 Run Spark ValidatesRunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] piotr-szuberski commented on pull request #13352: [BEAM-8615 BEAM-8569 BEAM-7937] Add hadoop 3 compatibility tests

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13352: URL: https://github.com/apache/beam/pull/13352#issuecomment-728029398 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski opened a new pull request #13352: [BEAM-8615 BEAM-8569 BEAM-7937] Add hadoop 3 compatibility tests

2020-11-16 Thread GitBox
piotr-szuberski opened a new pull request #13352: URL: https://github.com/apache/beam/pull/13352 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] piotr-szuberski commented on a change in pull request #13026: [WIP] [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524267637 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] piotr-szuberski commented on a change in pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524267637 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] iemejia commented on pull request #13350: [BEAM-11266] Python IO MongoDB: add bucket_auto aggregation option for bundling in Atlas.

2020-11-16 Thread GitBox
iemejia commented on pull request #13350: URL: https://github.com/apache/beam/pull/13350#issuecomment-728008920 @nikie in case you have the extra cycles to create a PR for the Java connector I will be glad to take a look

[GitHub] [beam] iemejia merged pull request #13287: [BEAM-8876] Run hadoop tests with different versions and enable HadoopFormatIT test on Postcommit

2020-11-16 Thread GitBox
iemejia merged pull request #13287: URL: https://github.com/apache/beam/pull/13287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] piotr-szuberski commented on pull request #13287: [BEAM-8876] Run hadoop tests with different versions and enable HadoopFormatIT test on Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13287: URL: https://github.com/apache/beam/pull/13287#issuecomment-727989092 > As a follow up it would be extremely nice to have also: > > 1. A phrase based task to invoke the Hadoop Versions tests from a PR e.g. "Run Hadoop Versions

[GitHub] [beam] iemejia merged pull request #13351: [BEAM-9278] hbase-shaded-client as provided dependency

2020-11-16 Thread GitBox
iemejia merged pull request #13351: URL: https://github.com/apache/beam/pull/13351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] piotr-szuberski commented on a change in pull request #13287: [BEAM-8876] Run hadoop tests with different versions and enable HadoopFormatIT test on Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on a change in pull request #13287: URL: https://github.com/apache/beam/pull/13287#discussion_r524253396 ## File path: sdks/java/io/hadoop-common/build.gradle ## @@ -16,17 +16,21 @@ * limitations under the License. */ +import

[GitHub] [beam] iemejia commented on a change in pull request #13287: [BEAM-8876] Run hadoop tests with different versions and enable HadoopFormatIT test on Postcommit

2020-11-16 Thread GitBox
iemejia commented on a change in pull request #13287: URL: https://github.com/apache/beam/pull/13287#discussion_r524129225 ## File path: sdks/java/io/hadoop-common/build.gradle ## @@ -16,17 +16,21 @@ * limitations under the License. */ +import java.util.stream.Collectors

[GitHub] [beam] piotr-szuberski commented on a change in pull request #13287: [BEAM-8876] Run hadoop tests with different versions and enable HadoopFormatIT test on Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on a change in pull request #13287: URL: https://github.com/apache/beam/pull/13287#discussion_r524253396 ## File path: sdks/java/io/hadoop-common/build.gradle ## @@ -16,17 +16,21 @@ * limitations under the License. */ +import

[GitHub] [beam] iemejia commented on a change in pull request #13287: [BEAM-8876] Run hadoop tests with different versions and enable HadoopFormatIT test on Postcommit

2020-11-16 Thread GitBox
iemejia commented on a change in pull request #13287: URL: https://github.com/apache/beam/pull/13287#discussion_r524046472 ## File path: runners/spark/build.gradle ## @@ -41,10 +42,15 @@ evaluationDependsOn(":runners:core-java") configurations { validatesRunner -

[GitHub] [beam] piotr-szuberski commented on a change in pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524248460 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] piotr-szuberski commented on a change in pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524248460 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] piotr-szuberski commented on a change in pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524248460 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] aromanenko-dev commented on a change in pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
aromanenko-dev commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524228547 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] aromanenko-dev commented on a change in pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
aromanenko-dev commented on a change in pull request #13026: URL: https://github.com/apache/beam/pull/13026#discussion_r524226883 ## File path: sdks/java/io/kafka/build.gradle ## @@ -65,26 +76,68 @@ dependencies { testCompile library.java.junit testCompile

[GitHub] [beam] piotr-szuberski commented on pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-727947192 Run Java KafkaIO Performance Test This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] codecov[bot] edited a comment on pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-704839820 # [Codecov](https://codecov.io/gh/apache/beam/pull/13026?src=pr=h1) Report > Merging [#13026](https://codecov.io/gh/apache/beam/pull/13026?src=pr=desc) (000ac07)

[GitHub] [beam] piotr-szuberski removed a comment on pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski removed a comment on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-727942075 Run Java KafkaIO Performance Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] piotr-szuberski commented on pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-727942075 Run Java KafkaIO Performance Test This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] codecov[bot] edited a comment on pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-704839820 # [Codecov](https://codecov.io/gh/apache/beam/pull/13026?src=pr=h1) Report > Merging [#13026](https://codecov.io/gh/apache/beam/pull/13026?src=pr=desc) (000ac07)

[GitHub] [beam] piotr-szuberski removed a comment on pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski removed a comment on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-727941678 Run Java KafkaIO Performance Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] codecov[bot] edited a comment on pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-704839820 # [Codecov](https://codecov.io/gh/apache/beam/pull/13026?src=pr=h1) Report > Merging [#13026](https://codecov.io/gh/apache/beam/pull/13026?src=pr=desc) (000ac07)

[GitHub] [beam] piotr-szuberski commented on pull request #13026: [BEAM-7003 BEAM-8639 BEAM-8774] Update Kafka dependencies, enable IT test in Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-727941678 Run Java KafkaIO Performance Test This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] pawelpasterz commented on pull request #13351: [BEAM-9278] hbase-shaded-client as provided dependency

2020-11-16 Thread GitBox
pawelpasterz commented on pull request #13351: URL: https://github.com/apache/beam/pull/13351#issuecomment-727937165 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] kamilwu commented on pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-16 Thread GitBox
kamilwu commented on pull request #13272: URL: https://github.com/apache/beam/pull/13272#issuecomment-727926020 @lostluck That should be it. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] kamilwu commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-16 Thread GitBox
kamilwu commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r524143231 ## File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx.go ## @@ -0,0 +1,181 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] kamilwu commented on pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-16 Thread GitBox
kamilwu commented on pull request #13272: URL: https://github.com/apache/beam/pull/13272#issuecomment-727912681 Run Go PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] bntnam commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component

2020-11-16 Thread GitBox
bntnam commented on a change in pull request #13331: URL: https://github.com/apache/beam/pull/13331#discussion_r524034050 ## File path: website/www/site/assets/icons/github-icon.svg ## @@ -0,0 +1,10 @@ +http://www.w3.org/2000/svg; width="32" height="32" fill="none" viewBox="0

[GitHub] [beam] nikie commented on pull request #12779: [BEAM-10856] Support for NestedValueProvider for Python SDK

2020-11-16 Thread GitBox
nikie commented on pull request #12779: URL: https://github.com/apache/beam/pull/12779#issuecomment-727860809 @epicfaace I am not sure why the tests are still failing. Rebasing against current `master` might help. Pylint runs fine locally after my docstrings fix. I have also

[GitHub] [beam] bntnam commented on a change in pull request #13331: [BEAM-11219][Website revamp] Development of All about Apache Beam component

2020-11-16 Thread GitBox
bntnam commented on a change in pull request #13331: URL: https://github.com/apache/beam/pull/13331#discussion_r524026653 ## File path: website/www/site/layouts/partials/pillars/pillars-social.html ## @@ -0,0 +1,39 @@ +{{/* + Licensed under the Apache License, Version 2.0 (the

[GitHub] [beam] piotr-szuberski commented on pull request #13287: [BEAM-8876] Run hadoop tests with different versions and enable HadoopFormatIT test on Postcommit

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13287: URL: https://github.com/apache/beam/pull/13287#issuecomment-727846119 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #13319: [BEAM-11173] Add Bigtable table with read operation

2020-11-16 Thread GitBox
piotr-szuberski commented on pull request #13319: URL: https://github.com/apache/beam/pull/13319#issuecomment-727823590 > My current question is, for the problem you find that ARRAY is not well supported, what part of design have it affected? It affects the possibility of reading

<    1   2