TheNeuralBit commented on a change in pull request #13341:
URL: https://github.com/apache/beam/pull/13341#discussion_r524484614
##
File path: sdks/python/apache_beam/dataframe/frames.py
##
@@ -1917,9 +1918,12 @@ def func(df, *args, **kwargs):
'__i%s__' % base,
KevinGG commented on a change in pull request #13335:
URL: https://github.com/apache/beam/pull/13335#discussion_r524478709
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -510,11 +529,10 @@ def track_user_pipelines(self):
boyuanzz commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524484370
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
boyuanzz commented on pull request #13344:
URL: https://github.com/apache/beam/pull/13344#issuecomment-728243326
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
KevinGG commented on a change in pull request #13335:
URL: https://github.com/apache/beam/pull/13335#discussion_r524478709
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -510,11 +529,10 @@ def track_user_pipelines(self):
TheNeuralBit commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-728234466
Looks good, merging now. Thanks for all your work on this @piotr-szuberski :)
This is an automated message
TheNeuralBit merged pull request #12611:
URL: https://github.com/apache/beam/pull/12611
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit commented on a change in pull request #12611:
URL: https://github.com/apache/beam/pull/12611#discussion_r524471761
##
File path: sdks/python/apache_beam/io/gcp/spanner.py
##
@@ -0,0 +1,635 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
TheNeuralBit commented on a change in pull request #12611:
URL: https://github.com/apache/beam/pull/12611#discussion_r524468664
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/StructUtils.java
##
@@ -0,0 +1,380 @@
+/*
+ *
iemejia commented on pull request #13352:
URL: https://github.com/apache/beam/pull/13352#issuecomment-728219821
This deserves a mention in the CHANGES.md release notes, so don't hesitate
to open a PR for this too.
This is
TheNeuralBit commented on pull request #13341:
URL: https://github.com/apache/beam/pull/13341#issuecomment-728215583
Run Portable_Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #13352:
URL: https://github.com/apache/beam/pull/13352#issuecomment-728214918
> LGTM
>
> Fantastic! I am really happy to see this one in. Gives me so much more
confidence on future changes compatibility!
Glad to hear that! :)
tvalentyn merged pull request #13349:
URL: https://github.com/apache/beam/pull/13349
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tvalentyn merged pull request #13337:
URL: https://github.com/apache/beam/pull/13337
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tysonjh commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-728201724
> @tysonjh Hey, Seems like this commit breaks my code. Building my code, I
get a `NoSuchMethodError` over `setOrderingKey`/`getOrderingKey` for the
`pubsubMessage` (the
tysonjh edited a comment on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-728196383
> > Java precommit - I think this is a flaky test :
"org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testAllAttemptedMetrics".
@tysonjh @kennknowles - could
TheNeuralBit commented on a change in pull request #13345:
URL: https://github.com/apache/beam/pull/13345#discussion_r524431127
##
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java
##
@@ -146,20 +147,25 @@ public void
tysonjh commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-728196383
> > Java precommit - I think this is a flaky test :
"org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testAllAttemptedMetrics".
@tysonjh @kennknowles - could we
tysonjh commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-728191942
> Java precommit - I think this is a flaky test :
"org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testAllAttemptedMetrics".
@tysonjh @kennknowles - could we
aromanenko-dev commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524416279
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
rosetn commented on a change in pull request #13326:
URL: https://github.com/apache/beam/pull/13326#discussion_r524389224
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5188,16 +5188,60 @@ restriction pairs.
12.1.1. A basic SDF
lazylynx commented on pull request #13337:
URL: https://github.com/apache/beam/pull/13337#issuecomment-728163435
@tvalentyn LGTM, Thanks!
This is an automated message from the Apache Git Service.
To respond to the message,
allenpradeep commented on pull request #12255:
URL: https://github.com/apache/beam/pull/12255#issuecomment-728161911
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
suztomo commented on a change in pull request #13342:
URL: https://github.com/apache/beam/pull/13342#discussion_r524373408
##
File path: sdks/java/build-tools/beam-linkage-check.sh
##
@@ -36,46 +36,60 @@ set -o pipefail
set -e
# These default artifacts are common causes of
suztomo commented on a change in pull request #13342:
URL: https://github.com/apache/beam/pull/13342#discussion_r524361509
##
File path: sdks/java/build-tools/beam-linkage-check.sh
##
@@ -36,46 +36,60 @@ set -o pipefail
set -e
# These default artifacts are common causes of
piotr-szuberski commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524364352
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
je-ik commented on a change in pull request #13353:
URL: https://github.com/apache/beam/pull/13353#discussion_r524333570
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTranslationContext.java
##
@@ -84,6 +85,17 @@ public void
dmvk opened a new pull request #13353:
URL: https://github.com/apache/beam/pull/13353
https://issues.apache.org/jira/browse/BEAM-11267
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
piotr-szuberski commented on pull request #13352:
URL: https://github.com/apache/beam/pull/13352#issuecomment-728035522
Run SQL PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski commented on pull request #13352:
URL: https://github.com/apache/beam/pull/13352#issuecomment-728030089
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #13352:
URL: https://github.com/apache/beam/pull/13352#issuecomment-728029398
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski opened a new pull request #13352:
URL: https://github.com/apache/beam/pull/13352
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
piotr-szuberski commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524267637
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
piotr-szuberski commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524267637
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
iemejia commented on pull request #13350:
URL: https://github.com/apache/beam/pull/13350#issuecomment-728008920
@nikie in case you have the extra cycles to create a PR for the Java
connector I will be glad to take a look
iemejia merged pull request #13287:
URL: https://github.com/apache/beam/pull/13287
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
piotr-szuberski commented on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-727989092
> As a follow up it would be extremely nice to have also:
>
> 1. A phrase based task to invoke the Hadoop Versions tests from a PR
e.g. "Run Hadoop Versions
iemejia merged pull request #13351:
URL: https://github.com/apache/beam/pull/13351
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
piotr-szuberski commented on a change in pull request #13287:
URL: https://github.com/apache/beam/pull/13287#discussion_r524253396
##
File path: sdks/java/io/hadoop-common/build.gradle
##
@@ -16,17 +16,21 @@
* limitations under the License.
*/
+import
iemejia commented on a change in pull request #13287:
URL: https://github.com/apache/beam/pull/13287#discussion_r524129225
##
File path: sdks/java/io/hadoop-common/build.gradle
##
@@ -16,17 +16,21 @@
* limitations under the License.
*/
+import java.util.stream.Collectors
piotr-szuberski commented on a change in pull request #13287:
URL: https://github.com/apache/beam/pull/13287#discussion_r524253396
##
File path: sdks/java/io/hadoop-common/build.gradle
##
@@ -16,17 +16,21 @@
* limitations under the License.
*/
+import
iemejia commented on a change in pull request #13287:
URL: https://github.com/apache/beam/pull/13287#discussion_r524046472
##
File path: runners/spark/build.gradle
##
@@ -41,10 +42,15 @@ evaluationDependsOn(":runners:core-java")
configurations {
validatesRunner
-
piotr-szuberski commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524248460
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
piotr-szuberski commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524248460
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
piotr-szuberski commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524248460
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
aromanenko-dev commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524228547
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
aromanenko-dev commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524226883
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
piotr-szuberski commented on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-727947192
Run Java KafkaIO Performance Test
This is an automated message from the Apache Git Service.
To respond
codecov[bot] edited a comment on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-704839820
# [Codecov](https://codecov.io/gh/apache/beam/pull/13026?src=pr=h1) Report
> Merging
[#13026](https://codecov.io/gh/apache/beam/pull/13026?src=pr=desc) (000ac07)
piotr-szuberski removed a comment on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-727942075
Run Java KafkaIO Performance Test
This is an automated message from the Apache Git Service.
To
piotr-szuberski commented on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-727942075
Run Java KafkaIO Performance Test
This is an automated message from the Apache Git Service.
To respond
codecov[bot] edited a comment on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-704839820
# [Codecov](https://codecov.io/gh/apache/beam/pull/13026?src=pr=h1) Report
> Merging
[#13026](https://codecov.io/gh/apache/beam/pull/13026?src=pr=desc) (000ac07)
piotr-szuberski removed a comment on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-727941678
Run Java KafkaIO Performance Test
This is an automated message from the Apache Git Service.
To
codecov[bot] edited a comment on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-704839820
# [Codecov](https://codecov.io/gh/apache/beam/pull/13026?src=pr=h1) Report
> Merging
[#13026](https://codecov.io/gh/apache/beam/pull/13026?src=pr=desc) (000ac07)
piotr-szuberski commented on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-727941678
Run Java KafkaIO Performance Test
This is an automated message from the Apache Git Service.
To respond
pawelpasterz commented on pull request #13351:
URL: https://github.com/apache/beam/pull/13351#issuecomment-727937165
R: @iemejia
This is an automated message from the Apache Git Service.
To respond to the message, please
kamilwu commented on pull request #13272:
URL: https://github.com/apache/beam/pull/13272#issuecomment-727926020
@lostluck That should be it.
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on a change in pull request #13272:
URL: https://github.com/apache/beam/pull/13272#discussion_r524143231
##
File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx.go
##
@@ -0,0 +1,181 @@
+// Licensed to the Apache Software Foundation (ASF) under one or
kamilwu commented on pull request #13272:
URL: https://github.com/apache/beam/pull/13272#issuecomment-727912681
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
bntnam commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r524034050
##
File path: website/www/site/assets/icons/github-icon.svg
##
@@ -0,0 +1,10 @@
+http://www.w3.org/2000/svg; width="32" height="32" fill="none"
viewBox="0
nikie commented on pull request #12779:
URL: https://github.com/apache/beam/pull/12779#issuecomment-727860809
@epicfaace
I am not sure why the tests are still failing.
Rebasing against current `master` might help.
Pylint runs fine locally after my docstrings fix. I have also
bntnam commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r524026653
##
File path: website/www/site/layouts/partials/pillars/pillars-social.html
##
@@ -0,0 +1,39 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the
piotr-szuberski commented on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-727846119
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski commented on pull request #13319:
URL: https://github.com/apache/beam/pull/13319#issuecomment-727823590
> My current question is, for the problem you find that ARRAY is not well
supported, what part of design have it affected?
It affects the possibility of reading
101 - 164 of 164 matches
Mail list logo