ZijieSong946 commented on a change in pull request #12348:
URL: https://github.com/apache/beam/pull/12348#discussion_r462561296
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/DateTime.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache
TheNeuralBit commented on pull request #12399:
URL: https://github.com/apache/beam/pull/12399#issuecomment-665898624
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messa
amaliujia merged pull request #12400:
URL: https://github.com/apache/beam/pull/12400
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
iindyk opened a new pull request #12420:
URL: https://github.com/apache/beam/pull/12420
Extending functionality of ApproximateQuantiles PTransform to calculate
quantiles of a data stream with custom weights. In case of weighted quantiles,
input PCollection is expected to contain tuples of
rohdesamuel opened a new pull request #12412:
URL: https://github.com/apache/beam/pull/12412
Change-Id: I093e1dc1f99c31b1e0bb868fc3bcfc507bd24c8d
PR 3/7
This builds on https://github.com/apache/beam/pull/12411 to utilize the
ElementLimiters to stop reading from cache. This als
lostluck commented on pull request #12393:
URL: https://github.com/apache/beam/pull/12393#issuecomment-665916062
Thank you for the contribution!
This is an automated message from the Apache Git Service.
To respond to the mess
amaliujia opened a new pull request #12417:
URL: https://github.com/apache/beam/pull/12417
SQL precommit has covered BeamZetaSQL precommit
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and e
danielxjd commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r462571602
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImplTest.java
##
@@ -733,26 +734,29 @
rohdesamuel commented on a change in pull request #12411:
URL: https://github.com/apache/beam/pull/12411#discussion_r462637247
##
File path:
sdks/python/apache_beam/runners/interactive/options/capture_limiters.py
##
@@ -71,3 +87,62 @@ def _trigger(self):
def is_triggered(
rohdesamuel opened a new pull request #12415:
URL: https://github.com/apache/beam/pull/12415
The RecordingManager abstracts out the details on how to read elements from
cache.
Change-Id: I9e3c57d91ff56aba4b54d8c2e627b658c0667089
PR 6/7
Th
kennknowles commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-665951261
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
robertwb merged pull request #11974:
URL: https://github.com/apache/beam/pull/11974
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chamikaramj commented on a change in pull request #12399:
URL: https://github.com/apache/beam/pull/12399#discussion_r462658530
##
File path: sdks/python/apache_beam/examples/sql_taxi.py
##
@@ -0,0 +1,97 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
boyuanzz opened a new pull request #12419:
URL: https://github.com/apache/beam/pull/12419
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quick
kennknowles merged pull request #11924:
URL: https://github.com/apache/beam/pull/11924
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rohdesamuel opened a new pull request #12413:
URL: https://github.com/apache/beam/pull/12413
Change-Id: I9a2fbf1532b3d22a612e7a09f4f1fb2b9635c40b
PR 4/7
Reading elements from cache can yield TestStreamFileRecords which can have
many elements that exceeds the requested element
rohdesamuel opened a new pull request #12410:
URL: https://github.com/apache/beam/pull/12410
Change-Id: I1b25694c2f8f52d5335da889610ae1871deb0917
PR 1/7
When the DirectRunner gets canceled, there is no signal to pass to the
evaluation context to gracefully shut it down. The Te
piotr-szuberski commented on a change in pull request #12406:
URL: https://github.com/apache/beam/pull/12406#discussion_r462771399
##
File path: sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py
##
@@ -91,7 +90,12 @@ def setUp(self):
self.host, self.port, sel
tvalentyn commented on pull request #12212:
URL: https://github.com/apache/beam/pull/12212#issuecomment-665910356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
davidyan74 commented on a change in pull request #12411:
URL: https://github.com/apache/beam/pull/12411#discussion_r462561306
##
File path:
sdks/python/apache_beam/runners/interactive/options/capture_limiters.py
##
@@ -71,3 +87,62 @@ def _trigger(self):
def is_triggered(s
tysonjh commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-665843586
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
damondouglas commented on pull request #12402:
URL: https://github.com/apache/beam/pull/12402#issuecomment-665916576
@lostluck The `*-remote.yaml` files are now committed from updating the
[Stepik course](https://stepik.org/course/70387) and this PR is ready to merge.
KevinGG commented on a change in pull request #12372:
URL: https://github.com/apache/beam/pull/12372#discussion_r462542550
##
File path:
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/kernel/KernelModel.ts
##
@@ -0,0 +1,161 @@
+// L
rohdesamuel commented on pull request #12411:
URL: https://github.com/apache/beam/pull/12411#issuecomment-665845192
R: @KevinGG
R: @davidyan74
This is an automated message from the Apache Git Service.
To respond to the m
kennknowles commented on pull request #12400:
URL: https://github.com/apache/beam/pull/12400#issuecomment-666032661
It is a good point that `CalcMergeRule` and `FilterToCalcRule` should be
enough so this rule is not needed. You might ask on dev@calcite why they both
exist.
But how d
aaltay commented on pull request #12409:
URL: https://github.com/apache/beam/pull/12409#issuecomment-665836821
LGTM. Ping me when ready.
This is an automated message from the Apache Git Service.
To respond to the message, ple
saavannanavati commented on pull request #12009:
URL: https://github.com/apache/beam/pull/12009#issuecomment-666071126
run python precommit
This is an automated message from the Apache Git Service.
To respond to the m
pabloem opened a new pull request #12418:
URL: https://github.com/apache/beam/pull/12418
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickl
robinyqiu commented on a change in pull request #12348:
URL: https://github.com/apache/beam/pull/12348#discussion_r462568818
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
##
@@ -258
KevinGG commented on pull request #12372:
URL: https://github.com/apache/beam/pull/12372#issuecomment-665888592
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
tvalentyn merged pull request #12212:
URL: https://github.com/apache/beam/pull/12212
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tysonjh opened a new pull request #12416:
URL: https://github.com/apache/beam/pull/12416
Update google-api-services* versions and google-client version to latest.
Thank you for your contribution! Follow this checklist to help us
incorporate your contri
lostluck merged pull request #12393:
URL: https://github.com/apache/beam/pull/12393
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kennknowles merged pull request #12376:
URL: https://github.com/apache/beam/pull/12376
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
iindyk commented on pull request #12420:
URL: https://github.com/apache/beam/pull/12420#issuecomment-666062605
R: @chrisgorgo
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rohdesamuel commented on pull request #12410:
URL: https://github.com/apache/beam/pull/12410#issuecomment-665827616
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
jiyongjung0 commented on pull request #12404:
URL: https://github.com/apache/beam/pull/12404#issuecomment-666007314
R: @aaltay
Could you please take a look?
This is an automated message from the Apache Git Service.
To
rohdesamuel opened a new pull request #12414:
URL: https://github.com/apache/beam/pull/12414
Change-Id: I52a4f36b09e6f6899d7c59756c9702ba983e083b
PR 5/7
The logic to stop reading from cache was incorrect and did not properly stop
if the cache changed.
--
pabloem commented on pull request #12418:
URL: https://github.com/apache/beam/pull/12418#issuecomment-665868369
oddly I got this to pass on my machine.
This is an automated message from the Apache Git Service.
To respond to t
tvalentyn commented on a change in pull request #12212:
URL: https://github.com/apache/beam/pull/12212#discussion_r462566471
##
File path: website/www/site/content/en/get-started/downloads.md
##
@@ -87,6 +87,13 @@ versions denoted `0.x.y`.
## Releases
+### 2.23.0 (2020-07-
aaltay merged pull request #12394:
URL: https://github.com/apache/beam/pull/12394
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ihji commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r462534513
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImplTest.java
##
@@ -733,26 +734,29 @@ pub
ibzib commented on a change in pull request #12212:
URL: https://github.com/apache/beam/pull/12212#discussion_r462571597
##
File path: website/www/site/content/en/get-started/downloads.md
##
@@ -87,6 +87,13 @@ versions denoted `0.x.y`.
## Releases
+### 2.23.0 (2020-07-16)
chamikaramj commented on a change in pull request #12406:
URL: https://github.com/apache/beam/pull/12406#discussion_r462656463
##
File path: sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py
##
@@ -91,7 +90,12 @@ def setUp(self):
self.host, self.port, self.da
prodonjs commented on a change in pull request #12372:
URL: https://github.com/apache/beam/pull/12372#discussion_r462515880
##
File path:
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/kernel/KernelModel.ts
##
@@ -0,0 +1,161 @@
+//
aaltay commented on pull request #12118:
URL: https://github.com/apache/beam/pull/12118#issuecomment-665835545
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
ihji commented on pull request #12106:
URL: https://github.com/apache/beam/pull/12106#issuecomment-665922796
LGTM. Thanks.
@chamikaramj Any additional comment?
This is an automated message from the Apache Git S
rohdesamuel opened a new pull request #12411:
URL: https://github.com/apache/beam/pull/12411
Change-Id: I9f7030999f2ce38073ca72512c71794dbdbc301e
PR 2/7
This will allow for the cache to stop reading based on elements. Currently,
the cache can only stop based on global configur
kennknowles commented on pull request #12387:
URL: https://github.com/apache/beam/pull/12387#issuecomment-666048972
This PR has now become trivial, as the substantive bits were modified and
moved into the `rawtypes-gcp` pull request. Still, the new spotbugs does catch
a bunch more errors (
henryken commented on pull request #12362:
URL: https://github.com/apache/beam/pull/12362#issuecomment-666093915
Thanks for the change @robertwb! LGTM.
After the merge, I'll help to update the course on Stepik.
This is an
tvalentyn merged pull request #12213:
URL: https://github.com/apache/beam/pull/12213
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
DariuszAniszewski commented on pull request #12099:
URL: https://github.com/apache/beam/pull/12099#issuecomment-666260179
Hey @TheNeuralBit @pabloem
The `2.23.0` version is released, so this PR can be merged ;)
This
simonepri opened a new pull request #12421:
URL: https://github.com/apache/beam/pull/12421
The documentation says
> CountElms counts the number of elements in a collection.
> It expects a PCollection as input and returns a PCollection of
**one element** containing the count.
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666279110
@TheNeuralBit Sorry for lots of messages but every day brings something new.
I've managed to modify existing KinesisIOIT to work with localstack (I'll
push it in a
piotr-szuberski edited a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666279110
@TheNeuralBit Sorry for lots of messages but every day brings something new.
I've managed to modify existing KinesisIOIT to work with localstack (I'll
push i
piotr-szuberski edited a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666279110
@TheNeuralBit Sorry for lots of messages but every day brings something new.
I've managed to modify existing KinesisIOIT to work with localstack (I'll
push i
rworley-monster commented on pull request #12389:
URL: https://github.com/apache/beam/pull/12389#issuecomment-666280160
> This needs tests!
Indeed, I will add appropriate tests in `BigQueryUtilsTest`.
> BigQuery doesn't fundamentally support maps. This change modifies the IO
t
simonepri commented on pull request #12421:
URL: https://github.com/apache/beam/pull/12421#issuecomment-666285522
R: @youngoli, @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, pl
rworley-monster commented on a change in pull request #12389:
URL: https://github.com/apache/beam/pull/12389#discussion_r462906573
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##
@@ -442,6 +450,17 @@ priv
piotr-szuberski opened a new pull request #12422:
URL: https://github.com/apache/beam/pull/12422
I've done this by the way of writing cross-language integration tests.
Thank you for your contribution! Follow this checklist to help us
incorporate your c
piotr-szuberski commented on pull request #12422:
URL: https://github.com/apache/beam/pull/12422#issuecomment-666291814
R: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, pl
rworley-monster removed a comment on pull request #12389:
URL: https://github.com/apache/beam/pull/12389#issuecomment-664974133
retest this please
This is an automated message from the Apache Git Service.
To respond to the me
damgad commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-666297321
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
damgad commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-666299886
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
damgad commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-666303215
Verified that it works as expected:
```
INFO:root:Generating Committers.groovy
INFO:root:70 committers' GitHub usernames fetched correctly
INFO:root:Committers.groov
damgad commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-666304130
R: @aaltay @udim
This is an automated message from the Apache Git Service.
To respond to the message, please log
piotr-szuberski commented on pull request #12422:
URL: https://github.com/apache/beam/pull/12422#issuecomment-666312635
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
kkucharc commented on pull request #12151:
URL: https://github.com/apache/beam/pull/12151#issuecomment-666319639
Friendly pinging after 3 days @pabloem :)
This is an automated message from the Apache Git Service.
To respond t
kkucharc commented on pull request #12296:
URL: https://github.com/apache/beam/pull/12296#issuecomment-666320425
@slawomir-andrian is on vacations until end of the week but I can respond in
case of any doubts @TheNeuralBit :)
---
TobKed commented on a change in pull request #12405:
URL: https://github.com/apache/beam/pull/12405#discussion_r462946005
##
File path: CI.md
##
@@ -0,0 +1,104 @@
+
+
+# Apache Beam
+
+## CI Environment
+
+Continuous Integration is important component of making Apache Beam robu
TobKed commented on a change in pull request #12405:
URL: https://github.com/apache/beam/pull/12405#discussion_r462952380
##
File path: CI.md
##
@@ -0,0 +1,104 @@
+
+
+# Apache Beam
+
+## CI Environment
+
+Continuous Integration is important component of making Apache Beam robu
TobKed commented on pull request #12405:
URL: https://github.com/apache/beam/pull/12405#issuecomment-666329030
@aaltay thanks for review. I fixed typo and replied to your comments.
This is an automated message from the Apache
TobKed commented on a change in pull request #12405:
URL: https://github.com/apache/beam/pull/12405#discussion_r462953052
##
File path: CI.md
##
@@ -0,0 +1,104 @@
+
+
+# Apache Beam
+
+## CI Environment
+
+Continuous Integration is important component of making Apache Beam robu
TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r462956031
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -170,7 +170,7 @@ def get_last_run_id(
f"GCS location corresponding
TobKed commented on a change in pull request #12318:
URL: https://github.com/apache/beam/pull/12318#discussion_r462965733
##
File path: .github/workflows/build_wheels.yml
##
@@ -193,29 +196,232 @@ jobs:
GITHUB_BASE_REF=$GITHUB_BASE_REF
EOF
echo $(cat
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666350605
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski removed a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666350605
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666352407
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski removed a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666352407
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666361077
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666363032
@TheNeuralBit Forget what I said. I've just found that the expansion-service
has an indirect dependency on harness and I managed to set test properties in
gradle file. No
piotr-szuberski edited a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666363032
This is an automated message from the Apache Git Service.
To respond to the message, please log on
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463003111
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,419 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463003111
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,419 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666382582
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski removed a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666361077
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463019759
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,419 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
piotr-szuberski opened a new pull request #12423:
URL: https://github.com/apache/beam/pull/12423
During writing kinesis for cross-language it was suggested to emplace all
classes connected to cross-language in one file. I do the same here for jdbc.
R: @chamikaramj
---
piotr-szuberski commented on pull request #12406:
URL: https://github.com/apache/beam/pull/12406#issuecomment-666394811
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski commented on pull request #12423:
URL: https://github.com/apache/beam/pull/12423#issuecomment-666395401
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666408845
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski removed a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666382582
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to
piotr-szuberski edited a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666363032
@TheNeuralBit Forget what I just said. I've just found that the
expansion-service has an indirect dependency on harness and I managed to set
test properties in the
piotr-szuberski edited a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666363032
@TheNeuralBit Forget what I just said. I've just found that the
expansion-service has an indirect dependency on harness and I managed to set
test properties in the
iindyk edited a comment on pull request #12420:
URL: https://github.com/apache/beam/pull/12420#issuecomment-666062605
R: @pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666458687
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski removed a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666408845
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to
piotr-szuberski edited a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666363032
@TheNeuralBit Forget what I just said. I've just found that the
expansion-service has an indirect dependency on harness and I managed to set
test properties in the
piotr-szuberski commented on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666472634
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the mes
piotr-szuberski removed a comment on pull request #12297:
URL: https://github.com/apache/beam/pull/12297#issuecomment-666458687
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to
1 - 100 of 226 matches
Mail list logo
