lewiszlw opened a new pull request, #10441:
URL: https://github.com/apache/datafusion/pull/10441
## Which issue does this PR close?
Remove `AggregateFunctionDefinition::Name` as it's useless.
## Rationale for this change
## What changes are included in thi
jayzhan211 commented on issue #10424:
URL: https://github.com/apache/datafusion/issues/10424#issuecomment-2103912260
> Is it possible to make the `array_slice` function accept a vector as its
parameter?
>
> ```rust
> fn array_slice(args: Vec) {
> }
> ```
>
> When makin
jayzhan211 commented on issue #10440:
URL: https://github.com/apache/datafusion/issues/10440#issuecomment-2103891076
I also notice that but did not dig into it. We might need type coercion in
`LogicalPlan::Values`.
--
This is an automated message from the Apache Git Service.
To respond to
yyy1000 commented on code in PR #10418:
URL: https://github.com/apache/datafusion/pull/10418#discussion_r1596271053
##
datafusion/physical-expr/src/aggregate/covariance.rs:
##
@@ -319,281 +225,3 @@ impl Accumulator for CovarianceAccumulator {
std::mem::size_of_val(self)
jayzhan211 commented on code in PR #10418:
URL: https://github.com/apache/datafusion/pull/10418#discussion_r1596262433
##
datafusion/physical-expr/src/aggregate/covariance.rs:
##
@@ -319,281 +225,3 @@ impl Accumulator for CovarianceAccumulator {
std::mem::size_of_val(se
jayzhan211 commented on code in PR #10418:
URL: https://github.com/apache/datafusion/pull/10418#discussion_r1596262433
##
datafusion/physical-expr/src/aggregate/covariance.rs:
##
@@ -319,281 +225,3 @@ impl Accumulator for CovarianceAccumulator {
std::mem::size_of_val(se
yyy1000 opened a new issue, #10440:
URL: https://github.com/apache/datafusion/issues/10440
### Is your feature request related to a problem or challenge?
When creating a table specifying the double as column datatype and giving
some initial values without explicit double type, for exa
yyy1000 commented on code in PR #10418:
URL: https://github.com/apache/datafusion/pull/10418#discussion_r1596242627
##
datafusion/physical-expr/src/aggregate/covariance.rs:
##
@@ -319,281 +225,3 @@ impl Accumulator for CovarianceAccumulator {
std::mem::size_of_val(self)
jayzhan211 commented on code in PR #10439:
URL: https://github.com/apache/datafusion/pull/10439#discussion_r1596183866
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -833,12 +865,8 @@ mod test {
signature: Signature::uniform(1, vec![DataType::Float32],
lewiszlw commented on code in PR #10432:
URL: https://github.com/apache/datafusion/pull/10432#discussion_r1596181005
##
datafusion-examples/examples/flight/flight_sql_server.rs:
##
@@ -337,234 +346,52 @@ impl FlightSqlService for FlightSqlServiceImpl {
Ok(resp)
}
github-actions[bot] closed pull request #7338: Support nulls and empty for
array functions
URL: https://github.com/apache/datafusion/pull/7338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
github-actions[bot] commented on PR #8664:
URL: https://github.com/apache/datafusion/pull/8664#issuecomment-2103703306
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or th
github-actions[bot] commented on PR #9413:
URL: https://github.com/apache/datafusion/pull/9413#issuecomment-2103703270
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or th
jayzhan211 commented on code in PR #10439:
URL: https://github.com/apache/datafusion/pull/10439#discussion_r1596155186
##
datafusion/expr/src/expr_schema.rs:
##
@@ -139,9 +139,10 @@ impl ExprSchemable for Expr {
.map(|e| e.get_type(schema))
jayzhan211 opened a new pull request, #10439:
URL: https://github.com/apache/datafusion/pull/10439
## Which issue does this PR close?
Closes #10423 .
## Rationale for this change
## What changes are included in this PR?
## Are these changes
rohitrastogi commented on code in PR #399:
URL: https://github.com/apache/datafusion-comet/pull/399#discussion_r1596117835
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -232,6 +232,240 @@ macro_rules! cast_int_to_int_macro {
}};
}
+// When Spark casts to By
rohitrastogi commented on code in PR #399:
URL: https://github.com/apache/datafusion-comet/pull/399#discussion_r1596117835
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -232,6 +232,240 @@ macro_rules! cast_int_to_int_macro {
}};
}
+// When Spark casts to By
rohitrastogi commented on code in PR #399:
URL: https://github.com/apache/datafusion-comet/pull/399#discussion_r1596118952
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -232,6 +232,240 @@ macro_rules! cast_int_to_int_macro {
}};
}
+// When Spark casts to By
jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2103614074
You can define closure in `datafusion/expr/src/function.rs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
viirya commented on PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#issuecomment-2103479317
I remember only the first-time contributors need approval to trigger CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
viirya commented on PR #403:
URL: https://github.com/apache/datafusion-comet/pull/403#issuecomment-2103477288
Ah, I found that I made a mistake in the Java Arrow PR that it doesn't
initiate the offset buffer well. Proposed another issue at Java Arrow
https://github.com/apache/arrow/issues/4
kazuyukitanimura commented on PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#issuecomment-2103476973
@viirya @andygrove Is there a way to start CI without bothering you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
emgeee closed pull request #10438: Add franz feature
URL: https://github.com/apache/datafusion/pull/10438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
emgeee opened a new pull request, #10438:
URL: https://github.com/apache/datafusion/pull/10438
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
tinfoil-knight commented on code in PR #10117:
URL: https://github.com/apache/datafusion/pull/10117#discussion_r1595938806
##
datafusion/expr/src/signature.rs:
##
@@ -346,13 +346,60 @@ impl Signature {
}
}
-/// Monotonicity of the `ScalarFunctionExpr` with respect to its
backkem commented on issue #7871:
URL: https://github.com/apache/datafusion/issues/7871#issuecomment-2103372651
The federation repo turns (part of) the query plan back into SQL. In the
simple case, the query only uses table providers of one remote DBMS. In that
case the entire query will be
tinfoil-knight commented on code in PR #10117:
URL: https://github.com/apache/datafusion/pull/10117#discussion_r1595579610
##
datafusion/expr/src/signature.rs:
##
@@ -346,13 +346,81 @@ impl Signature {
}
}
-/// Monotonicity of the `ScalarFunctionExpr` with respect to its
karlovnv commented on issue #7871:
URL: https://github.com/apache/datafusion/issues/7871#issuecomment-2103286570
> For now I'm experiencing with another approach in
[datafusion-federation](https://github.com/datafusion-contrib/datafusion-federation).
@backkem Could you please provide mor
viirya commented on PR #403:
URL: https://github.com/apache/datafusion-comet/pull/403#issuecomment-2103282710
Hmm, the error is actually different:
```
Cause: org.apache.comet.CometNativeException: Fail to process Arrow array
with reason C Data interface error: The external buffe
Michael-J-Ward opened a new issue, #675:
URL: https://github.com/apache/datafusion-python/issues/675
@andygrove via Discord:
Documentation publishing to the site is broken, likely because this does not
get tested on PR builds
```
>>>--
backkem commented on issue #7871:
URL: https://github.com/apache/datafusion/issues/7871#issuecomment-210356
Indeed, my use-case is querying across remote DBMSs. For now I'm
experiencing with another approach in
[datafusion-federation](https://github.com/datafusion-contrib/datafusion-fed
mattharder91 commented on issue #326:
URL:
https://github.com/apache/datafusion-comet/issues/326#issuecomment-2103196311
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Smotrov commented on issue #10435:
URL: https://github.com/apache/datafusion/issues/10435#issuecomment-2103194344
Here is an example file
[data.zst.json](https://github.com/apache/datafusion/files/15266143/data.zst.json)
And the code, which shows that the file could be perfectly decod
andygrove merged PR #674:
URL: https://github.com/apache/datafusion-python/pull/674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
andygrove commented on code in PR #401:
URL: https://github.com/apache/datafusion-comet/pull/401#discussion_r1595801156
##
core/benches/cast_numeric.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
andygrove merged PR #401:
URL: https://github.com/apache/datafusion-comet/pull/401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
alamb commented on issue #10433:
URL: https://github.com/apache/datafusion/issues/10433#issuecomment-2103142141
(BTW @NGA-TRAN and I worked on a very similar feature in InfluxDB IOx --
and we implemented a special operator that knows how to do this "read only the
most recent file" for quer
andygrove commented on code in PR #674:
URL: https://github.com/apache/datafusion-python/pull/674#discussion_r1595785654
##
dev/release/README.md:
##
@@ -103,42 +103,7 @@ git push apache 0.8.0-rc1
./dev/release/create-tarball.sh 0.8.0 1
```
-This will also create the email t
andygrove opened a new pull request, #674:
URL: https://github.com/apache/datafusion-python/pull/674
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes
alamb commented on issue #10433:
URL: https://github.com/apache/datafusion/issues/10433#issuecomment-2103138751
> It the example TableProvider may know that it needed to provide only last
record batch (or the latest parquet file from folder).
The provider can tell DataFusion it produc
karlovnv commented on issue #7871:
URL: https://github.com/apache/datafusion/issues/7871#issuecomment-2103134768
> Is the idea that the table providers have some faster way to sort than
what is built into DataFusion?
As I understand @backkem wanted to load data from an external dataso
alamb opened a new pull request, #10437:
URL: https://github.com/apache/datafusion/pull/10437
## Which issue does this PR close?
Related to https://github.com/apache/datafusion/issues/10291
## Rationale for this change
While reviewing this code for
https://github.com/apache/
viirya commented on PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#issuecomment-2103124845
Triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
karlovnv commented on issue #10433:
URL: https://github.com/apache/datafusion/issues/10433#issuecomment-2103119446
> Possibly related: #7871
@alamb Thank you for the reply!
I've read discussion in #7871 and think that this case is different.
I don't want to say that MySou
alamb commented on PR #10333:
URL: https://github.com/apache/datafusion/pull/10333#issuecomment-2103085218
Revert PR: https://github.com/apache/datafusion/pull/10436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on issue #10280:
URL: https://github.com/apache/datafusion/issues/10280#issuecomment-2103084827
We unfortunately found issues in
https://github.com/apache/datafusion/pull/10333 so we are going to revert it in
https://github.com/apache/datafusion/pull/10436
See discuss
kazuyukitanimura commented on PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#issuecomment-2103082792
@viirya @andygrove Please approve to start CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on issue #10433:
URL: https://github.com/apache/datafusion/issues/10433#issuecomment-2103079866
Possibly related: https://github.com/apache/datafusion/issues/7871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
kazuyukitanimura opened a new pull request, #407:
URL: https://github.com/apache/datafusion-comet/pull/407
## Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/372
## Rationale for this change
To be ready for Spark 4
alamb commented on issue #10435:
URL: https://github.com/apache/datafusion/issues/10435#issuecomment-2103074877
Thanks for the report -- can you possiblly share an example of such a file
(or instructions for how to create one)?
--
This is an automated message from the Apache Git Service.
MohamedAbdeen21 opened a new pull request, #10436:
URL: https://github.com/apache/datafusion/pull/10436
## Which issue does this PR close?
Revert #10333
## Rationale for this change
This issue is to be revisited after #10413.
## What changes are in
alamb commented on code in PR #10430:
URL: https://github.com/apache/datafusion/pull/10430#discussion_r1594710170
##
datafusion/optimizer/src/eliminate_cross_join.rs:
##
@@ -250,90 +265,67 @@ fn find_inner_join(
}))
}
-fn intersect(
-accum: &mut Vec<(Expr, Expr)>,
-
alamb commented on code in PR #10430:
URL: https://github.com/apache/datafusion/pull/10430#discussion_r1594710628
##
datafusion/optimizer/src/join_key_set.rs:
##
@@ -0,0 +1,240 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
alamb merged PR #10427:
URL: https://github.com/apache/datafusion/pull/10427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #10427:
URL: https://github.com/apache/datafusion/pull/10427#issuecomment-2103048124
Thanks for the reviews @jackwener and @comphead ❤️ -- this now opens up a
few more PRs I have queued up to make this code faster (by reducing cloning)
https://github.com/apache/datafu
alamb commented on code in PR #10427:
URL: https://github.com/apache/datafusion/pull/10427#discussion_r1595719478
##
datafusion/expr/src/utils.rs:
##
@@ -909,8 +909,8 @@ pub fn check_all_columns_from_schema(
pub fn find_valid_equijoin_key_pair(
left_key: &Expr,
right_
yyy1000 commented on code in PR #10381:
URL: https://github.com/apache/datafusion/pull/10381#discussion_r1595718706
##
datafusion/sqllogictest/test_files/parquet_sorted_statistics.slt:
##
@@ -260,3 +260,77 @@ physical_plan
01)SortPreservingMergeExec: [constant_col@0 ASC NULLS L
yyy1000 commented on code in PR #10381:
URL: https://github.com/apache/datafusion/pull/10381#discussion_r1595718706
##
datafusion/sqllogictest/test_files/parquet_sorted_statistics.slt:
##
@@ -260,3 +260,77 @@ physical_plan
01)SortPreservingMergeExec: [constant_col@0 ASC NULLS L
andygrove commented on issue #368:
URL:
https://github.com/apache/datafusion-comet/issues/368#issuecomment-2103044593
In order to enable the discussions feature, I will need to file an issue
with ASF INFRA and will need to provide a link to a "consensus discussion
thread". I will start a t
andygrove closed issue #667: Boolean operators in expressions are ignored
URL: https://github.com/apache/datafusion-python/issues/667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
andygrove merged PR #668:
URL: https://github.com/apache/datafusion-python/pull/668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
comphead commented on code in PR #401:
URL: https://github.com/apache/datafusion-comet/pull/401#discussion_r1595622813
##
core/benches/cast_numeric.rs:
##
@@ -0,0 +1,79 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
comphead commented on code in PR #401:
URL: https://github.com/apache/datafusion-comet/pull/401#discussion_r1595619638
##
core/benches/cast_from_string.rs:
##
@@ -73,6 +61,23 @@ fn criterion_benchmark(c: &mut Criterion) {
});
}
+fn create_utf8_batch() -> RecordBatch {
R
comphead commented on code in PR #331:
URL: https://github.com/apache/datafusion-comet/pull/331#discussion_r1595595448
##
spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala:
##
@@ -135,6 +146,97 @@ class CometExpressionCoverageSuite extends CometTestBase
w
comphead commented on code in PR #331:
URL: https://github.com/apache/datafusion-comet/pull/331#discussion_r1595594959
##
spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala:
##
@@ -135,6 +146,97 @@ class CometExpressionCoverageSuite extends CometTestBase
w
comphead commented on code in PR #331:
URL: https://github.com/apache/datafusion-comet/pull/331#discussion_r1595593862
##
spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala:
##
@@ -123,7 +134,7 @@ class CometExpressionCoverageSuite extends CometTestBase
wi
comphead commented on PR #331:
URL: https://github.com/apache/datafusion-comet/pull/331#issuecomment-2102867711
> Just to understand, backed by datafusion does not automatically mean that
has Spark compatibility?
I hope in most cases yes as we have a generic wrapper, this file is more
comphead commented on code in PR #10381:
URL: https://github.com/apache/datafusion/pull/10381#discussion_r1595586048
##
datafusion/sqllogictest/test_files/parquet_sorted_statistics.slt:
##
@@ -260,3 +260,77 @@ physical_plan
01)SortPreservingMergeExec: [constant_col@0 ASC NULLS
berkaysynnada commented on code in PR #10404:
URL: https://github.com/apache/datafusion/pull/10404#discussion_r1595583918
##
datafusion/sql/src/parser.rs:
##
@@ -1048,66 +959,41 @@ mod tests {
name: "t".into(),
columns: vec,
users can choose to maintain the existin
berkaysynnada commented on code in PR #10404:
URL: https://github.com/apache/datafusion/pull/10404#discussion_r1595568026
##
datafusion/sqllogictest/test_files/parquet.slt:
##
@@ -66,7 +66,6 @@ CREATE EXTERNAL TABLE test_table (
date_col DATE
)
STORED AS PARQUET
-WITH HEADE
timsaucer commented on PR #668:
URL:
https://github.com/apache/datafusion-python/pull/668#issuecomment-2102810555
@andygrove Checks passed, should be ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
viirya commented on code in PR #395:
URL: https://github.com/apache/datafusion-comet/pull/395#discussion_r1595546942
##
common/src/main/java/org/apache/comet/vector/CometPlainVector.java:
##
@@ -111,7 +115,12 @@ public UTF8String getUTF8String(int rowId) {
byte[] result =
jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102766839
> > > We're on the same page @jayzhan211
> >
> >
> > If we don't need `Expr` for simplified UDAF, than we can have
> > ```rust
> > pub fn simplify(
> > &
alamb commented on issue #10291:
URL: https://github.com/apache/datafusion/issues/10291#issuecomment-2102764792
I am starting to unravel the remaining copies in PushDownFilter -- it is non
trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
mattharder91 commented on PR #406:
URL: https://github.com/apache/datafusion-comet/pull/406#issuecomment-2102747381
I am getting
```
Cannot resolve "TRY_CAST(a AS BINARY)" due to data type mismatch: cannot
cast "BIGINT" to "BINARY"
```
In non ANSI Mode and respectfully for a
mattharder91 commented on code in PR #406:
URL: https://github.com/apache/datafusion-comet/pull/406#discussion_r1595509847
##
spark/src/main/scala/org/apache/comet/expressions/CometCast.scala:
##
@@ -248,4 +250,12 @@ object CometCast {
case _ => Unsupported
}
+ privat
leoluan2009 commented on code in PR #406:
URL: https://github.com/apache/datafusion-comet/pull/406#discussion_r1595505674
##
spark/src/main/scala/org/apache/comet/expressions/CometCast.scala:
##
@@ -248,4 +250,12 @@ object CometCast {
case _ => Unsupported
}
+ private
alamb commented on issue #10287:
URL: https://github.com/apache/datafusion/issues/10287#issuecomment-2102719342
It is done over a few PRs but I have this change now working and I think it
is looking quite good: https://github.com/apache/datafusion/pull/10431
--
This is an automated messag
alamb commented on code in PR #10431:
URL: https://github.com/apache/datafusion/pull/10431#discussion_r1595486547
##
datafusion/optimizer/src/eliminate_cross_join.rs:
##
@@ -237,7 +324,7 @@ fn find_inner_join(
)?);
return Ok(LogicalPlan::Join(Join {
-
milenkovicm commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102706142
> > We're on the same page @jayzhan211
>
> If we don't need `Expr` for simplified UDAF, than we can have
>
> ```rust
> pub fn simplify(
> &self,
>
jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102701229
> We're on the same page @jayzhan211
If we don't need `Expr` for simplified UDAF, than we can have
```rust
pub fn simplify(
&self,
args: Aggregate
milenkovicm commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102693750
We're on the same page @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102684929
It should be this.
```rust
// UDF
fn simplify(
&self,
) -> Option
Result>> {
```
The reason for optional closure is that I assume we need to re
milenkovicm commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102672197
>
> My final answer for today is
>
> ```rust
> fn simplify(
> &self,
> args: AggregateArgs,
> _info: &dyn SimplifyInfo,
> ) ->
jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102665705
> > After playing around, I feel like maybe optional closure is our answer 🤔
>
> Damn! I should have created a branch with that code 😀, if we have
consensus on that directio
ozankabak commented on code in PR #10434:
URL: https://github.com/apache/datafusion/pull/10434#discussion_r1595444209
##
datafusion/physical-expr/src/equivalence/properties.rs:
##
@@ -198,6 +198,61 @@ impl EquivalenceProperties {
left: &Arc,
right: &Arc,
)
jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102642821
> > After playing around, I feel like maybe optional closure is our answer 🤔
>
> Damn! I should have created a branch with that code 😀, if we have
consensus on that directio
Smotrov opened a new issue, #10435:
URL: https://github.com/apache/datafusion/issues/10435
### Describe the bug
When reading a partition of big NDJSON files compressed with ZSTD there is
an error appears.
`Error: Custom { kind: Other, error:
External(ArrowError(ExternalError(IoEr
mattharder91 opened a new pull request, #406:
URL: https://github.com/apache/datafusion-comet/pull/406
## Which issue does this PR close?
https://github.com/apache/datafusion-comet/issues/405,
https://github.com/apache/datafusion-comet/issues/377
Closes #.
## Rationale f
milenkovicm commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102610136
> After playing around, I feel like maybe optional closure is our answer 🤔
Damn! I should have created a branch with that code 😀, if we have consensus
on that direction I'
fabianmurariu commented on issue #10421:
URL: https://github.com/apache/datafusion/issues/10421#issuecomment-2102606499
Strange, I'm encountering this with custom TableProviders, I'll be able to
share more next week tho
--
This is an automated message from the Apache Git Service.
To respo
jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102602155
> @jayzhan211 and @alamb whenever you get chance please have a look, IMHO I
find proposal with closure to tick all the boxes, but this one is definitely
simpler.
After playing
alamb commented on PR #10333:
URL: https://github.com/apache/datafusion/pull/10333#issuecomment-2102581042
Sounds like the consensus is to revert this PR -- could you possible make a
revert PR @MohamedAbdeen21 ?
--
This is an automated message from the Apache Git Service.
To respond to t
alamb commented on code in PR #10410:
URL: https://github.com/apache/datafusion/pull/10410#discussion_r1595387773
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -467,6 +468,200 @@ impl LogicalPlan {
self.with_new_exprs(self.expressions(), inputs.to_vec())
}
+
mustafasrepo commented on issue #10421:
URL: https://github.com/apache/datafusion/issues/10421#issuecomment-2102576381
> Thanks @fabianmurariu
>
> cc @mustafasrepo in case you have any thoughts
I have tried to reproduce problem by defining absolutely necessary fields in
the que
1 - 100 of 128 matches
Mail list logo
