ClSlaid commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597542555
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
ClSlaid commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597542555
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
ClSlaid commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597542555
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
ClSlaid commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597540519
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
leoluan2009 commented on PR #418:
URL: https://github.com/apache/datafusion-comet/pull/418#issuecomment-2106099066
@viirya Help to start CI, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
leoluan2009 opened a new pull request, #418:
URL: https://github.com/apache/datafusion-comet/pull/418
## Which issue does this PR close?
Closes #417.
## Rationale for this change
## What changes are included in this PR?
## How are these chan
Weijun-H opened a new issue, #687:
URL: https://github.com/apache/datafusion-python/issues/687
**Describe the bug**
The logo and the links on the website are outdated and deprecated. We should
check and update them.
--
This is an automated message from the Apache Git Service.
To re
leoluan2009 opened a new issue, #417:
URL: https://github.com/apache/datafusion-comet/issues/417
### What is the problem the feature request solves?
some config name of columnar shuffle is not consistent and refine it
### Describe the potential solution
_No response_
github-actions[bot] commented on PR #6047:
URL: https://github.com/apache/datafusion/pull/6047#issuecomment-2106085595
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or th
github-actions[bot] closed pull request #6713: Add `async` UDF example
URL: https://github.com/apache/datafusion/pull/6713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] closed pull request #6943: UpdateD pool.rs
URL: https://github.com/apache/datafusion/pull/6943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
yyy1000 commented on issue #10456:
URL: https://github.com/apache/datafusion/issues/10456#issuecomment-2106074548
On a second glance, I feel it's difficult. 😥
When simplifying a logicalplan, it seems impossible to get the underlying
data which could making `guarantees`.
--
This is an
yyy1000 closed pull request #10463: Add simplifier additional between
URL: https://github.com/apache/datafusion/pull/10463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
comphead commented on code in PR #10356:
URL: https://github.com/apache/datafusion/pull/10356#discussion_r1597527103
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -98,25 +101,75 @@ fn analyze_internal(
// select t2.c2 from t1 where t1.c1 in (select t2.c1 from
comphead commented on code in PR #10356:
URL: https://github.com/apache/datafusion/pull/10356#discussion_r1597526532
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -98,25 +101,75 @@ fn analyze_internal(
// select t2.c2 from t1 where t1.c1 in (select t2.c1 from
comphead commented on code in PR #10356:
URL: https://github.com/apache/datafusion/pull/10356#discussion_r1597526491
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -66,26 +67,28 @@ impl AnalyzerRule for TypeCoercion {
}
fn analyze(&self, plan: LogicalPl
yyy1000 commented on PR #10463:
URL: https://github.com/apache/datafusion/pull/10463#issuecomment-2106065020
The example in #10456 in this PR like below
```
> create table t (c int) as values (1), (3), (5);
0 row(s) fetched.
Elapsed 0.031 seconds.
> explain verbose sel
yyy1000 opened a new pull request, #10463:
URL: https://github.com/apache/datafusion/pull/10463
## Which issue does this PR close?
Closes #10456.
## Rationale for this change
## What changes are included in this PR?
## Are these changes test
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597524103
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597524103
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on issue #10424:
URL: https://github.com/apache/datafusion/issues/10424#issuecomment-2106058219
Do you mean df-python always panics if `stride` is not given?
```
#[pyfunction]
#[pyo3(signature = (array, begin, end, stride = 1))]
fn array_slice(array: PyExp
Omega359 opened a new issue, #10462:
URL: https://github.com/apache/datafusion/issues/10462
### Describe the bug
The to_unixtime function is missing from the scalar functions doc in the
user guide.
### To Reproduce
See
https://datafusion.apache.org/user-guide/sql/scalar
Omega359 opened a new issue, #10461:
URL: https://github.com/apache/datafusion/issues/10461
### Describe the bug
The to_date function is missing from the scalar functions doc in the user
guide.
### To Reproduce
See
https://datafusion.apache.org/user-guide/sql/scalar_fun
alamb commented on PR #10454:
URL: https://github.com/apache/datafusion/pull/10454#issuecomment-2106006470
Wow -- according to my benchmarks this change makes a non trivial difference
in performance. We just keep driving tese numbers down
```
group
dependabot[bot] opened a new pull request, #686:
URL: https://github.com/apache/datafusion-python/pull/686
Bumps [datafusion-expr](https://github.com/apache/datafusion) from 37.1.0 to
38.0.0.
Commits
https://github.com/apache/datafusion/commit/cafbc9ddceb5af8c6408d0c8bbfed7568f
dependabot[bot] opened a new pull request, #685:
URL: https://github.com/apache/datafusion-python/pull/685
Bumps [datafusion-sql](https://github.com/apache/datafusion) from 37.1.0 to
38.0.0.
Commits
https://github.com/apache/datafusion/commit/cafbc9ddceb5af8c6408d0c8bbfed7568f6
dependabot[bot] opened a new pull request, #684:
URL: https://github.com/apache/datafusion-python/pull/684
Bumps [datafusion-functions-array](https://github.com/apache/datafusion)
from 37.1.0 to 38.0.0.
Commits
https://github.com/apache/datafusion/commit/cafbc9ddceb5af8c6408d0c
dependabot[bot] opened a new pull request, #683:
URL: https://github.com/apache/datafusion-python/pull/683
Bumps [datafusion-substrait](https://github.com/apache/datafusion) from
37.1.0 to 38.0.0.
Commits
https://github.com/apache/datafusion/commit/cafbc9ddceb5af8c6408d0c8bbfed
alamb commented on PR #10439:
URL: https://github.com/apache/datafusion/pull/10439#issuecomment-2105998161
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
dependabot[bot] closed pull request #631: build(deps): bump syn from 2.0.48 to
2.0.58
URL: https://github.com/apache/datafusion-python/pull/631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dependabot[bot] commented on PR #631:
URL:
https://github.com/apache/datafusion-python/pull/631#issuecomment-2105997735
Superseded by #682.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dependabot[bot] opened a new pull request, #682:
URL: https://github.com/apache/datafusion-python/pull/682
Bumps [syn](https://github.com/dtolnay/syn) from 2.0.60 to 2.0.63.
Release notes
Sourced from https://github.com/dtolnay/syn/releases";>syn's
releases.
2.0.63
Pa
dependabot[bot] opened a new pull request, #681:
URL: https://github.com/apache/datafusion-python/pull/681
Bumps [datafusion-optimizer](https://github.com/apache/datafusion) from
37.1.0 to 38.0.0.
Commits
https://github.com/apache/datafusion/commit/cafbc9ddceb5af8c6408d0c8bbfed
dependabot[bot] opened a new pull request, #679:
URL: https://github.com/apache/datafusion-python/pull/679
Bumps [datafusion-common](https://github.com/apache/datafusion) from 37.1.0
to 38.0.0.
Commits
https://github.com/apache/datafusion/commit/cafbc9ddceb5af8c6408d0c8bbfed756
dependabot[bot] opened a new pull request, #680:
URL: https://github.com/apache/datafusion-python/pull/680
Bumps [datafusion](https://github.com/apache/datafusion) from 37.1.0 to
38.0.0.
Commits
https://github.com/apache/datafusion/commit/cafbc9ddceb5af8c6408d0c8bbfed7568f655dd
alamb commented on PR #10430:
URL: https://github.com/apache/datafusion/pull/10430#issuecomment-2105995932
Thanks for the review @comphead 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597493578
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
alamb commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597493524
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
alamb commented on issue #10293:
URL: https://github.com/apache/datafusion/issues/10293#issuecomment-2105992692
> hi, @alamb, I'd like to know if those two expressions are semantically
identical:
Yes, I believe they are the same
--
This is an automated message from the Apache Git S
alamb commented on PR #10454:
URL: https://github.com/apache/datafusion/pull/10454#issuecomment-2105992517
Thanks @erratic-pattern -- I took the liberty of merging the branch up from
main to resolve a merge conflict as well
--
This is an automated message from the Apache Git Service.
To
andygrove merged PR #676:
URL: https://github.com/apache/datafusion-python/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
andygrove closed issue #675: doc builds are broken
URL: https://github.com/apache/datafusion-python/issues/675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
viirya commented on PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#issuecomment-2105965894
Triggered CI pipelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
viirya commented on PR #410:
URL: https://github.com/apache/datafusion-comet/pull/410#issuecomment-2105965411
> Ci failed because of connection timeout
I will re-trigger failed pipelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ClSlaid commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597480063
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
ClSlaid commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597478938
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
ClSlaid commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597478938
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
ClSlaid commented on code in PR #10460:
URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597478628
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
input,
Michael-J-Ward commented on issue #10424:
URL: https://github.com/apache/datafusion/issues/10424#issuecomment-2105957139
Since the `regexp_*` UDFs have the same problem, I suspect that
`array_slice` was just our first encounter w/ the underlying issue: any "inner"
UDF implementation that be
ClSlaid opened a new pull request, #10460:
URL: https://github.com/apache/datafusion/pull/10460
## Which issue does this PR close?
Closes #10293.
## Rationale for this change
## What changes are included in this PR?
## Are these changes test
ClSlaid commented on issue #10293:
URL: https://github.com/apache/datafusion/issues/10293#issuecomment-2105950929
hi, @alamb, I'd like to know if those two expressions differ:
```rust
let aggr_expr =
vec;
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597438771
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597437435
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597437435
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10439:
URL: https://github.com/apache/datafusion/pull/10439#discussion_r1597436309
##
datafusion/expr/src/type_coercion/functions.rs:
##
@@ -20,23 +20,124 @@ use std::sync::Arc;
use crate::signature::{
ArrayFunctionSignature, FIXED_SIZE_
kazuyukitanimura commented on PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#issuecomment-2105690563
@viirya @andygrove passed all the tests on my personal github actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
b41sh commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597433886
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
b41sh commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597432978
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
vaibhawvipul opened a new pull request, #416:
URL: https://github.com/apache/datafusion-comet/pull/416
## Which issue does this PR close?
Closes #374 .
## Rationale for this change
## What changes are included in this PR?
## How are these ch
alamb commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597428939
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
peter-toth commented on issue #9873:
URL: https://github.com/apache/datafusion/issues/9873#issuecomment-2105681913
> UPDATE: It looks like Expr already derives Hash. Is there a reason we're
not using that instead of string keys?
I forgot to comment on this thread that my detailed answ
alamb commented on issue #10293:
URL: https://github.com/apache/datafusion/issues/10293#issuecomment-2105681808
of course thank you @ClSlaid -- just be aware these PRs have tended to be
tricky. I recommend doing it incrementally if possible. Let me know if you need
some help 🙏
--
This
alamb commented on code in PR #10439:
URL: https://github.com/apache/datafusion/pull/10439#discussion_r1597427699
##
datafusion/expr/src/type_coercion/functions.rs:
##
@@ -20,23 +20,124 @@ use std::sync::Arc;
use crate::signature::{
ArrayFunctionSignature, FIXED_SIZE_LIST_
alamb commented on issue #9873:
URL: https://github.com/apache/datafusion/issues/9873#issuecomment-2105680216
> UPDATE: It looks like Expr already derives Hash. Is there a reason we're
not using that instead of string keys?
I believe CSE may predate the Hash impl for Expr
--
This i
alamb commented on code in PR #10454:
URL: https://github.com/apache/datafusion/pull/10454#discussion_r1597426402
##
datafusion/expr/src/expr.rs:
##
@@ -1654,28 +1654,42 @@ fn fmt_function(
write!(f, "{}({}{})", fun, distinct_str, args.join(", "))
}
-fn create_function_n
alamb merged PR #10458:
URL: https://github.com/apache/datafusion/pull/10458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
NoeB commented on PR #10457:
URL: https://github.com/apache/datafusion/pull/10457#issuecomment-2105674257
@Jefffrey Thank you for the review, I added a new commit which adds the
missing distinct for the type
--
This is an automated message from the Apache Git Service.
To respond to the me
Jefffrey opened a new pull request, #10458:
URL: https://github.com/apache/datafusion/pull/10458
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
alamb commented on PR #10443:
URL: https://github.com/apache/datafusion/pull/10443#issuecomment-2105669432
Thanks for the review @Jefffrey and @yyy1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb merged PR #10443:
URL: https://github.com/apache/datafusion/pull/10443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
peter-toth commented on issue #10426:
URL: https://github.com/apache/datafusion/issues/10426#issuecomment-2105664520
> Are there any potential issues with simply using the existing `Hash`
implementation of `Expr` to create `HashSet`s?
>
> Serveral other optimization passes use string
Jefffrey commented on code in PR #10457:
URL: https://github.com/apache/datafusion/pull/10457#discussion_r1597413465
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -2285,6 +2285,201 @@ ORDER BY tag
33 11 NULL 33 11 NULL 33 11 NULL B
+# bit_and_i32
+statement ok
b41sh commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597413786
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
NoeB opened a new pull request, #10457:
URL: https://github.com/apache/datafusion/pull/10457
## Which issue does this PR close?
part of #10384
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
##
samuelcolvin commented on issue #10400:
URL: https://github.com/apache/datafusion/issues/10400#issuecomment-2105649193
@alamb using `PruningPredicate` makes sense, but please can you point me at
where I need to make changes to add this functionality?
--
This is an automated message from t
jayzhan211 opened a new issue, #10456:
URL: https://github.com/apache/datafusion/issues/10456
### Is your feature request related to a problem or challenge?
While deprecating`Expr::GetIndexedField`, I found there are many test cases
that are not covered in sqllogictest, for example
`
ClSlaid commented on issue #10293:
URL: https://github.com/apache/datafusion/issues/10293#issuecomment-2105629456
May I take a look? Merci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
leoluan2009 commented on PR #410:
URL: https://github.com/apache/datafusion-comet/pull/410#issuecomment-2105628167
> thanks @leoluan2009 appreciate if you could add the unit test to prevent
regression
@comphead can you give me a example? thanks
--
This is an automated message from
leoluan2009 commented on PR #410:
URL: https://github.com/apache/datafusion-comet/pull/410#issuecomment-2105618196
Ci failed because of connection timeout:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
prashantksharma commented on issue #361:
URL:
https://github.com/apache/datafusion-comet/issues/361#issuecomment-2105614143
@andygrove cc: @viirya
I have opended a draft PR.
I have tested the changes using
- `make test-rust`
- `make test-jvm`
Details on PR messa
1 - 100 of 101 matches
Mail list logo
