Hi Itzik,
An alternative to propagating the exception is to create an object
with details of the outcome of the RPC call regardless of success or
an error (other than an error connecting to the server).
In this object have methods to store and retrieve error codes and
messages so that your
Hi Blaze,
I haven't tried Fernando's method, but it sounds like a convenient way
to integrate the client side with EJB's.
The method I have successfully used is to simply call the EJB's from
the GWT RPC servlets.
That code snippet you wrote is the right idea. The local interface is
fine, since
WOW, this is really a bug of GWT Compiler.
I'll report to GWT issues tracking.
It's caused by GWT can't analyze main class to bind with uibinder
class when project name is same package name.
Cheers,
Hung
On Oct 12, 9:54 am, heros lvh...@gmail.com wrote:
Thanks for your link (I have clicked some
Hi,
Agree with Lukasz on separating the two layers.
Also, if your DAO class (or any other class you want to test) needs a
full J2EE container (which I suspect it might), then I don't think it
will run properly under JUnit. I ran into problems trying to test my
persistence code with JUnit
+1 to Filipe's great instructions!
You can use GWT Dev mode with Glassfish - just add a parameter to the
URL of your application: gwt.codesvr=127.0.0.1:9997 (or whatever your
GWT Dev mode port is)
e.g. http://localhost:8080/AppName/gwtHostPage.html?gwt.codesvr=127.0.0.1:9997
Has saved me
Sounds strange that it would be a bug (but perhaps you are right).
I would recommend having your EntryPoint class separate from your
UiBinder classes. i.e. Testgwt is your entry point class and then
have a separate class for the widget (say GWTWidget.java and
GWTWidget.ui.xml)
Your entry point
Hello,
I have a GWT application with I18N features.
Within one composite I do not want to access internationalized strings
but I want to know which language is selected.
So my question is if there is a mechanism like
GWT.getSelectedLanguage() which would return en or de.
Is there such a thing?
Denis,
Not sure if you're already aware of this or whether it will help your
situation: There is a technique called code splitting where you split
up a GWT app into smaller components so that the visible components
load faster.
Other components are loaded as needed or in the background after
Hi Stefan,
Is com.google.gwt.i18n.client.LocaleInfo.getCurrentLocale() what
you're looking for?
Hope this helps.
//Jason
On Tue, Oct 12, 2010 at 10:08 AM, StrongSteve swe.sta...@gmail.com wrote:
Hello,
I have a GWT application with I18N features.
Within one composite I do not want to access
Yuri,
Regarding resource injection with Jetty, please see:
http://wiki.eclipse.org/Jetty/Feature/Annotations
Looks like config might affect whether annotations are read from code
(or whether they need to be specified in a config file).
Jin
On Oct 12, 11:36 am, Y2i yur...@gmail.com wrote:
I
Thanks. I am aware of the feature. But i think it's not an appropriate
solution in the particular case. The thing is that all the client code
is loaded on startup the only thing that happens when user changes
pages is that new DTOs are sent over and the existing views (which are
already present on
The sample fails on the server-side because
somehow the EMF does not get initialized.
I've imported the sample into Eclipse 3.6 on
Windows 7 and running the LoadExpensesDB
module via Debug As menu item of Eclipse
Property Context Menu.
Can anybody please shed some light on how to
initialize the
How about ETag ? This should work out of the box with any tomcat.
On Oct 9, 8:16 pm, PeterT peterteunis...@verizon.net wrote:
We have a project.nocache.js file that included other .js and .css
files. The generated project has a long GUID like name which changes
each compilation, so that file
On 2 oct, 04:34, Nick nix...@gmail.com wrote:
I am in the process of creating a Progress Bar Cell that will work in
a GWT2.1 CellTable. So far I have the cell rendering a simple html
progress bar in a manner that is consistent with other cell renders.
I need to somehow update the progress
Hello Denis,
That is unlikely - cookie values are mostly set on the server side.
Since you are using Firebug, why don't you look out for the one
response that overrides the cookie? JSP pages for instance like
setting their own cookies in the default setup. Another thing to watch
for is the cookie
Hi,
Below is a code snippet. I am trying to load a Tree selection into a
frame.
Working with menu options the frame loads ok.
Working with Tree items, the resulting link takes over the whole
browser window and exits the application. IE the module unloads.
I tried the cancel bubble event
http://code.google.com/webtoolkit/doc/trunk/DevGuideMvpActivitiesAndPlaces.html
http://code.google.com/webtoolkit/doc/trunk/DevGuideUiCellWidgets.html
On Aug 16, 9:58 am, Bayard Randel k...@bestpractice.org.nz wrote:
Hi there,
Is there any preliminary documentation around the new features
Hi Guys
I have problem with my starter application for integrating gwt and
spring framework.
Application is made up of simple button, when client push it, server
response trough popup box with string message .
This is server response:
The error is :
Hi folk
I have GWT 2.0.4 and Eclipse Galileo, i want for example when i open
www.google.com to execute my GWT code in google page.
I will be thankful for any help.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group,
Exactly what I was searching for!
Thx a lot! ;)
Greetings
Stefan
On Oct 12, 10:13 am, Jason Morris lem...@gmail.com wrote:
Hi Stefan,
Is com.google.gwt.i18n.client.LocaleInfo.getCurrentLocale() what
you're looking for?
Hope this helps.
//Jason
On Tue, Oct 12, 2010 at 10:08 AM,
Maybe open the login in a new window or in a new tab and once the user
has logged in he will click a button like I have logged in and then
just ajax to the server and check his login status.
On 5 אוקטובר, 20:27, Haris harishas...@gmail.com wrote:
A good idea. However there bound to be user who
Basically for server-client communication with a non Java Backend you
either have to use XML or JSON.
I would recommend JSON (tutorial:
http://code.google.com/webtoolkit/doc/latest/tutorial/JSONphp.html)
For application design there are two approaches:
- web-application (one host page - AJAX
Thanks a lot! This worked. I really appreciate this!
On Oct 10, 6:31 pm, Gal Dolber gal.dol...@gmail.com wrote:
You can use a FocusPanel or extend any panel and implement the mouse events
on it
(http://code.google.com/p/google-web-toolkit-incubator/wiki/GwtEventSy...
help)
Best
On
Hi everybody
I have a problem running a GWT application in Development Mode, by
using Chrome as a Default Browser, while it works fine in IE8.
I simply downloaded Chrome and installed the plug-in, as i did for
IE8.
The error is:
Network Access Message: The page cannot be displayed
Explanation:
i have a problem with a simple GWT project. It is made of two .java
files.
The first just add two same composites (MainForm) to the Root
Panel.
public class ImageViewer implements EntryPoint {
public void onModuleLoad() {
RootPanel rootPanel = RootPanel.get();
Also look out for requests to
http://www.yoursiteurl.com
and
http://yoursiteurl.com
Cookies for one, depending on the way your cookies are being set (the
host, in particular), may not be valid for both.
On Oct 12, 5:14 am, George Georgovassilis g.georgovassi...@gmail.com
wrote:
Hello Denis,
The above error message gets propagated to the uncaught exception
handler when I execute the DOM.removeChild line in the code below:
if ( mainScreen != null container != null) {
DOM.removeChild(container.getElement(),
mainScreen.getElement());
Esfand,
You need the RC1 version of the Google Plugin for Eclipse also. You
can download it here:
http://code.google.com/webtoolkit/download_2_1_rc1.html
Please post back if you're still having problems.
--
David Chandler
Developer Programs Engineer, Google Web Toolkit
Atlanta, GA USA
On Oct
My mistake, this actually only fixed the memory leak because it was
throwing a js error that prevented the code from continuing on to leak
memory.
On Oct 11, 11:32 am, chrisr chris.robert.rowl...@gmail.com wrote:
Got pulled off to work on other issues, finally coming back to this
again.
I
Check out this thread for some solutions:
http://groups.google.com/group/google-web-toolkit/browse_thread/thread/04bbf17d8445580f#
On Oct 11, 9:40 pm, Didier DURAND durand.did...@gmail.com wrote:
It works here in Ubuntu 32bit 10.04
Do you use 64 bits ? I have read about some issues with 64
Can some one gives the suggestion about what is the best way to create
a color picker with GWT?
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from
For server side code compilation, if you use Maven, you can create
different profile to skip GWT compilation.
Or just use command line:
mvn compiler:compile
and copy class files from target folder to your runtime folder.
On Oct 11, 3:03 pm, Sorinel C scristescu...@hotmail.com wrote:
Are you
http://code.google.com/p/auroris/
On Oct 12, 8:17 am, Michelle Mu mmumail2...@gmail.com wrote:
Can some one gives the suggestion about what is the best way to create
a color picker with GWT?
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit
Thanks, Jim.
On Oct 12, 11:48 am, Jim Douglas jdou...@basis.com wrote:
http://code.google.com/p/auroris/
On Oct 12, 8:17 am, Michelle Mu mmumail2...@gmail.com wrote:
Can some one gives the suggestion about what is the best way to create
a color picker with GWT?- Hide quoted text -
-
Ok, that's it! this code solved my problem. But i have another one. For
example, i use this code to select the state, but how i can do another
combobox that show only the cities previously selected in the previous
combobox?
Thanks for the help!
2010/10/11 Carl Pritchett bogusggem...@gmail.com
The helloMVP.zip
http://code.google.com/webtoolkit/doc/trunk/tutorial/projects/hellomvp.zip
file is broken with regards to 2.1. The packages in 2.1 have moved
around.
I have uploaded a compiling version to the gwt contributors group.
Hi David. Thanks for your reply.
I am already using GPE 1.4.rc1-201010102248 with Eclipse 3.6
I am not using any of the jar files download by maven, instead I'm
using GAE/J 1.3.8-prerelease and GWT.2.1.0.RC1 distributed
via thezip-file (
Thanks a lot for the link Jin, really appreciate it!
On Oct 12, 1:24 am, Jin jintl...@gmail.com wrote:
Yuri,
Regarding resource injection with Jetty, please
see:http://wiki.eclipse.org/Jetty/Feature/Annotations
Looks like config might affect whether annotations are read from code
(or
Thanks a lot!
On Tue, Oct 12, 2010 at 12:38 AM, Goby chris.ky.le...@gmail.com wrote:
http://code.google.com/webtoolkit/doc/trunk/DevGuideMvpActivitiesAndPlaces.html
http://code.google.com/webtoolkit/doc/trunk/DevGuideUiCellWidgets.html
On Aug 16, 9:58 am, Bayard Randel
Hi all,
First tnx for the replay!
I tried Fernando's method and cant get it work, I also dont undertend how to
package if I doit this way
do i have to add gwt.war file in the ear file or...
Abouth the local way Jin is saying, I tried this also but not working again
(I tried this long time ago)
Hey Gang,
I was hoping someone might have an idea why this is happening. I have
two projects of 8 that use UiBinder at the moment. One project
compiles fine, the other however always fails with the following since
I updated to GWT 2.1.0-RC1. I've combed over it looking for some
small issue,
I created the class :
public class Game{
public static int quantidadeDeUsuario;
public void somarQuantidadeUsuario(){
quantidadeUsuario ++;
System.out.println(quantidadeUsuario);
}
}
---
gwt but this
On 12 oct, 17:38, Michael W mwang_2...@yahoo.com wrote:
For server side code compilation, if you use Maven, you can create
different profile to skip GWT compilation.
Or pass the gwt.compiler.skip system property: -
Dgwt.compiler.skip=true
Nevermind... It was a mismatch of 2.0.x and 2.1 jars. Apparently
there's UiBinder code in gwt-server.jar. Go figure!
-Adam
On Oct 12, 1:48 pm, Adam ambr...@gmail.com wrote:
Hey Gang,
I was hoping someone might have an idea why this is happening. I have
two projects of 8 that use UiBinder
Is there a good step-by-step tutorial on that?
Is there any technology to do that other than GWTAI?
Is there a good step-by-step tutorial on GWTAI?
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to
Hi
I have downloaded eclipse 3.6 helios. I'm trying to download GWT from
eclipse and it gives me the following exception after some period of
time:
An error occurred while collecting items to be installed
session context was:(profile=epp.package.java,
DateTimeFormat.getFormat(EEE MMM dd HH:mm:ss z ).parse(Fri Oct
30 00:00:00 EDT 2009)
throws
java.lang.IllegalArgumentException: Fri Oct 30 00:00:00 EDT 2009
at
com.google.gwt.i18n.client.DateTimeFormat.parse(DateTimeFormat.java:
1325)
at
Hi,
I am trying to embed VLC plugin to show a live streaming video from a
IP camera in a GWT web application. I am generating all html
dynamically from code. I have a DockLayoutPanel and I would like to
show the streaming video on the west side constantly. Below is a
snippet of my code to add the
Create a new store with the current selection... something like that:
ListStoreModelData newStore = new ListStoreModelData();
newStore.add(combo.getSelection());
ComboBoxModelData newBox = new ComboBoxModelData();
newBox.setStore(newStore);
On 12 Okt., 17:57, Diego Venuzka dvenu...@gmail.com
IE (78) don't work well with setInnerHTML. The same calls that work
find with FireFox and other browsers fail for IE. I've got some HTML
that is sent from the server and must be inserted into an element.
setInnerHTML always works for FF. On IE, I need to know when
setInnerHTML will fail, and what
Ouh and if you want to change the data in the second combo live you
have to set:
newStore.setMonitorChanges(true);
and you need to add an selectionChangedlistener:
combo.addSelectionChangedListener(mylistener); which updates the
models in newStore.
And as Carl already said:
when onModuleLoad() is called the system is initializing everything.
On Tue, Oct 12, 2010 at 10:53 AM, Yudji guilhermeyu...@hotmail.com wrote:
I created the class :
public class Game{
public static int quantidadeDeUsuario;
public void somarQuantidadeUsuario(){
quantidadeUsuario
Thanks, Jeff. I've uploaded a corrected version of the sample app to
the original location.
--
David Chandler
Developer Programs Engineer, GWT
Atlanta, GA USA
On Oct 12, 12:01 pm, Jeff Larsen larse...@gmail.com wrote:
The
Hi Esfand,
At present, you also need to run mvn package to ensure that
DataNucleus enhancement (attached to compile goal in the pom) runs and
that the static webapp files are moved into place under the target
directory. This will be addressed in the release version of the
plugin. Does that
Hi,
I've simple tree with some tree items. I need to copy text manually
(with mouse). When I tried to select(highlight) the part of the tree
item text(highlight), text getting unselected. It is happening only in
FIREFOX. Please help me on this issue.
Here is the sample code. Try to select the
Hi,
I want to replace triangle with + and -. How do I do that?
What is the style sheet class for these items?
thanks
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
When I look at this demo and new Cell widgets the first impression is
that those widgets wasting a lot of space. Visually the interface
absolutely not attractive. Maybe it is just my problem J ? I think even
for the demo it is unacceptable. The distance between table rows or tree
nodes is huge.
I have this existing table element in the HTML. And I want to control
it with gwt.
Is there a way just like using
myButton =
Button.wrap(RootPanel.get(myExistingHtmlButton).getElement());
like this code but for the table.
--
You received this message because you are subscribed to the Google
See this thread:
https://groups.google.com/group/google-web-toolkit/browse_thread/thread/48e5b360693b8b04/8df59494d982dcd1
--
David Chandler
Developer Programs Engineer, Google Web Toolkit
Atlanta, GA USA
On Oct 12, 4:36 pm, epoy epsil...@gmail.com wrote:
I have this existing table element in
On 12 oct, 21:51, Blackberet ramonjsanti...@gmail.com wrote:
Hi,
I want to replace triangle with + and -. How do I do that?
What is the style sheet class for these items?
It's a ClientBundle passed to the CellTree constructor. See:
In fact I did run 'mvn package' before 'mvn eclipse:eclipse'
based on your advice I read on this forum a few days ago.
I just ran the sample using 'mvn gwt:run' directly
(after running 'mvn pakage') In other words no Eclipse in
the way and interestingly the same error happened.
I'm using maven
I forgot to mention that when running 'mvn gwt:run', I see a bunch
of errors and warnings such as the following:
[WARNING] Could not transfer metadata asm:asm/maven-metadata.xml from
local.repository (file:../../local.repository/trunk):
No connector available to access repository local.repository
Ok, i going search this in the sencha.com, but i don't understand your
codecan you send a code of working example ?
Thanks 4all! =D
2010/10/12 Flori floon...@googlemail.com
Ouh and if you want to change the data in the second combo live you
have to set:
newStore.setMonitorChanges(true);
Drop in the gxt.jar, udpate files in the resources directory, then run
your app and your manual and automated (selenium) test.
If you hit any compile / runtime quirks then check the GXT forums.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit
I am having a problem being able to change the style for 2 different
instances of cell table. I have one instance that I want to make
selectable so the css has cursor:pointer; and one that isn't so it has
cursor:default;. They seem to be generated and injected with the same
class name, so any
Hi all,
I am using an enum in one of my overlay types:
public final class DefaultLevelBean implements LevelBean {
public static final LevelBean create() {
final DefaultLevelBean level = (DefaultLevelBean)
JavaScriptObject.createObject();
return level;
}
protected DefaultLevelBean()
Here's another solution:
1. Cookie the user with a UUID for each browser page instance. You can do
this either server side or client side, though I'm a bit wary of client side
UUID generation. For most intents and purposes, the possibility of a clash
is too low to worry about.
2. If the user is
http://code.google.com/p/google-web-toolkit/source/browse/?r=8664#svn/trunk/samples%3Fstate%3Dclosed
I have checked out the code from SVN for the custom written code used
in Google IO demo, but i am having trouble setting it up locally, did
any one else tried to set the project up locally ???
--
Hi,
I tried integrating SmartGWT and GWT without success.
A few months ago when I was checking it out, I found one small line on
the SmartGWT site that says that it is incompatible with GWT widgets -
you cannot use GWT widgets if you want to use SmartGWT.
Try one of the other GWT frameworks
Hi,
Did you try refactoring the code so that it's all part of the same
project?
That was the only way I could get the GWT servlets to talk to the
EJB's (There may be other ways, but I'm not aware of them).
Not ideal, but it worked for me...
Cheers,
Jin
On Oct 13, 4:18 am, Blagoja Chavkoski
http://gwt-code-reviews.appspot.com/983802/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
(right):
http://gwt-code-reviews.appspot.com/983802/diff/1/3#newcode80
dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java:80: *
Attempts to remove dead code.
Reviewers: rjrjr,
Description:
Deprecate DeferredCommand and IncrementalCommand.
Add MockScheduler.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/982802/show
Affected files:
M user/src/com/google/gwt/core/client/Scheduler.java
A
ping - I addressed the bug you found in Patch Set 2
http://gwt-code-reviews.appspot.com/971801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/971801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9029
Author: gwt.mirror...@gmail.com
Date: Mon Oct 11 12:09:16 2010
Log: Replace BidiFormatter's temporary implementation of htmlEscape with a
call to SafeHtml's escaper.
http://code.google.com/p/google-web-toolkit/source/detail?r=9029
Modified:
Revision: 9030
Author: p...@google.com
Date: Tue Oct 12 04:54:57 2010
Log: Replace I generics with T to prevent italics in javadoc.
Review at http://gwt-code-reviews.appspot.com/982801
http://code.google.com/p/google-web-toolkit/source/detail?r=9030
Modified:
LGTM
A few minor nits.
http://gwt-code-reviews.appspot.com/985801/diff/1/3
File user/src/com/google/gwt/activity/shared/ActivityMapper.java
(right):
http://gwt-code-reviews.appspot.com/985801/diff/1/3#newcode31
user/src/com/google/gwt/activity/shared/ActivityMapper.java:31: *
Returns the
Reviewers: rjrjr,
Description:
Deprecate DeferredCommand and IncrementalCommand.
Add MockScheduler.
At the risk of making myself unpopular, I think MockScheduler would
be more appropriately be named StubScheduler:
http://martinfowler.com/articles/mocksArentStubs.html
- Stephen
--
Reviewers: rchandia,
Description:
Remove 'experimental' javadoc warnings
Please review this at http://gwt-code-reviews.appspot.com/986801/show
Affected files:
M user/src/com/google/gwt/activity/shared/AbstractActivity.java
M user/src/com/google/gwt/activity/shared/Activity.java
M
Reviewers: jat,
Description:
Use Java to generate the list of packages for javadoc
Please review this at http://gwt-code-reviews.appspot.com/980803/show
Affected files:
A build-tools/doctool/src/com/google/doctool/custom/FindPackages.java
M doc/build.xml
D doc/find-packages.sh
--
Revision: 9031
Author: r...@google.com
Date: Tue Oct 12 07:55:56 2010
Log: Javadoc cleanup
Review at http://gwt-code-reviews.appspot.com/985801
Review by: p...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9031
Modified:
I assume you have tested this manually and the output is as expected.
http://gwt-code-reviews.appspot.com/980803/diff/1/2
File build-tools/doctool/src/com/google/doctool/custom/FindPackages.java
(right):
http://gwt-code-reviews.appspot.com/980803/diff/1/2#newcode111
I assume you have tested this manually and the output is as expected.
http://gwt-code-reviews.appspot.com/980803/diff/1/2
File build-tools/doctool/src/com/google/doctool/custom/FindPackages.java
(right):
http://gwt-code-reviews.appspot.com/980803/diff/1/2#newcode111
The helloMVP.zip file must have been using some of the old package
namespaces. I had to go through and fix every import. I also removed
the @Override annotations on interfaces so the project will compile on
1.5 JREs.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
My knowledge and familiarity with the workings of how CssResources are
generated is shallow, but I applied the patch here to my project and was
able to compile a module that used @font-face in the CSS.
As described in the bug report
I should add one note that although the code compiles without warning,
it does not guarantee that the font will have downloaded before the
content is displayed to the user. So there is still the possibility that
users will see fallback fonts until the webfont has downloaded.
Other than inlining
Reviewers: ,
Description:
Panel's onLoad does not call super.onLoad. This is a simple fix that
just adds the missing onLoad call.
I have another patch set which fires the attach event in
onAttach/onDetach, given these are more stable methods that user's are
less prone overriding them.
Please
Reviewers: fredsa,
Description:
Fix deobfuscation of throwables with a cause
Review by: fre...@google.com
Please review this at http://gwt-code-reviews.appspot.com/987801/show
Affected files:
M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
Index:
Reviewers: rjrjr,
Description:
Add graceful failure when a client sends a deleted EntityProxy in a
request.
Resolves GWT issue 5403.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/986802/show
Affected files:
A
I assume you have tested this manually and the output is as expected.
http://gwt-code-reviews.appspot.com/980803/diff/1/2
File build-tools/doctool/src/com/google/doctool/custom/FindPackages.java
(right):
http://gwt-code-reviews.appspot.com/980803/diff/1/2#newcode111
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/983802/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
(right):
http://gwt-code-reviews.appspot.com/983802/diff/1/3#newcode80
dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java:80: *
Attempts to remove dead code.
LGTM
http://gwt-code-reviews.appspot.com/986802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/983802/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
(right):
http://gwt-code-reviews.appspot.com/983802/diff/1/3#newcode80
dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java:80: *
Attempts to remove dead code.
LGTM.
But I would put in a TODO that we can really do better than this. A
better solution would allow disjoint sets of oracles to be refreshed
simultaneously.
http://gwt-code-reviews.appspot.com/980802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hmm... I didn't even realize AttachEvent had been added. John Ray, you
might want to take a look at this -- in the original design this super
invocation wouldn't have mattered, because widget's onLoad() was empty
(onAttach/Detach() weren't really meant to overridden outside of Panel and
Composite
Wow, that's one hell of a refactoring. I added a couple of 'taste'
comments that you're free to do with as you will; and there's one spot
where I think you're missing a 'var' or two.
No need to re-review. Once you're satisfied, feel free to submit.
Thanks, new patch.
http://gwt-code-reviews.appspot.com/983802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
FYI, I like the refactoring of JModVisitor
I have no idea how you came up with these changes other than to pick up
a huge piece of code and start setting break points in the compiler and
iterating until you fixed them. That's a difficult tasks for mere
mortal coders to repeat.
At the very
On Tue, Oct 12, 2010 at 4:07 PM, zun...@google.com wrote:
FYI, I like the refactoring of JModVisitor
Thanks!
I have no idea how you came up with these changes other than to pick up
a huge piece of code and start setting break points in the compiler and
iterating until you fixed them.
1 - 100 of 117 matches
Mail list logo
