Brian Slesinsky has posted comments on this change.
Change subject: Moves GWTTestCase to
Impl#setUncaughtExceptionHandlerForTest.
..
Patch Set 3: Code-Review+1
(5 comments)
Looking good. Some javadoc tweaks
Brian Slesinsky has posted comments on this change.
Change subject: Moves GWTTestCase to
Impl#setUncaughtExceptionHandlerForTest.
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2190
Brian Slesinsky has posted comments on this change.
Change subject: Changes StackTraceDeobfuscator to abstract and provide
various factory methods.
..
Patch Set 2:
(2 comments
Brian Slesinsky has posted comments on this change.
Change subject: Changes StackTraceDeobfuscator to abstract and provide
various factory methods.
..
Patch Set 3: Code-Review+1
--
To view, visit https://gwt
Brian Slesinsky has posted comments on this change.
Change subject: fix mismatch in Double/Float.isInfinite between dev /
production
..
Patch Set 1: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2250
Brian Slesinsky has posted comments on this change.
Change subject: Changes StackTraceDeobfuscator to abstract and provide
various factory methods.
..
Patch Set 1:
(8 comments
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2271
Change subject: Attempt to continue after the JDT compiler aborts.
..
Attempt to continue after the JDT compiler aborts
Brian Slesinsky has posted comments on this change.
Change subject: Remove early optimization from Precompile.
..
Patch Set 2: Code-Review+1
It makes sense. It seems like the only way this could break something
Brian Slesinsky has posted comments on this change.
Change subject: Changes StackTraceDeobfuscator to abstract and provide
various factory methods.
..
Patch Set 2:
(3 comments
Brian Slesinsky has posted comments on this change.
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better integration with closure compiler
which has
Brian Slesinsky has posted comments on this change.
Change subject: add Class.getSimpleName to gwt emulation
..
Patch Set 1: Code-Review+1
It won't work with obfuscation on but it seems no worse than
Class.getName
Brian Slesinsky has posted comments on this change.
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better integration with closure compiler
which has
Brian Slesinsky has posted comments on this change.
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better integration with closure compiler
which has
Brian Slesinsky has posted comments on this change.
Change subject: Avoid running JsInliner on the full JavaScript tree.
..
Patch Set 9:
(1 comment)
File dev/core/src/com
Brian Slesinsky has posted comments on this change.
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better integration with closure compiler
which has
Brian Slesinsky has posted comments on this change.
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better integration with closure compiler
which has
Brian Slesinsky has posted comments on this change.
Change subject: Avoid running JsInliner on the full JavaScript tree.
..
Patch Set 8:
(1 comment)
File dev/core/src/com
Brian Slesinsky has posted comments on this change.
Change subject: set target and source level to 1.6 for JSP compilation
..
Patch Set 2: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2201
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2200
Change subject: Add a /policies/ directory to Super Dev Mode code server.
..
Add a /policies/ directory to Super Dev Mode code
Brian Slesinsky has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 5: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2160
Brian Slesinsky has posted comments on this change.
Change subject: Moves GWTTestCase to use
Impl#setUncaughtExceptionHandlerForTest to prevent conflicts with
production handlers.
..
Patch Set 2: Code-Review+1
(6
Brian Slesinsky has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 3: Code-Review+1
(8 comments)
Seems basically okay. Thanks for writing the tests. Some
Brian Slesinsky has abandoned this change.
Change subject: Report a proper error when the JDT compiler aborts.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/2090
To unsubscribe, visit https
Brian Slesinsky has abandoned this change.
Change subject: Remove unnecessary wrapping of IOException in
DiskCacheToken. Instead, catch the exception at the artifact level and log
it with some context.
..
Abandoned
Brian Slesinsky has posted comments on this change.
Change subject: Fix a race condition in the GWTTestCase runner.
..
Patch Set 1:
Sure, we can go over it when you're here.
I don't know whether anyone is using multi-client
Brian Slesinsky has posted comments on this change.
Change subject: Adds stack traces to printStackTrace in java/lang/Throwable
emulation.
..
Patch Set 2:
(5 comments)
It's unfortunate that printStackTrace() didn't work
Brian Slesinsky has posted comments on this change.
Change subject: Fix a race condition in the GWTTestCase runner.
..
Patch Set 1:
RunStyle.initialize() returns the number of clients that will be created
Brian Slesinsky has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 1:
(9 comments)
I'm starting to like this better.
I don't quite get what you mean
Brian Slesinsky has posted comments on this change.
Change subject: Refactors StackTraceDeobfuscator as public API.
..
Patch Set 1:
(3 comments)
The public API seems mostly okay, except that if we're going to clean
things
Brian Slesinsky has posted comments on this change.
Change subject: Adds stack traces to printStackTrace in java/lang/Throwable
emulation.
..
Patch Set 3:
(2 comments)
I've realized that I'm confused. When does this code
Brian Slesinsky has posted comments on this change.
Change subject: Refactors StackTraceDeobfuscator as public API.
..
Patch Set 2:
If we move it then Googlers might start updating their subclasses to extend
the new class
Brian Slesinsky has abandoned this change.
Change subject: Fix a race condition in the GWTTestCase runner.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/2150
To unsubscribe, visit https://gwt
Brian Slesinsky has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
..
Patch Set 1:
(2 comments)
I thought about the one versus two-class solution and I don't think
Brian Slesinsky has posted comments on this change.
Change subject: bump pom.xml versions to 2.5.1
..
Patch Set 1: Verified+1
--
To view, visit https://gwt-review.googlesource.com/2140
To unsubscribe, visit https://gwt
Brian Slesinsky has posted comments on this change.
Change subject: Introduces a common SerializableThrowable and refactors
StackTraceDeobfuscator as public API.
..
Patch Set 2:
(4 comments)
I think they could be part
Brian Slesinsky has posted comments on this change.
Change subject: Refactors JVisitor to standarize access to method/field at
top of subtree.
..
Patch Set 4:
(1 comment)
Okay, fair enough
Brian Slesinsky has posted comments on this change.
Change subject: Refactors JVisitor to standarize access to method/field at
top of subtree.
..
Patch Set 4: Verified+1
(3 comments
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2090
Change subject: Report a proper error when the JDT compiler aborts.
..
Report a proper error when the JDT compiler aborts
Brian Slesinsky has posted comments on this change.
Change subject: Introduces a common SerializableThrowable and refactors
StackTraceDeobfuscator as public API.
..
Patch Set 1:
(3 comments
Brian Slesinsky has uploaded a new patch set (#2).
Change subject: Remove unnecessary wrapping of IOException in
DiskCacheToken. Instead, catch the exception at the artifact level and log
it with some context.
..
Remove
version (9738). This
is because 11338 crashes - will not load into Chrome 25.0.1364.97 m. To
say this is aggravating is an understatement. Suggestions?
On Fri, Jan 4, 2013 at 3:45 PM, Brian Slesinsky skybr...@google.comwrote:
We switched to the Chrome store fairly recently and the migration
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2020
Change subject: Remove unnecessary wrapping of IOException in
DiskCacheToken. This just increases stack trace verbosity, since the
callers either throw IOException already or could easily do so
Brian Slesinsky has posted comments on this change.
Change subject: Fix SpeedTracer Log when compilation is spread across
different processes.
..
Patch Set 1: Code-Review+1
Sure, makes sense.
--
To view, visit https://gwt
Brian Slesinsky has posted comments on this change.
Change subject: Removes deprecated checkpoint functionality from
GWTTestCase.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2001
Brian Slesinsky has posted comments on this change.
Change subject: Adds the GWT 2.5_3.0 API Checker configuration file and
creates new reference jars for api-checker.
..
Patch Set 1: Code-Review+1
(2 comments
Brian Slesinsky has posted comments on this change.
Change subject: Adds the GWT 2.5_3.0 API Checker configuration file and
creates new reference jars for api-checker.
..
Patch Set 2: Code-Review+1
(1 comment
Brian Slesinsky has posted comments on this change.
Change subject: Removes Profile code.
..
Patch Set 1: Code-Review+1
Never seen it before. It doesn't look important.
--
To view, visit https://gwt-review.googlesource.com
Brian Slesinsky has posted comments on this change.
Change subject: Removes deprecated com.google.gwt.benchmarks.*
..
Patch Set 1: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/1970
To unsubscribe, visit
Brian Slesinsky has abandoned this change.
Change subject: Make AnimationScheduler configurable and change defaults.
..
Abandoned
We went with the simpler fix for 2.5.1 and I'm unlikely to get back to this.
--
To view, visit
Brian Slesinsky has posted comments on this change.
Change subject: I18N shared APIs
..
Patch Set 6:
Hi John, do you have another patch on its way or should I review and test
this one?
--
To view, visit https://gwt
Brian Slesinsky has posted comments on this change.
Change subject: Run JsInliner only on methods that are JSNI or that contain
JSNI calls (not on the whole AST).
..
Patch Set 6: Code-Review+1
(2 comments
Brian Slesinsky has posted comments on this change.
Change subject: Overhauls the generated code that is required by
GWTTestCase to function.
..
Patch Set 2: Code-Review+1
Seems okay, but hard to tell the consequences. I
Brian Slesinsky has posted comments on this change.
Change subject: Run JsInliner only on methods that are JSNI or that contain
JSNI calls (not on the whole AST).
..
Patch Set 5:
(7 comments
Brian Slesinsky has uploaded a new patch set (#2).
Change subject: Introduce ImmutableAnnotations to reduce memory usage.
..
Introduce ImmutableAnnotations to reduce memory usage.
Most usages of the Annotations class don't
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/1920
Change subject: Introduce ImmutableAnnotations to reduce memory usage.
..
Introduce ImmutableAnnotations to reduce memory usage
Brian Slesinsky has posted comments on this change.
Change subject: Introduce ImmutableAnnotations to reduce memory usage.
..
Patch Set 1:
I don't intend any change in semantics; I'm just documenting the
preexisting
Brian Slesinsky has abandoned this change.
Change subject: Reduce devmode memory usage by not caching bytecode.
..
Abandoned
Committed.
--
To view, visit https://gwt-review.googlesource.com/1910
To unsubscribe, visit https
Brian Slesinsky has abandoned this change.
Change subject: Clear the GWT bridge to reduce severity of memory leaks.
This allows data held by generators to be freed. (Also, reduces the number
of red herrings when tracking down a memory leak
Brian Slesinsky has posted comments on this change.
Change subject: Introduce ImmutableAnnotations to reduce memory usage.
..
Patch Set 1:
Some numbers, using our largest project:
Without this change there about 480k
Brian Slesinsky has posted comments on this change.
Change subject: Prevents GWTTestCase to become zombie when communication
with backend fails.
..
Patch Set 1:
(1 comment)
Good find! But I'm not sure we're reporting
Brian Slesinsky has posted comments on this change.
Change subject: Enables wrapping of un-serializable exceptions in web mode.
..
Patch Set 1: Code-Review+1
(3 comments
Brian Slesinsky has posted comments on this change.
Change subject: Prevents GWTTestCase to become zombie when communication
with backend fails.
..
Patch Set 1: Code-Review+1
(2 comments
Brian Slesinsky has posted comments on this change.
Change subject: Deprecates com.google.gwt.benchmark.*.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/1900
To unsubscribe, visit https
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/1910
Change subject: Reduce devmode memory usage by not caching bytecode.
..
Reduce devmode memory usage by not caching bytecode
Brian Slesinsky has posted comments on this change.
Change subject: Enables wrapping of un-serializable exceptions in web mode.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/1890
Brian Slesinsky has posted comments on this change.
Change subject: Reduce devmode memory usage by not caching bytecode.
..
Patch Set 1:
(1 comment)
File dev/core/src/com
Brian Slesinsky has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
..
Patch Set 3: Code-Review+1
(1 comment)
Seems fine
Brian Slesinsky has posted comments on this change.
Change subject: Introduces GWT#maybeReportUncaughtException.
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/1820
To unsubscribe, visit
Brian Slesinsky has uploaded a new patch set (#2).
Change subject: Reduce devmode memory usage by not caching bytecode.
..
Reduce devmode memory usage by not caching bytecode.
Instead of caching bytecode in a byte[] array
Brian Slesinsky has abandoned this change.
Change subject: Updates ICU4J from 4.4.2 to 50.1.1
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/1700
To unsubscribe, visit https://gwt
Brian Slesinsky has abandoned this change.
Change subject: Add a webApiUsage property to control whether prefixed
API's will be used.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/1840
Brian Slesinsky has posted comments on this change.
Change subject: Missing overrides in JNonNullType made signatures for same
types differ.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gwt
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/1870
Change subject: Clear the GWT bridge to reduce severity of memory leaks.
This allows data held by generators to be freed. (Also, reduces the number
of red herrings when tracking down a memory
Brian Slesinsky has posted comments on this change.
Change subject: Issue 7834 - fix BigDecimal compareTo
..
Patch Set 5: Code-Review+1
(1 comment)
Seems fine, and definitely simpler
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/1840
Change subject: Add a webApiUsage property to control whether prefixed
API's will be used.
..
Add a webApiUsage property
Brian Slesinsky has posted comments on this change.
Change subject: Add a webApiUsage property to control whether prefixed
API's will be used.
..
Patch Set 1:
Starting over with the simple version.
--
To view, visit https
Brian Slesinsky has posted comments on this change.
Change subject: Add a webApiUsage property to control whether prefixed
API's will be used.
..
Patch Set 1:
(1 comment
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Brian Slesinsky has posted comments on this change.
Change subject: Add a webApiUsage property to control whether prefixed
API's will be used.
..
Patch Set 1:
(1 comment
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/1821
Change subject: Shard UiSuite to make the smoke tests faster.
..
Shard UiSuite to make the smoke tests faster.
Change-Id
Brian Slesinsky has posted comments on this change.
Change subject: Shard UiSuite to make the smoke tests faster.
..
Patch Set 1:
(1 comment)
File user/test/com/google/gwt
Brian Slesinsky has uploaded a new patch set (#4).
Change subject: Make AnimationScheduler configurable and change defaults.
..
Make AnimationScheduler configurable and change defaults.
The new properties
Brian Slesinsky has abandoned this change.
Change subject: Shard UiSuite to make the smoke tests faster.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/1821
To unsubscribe, visit https://gwt
Brian Slesinsky has posted comments on this change.
Change subject: Make AnimationScheduler configurable and change defaults.
..
Patch Set 3:
(2 comments)
File user/src
Brian Slesinsky has posted comments on this change.
Change subject: Make AnimationScheduler configurable and change defaults.
..
Patch Set 4:
I think Gotug has a good point; since we're unlikely to see another bad bug
Brian Slesinsky has posted comments on this change.
Change subject: Make AnimationScheduler configurable and change defaults.
..
Patch Set 4:
But that seems unusable for anyone using lots of locales? (Due to the N*M
problem
Brian Slesinsky has posted comments on this change.
Change subject: Make AnimationScheduler configurable and change defaults.
..
Patch Set 4:
Hmm. It looks like we tried and failed to use soft permutations before:
https
Brian Slesinsky has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
..
Patch Set 1:
(6 comments
Brian Slesinsky has posted comments on this change.
Change subject: Fixes internal compiler error caused by a null logger
parsing jsni code that was generated by a generator at test time.
..
Patch Set 1:
(1 comment
Brian Slesinsky has posted comments on this change.
Change subject: Fixes internal compiler error caused by a null logger
parsing jsni code that was generated by a generator at test time.
..
Patch Set 2: Code-Review+1
Brian Slesinsky has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
..
Patch Set 1:
(1 comment
...@google.com
Gerrit-Reviewer: Brian Slesinsky skyb...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit
Brian Slesinsky has posted comments on this change.
Change subject: Proxy IDs have to be the same for a given proxy in the
response payload.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gwt
Brian Slesinsky has posted comments on this change.
Change subject: Currently the GWT compiler adds a var declaration for each
catch parameter in a try/catch statement, but this is unneeded according to
the spec, and the Closure compiler will issue errors against
...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group
Brian Slesinsky has posted comments on this change.
Change subject: Issue 7834 - fix BigDecimal compareTo
..
Patch Set 2:
(3 comments)
Could you simplify this code? I don't see the bug either
I've tried it recently with Chrome 25. You've checked the source maps on
checkbox and reloaded the page?
On Tuesday, January 22, 2013 1:08:41 PM UTC-8, Daniel Kurka wrote:
I can`t seem to get source maps working with Chrome 24.
Is it just me or is there still something off?
On Friday,
Brian Slesinsky has uploaded a new patch set (#2).
Change subject: Make AnimationScheduler configurable and change defaults.
..
Make AnimationScheduler configurable and change defaults.
The new properties
Brian Slesinsky has uploaded a new patch set (#3).
Change subject: Make AnimationScheduler configurable and change defaults.
..
Make AnimationScheduler configurable and change defaults.
The new properties
Brian Slesinsky has posted comments on this change.
Change subject: Make AnimationScheduler configurable and change defaults.
..
Patch Set 1:
(4 comments)
File user/src
201 - 300 of 395 matches
Mail list logo
