tried to change the hosted.html file but
there is no change.
Itzik
On Jan 9, 6:04 pm,Stevkoandy.ste...@gmail.com wrote:
I've managed to get my application to work in an external iframe by
editing the hosted.html file and changing line 226
from
var topWin = window.top;
to
var topWin
I have the same issue, I've tried to change the hosted.html file but
there is no change.
Itzik
On Jan 9, 6:04 pm, Stevko andy.ste...@gmail.com wrote:
I've managed to get my application to work in an external iframe by
editing the hosted.html file and changing line 226
from
var topWin
Hi. We have an arrangement where a publisher of various sites displays
our content in an iFrame. What we are trying to do using GWT is to
validate whether the iframe (and our content) is actually visible in
the window (screen) or whether somebody scrolls and the iframe comes
into view
Hi. I did ask this question this morning but it doesn't look like it
went through. Anyway...
We have a website where we provide content and we have agreed to
provide this content to a publisher (who has numerous websites) who
will display our content in an iFrame (please note, this is cross
Hi everyone! I have put my GWT application in an iframe called
mainIframe. When the application-server starts I want to load the
contents of some database tables into a javascript dictionary which I
have put in a dedicated iframe, called staticIframe. My question is;
How can I access
application in an iframe called
mainIframe. When the application-server starts I want to load the
contents of some database tables into a javascript dictionary which I
have put in a dedicated iframe, called staticIframe. My question is;
How can I access the javascript contents
I've managed to get my application to work in an external iframe by
editing the hosted.html file and changing line 226
from
var topWin = window.top;
to
var topWin = window.self;
This is the context...
gwtOnLoad = function(errFn, modName, modBase){
$moduleName = modName;
$moduleBase = modBase
On Jan 7, 12:23 am, John Tamplin j...@google.com wrote:
What about the case of multiple instances of the same module?
How about simply using Document.get().createUniqueId() ?
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
createUniqueId() guarantees a unique id for the document, but makes no
guarantees about uniqueness within the global namespace ($wnd). I think it
would be a worthwhile addition to create such a method in the future,
though.
On Thu, Jan 7, 2010 at 4:12 AM, Thomas Broyer t.bro...@gmail.com wrote:
such a method in the future,
though.
And to that point, we are generating a unique name for the hidden iframe,
not a unique ID. I'm not sure what effect it would have to have names that
are not unique in the global namespace.
Thanks,
John LaBanca
jlaba...@google.com
On Thu, Jan 7, 2010 at 9:24 AM
,
though.
And to that point, we are generating a unique name for the hidden iframe,
not a unique ID. I'm not sure what effect it would have to have names that
are not unique in the global namespace.
I'm an idiot, sorry. This is for the 'name' attribute of a form panel, not a
global variable. I'm
On Wed, Jan 6, 2010 at 5:05 PM, codesite-nore...@google.com wrote:
Revision: 7364
Author: jlaba...@google.com
Date: Wed Jan 6 14:04:31 2010
Log: Adds the module name to the generated ID of FormPanel's iframe to
ensure that IDs are unique across modules.
Patch by: jlabanca
Review by: jgw
Hi ... we have a GWT 1.5 application that launches another GWT
application (plugin) in an iframe. The main application communicates
to the embedded plugin using JNI calls. We are trying to upgrade to
2.0 but have run into the following issues.
1) We can debug the main application via the browser
Hey, Matt,
I've now double checked on several browsers other than Opera, and I
agree that onerror works on non-IE and onreadystatechange works on IE.
Details here:
http://blog.lexspoon.org/2009/12/detecting-download-failures-with-script.html
One tricky aspect is that I don't see how to get IE
On Tue, Dec 15, 2009 at 2:48 PM, Lex Spoon sp...@google.com wrote:
Ideas would be welcome about how to deal with that.
Could the fragments include some JS at the end which calls a well-known I
loaded successfully method?
--
John A. Tamplin
Software Engineer (GWT), Google
--
On Tue, Dec 15, 2009 at 2:53 PM, John Tamplin j...@google.com wrote:
On Tue, Dec 15, 2009 at 2:48 PM, Lex Spoon sp...@google.com wrote:
Ideas would be welcome about how to deal with that.
Could the fragments include some JS at the end which calls a well-known I
loaded successfully method?
On 15-Dec-09, at 12:48 PM, Lex Spoon wrote:
I've now double checked on several browsers other than Opera, and I
agree that onerror works on non-IE and onreadystatechange works on IE.
Details here:
http://blog.lexspoon.org/2009/12/detecting-download-failures-with-script.html
One tricky
On Dec 14, 8:57 am, David david.no...@gmail.com wrote:
Hi,
I was assuming that the IFrame behind the popup panel trick was going
to be removed in this release, just as were some other IE6 tricks for
ImageBundles.
I looked in the code and I realized that this is not the case.
Why
Reviewers: jgw,
Description:
FormPanel assigns names to hidden iframes using a static counter. If a
page loads multiple GWT apps, the names will not be unique.
Fix:
We now increment an expando on $wnd instead.
Testing:
Manually verified the fix.
Also, I re-enabled FormPanelTest
Isn't it technically possible for multiple apps to have the same module
name? For example, I can image an app where the user customizes the
interface, and includes the same app twice.
Thanks,
John LaBanca
jlaba...@google.com
On Mon, Dec 14, 2009 at 5:49 PM, knor...@google.com wrote:
On Mon, Dec 14, 2009 at 5:50 PM, John LaBanca jlaba...@google.com wrote:
Isn't it technically possible for multiple apps to have the same module
name? For example, I can image an app where the user customizes the
interface, and includes the same app twice.
Yes, absolutely.
--
John A.
No, if two modules with the same name load, it's only through luck:
Here's one example of why:
http://code.google.com/p/google-web-toolkit/source/browse/trunk/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js#90
/kel
On Mon, Dec 14, 2009 at 5:50 PM, John LaBanca jlaba...@google.com
http://gwt-code-reviews.appspot.com/125801/diff/1/4
File user/src/com/google/gwt/user/client/ui/FormPanel.java (right):
http://gwt-code-reviews.appspot.com/125801/diff/1/4#newcode298
Line 298: /**
Rather than polluting $wnd even more, why not make the id:
FormPanel_ + GWT.getModuleName() +
Hi,
I was assuming that the IFrame behind the popup panel trick was going
to be removed in this release, just as were some other IE6 tricks for
ImageBundles.
I looked in the code and I realized that this is not the case.
Why is this a problem for me: we see a 500ms slowdown everytime we use
On Wed, Dec 9, 2009 at 12:47 PM, Matt Mastracci matt...@mastracci.com wrote:
Do you know how to get onerror to fire in IE? It didn't seem to work in my
testing.
No, but why do you need it if you have onreadystatechanged? It should
be no problem to hook up both callbacks.
Lex
--
On 9-Dec-09, at 1:55 PM, Lex Spoon wrote:
On Wed, Dec 9, 2009 at 12:47 PM, Matt Mastracci
matt...@mastracci.com wrote:
Do you know how to get onerror to fire in IE? It didn't seem to
work in my
testing.
No, but why do you need it if you have onreadystatechanged? It should
be no
On Mon, Nov 30, 2009 at 10:28 PM, Matt Mastracci matt...@mastracci.com wrote:
2. onerror works some of the time in some of the browsers. It fails on
various combinations of resolve errors, error status codes and other failure
conditions. For all browsers (except Opera) that don't support it
Ray/Lex,
I'm starting to think that the dynamic iframe might not be a bad first
approach to this problem either. A single linker would be able to
provide cross-domain-capable, multi-module-safe code that doesn't
require any additional post-processing to support loading of
fragments
is that iframes
don't work reasonably on iPhones. So, we need to support non-iframe
linkers for at least some use cases.
Lex
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
don't know all the reasons why, but one example reason is that iframes
don't work reasonably on iPhones. So, we need to support non-iframe
linkers for at least some use cases.
Lex
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
(Reposting to get it on the mailing list; first try bounced.)
Hey, Matt,
I agree with your analysis about the code-splitting issues.
I've worked out a preliminary patch to do var renaming, but I haven't
shared it yet because it's in a pretty early state. I could share it
if you or someone is
Lex,
JSONP loading + dynamic iframe seems like a straightforward viable option
that doesn't require a lot of complicated compiler work, what do you think
of providing this as an option?
-Ray
On Mon, Nov 30, 2009 at 12:29 PM, Lex Spoon sp...@google.com wrote:
(Reposting to get
Sure, I'd love to take a look at it. I've got a basic version of
globally-scoped, cross-domain code-splitting up and running that uses
simple script-tags for the cross-domain load right now.
Re: script tag error reporting. In my investigations, this has been
particularly bad and highly
.
Here's a summary of the linking options that I know of. I've added in
an alternative iframe linker that doesn't load HTML from a remote
source, but dynamically constructs the iframe contents and injects the
scripts into it:
1. Monolithic iframe (IFrameLinker):
Supports multimodule: Yes
Hey all,
If I recall correctly, the original reason that GWT used iframe-
wrapped scripts was to work around the buggy compression of Javascript
some early versions of IE (example:
http://support.microsoft.com/default.aspx?scid=kb;en-us;823386Product=ie600)
.
The number of users on IE 6 SP1
I think this is a good direction to be heading in. It's a bit non-trivial,
though, because the plugin expects to be nested in an iframe. I'm sure
that's solvable, but it will be some work.
On Tue, Nov 24, 2009 at 6:38 PM, Matt Mastracci matt...@mastracci.comwrote:
Hey all,
If I recall
it would work, because it seems to me that changes to
the non-GWT-History iframe can affect the browser's own
history without informing the GWT History mechanism. However, until I
actually try what you are
suggesting, I can't be sure that it would not work; it may be that
when the change to the contents
Revision: 6891
Author: br...@google.com
Date: Fri Nov 13 09:04:35 2009
Log: Makes the missing plugin iframe take up the entire window for a
reasonably nice look that works across browsers.
Change by: bruce
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6891
(div);
On 2009/11/13 16:55:51, jat wrote:
Why topDoc instead of $doc? Do you really want it stepping outside of
this
iframe?
This is the incantation that seemed to work most reliably on IE6 to get
rid of the yucky iframe border. I didn't really investigate too much
why or if there could
Revision: 6892
Author: br...@google.com
Date: Fri Nov 13 09:24:32 2009
Log: Merges tr...@6891 into this branch to make missing plugin iframe
prettier in hosted.html and updated missing plugin url to point to
appspot.com
http://code.google.com/p/google-web-toolkit/source/detail?r=6892
(right):
http://gwt-code-reviews.appspot.com/102815/diff/1002/3#newcode35
Line 35: var iframeDiv = topDoc.createElement(div);
On 2009/11/13 16:55:51, jat wrote:
Why topDoc instead of $doc? Do you really want it stepping outside of
this
iframe?
This is the incantation that seemed to work
On Mon, Nov 9, 2009 at 8:51 PM, Joel Webber j...@google.com wrote:
And just to be clear, we recognize that it's a real problem, but I think
it's going to take some time to work out how to shove the iframe shim in, in
such a way that it doesn't break existing code (the IE6/7 implementation
LGTM. Thanks.
http://gwt-code-reviews.appspot.com/97807/diff/3/1002
File user/src/com/google/gwt/user/client/ui/impl/PopupImplIE6.java
(right):
http://gwt-code-reviews.appspot.com/97807/diff/3/1002#newcode71
Line 71: private native void do_onHide(Element popup) /*-{
I know these are private,
Sorry to jump in without having been invited but, given
http://code.google.com/p/google-web-toolkit/issues/detail?id=805 (among
others), shouldn't the iframe shim be extended to all browsers instead?
(Closure-library seems to be doing just this; or actually, it moves the
responsibility
On 2009/11/09 14:34:54, t.broyer wrote:
Sorry to jump in without having been invited but, given
http://code.google.com/p/google-web-toolkit/issues/detail?id=805
(among others),
shouldn't the iframe shim be extended to all browsers instead?
(Closure-library seems to be doing just
On 2009/11/09 14:49:12, jgw wrote:
On 2009/11/09 14:34:54, t.broyer wrote:
Sorry to jump in without having been invited but, given
http://code.google.com/p/google-web-toolkit/issues/detail?id=805
(among
others),
shouldn't the iframe shim be extended to all browsers instead?
(Closure
I'm not a code reviewer... but just a useful comment:
You might want to move the isIE6 method somewhere else so that you
could avoid the memory leak on ie7/ie8 when using ImageBundles as
well.
For ie7 and ie8 this workaround to get transparent PNGs working is no
longer needed and it's leaking a
Agreed -- we're going to do precisely that. I think we'll probably end up
sticking isIE6() in the image bundle code for the moment, as Bob has a
better general solution in the pipeline (which he calls soft permutations).
But yes, the image bundle insanity on IE6 is the more important of the two
onShow(Element popup) /*-{
+
+ private native void do_onShow(Element popup) /*-{
// TODO: make this more Java and less JSNI?
var frame = $doc.createElement('iframe');
@@ -82,8 +125,7 @@ public class PopupImplIE6 extends PopupImpl {
popup.parentElement.insertBefore(frame, popup
And just to be clear, we recognize that it's a real problem, but I think
it's going to take some time to work out how to shove the iframe shim in, in
such a way that it doesn't break existing code (the IE6/7 implementation
takes advantage of CSS expressions to keep the iframe positioned correctly
I'm trying out GWT 2.0 MS2, and I just hit an unexpected behavior: I
removed the __gwt_historyFrame iframe that's used for History
management to check what error message I'd get -- but Alt+Backspace
seemingly kept working!? I tried out some Hyperlinks, and everything
(back, forward) runs OK... am
I am developing an application that uses an iFrame to display help
page content, while keeping the main page (which contains my GWT
widgets) unchanged. This is being done to preserve the state of the
GWT widgets while various help pages are viewed by the user.
The fundamental problem
...@cowlark.com wrote:
David Given wrote:
I want to embed a mini web browser into my app (for help text). I've
seen this done before on other sites. I want to load the help pages into
an iframe, and then use GWT widgetry to listen for onload events,
determine the page title, go forwards and back
ThomasWrobel wrote:
Id like to know this too.
I'm not sure if its even possible for the parent frame to know the url
of the child frame if it changes.
My experiments always resulted in getting the initial url it was set
too, and not the new one since the user clicked.
Looking at the EyeOS
David Given wrote:
I want to embed a mini web browser into my app (for help text). I've
seen this done before on other sites. I want to load the help pages into
an iframe, and then use GWT widgetry to listen for onload events,
determine the page title, go forwards and back, and remotely
I want to embed a mini web browser into my app (for help text). I've
seen this done before on other sites. I want to load the help pages into
an iframe, and then use GWT widgetry to listen for onload events,
determine the page title, go forwards and back, and remotely set the URL.
I've looked
Anyone has some insights on this problem?
Thanks!
On Sep 15, 8:38 pm, Ben benzhe...@gmail.com wrote:
I have a problem related to iFrame andJSNIproblem. Basically the
scenario is like this:
I have an application written in GWT and in this application I have an
iFrame and the page inside
I have a problem related to iFrame and JSNI problem. Basically the
scenario is like this:
I have an application written in GWT and in this application I have an
iFrame and the page inside iFrame is in the same domain as my GWT
application. When the iFrame content finishes loading, I need
ben fenster wrote:
your answear is based on your knolage in js but i need an answear
based on actual in depth knowlage in how browser work since each
iframe act as an independed wep page and loaded sepertly
No, you misunderstand --- if your code can see an iframe, that iframe
must be part
ok thats sounds right but if thats true can i access static classes
in the entrypoint module from a seperate module loaded in an iframe
(that ofcours exists in the first module) ?
On 3 ספטמבר, 03:00, David Given d...@cowlark.com wrote:
ben fenster wrote:
your answear is based on your knolage
ben fenster wrote:
ok thats sounds right but if thats true can i access static classes
in the entrypoint module from a seperate module loaded in an iframe
(that ofcours exists in the first module) ?
Javascript will let you do it, provided the security rules let you (the
page in the iframe
There is just 1 JS thread. Regardless of URL or IFrame.
The limit of max 2 connections is purely based on URL, not on per
IFrame basis. IE8 allows more than 2, I forgot the exact number.
To work around the connections limit you can spread web resources over
different hosts in the same domain
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
ben fenster wrote:
i was wondering that if by opening another module in an iframe tag the
code of that module runs in another thread ??
Nope. There is no way of getting access to multiple Javascript threads
from a web browser, unless you use some
i was wondering that if by opening another module in an iframe tag the
code of that module runs in another thread ??
more over is the limit of 2 open http request apply on 2 diffrent
modules running in diffrent iframes ??
--~--~-~--~~~---~--~~
You received
another thing about the http request limitation most browsers rejects
more then 2 simultinus requests to a spacific url and i wondered i
its aplays to 2 diffrent browser windows (diffrent process in new
browsers) and if iframe acts as new web page maybe the limitation
grows by 2 for each iframe
your answear is based on your knolage in js but i need an answear
based on actual in depth knowlage in how browser work since each
iframe act as an independed wep page and loaded sepertly then the
containing page made me wonder about how its being done without a
diffrent thread ?
and if another
By default, GWT already loads itself into an iFrame. I believe that
the XS linker does that as well. You don't need to do anything extra.
-jason
On Aug 24, 2009, at 3:05 AM, John O'Conner wrote:
I've searched the GWT discussion group, but I haven't found an answer.
As a newb with GWT, I
GWT code compiled with the standard linker is in an iframe but the RootPanel
and widgets are in the original document.
You could hack and redefine the RootPanel pointing to the iframe's document
but I dont think this is a good idea because you should to redefine $wnd,
$doc and write several JSNI
on a
different domain. I'd like to load my application into a separate
iframe which doesn't exist in their document. So, I think my entry
point needs to create a new iframe and load itself into that iframe.
My initial thought is that I probably need TWO entry points to
accomplish this:
1. the first
lgtm, w/ just one random comment.
http://gwt-code-reviews.appspot.com/61805/diff/1/2
File dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
(right):
http://gwt-code-reviews.appspot.com/61805/diff/1/2#newcode276
Line 276: // look for the old query parameter if we don't find the new
Revision: 5981
Author: j...@google.com
Date: Thu Aug 20 10:42:37 2009
Log: Correct a problem with showing the troubleshooting iframe, add support
for
renamed query parameter (while retaining backwards compatibility for now).
Patch by: jat
Review by: knorton
http://code.google.com/p/google-web
Reviewers: jgw, knorton,
Description:
This patch fixes the issue Kelly found where the iframe used to display
an OOPHM troubleshooting page might not be ready to redirect to the URL.
The fix is to simply specify the URL when the iframe is created, as the
javascript:'' hack is not needed here
I can verify this issue when the GWT application is loaded within an
iframe that's not currently displayed.
On Jul 15, 3:10 pm, T somevow...@gmail.com wrote:
When embedding a GWT application in an iframe it looks like some of
the functions expected by widgets (like the absolute panel) don't
I dont know if its the best solution for what your doing, but Ive
certainly used the same and it seems to work.
The key is you gota use native javascript commands to communicate
between the inner/outer gwt. (if you need to do that at all)
On Aug 10, 9:19 am, Saeed Zarinfam zarinfa...@gmail.com
I have some problem regarding IFrame issue. When loading the IFrame,
the object of IFrame will be stored in the Map. Each time when i get
the same object for the IFrame from the Map, It reloads again. It
doesn't reload in the IE but It does in Firefox. How can I do to
prevent IFrame from
Hi
A friend suggest me use Frame widget for loading a GWT module in
another GWT module. I want to know is this a best solution for me. I
want to build an application that load GWT modules and manage in (like
a gadget container).
thanks.
--~--~-~--~~~---~--~~
You
native void scrollIt(Element frame, int px) /*-{
frame.style.top=px;
}-*/;
I have searches for both javaScript and GWT solutions. I know its
possible to scroll an iframe from the parent window as seen in this
java script example: http://jdstiles.com/java/iframe_ticker.html
Any help
Dear
I have set the iframe to the Panel using the Panal setHtml method as follows
editPanel.setHtml(
center +
brbr +
iframe name='+iFrameName+' id='+iFrameName+'
scrolling='yes' +
src= + urlVM + width
.
-= Mat
On Thu, Jul 16, 2009 at 4:27 PM,tintin.pavli...@gmail.com wrote:
I am writing a GWT app that involves interacting with an external
document in an iframe. As a proof of concept, I am trying to attach a
click handler to a button.
The following works in javascript
var iframe
in an iframe. As a proof of concept, I am trying to attach a
click handler to a button.
The following works in javascript
var iframe = document.getElementById(rawJSIFrame);
var doc = iframe.contentDocument;
var body = doc.body;
var button = doc.getElementsByTagName(input).namedItem(submit
Hi everyone,
I am writing a GWT app that involves interacting with an external
document in an iframe. As a proof of concept, I am trying to attach a
click handler to a button.
The following works in javascript
var iframe = document.getElementById(rawJSIFrame);
var doc
When embedding a GWT application in an iframe it looks like some of
the functions expected by widgets (like the absolute panel) don't
work. For example, the DOMImplMozilla.class overrides the
DOMImpl.class (which just returns 0) as follows:
@Override
public native int getBodyOffsetLeft(Document
LGTM
http://gwt-code-reviews.appspot.com/48808
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On 2009/07/08 20:47:56, scottb wrote:
LGTM
Committed at r5691.
http://gwt-code-reviews.appspot.com/48808
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: j...@google.com
Date: Wed Jul 8 14:29:31 2009
New Revision: 5691
Modified:
trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
trunk/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Reverting XHR changes to the std (iframe) linker.
This patch
Solution! On the application's HTML page, instead of creating the
iframe with id=__gwt_downloadFrame, use a div, like so:
body
!-- For the DownloadIFrame widget. --
div id=__gwt_downloadFrame/div
!-- For the rest of my application loads here. --
div id
When I bring up the URL in the Frame the page just refreshes over and
over again, has anyone seen this before?
OpenXava uses AJAX, I'm not sure if that is the issue, is there a way
to get around the continuous refreshing?
--~--~-~--~~~---~--~~
You received this
to 0 in the css. I think this is because of iframe has
a separate frameborder attribute. How can I set this attribute? I
don't see the function in Frame, there is one in IFrameElement, but I
can't figure out how to go from Frame to IFrameElement
Hi,
I'm using com.google.gwt.user.client.ui.Frame to embed an external
url. There seem to be a small inset border even though I have
everything set to 0 in the css. I think this is because of iframe has
a separate frameborder attribute. How can I set this attribute? I
don't see the function
) {
}
}
On my application's HTML page, I have
iframe src=javascript:'' id=__gwt_downloadFrame tabIndex='-1'
style=position:absolute;width:0;height:0;border:0/iframe
My application is loaded into a separate div
Any ideas how to make this work in IE and Safari
/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Rolling tr...@5393 out of this branch. The IFRAME XHR change is broken on
IE6 hosted and Safari 3.
Modified: branches/snapshot-2009.05.12-r5406/branch-info.txt
Author: j...@google.com
Date: Fri May 15 11:21:57 2009
New Revision: 5393
Modified:
trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
trunk/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Changes the IFrame linker to use an XHR to fetch the compiled
Good catch on the 10k p tags thing. Turns out there was a missing
check for 'bodyDone' in maybeStartModule().
http://gwt-code-reviews.appspot.com/33808/diff/1/3
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (left):
http://gwt-code-reviews.appspot.com/33808/diff/1/3#oldcode284
LGTM++
A few new spacing issues showed up. It could be tabs.
http://gwt-code-reviews.appspot.com/33808/diff/1005/1007
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):
http://gwt-code-reviews.appspot.com/33808/diff/1005/1007#newcode47
Line 47: // The frame that will
candidate for 1.6.5?
On Thursday, May 14, 2009, knor...@google.com wrote:
LGTM++
A few new spacing issues showed up. It could be tabs.
http://gwt-code-reviews.appspot.com/33808/diff/1005/1007
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):
Kinda scary if you ask me. I *believe* it works everywhere, and have good
evidence of it, but still -- if something turns out to be subtly wrong, we
can patch google3, but 1.6.(N5) would be, uh, unpleasant.
On Thu, May 14, 2009 at 12:38 PM, Bruce Johnson br...@google.com wrote:
candidate for
lgtm - and I confirmed parallel on ff3 on os x.
http://gwt-code-reviews.appspot.com/33808/diff/1/3
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (left):
http://gwt-code-reviews.appspot.com/33808/diff/1/3#oldcode284
Line 284: iframe.id = __MODULE_NAME__;
Why was this here? I
Found one thing:
Expanded the host page w/ 10,000 p tags. Turned on 28.8 throttling and
managed to get Showcase's UI injected about 2/3 of the way down the page
amongst the p tags. I would've expected it to be the last element.
http://gwt-code-reviews.appspot.com/33808
Reviewers: knorton, scottb, bruce,
Description:
Changes IFrameLinker to cause the compiled script to load in parallel
with other scripts. It does this by using XMLHttpRequest to fetch the
compiled script, rather than waiting on the injected iframe to load it
(this is the approach described
Also forgot to add that I confirmed the parallel script-fetching
behavior using the Charles proxy in throttled mode and a large external
Javascript file.
http://gwt-code-reviews.appspot.com/33808
--~--~-~--~~~---~--~~
201 - 300 of 337 matches
Mail list logo
