Since 1.6 is currently red, I can't prove that it passes. Yet. I'll hold
it 'til I can...
On Tue, Jan 20, 2009 at 10:09 PM, Scott Blum wrote:
> No need to review if it passes and is a clean merge.
>
>
> On Tue, Jan 20, 2009 at 9:59 PM, Freeland Abbott <
> gwt.team.fabb...@gmail.com> wrote:
>
>
Jarjar is a trunk issue that I believe is unrelated.
On Tue, Jan 20, 2009 at 10:08 PM, John Tamplin wrote:
> On Tue, Jan 20, 2009 at 9:41 PM, Scott Blum wrote:
>
>> Thanks, nicolas. Your test reproduced an issue, but I was unable to get
>> Tomcat to work properly. We will probably not fix thi
No need to review if it passes and is a clean merge.
On Tue, Jan 20, 2009 at 9:59 PM, Freeland Abbott wrote:
> @Scott,
> Perhaps an exercise in barn door closing, but this patch pulls LinkerSuite
> from trunk to 1.6.
>
>
>
--~--~-~--~~~---~--~~
http://groups.goog
On Tue, Jan 20, 2009 at 9:41 PM, Scott Blum wrote:
> Thanks, nicolas. Your test reproduced an issue, but I was unable to get
> Tomcat to work properly. We will probably not fix this for 1.6 since Jetty
> works fine.
> http://code.google.com/p/google-web-toolkit/issues/detail?id=1032
>
Actually
@Scott,
Perhaps an exercise in barn door closing, but this patch pulls LinkerSuite
from trunk to 1.6.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
linkertest-r4506.patch
Thanks, nicolas. Your test reproduced an issue, but I was unable to get
Tomcat to work properly. We will probably not fix this for 1.6 since Jetty
works fine.
http://code.google.com/p/google-web-toolkit/issues/detail?id=1032
Scott
On Tue, Jan 20, 2009 at 10:44 AM, nicolas de loof
wrote:
> You
Author: j...@google.com
Date: Tue Jan 20 16:55:55 2009
New Revision: 4506
Modified:
trunk/dev/oophm/src/com/google/gwt/dev/shell/BrowserListener.java
Log:
Catch the case of a failure to start the browser listener and avoid NPE, so
the
log message stays visible.
Patch by: jat
Review by: bo
ClassPathEntry: update @return on line 33
PathPrefixSet:
- slightly dangerous to overload modCount this way
- Needs format
- Use javadoc on field comments, not single-line non-javadoc comments
ResourceOracleImpl
- Single-line multi-line comment on 305
- Comment for globalResourceToPrefixMap?
- Let
The end game for Jetty is to probably move it out of gwt-dev into a separate
jar.
On Tue, Jan 20, 2009 at 7:43 PM, Miroslav Pokorny <
miroslav.poko...@gmail.com> wrote:
>
> Your problem is because the jetty classes have been re-packaged under
> com.goolgle.gwt.thirdparty etc but somewhere there's
Bob, could you review trunk/r4506? It was a trivial change to add a null
check arounjd starting the BrowserListener thread so that if an exception
occurred during initialization (which would be logged), an NPE prevented the
user from reading it. One common cause would be starting a second OOPHM
s
On Tue, Jan 20, 2009 at 11:15 AM, Jack Yang wrote:
> Yes, I truly understand your considerations about the confusing of setting
> the alignment of the widget itself. When I asked myself what might be your
> reason on not having these methods for alignment I think of this point. But,
> I think thi
Author: fabb...@google.com
Date: Tue Jan 20 15:06:01 2009
New Revision: 4504
Modified:
releases/1.6/dev/core/src/com/google/gwt/core/linker/SingleScriptLinker.java
releases/1.6/dev/core/src/com/google/gwt/core/linker/XSLinker.java
Log:
buildbreak fix, that onScriptLoad needs to be give
Your problem is because the jetty classes have been re-packaged under
com.goolgle.gwt.thirdparty etc but somewhere there's some reflection
code try to instantiate a jetty class using it's org.mortbay name. The
class name must be coming from a string or text file which
unfortunately did not
Yes, I truly understand your considerations about the confusing of
setting the alignment of the widget itself. When I asked myself what
might be your reason on not having these methods for alignment I think
of this point. But, I think this is the wrong way. In my opinion, GWT
should aim to encapsu
Yes, I truly understand your considerations about the confusing of setting
the alignment of the widget itself. When I asked myself what might be your
reason on not having these methods for alignment I think of this point. But,
I think this is the wrong way. In my opinion, GWT should aim to encapsul
Got the same problem, the project skeleton created by WebAppCreator
failed to execute
Seems to be a CL issue
Any idea ?
conf -> Windows XP r4505
Sami
2009-01-21 01:13:39.299::INFO: Logging to STDERR via
com.google.gwt.thirdparty.org.mortbay.log.StdErrLog
2009-01-21 01:13:39.339::INFO: jet
Author: sco...@google.com
Date: Tue Jan 20 14:51:34 2009
New Revision: 4502
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/Compiler.java
releases/1.6/dev/core/src/com/google/gwt/dev/GWTCompiler.java
Log:
Fixed a bug where compiling from hosted mode would fail to refresh module
Author: fabb...@google.com
Date: Tue Jan 20 13:25:41 2009
New Revision: 4499
Modified:
trunk/dev/core/src/com/google/gwt/util/tools/Utility.java
Log:
Merged a fix to tmpdir creation, so the gwt-tmp layer can't create
permission errors
Review by: scottb
Merge from: 1...@4498
Modified: trun
Author: sco...@google.com
Date: Tue Jan 20 14:52:14 2009
New Revision: 4503
Modified:
releases/1.6/user/src/com/google/gwt/event/shared/HandlerManager.java
Log:
Organize imports.
Modified:
releases/1.6/user/src/com/google/gwt/event/shared/HandlerManager.java
==
Author: j...@google.com
Date: Tue Jan 20 12:56:27 2009
New Revision: 4497
Modified:
releases/1.6/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml
Log:
Fixed capitalization typo (don't ask me how this compiled on my desk).
Modified: releases/1.6/user/src/com/google/gwt/event/dom/DomEvent.
Author: fabb...@google.com
Date: Tue Jan 20 15:07:43 2009
New Revision: 4505
Modified:
trunk/dev/core/src/com/google/gwt/core/linker/SingleScriptLinker.java
trunk/dev/core/src/com/google/gwt/core/linker/XSLinker.java
Log:
upmerge of buildbreak fix for XSLinker and StandaloneScriptLinker
On Tue, Jan 20, 2009 at 5:57 PM, Freeland Abbott wrote:
> For the XSLinker breakage... longer in the digging than the fixing. This
> is against *trunk* r4499, although I imagine it's identical in 1.6... in
> 1.6, I also wanted to downport the LinkerSuite tests, but I'm getting what I
> think is
Author: amitman...@google.com
Date: Mon Jan 19 15:16:47 2009
New Revision: 4493
Modified:
tools/redist/emma/README.txt
tools/redist/emma/com.mountainminds.eclemma.core_1.3.2.jar
tools/redist/emma/emma-multiclassloader-fix.patch
tools/redist/emma/emma.jar
Log:
Fixes the ClassCastE
For the XSLinker breakage... longer in the digging than the fixing. This is
against *trunk* r4499, although I imagine it's identical in 1.6... in 1.6, I
also wanted to downport the LinkerSuite tests, but I'm getting what I think
is an unrelated break in
user/test/com/google/gwt/junit/client/TestMa
Author: j...@google.com
Date: Tue Jan 20 14:11:08 2009
New Revision: 4501
Modified:
releases/1.6/eclipse/README.txt
Log:
Update documentation to include new way of specifying the
gwt-dev-.jar
location.
Patch by: jat
Review by: scottb
Modified: releases/1.6/eclipse/README.txt
===
Author: fabb...@google.com
Date: Tue Jan 20 12:56:29 2009
New Revision: 4498
Modified:
releases/1.6/dev/core/src/com/google/gwt/util/tools/Utility.java
Log:
Fix Utility.java to use better unique temporaries, not under gwt-tmp (which
can have permission issues).
Review by: scottb
Modified:
Methinks your fencepost is wrong... shouldn't that be 4490:4497,4498: if
you want to skip c4498?
On Tue, Jan 20, 2009 at 5:13 PM, wrote:
>
> Author: fabb...@google.com
> Date: Tue Jan 20 13:27:40 2009
> New Revision: 4500
>
> Modified:
>releases/1.6/branch-info.txt
>
> Log:
> Recording m
Ray nailed it mostly. You can (as of 5 minutes ago) clip from a source
image in GWTCanvas. However, you will notice that GWTCanvas
drawImage() expects a regular ImageElement.
ImageBundle uses background image slicing and other trickery that
varies by browser. You can do some magic to tease the un
Thanks Ray! I'll just do traditional ImagePrefetching then...
( I'm just experimenting with using the new Canvas object to do GWT
based games. Say No to Flash! :-)
Kind regards,
Axel
BTW: just realising I might have hit the wrong group, sorry about
that.
On Jan 20, 10:15 pm, Ray Cromwell wro
Author: fabb...@google.com
Date: Tue Jan 20 13:27:40 2009
New Revision: 4500
Modified:
releases/1.6/branch-info.txt
Log:
Recording merge of c4498 to trunk
Modified: releases/1.6/branch-info.txt
==
--- releases/1.6/
Author: j...@google.com
Date: Tue Jan 20 09:18:24 2009
New Revision: 4494
Added:
releases/1.6/user/src/com/google/gwt/event/EventBase.gwt.xml
releases/1.6/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml
releases/1.6/user/src/com/google/gwt/event/logical/LogicalEvent.gwt.xml
Modifie
Author: j...@google.com
Date: Tue Jan 20 10:38:07 2009
New Revision: 4496
Modified:
releases/1.6/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java
releases/1.6/user/test/com/google/gwt/junit/client/TestManualAsync.java
Log:
JUnit infrastructure n
I don't think you can, at least not easily. To do this requires the
drawImage() call which allows specifying the source rectangle. GWTCanvas
doesn't support clipping either, so you can't set a rectangle path, and clip
the source image. This might be due to a limitation of IE/VML, I dunno, I
try to
Can I (and if yes how) use ImageBundle images in GWTCanvas.drawImage
()?
Kind regards,
Axel
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM.
On Tue, Jan 20, 2009 at 2:47 PM, John Tamplin wrote:
> The attached patch, relative to 1.6 @ r4495, updates the Eclipse README.txt
> file to properly set the recently introduced gwt_devjar variable.
>
> --
> John A. Tamplin
> Software Engineer (GWT), Google
>
--~--~-~--~~-
LGTM. Feel free to commit to both 1.6 and trunk as there is a 99.9% chance
this will merge cleanly.
On Tue, Jan 20, 2009 at 1:14 PM, Freeland Abbott wrote:
> We've bumped into some problems where the pattern /tmp/gwt-tmp/*
> something-unique* fails, because the intermediate gwt-tmp layer has ba
The attached patch, relative to 1.6 @ r4495, updates the Eclipse README.txt
file to properly set the recently introduced gwt_devjar variable.
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit
One design issue below. LGTM once you shoot it down. :-)
http://gwt-code-reviews.appspot.com/2009/diff/1/8
File user/src/com/google/gwt/user/client/Event.java (right):
http://gwt-code-reviews.appspot.com/2009/diff/1/8#newcode464
Line 464: DOM.setEventListener((com.google.gwt.user.client.Element
On Fri, Jan 16, 2009 at 8:46 PM, Cameron Braid wrote:
> I am using version 1.2.1
>
> I created a new module that triggers the compiler error :
>
>
>
>
>
>
>
> package error.client;
> import com.extjs.gxt.ui.client.widget.ContentPanel;
> import com.google.gwt.core.client.EntryPoin
http://gwt-code-reviews.appspot.com/2009/diff/1/7
File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(right):
http://gwt-code-reviews.appspot.com/2009/diff/1/7#newcode46
Line 46: var button = evt.button;
Note that this switch from evt.which to evt.button is quite intentional.
It
Reviewers: rjrjr, ecc,
Description:
This was originally discussed on the main Rietveld instance here:
http://codereview.appspot.com/8894
I'm moving it here because that's where we're doing everything now, and
the 1.6 branch has drifted enough that it merits another look.
This includes:
- All
Ok, I *finally* got the freakin' JUnit infrastructure changes committed,
which means it's time to get this stuff landed as well. The 1.6 release
branch has drifted a bit since I last put this patch up for review, so I'll
send out a new one momentarily. There should be no substantive changes over
th
Commited as r4496.
http://gwt-code-reviews.appspot.com/2008
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On 2009/01/16 15:34:48, jgw wrote:
>
From scottb on issue 3258: LGTM.
http://gwt-code-reviews.appspot.com/2008
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
We've bumped into some problems where the pattern /tmp/gwt-tmp/*
something-unique* fails, because the intermediate gwt-tmp layer has bad
permissions from one user that later block a second user.
I think that was my original error, fwiw, but here's a patch that just cuts
the middle layer... less "p
Oh yeah, forgot to answer that.
HasHandlers.isEventHandled() exists to allow optimization of event object
instantiation, as in:
class SomeEvent {
static void fireSomeEvent(HasHandlers source) {
if (source.isEventHandled(SomeEvent.TYPE) {
source.fireEvent(new SomeEvent());
}
}
}
It would be very nice if we could add widgets to MenuItems instead of
using setting html. This would make formatting of custom menu items a
lot easier.
I just tried to add menu items that display text + an aligned image
and it took some time to find out how to do that (nesting a table).
On Jan 2
You can get the test project from http://people.apache.org/~nicolas/MGWT-14/ as
a ZIP of browse its content.
plugin source is code at
https://svn.codehaus.org/mojo/trunk/mojo/gwt-maven-plugin
The maven plugin creates :
- a classpath entries list in target/gwt.classpath file (warning : files
path
The fact that MenuBar uses a table to render itself is just an
implementation detail, and sometimes we abstract away the DOM implementation
of a widget. Personally, I think adding a setHorizontal/VerticalAlignment()
would be a little confusing because people might assume it would set the
alignment
Hi Nicolas,
Can you supply the actual script produced and any Java classes that are used
to setup the "booter"?
Thanks,
Scott
On Tue, Jan 20, 2009 at 5:04 AM, nicolas.deloof wrote:
>
> Hi,
>
> the gwt-maven-plugin development has a Classloader issue with tomcat
> embedded
> http://jira.codehaus.
Hi,
the gwt-maven-plugin development has a Classloader issue with tomcat
embedded
http://jira.codehaus.org/browse/MGWT-14
We have no idea of what's wrong, so any of you with ClassLoader /
Tomcat embedded skills would be welcome to help if possible.
Please apologies for "spaming" this group for a
51 matches
Mail list logo
