Reviewers: jlabanca,
Description:
Moves the Cell interfaces and implementations from Bikeshed into
c.g.g.cell.
Also makes Cell an interface and changes existing cells to extend
AbstractCell.
Please review this at http://gwt-code-reviews.appspot.com/467801/show
Affected files:
D
LGTM
Some minor nits.
http://gwt-code-reviews.appspot.com/467801/diff/1/60
File /user/src/com/google/gwt/cell/client/ActionCell.java (right):
http://gwt-code-reviews.appspot.com/467801/diff/1/60#newcode55
/user/src/com/google/gwt/cell/client/ActionCell.java:55:
Should implement
All nits picked, fixed, and committed.
http://gwt-code-reviews.appspot.com/467801/diff/1/60
File /user/src/com/google/gwt/cell/client/ActionCell.java (right):
http://gwt-code-reviews.appspot.com/467801/diff/1/60#newcode55
/user/src/com/google/gwt/cell/client/ActionCell.java:55:
On 2010/05/05
I also added delegation for the other public functions. It's broken,
in the sense that it'll work in dev mode while the JRE is still being
used for the client stuff and break in web mode, but that's true for any
JRE emulation classes that don't implement all of the functions. Does
that sound
You should be able to throw subclasses of RuntimeException, no?
On Wed, May 5, 2010 at 11:03 AM, unn...@google.com wrote:
I also added delegation for the other public functions. It's broken,
in the sense that it'll work in dev mode while the JRE is still being
used for the client stuff and
huh - I didn't know that (I seem to learn something new about java
every day...) I'll do that - thanks!
- Unnur
On Wed, May 5, 2010 at 11:15 AM, Ray Ryan rj...@google.com wrote:
You should be able to throw subclasses of RuntimeException, no?
On Wed, May 5, 2010 at 11:03 AM, unn...@google.com
LGTM.
Since you don't actually implement most of that public API in our
emulation library, I believe you get a compile error even in dev mode if
client code tries to call it. So I would expect that (unless you add
those functions to the JRE in the future) those methods will never get
called
On Wed, May 5, 2010 at 2:15 PM, Ray Ryan rj...@google.com wrote:
You should be able to throw subclasses of RuntimeException, no?
For example, UnsupportedOperationException. -Lex
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I spoke to Scott offline and he thinks that the client code should
never get to these operations due to compile errors. At the same time,
many of the functions can't throw exceptions since even though client
code does not call them, the class itself will call some of them (even
though they are
LGTM
http://gwt-code-reviews.appspot.com/439801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
What are the technical hurdles that would prevent a widget from
employing multiple UiBinder templates to create discrete Widget
structures?
Specifically, I want to build a Composite that includes, among other
things, a PopupPanel. I want to use UiBinder to declare the overall
layout, as well as
Reviewers: scottb,
Message:
Ready for first round of reviews.
http://gwt-code-reviews.appspot.com/473801/diff/1/11
File
dev/core/src/com/google/gwt/dev/shell/rewrite/SingleJsoImplSupport.java
(right):
http://gwt-code-reviews.appspot.com/473801/diff/1/11#newcode29
Reviewers: jlabanca, cromwellian,
Description:
Creates the c.g.g.view module, moving the abstract interfaces and
non-widget implementations from the Bikeshed.
Creates the (currently empty) c.g.g.user.cellview module, which will
eventually hold the Bikeshed widgets.
Also cleans up the dependency
Reviewers: amitmanjhi, jlabanca,
Description:
Sorry, for some reason side-by-side diff isn't working for me.
This patch is to alleviate the fact that:
ant -f user/build.xml test
Does practically nothing. Even if hmtlunit is somewhat flaky, it's
gotten be better than nothing.
Please review
LGTM as long as Miguel and Freeland agree that its a good idea.
Thanks,
John LaBanca
jlaba...@google.com
On Wed, May 5, 2010 at 5:52 PM, sco...@google.com wrote:
Reviewers: amitmanjhi, jlabanca,
Description:
Sorry, for some reason side-by-side diff isn't working for me.
This patch is to
LGTM. HtmlUnit should be used; it should be uncommented everywhere. I
uncommented a few things in r7787 (link below), but it seems like I missed a
few instances.
http://code.google.com/p/google-web-toolkit/source/detail?r=7787path=/trunk/user/build.xml
One nit : the assertion that ant -f
LGTM
http://gwt-code-reviews.appspot.com/474801/diff/1/22
File /bikeshed/src/com/google/gwt/bikeshed/tree/client/CellTree.css
(left):
http://gwt-code-reviews.appspot.com/474801/diff/1/22#oldcode18
/bikeshed/src/com/google/gwt/bikeshed/tree/client/CellTree.css:18:
gwt-image:
this issue is reverted, and instead pursued in issue 438801
http://gwt-code-reviews.appspot.com/341803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jgw,
Description:
Enables AppStats for bikeshed.
Please review this at http://gwt-code-reviews.appspot.com/477801/show
Affected files:
M /bikeshed/war/WEB-INF/web.xml
Index: /bikeshed/war/WEB-INF/web.xml
===
---
I have no way of testing this ... but I think it's correct.
http://gwt-code-reviews.appspot.com/477801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, May 5, 2010 at 7:01 PM, Amit Manjhi amitman...@google.com wrote:
LGTM. HtmlUnit should be used; it should be uncommented everywhere. I
uncommented a few things in r7787 (link below), but it seems like I missed a
few instances.
LGTM from me---I remember we turned it off when htmlunit was all hangy, and
at the time I was lobbying that iwe should at least have a warning saying
hey, nothing to do unless some of the remote properties was set. The
(probably correct) counter that nobody would notice the warning if they
didn't
Ping.
http://gwt-code-reviews.appspot.com/280801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
23 matches
Mail list logo
