[gwt-contrib] Re: Add numeric types required for autoboxing support to INDEX_TYPES_SET. (issue658803)

LGTM http://gwt-code-reviews.appspot.com/658803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add numeric wrappers to JavaResourceBase. (issue673801)

LGTM http://gwt-code-reviews.appspot.com/673801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add UiFieldMapper to allow dynamic access to UiFields to support data-driven UIs. (issue619806)

Reviewers: Ray Ryan, Description: Add UiFieldMapper to allow dynamic access to UiFields to support data-driven UIs. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/619806/show Affected files: M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml A us

[gwt-contrib] CSS obfuscation weirdness when using CellList.Resource

In my app I have 2 CellLists. During the construction of each I initialise each using a DIFFERENT CellList.Resource (each having a different CSS file). Because both of these resource files extend CellList.Resource they obviously both have the same CSS class names, namely: .evenItem .oddItem .selec

[gwt-contrib] Add numeric types required for autoboxing support to INDEX_TYPES_SET. (issue658803)

Reviewers: scottb, Description: Add numeric types required for autoboxing support to INDEX_TYPES_SET. Please review this at http://gwt-code-reviews.appspot.com/658803/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java Index: dev/core/src/com/google/gwt/dev/jjs/ast

[gwt-contrib] Add numeric wrappers to JavaResourceBase. (issue673801)

Reviewers: scottb, Description: Add numeric wrappers to JavaResourceBase. Review by: sco...@google.com Please review this at http://gwt-code-reviews.appspot.com/673801/show Affected files: M dev/core/test/com/google/gwt/dev/javac/impl/JavaResourceBase.java -- http://groups.google.com/group

[gwt-contrib] Re: Fix issue 5061: backslashes are not escaped by UiBinder in HasHTML and HasText (issue620804)

Submitted r8356 On Fri, Jul 2, 2010 at 10:52 AM, wrote: > LGTM > > Thanks! I'll try to get this in today. > > > http://gwt-code-reviews.appspot.com/620804/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for issue 516 (issue612802)

Here's the reverted patch set. http://gwt-code-reviews.appspot.com/612802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Revert the ListBoxCell changes that slipped into MailRecipe from another change that hasn't been... (issue650802)

comitted as r8358 http://gwt-code-reviews.appspot.com/650802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8358 committed - Revert the ListBoxCell changes that slipped into MailRecipe from anoth...

Revision: 8358 Author: jlaba...@google.com Date: Fri Jul 2 10:03:45 2010 Log: Revert the ListBoxCell changes that slipped into MailRecipe from another change that hasn't been submitted yet. Review at http://gwt-code-reviews.appspot.com/650802 http://code.google.com/p/google-web-toolkit/sourc

[gwt-contrib] History token encoding issues

I considered logging an issue about this, but I think I'm advocating a different, incompatible history encoding strategy (don't encode/ decode) and it will likely cause issues for some people if the change were made. As I understand the history of history encoding, originally it was encoded using

Re: [gwt-contrib] Re: Add WebSocket API (issue646803)

On 2 July 2010 15:37, wrote: > Here's what I think... > > What's the purpose of RawWebSocketImpl vs. WebSocket? that you could >> do a new WebSocket() instead of WebSocket.newInstance() ? (I don't >> dispute the interface+implementation, which is more-than-useful for >> mockability). >> > Differ

[gwt-contrib] Custom UiBinder attribute parsers

Hello, I've been investigating UiBinder with a view to creating a custom attribute parser. I was hoping to be able to add my own attributes to existing Widgets' elements in a similar way to the ui:field attribute. From the discussions I've seen, it seems that the only way to do it at the moment is

[gwt-contrib] Revert the ListBoxCell changes that slipped into MailRecipe from another change that hasn't been... (issue650802)

Reviewers: Dan Rice, Description: Revert the ListBoxCell changes that slipped into MailRecipe from another change that hasn't been submitted yet. Please review this at http://gwt-code-reviews.appspot.com/650802/show Affected files: M bikeshed/src/com/google/gwt/sample/bikeshed/cookbook/cli

Re: [gwt-contrib] UiBinder tweaks for GWT Designer

On Fri, Jul 2, 2010 at 6:20 PM, Ray Ryan wrote: >> This is absolutely not related to databinding, we just want to produce >> GUI builder for UiBinder. >> I think that tooling was specified as one of the reasons to use XML for >> GWT UI. So, this is on what I work now. :-) >> > > Well that ma

[gwt-contrib] Re: Replacing PagingListView.setPageStart/Size with PagingListView.setRange. Replacing CellListImpl... (issue614803)

committed as r8357 http://gwt-code-reviews.appspot.com/614803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8356 committed - UiBinderWriter#escapeTextForJavaStringLiteral correctly escapes \n and...

Revision: 8356 Author: rj...@google.com Date: Fri Jul 2 08:22:57 2010 Log: UiBinderWriter#escapeTextForJavaStringLiteral correctly escapes \n and ", but forgets \. Also, I couldn't see a reason for using replaceAll instead of replace. Patch by tbro...@gmail.com Review by rj...@google.com http:

[gwt-contrib] [google-web-toolkit] r8355 committed - Added the artifacts for Eclipse 3.3...

Revision: 8355 Author: amitman...@google.com Date: Fri Jul 2 11:16:44 2010 Log: Added the artifacts for Eclipse 3.3 Patch by: jasonparekh Commit by: amitmanjhi http://code.google.com/p/google-web-toolkit/source/detail?r=8355 Added: /2.1.0.M2/eclipse/plugin/3.3 /2.1.0.M2/eclipse/plugin/3.3/f

[gwt-contrib] [google-web-toolkit] r8354 committed - Added the artifacts for Eclipse 3.4...

Revision: 8354 Author: amitman...@google.com Date: Fri Jul 2 11:15:16 2010 Log: Added the artifacts for Eclipse 3.4 Patch by: jasonparekh Commit by: amitmanjhi http://code.google.com/p/google-web-toolkit/source/detail?r=8354 Added: /2.1.0.M2/eclipse/plugin/3.4 /2.1.0.M2/eclipse/plugin/3.4/a

[gwt-contrib] [google-web-toolkit] r8353 committed - Added the artifacts for Eclipse 3.6...

Revision: 8353 Author: amitman...@google.com Date: Fri Jul 2 11:12:19 2010 Log: Added the artifacts for Eclipse 3.6 Patch by: jasonparekh Commit by: amitmanjhi http://code.google.com/p/google-web-toolkit/source/detail?r=8353 Added: /2.1.0.M2/eclipse/plugin/3.6 /2.1.0.M2/eclipse/plugin/3.6/a

[gwt-contrib] Re: Adding NoSelectionModel, which allows selection without saving the selection state. (issue667801)

On 2010/06/28 17:44:06, jlabanca wrote: LGTM. http://gwt-code-reviews.appspot.com/667801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8352 committed - Populate GPE 1.4 M2 for Eclipse 3.5 into Maven repo.

Revision: 8352 Author: jasonpar...@google.com Date: Fri Jul 2 10:51:10 2010 Log: Populate GPE 1.4 M2 for Eclipse 3.5 into Maven repo. http://code.google.com/p/google-web-toolkit/source/detail?r=8352 Added: /2.1.0.M2/eclipse /2.1.0.M2/eclipse/plugin /2.1.0.M2/eclipse/plugin/3.5 /2.1.0.M2/ecli

[gwt-contrib] Re: Replacing PagingListView.setPageStart/Size with PagingListView.setRange. Replacing CellListImpl... (issue614803)

LGTM overall. Some minor comments that shouldn't stop you from committing. And let me just add "w00t, tests!" http://gwt-code-reviews.appspot.com/614803/diff/3001/4013 File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/614803/diff/3001/

[gwt-contrib] [google-web-toolkit] r8351 committed - Populate GWT 2.1 M2 into Maven repo.

Revision: 8351 Author: jasonpar...@google.com Date: Fri Jul 2 10:29:54 2010 Log: Populate GWT 2.1 M2 into Maven repo. http://code.google.com/p/google-web-toolkit/source/detail?r=8351 Added: /2.1.0.M2/gwt/maven/com/google/gwt /2.1.0.M2/gwt/maven/com/google/gwt/gwt-dev /2.1.0.M2/gwt/maven/com/g

[gwt-contrib] [google-web-toolkit] r8350 committed - Populate gwt-maven-plugin and GAE 1.3.5 into Maven repo.

Revision: 8350 Author: jasonpar...@google.com Date: Fri Jul 2 10:26:43 2010 Log: Populate gwt-maven-plugin and GAE 1.3.5 into Maven repo. http://code.google.com/p/google-web-toolkit/source/detail?r=8350 Added: /2.1.0.M2/gwt /2.1.0.M2/gwt/maven /2.1.0.M2/gwt/maven/com /2.1.0.M2/gwt/maven/com/

[gwt-contrib] [google-web-toolkit] r8349 committed - Create top-level directory for GWT 2.1 M2/GPE 1.4 M2.

Revision: 8349 Author: jasonpar...@google.com Date: Fri Jul 2 09:53:04 2010 Log: Create top-level directory for GWT 2.1 M2/GPE 1.4 M2. http://code.google.com/p/google-web-toolkit/source/detail?r=8349 Added: /2.1.0.M2 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

On 2010/07/02 16:26:08, tbroyer wrote: LGTM overall. As a side note, where is the c.g.g.dom.client.EventListener defined? Could it be made generic? I like how the WebSocket proposal added a base Event class mimicking the DOM Event interface, with NativeEvent (and other WebSocket-specific

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

http://gwt-code-reviews.appspot.com/623803/diff/1/4 File user/src/com/google/gwt/dom/client/DOMImplTrident.java (right): http://gwt-code-reviews.appspot.com/623803/diff/1/4#newcode161 user/src/com/google/gwt/dom/client/DOMImplTrident.java:161: // TODO: Hang on to enough information to implement

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

http://gwt-code-reviews.appspot.com/623803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add support for creating Grid elements using UiBinder. (issue154810)

You're trading off compile time simplicity at the expense of runtime efficiency, and it's a bad trade. Rather than emitting java lines as you walk the XML, you can build a model of what you want to write. Once you're done with your traversal, you can write out a single call to resize(int, int), an

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

http://gwt-code-reviews.appspot.com/623803/diff/1/3 File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode119 user/src/com/google/gwt/dom/client/DOMImplStandard.java:119: listen...@com.google.gwt.dom.client.eventlistener:

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

LGTM overall. As a side note, where is the c.g.g.dom.client.EventListener defined? Could it be made generic? I like how the WebSocket proposal added a base Event class mimicking the DOM Event interface, with NativeEvent (and other WebSocket-specific events) extending it. EventListener could then

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

http://gwt-code-reviews.appspot.com/623803/diff/1/3 File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115 user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public native void addEventListener(EventTarget ta

[gwt-contrib] Re: Add support for creating Grid elements using UiBinder. (issue154810)

Ok, I had a look and just remembered why I used more calls to resize methods. The GridParser walks through the Grid and on the fly calculates the size. So if it comes to an element that doesn't fit into the current grid element it expands it (either by number of columns, or rows - depends which o

[gwt-contrib] Re: Add WebSocket API (issue646803)

I don't have a particularly strong opinion on the RawWebSocket vs. RawWebSocketImpl dichotomy, but it might be a bit more abstracted that necessary. I'm perfectly fine with the WebSocket vs. RawWebSocket difference, though, because one's a native browser class, while the other provides a more Java

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

http://gwt-code-reviews.appspot.com/623803/diff/1/3 File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115 user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public native void addEventListener(EventTarget ta

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

http://gwt-code-reviews.appspot.com/623803/diff/1/3 File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115 user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public native void addEventListener(EventTarget ta

[gwt-contrib] Re: Adds Event.sinkEvent() to make it possible to sink custom events in gwt-user. Reimplements (issue635802)

http://gwt-code-reviews.appspot.com/635802/diff/1/3 File user/src/com/google/gwt/user/client/Event.java (right): http://gwt-code-reviews.appspot.com/635802/diff/1/3#newcode556 user/src/com/google/gwt/user/client/Event.java:556: DOM.sinkEvent((com.google.gwt.user.client.Element) elem, type, sink)

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

committed as r8348 http://gwt-code-reviews.appspot.com/645802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8348 committed - Inserting TreeItems into the logical list in the same spot that they a...

Revision: 8348 Author: jlaba...@google.com Date: Fri Jul 2 05:43:30 2010 Log: Inserting TreeItems into the logical list in the same spot that they are inserted into the physical DOM. This fixes a bug where keyboard navigation occurs out of order, and generally makes the logical and physical

[gwt-contrib] Re: Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

http://gwt-code-reviews.appspot.com/623803/diff/1/3 File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115 user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public native void addEventListener(EventTarget ta

[gwt-contrib] Re: Fix issue 4781: allow HTML="" in UiBinder for setHTML() (issue642801)

http://gwt-code-reviews.appspot.com/642801/diff/1/3 File user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java (right): http://gwt-code-reviews.appspot.com/642801/diff/1/3#newcode62 user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java:62: assertMethod(htmlSet

[gwt-contrib] Adding microbenchmark for event sinking (using gwt-user Event.sinkEvents()). (issue668802)

Reviewers: tbroyer, Description: Adding microbenchmark for event sinking (using gwt-user Event.sinkEvents()). Please review this at http://gwt-code-reviews.appspot.com/668802/show Affected files: M reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/Microbenchmarks

[gwt-contrib] Adds Event.sinkEvent() to make it possible to sink custom events in gwt-user. Reimplements (issue635802)

Reviewers: tbroyer, Description: Adds Event.sinkEvent() to make it possible to sink custom events in gwt-user. Reimplements gwt-user event handling in terms of standard dom EventTarget methods. Note: This is not remotely finished, nor the API certain. Please review this at http://gwt-code-revie

[gwt-contrib] Adds EventTarget, add/removeEventListener() et al to gwt dom. (issue623803)

Reviewers: tbroyer, Description: Adds EventTarget, add/removeEventListener() et al to gwt dom. Note: This is not remotely finished, nor is the API certain. Please review this at http://gwt-code-reviews.appspot.com/623803/show Affected files: M user/src/com/google/gwt/dom/client/DOMImpl.java

[gwt-contrib] [google-web-toolkit] r8347 committed - Adds parser for TextAlignConstant, which accepts both "friendly" names...

Revision: 8347 Author: rj...@google.com Date: Fri Jul 2 04:56:18 2010 Log: Adds parser for TextAlignConstant, which accepts both "friendly" names and the UGLY_ONES used in code. Horiz and Vert constant parsers retrofitted with the same friendliness. Patch by konstantin.scheg...@gmail.com Review

[gwt-contrib] Re: Fix issue 4781: allow HTML="" in UiBinder for setHTML() (issue642801)

Thanks for the patch, Thomas. Yeah, I hate to say this but could you make the fix backward compatible? http://gwt-code-reviews.appspot.com/642801/diff/1/3 File user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java (right): http://gwt-code-reviews.appspot.com/642801/diff/1/3#

[gwt-contrib] Re: Add support for creating Grid elements using UiBinder. (issue154810)

Yeah, I do remember. I will make the change later today. On 2010/07/02 14:40:57, Ray Ryan wrote: Remember this? It's really close, I think just one more change is needed (below). http://gwt-code-reviews.appspot.com/154810/diff/22003/54004 File user/test/com/google/gwt/uibinder/elementpars

[gwt-contrib] Re: Add support for creating Grid elements using UiBinder. (issue154810)

Remember this? It's really close, I think just one more change is needed (below). http://gwt-code-reviews.appspot.com/154810/diff/22003/54004 File user/test/com/google/gwt/uibinder/elementparsers/GridParserTest.java (right): http://gwt-code-reviews.appspot.com/154810/diff/22003/54004#newcode114

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

LGTM http://gwt-code-reviews.appspot.com/645802/diff/6001/7002 File user/src/com/google/gwt/user/client/ui/TreeItem.java (right): http://gwt-code-reviews.appspot.com/645802/diff/6001/7002#newcode482 user/src/com/google/gwt/user/client/ui/TreeItem.java:482: double margin = isRoot ? 0.0 : 16.0; M

Re: [gwt-contrib] UiBinder tweaks for GWT Designer

On Thu, Jul 1, 2010 at 3:55 PM, Konstantin Scheglov < konstantin.scheg...@gmail.com> wrote: > > > What does WBP stand for? >> > > WBP is acronym for "WindowBuilder > Pro" > - set of plugins for Eclipse for WYSIWYG development of GUI for Swing, SWT,

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

@rice - Do you mind taking another look at the updated Patch Set? http://gwt-code-reviews.appspot.com/645802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add WebSocket API (issue646803)

Here's what I think... What's the purpose of RawWebSocketImpl vs. WebSocket? that you could do a new WebSocket() instead of WebSocket.newInstance() ? (I don't dispute the interface+implementation, which is more-than-useful for mockability). Different browsers might have a slightly different Web

[gwt-contrib] Re: Add WebSocket API (issue646803)

On Fri, Jul 2, 2010 at 2:37 AM, wrote: > http://gwt-code-reviews.appspot.com/646803/show All in all, it really feels over-engineered to me. Sorry to be harsh, but let me explain: What's the purpose of RawWebSocketImpl vs. WebSocket? that you could do a new WebSocket() instead of WebSocket.newIn