Revision: 8377
Author: gwt.mirror...@gmail.com
Date: Mon Jul 12 14:25:43 2010
Log: Fix some bugs in symbol dumping.
1) Fixes an NPE when dumping symbols with -validateOnly.
2) Fixes unstable sort order being returned from TypeOracle.getTypes().
Review at http://gwt-code-reviews.appspot.com/68580
Actually, I may have jumped the gun on that. Making it static nested will
have an impact on command line callers who are specifying a strategy on the
command line, I think. (Separate discussion from whether we should flog the
responsible parties for polluting the junit package directly.) :)
On M
+1. Static nested FTW. :)
On Mon, Jul 12, 2010 at 5:14 PM, wrote:
> LGTM, though do all the *Strategy ones need to be top-level classes
> rather than static nested classes?
>
>
>
> http://gwt-code-reviews.appspot.com/686801/show
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contrib
http://gwt-code-reviews.appspot.com/686801/diff/1/3
File user/src/com/google/gwt/i18n/tools/ArgHandlerValueChooser.java
(right):
http://gwt-code-reviews.appspot.com/686801/diff/1/3#newcode49
user/src/com/google/gwt/i18n/tools/ArgHandlerValueChooser.java:49:
private Class argValue = Constants.cl
LGTM, though do all the *Strategy ones need to be top-level classes
rather than static nested classes?
http://gwt-code-reviews.appspot.com/686801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On Mon, Jul 12, 2010 at 4:58 PM, Scott Blum wrote:
> On Mon, Jul 12, 2010 at 4:54 PM, wrote:
>
>> http://gwt-code-reviews.appspot.com/685801/diff/1/2#newcode594
>> dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:594:
>> return result;
>> Cool, but is this better than stabiliz
Reviewers: jat,
Description:
Refactoring to one top level class per .java file, since some
tools don't understand more than that.
Review by: jat
Please review this at http://gwt-code-reviews.appspot.com/686801/show
Affected files:
M dev/core/super/com/google/gwt/lang/LongLibBase.java
A us
On Mon, Jul 12, 2010 at 4:54 PM, wrote:
> http://gwt-code-reviews.appspot.com/685801/diff/1/2#newcode594
> dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:594:
> return result;
> Cool, but is this better than stabilizing allTypes.values itself?
>
Yes... I thought about making allTy
http://gwt-code-reviews.appspot.com/685801/diff/2002/3002
File dev/core/src/com/google/gwt/dev/Precompile.java (left):
http://gwt-code-reviews.appspot.com/685801/diff/2002/3002#oldcode478
dev/core/src/com/google/gwt/dev/Precompile.java:478:
compilationState.getTypeOracle(), dumpSignatureFile);
T
http://gwt-code-reviews.appspot.com/685801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
(right):
http://gwt-code-reviews.appspot.com/685801/diff/1/2#newcode594
dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:594:
return result;
Cool, but is this bette
http://gwt-code-reviews.appspot.com/685801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: fabbott,
Description:
Fix some bugs in symbol dumping.
1) Fixes an NPE when dumping symbols with -validateOnly.
2) Fixes unstable sort order being returned from TypeOracle.getTypes().
Review by: fabb...@google.com
Please review this at http://gwt-code-reviews.appspot.com/685801/show
Did the changes... Will post the patch a little later... I need to
convert it from git to svn format first...
http://gwt-code-reviews.appspot.com/154810/diff/63002/70001
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):
http://gwt-code-reviews.appspot.com/154810/diff
[Sorry for the spotty response time, it's vacation season.]
Okay, that's pretty cute. And completely isolated from the patch I pointed
you at, so don't worry about it.
I'm open to this. My only reservation at this point is the question of how
we'll ensure that it's only available at "tool time."
http://gwt-code-reviews.appspot.com/612802/diff/28001/29001
File user/src/com/google/gwt/user/client/ui/RootPanel.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/28001/29001#newcode92
user/src/com/google/gwt/user/client/ui/RootPanel.java:92: }
There is no need to copy Panel#clear h
http://gwt-code-reviews.appspot.com/154810/diff/63002/70001
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):
http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode86
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:86:
writer.getOracle().f
Nice. Just some error checking nits left.
http://gwt-code-reviews.appspot.com/154810/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On Fri, Jul 9, 2010 at 2:17 PM, wrote:
> Reviewers: Ray Ryan,
>
> Description:
> Fix javadoc issues
>
>
> Please review this at http://gwt-code-reviews.appspot.com/681801/show
>
> Affected files:
> M user/src/com/google/gwt/app/place/AbstractRecordListActivity.java
> M user/src/com/google
Comment by cmcguire79:
Is there a working example of the @ImageOptions height and width
properties? My code will not compile when specifying those options and the
JavaDoc does not seem to indicate that these are valid. Is this a dropped
feature, or perhaps, a future enhancement?
For mo
Just curious when the gwt-incubator will become compatible with GWT 2.1?
Cameron
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
20 matches
Mail list logo
