Reviewers: Ray Ryan,
Description:
Partial commit towards making instance methods real. Merged the
execution paths
for the syncRequest and RequestObject.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/726801/show
Affected files:
LGTM
http://gwt-code-reviews.appspot.com/638802/diff/1/2
File user/src/com/google/gwt/logging/LogImpl.gwt.xml (right):
http://gwt-code-reviews.appspot.com/638802/diff/1/2#newcode11
user/src/com/google/gwt/logging/LogImpl.gwt.xml:11: replace-with
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat,
Description:
No longer require RPCs to contain a 'Content-Length' HTTP request
header, thus
enabling support for XHR with 'Transfer-Encoding: Chunked'.
Review by: j...@google.com
Please review this at http://gwt-code-reviews.appspot.com/727801/show
Affected files:
M
LGTM
On Wed, Jul 28, 2010 at 6:19 PM, amitman...@google.com wrote:
Reviewers: Ray Ryan,
Description:
Partial commit towards making instance methods real. Merged the
execution paths
for the syncRequest and RequestObject.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please
http://gwt-code-reviews.appspot.com/727801/diff/1/2
File user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java
(right):
http://gwt-code-reviews.appspot.com/727801/diff/1/2#newcode183
user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java:183: int
byteCount = in.read(buffer);
Does
LGTM with minor changes.
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001#newcode41
user/src/com/google/gwt/resources/client/DataResource.java:41:
http://gwt-code-reviews.appspot.com/698802/diff/1/5
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget.ui.xml
(right):
http://gwt-code-reviews.appspot.com/698802/diff/1/5#newcode17
On 2010/07/19 14:26:03, zundel wrote:
Thanks for all the feedback. My responses to the comments from the
Rays,
Thomas, John and Scott:
- We need functionality in the compiler to create JSON output to
create a
performance analysis tool. We are just using JSON as an exported data
format,
http://gwt-code-reviews.appspot.com/710802/diff/1/3
File user/src/com/google/gwt/cell/client/Cell.java (right):
http://gwt-code-reviews.appspot.com/710802/diff/1/3#newcode71
user/src/com/google/gwt/cell/client/Cell.java:71: boolean
isEditing(Element element, Object key);
Good idea.
On
LGTM
On Thu, Jul 29, 2010 at 6:22 AM, b...@google.com wrote:
http://gwt-code-reviews.appspot.com/698802/diff/1/5
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget.ui.xml
(right):
http://gwt-code-reviews.appspot.com/698802/diff/1/5#newcode17
http://gwt-code-reviews.appspot.com/717801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Still not ready for review, just sharing the progress. Activities no
longer have to clean up any event handlers they register, and
ActivityManger should be exception proof.
http://gwt-code-reviews.appspot.com/717801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Optimize ResourceOracle Refresh by removing some archaic guarantees and
some other peephole optimizations
R: scottb
Please review this at http://gwt-code-reviews.appspot.com/728801/show
Affected files:
M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
D
(rebase from superdevmode)
http://gwt-code-reviews.appspot.com/728801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001#newcode41
user/src/com/google/gwt/resources/client/DataResource.java:41: public
@interface DoNotEmbed
LGTM
http://gwt-code-reviews.appspot.com/728801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Nit:
http://gwt-code-reviews.appspot.com/728801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):
http://gwt-code-reviews.appspot.com/728801/diff/1/2#newcode125
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:125: private final
Styles styles = new Styles();;
Extra
http://gwt-code-reviews.appspot.com/638802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/638802/diff/1/2
File user/src/com/google/gwt/logging/LogImpl.gwt.xml (right):
http://gwt-code-reviews.appspot.com/638802/diff/1/2#newcode11
user/src/com/google/gwt/logging/LogImpl.gwt.xml:11: replace-with
Reviewers: tobyr,
Description:
Remove bogus @SuppressWarnings that eclipse wanted
Review by: to...@google.com
Please review this at http://gwt-code-reviews.appspot.com/729801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
Index:
LGTM
http://gwt-code-reviews.appspot.com/729801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jgw,
Description:
Adds a new CrossSiteIframeLinker. This linker works cross-site,
because it uses a script tag to download code instead of XHR. However,
like the iframe linker, it still uses an iframe to hold all the
installed code.
Review by: j...@google.com
Please review this at
This is ready for review.
It's almost the same as this change:
http://gwt-code-reviews.appspot.com/726802
The only difference is that this patch makes a new linker rather than
updating the XS linker in place. The contents of the new linker are the
same as what was in the previous patch.
Err, make that the following issue:
http://gwt-code-reviews.appspot.com/674802
http://gwt-code-reviews.appspot.com/726802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Lazily generate LocaleInfoImpl (rebase from superdevmode)
Review by: sco...@google.com
Please review this at http://gwt-code-reviews.appspot.com/619807/show
Affected files:
M user/src/com/google/gwt/i18n/client/LocaleInfo.java
--
Reviewers: amitmanjhi,
Description:
Forgot to commit .classpath and .project for DynaTableRf due to
.gitignore settings.
Review by: amitman...@google.com
Please review this at http://gwt-code-reviews.appspot.com/721802/show
Affected files:
A eclipse/samples/DynaTableRf/.classpath
A
Revision: 8439
Author: rj...@google.com
Date: Thu Jul 29 09:21:20 2010
Log: Remove bogus @SuppressWarnings that eclipse wanted
Review at http://gwt-code-reviews.appspot.com/729801
Review by: to...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8439
Modified:
LGTM
On Thu, Jul 29, 2010 at 12:47 PM, rj...@google.com wrote:
Reviewers: amitmanjhi,
Description:
Forgot to commit .classpath and .project for DynaTableRf due to
.gitignore settings.
Review by: amitman...@google.com
Please review this at http://gwt-code-reviews.appspot.com/721802/show
On 2010-07-26, at 4:56 PM, John Tamplin wrote:
Is the new linker designed to curtail extension, or to sanely encourage it?
The existing primary linkers ended up getting extended in brittle ways.
That's a good point. Let's make it a final class to start with, and open up
extension points
[manually forwarding to list due to subscription bug...]
Wow, this looks great. This is exactly what I had imagined.
Once dev mode is in place we should be able to switch dotspots over to
this from our current custom linker.
I was looking through the latest SelectionScriptLinker in trunk and
I don't have a strong opinion about it. They can be non-final, with simply
no particular effort to truly make them extensible.
I think it might be possible to move the template JS files to
GWT-translated code with extension points managed through rebinding and
overriding. Until then, making
Revision: 8441
Author: fabb...@google.com
Date: Thu Jul 29 09:26:40 2010
Log: Refactoring to one top level class per .java file, since some
tools don't understand more than that.
Review by: jat
Review at http://gwt-code-reviews.appspot.com/686801
Revision: 8442
Author: rj...@google.com
Date: Thu Jul 29 09:50:39 2010
Log: Forgot to commit .classpath and .project for DynaTableRf due to
.gitignore settings.
Review at http://gwt-code-reviews.appspot.com/721802
Review by: amitman...@google.com
http://gwt-code-reviews.appspot.com/717801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks, Chris. I'll plan a separate patch for that.
http://gwt-code-reviews.appspot.com/727801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/727801/diff/1/2
File user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java
(right):
http://gwt-code-reviews.appspot.com/727801/diff/1/2#newcode183
user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java:183: int
byteCount = in.read(buffer);
The
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8443
Author: gwt.mirror...@gmail.com
Date: Thu Jul 29 11:09:15 2010
Log: Re-introduces UiBinder parser for AbsolutePanel, now backward
compatible. Restores work introduced at r8430, rolled back at r8432.
Patch by konstantin.scheg...@gmail.com
Review by rj...@google.com
Reviewers: Ray Ryan,
Description:
DynatableRf refactoring in response to
http://code.google.com/p/google-web-toolkit/source/detail?r=8436
Patch by: amitmanjhi
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/674803/show
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/674803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8444
Author: unn...@google.com
Date: Thu Jul 29 12:27:21 2010
Log: rollback of optimizations that caused problems for some projects
Review by: con...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8444
Added:
Reviewers: Lex,
Description:
Ensure that we give createTempFile at least 3 characters for the prefix
See: http://code.google.com/p/google-weab-toolkit/issues/detail?id=5178
Review by: sp...@google.com
Please review this at http://gwt-code-reviews.appspot.com/699804/show
Affected files:
M
Revision: 8445
Author: amitman...@google.com
Date: Thu Jul 29 12:54:53 2010
Log: DynatableRf refactoring in response to
http://code.google.com/p/google-web-toolkit/source/detail?r=8436
Patch by: amitmanjhi
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/674803
I cursorily looked at the patch. It looks good but it seems you forgot
to upload the changes to the files in the bikeshed dir. I also had a few
minor comments, noted below.
Let me know when you update the complete patch.
http://gwt-code-reviews.appspot.com/700802/diff/2001/3004
File
Reviewers: Ray Ryan,
Description:
Change the way we include the User Auth files, keeping more of them
checked into GWT code rather than generated by roo
Please review this at http://gwt-code-reviews.appspot.com/721803/show
Affected files:
M
47 matches
Mail list logo
