[gwt-contrib] Partial commit towards making instance methods real. Merged the execution paths (issue726801)

2010-07-29 Thread amitmanjhi
Reviewers: Ray Ryan, Description: Partial commit towards making instance methods real. Merged the execution paths for the syncRequest and RequestObject. Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/726801/show Affected files:

[gwt-contrib] Re: Split LogManager class into an set of Impl classes so that any LogManager calls (issue638802)

2010-07-29 Thread fredsa
LGTM http://gwt-code-reviews.appspot.com/638802/diff/1/2 File user/src/com/google/gwt/logging/LogImpl.gwt.xml (right): http://gwt-code-reviews.appspot.com/638802/diff/1/2#newcode11 user/src/com/google/gwt/logging/LogImpl.gwt.xml:11: replace-with

[gwt-contrib] Re: Add two new ClientBundle annotations: (issue714801)

2010-07-29 Thread fredsa
http://gwt-code-reviews.appspot.com/714801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] No longer require RPCs to contain a 'Content-Length' HTTP request header, thus (issue727801)

2010-07-29 Thread fredsa
Reviewers: jat, Description: No longer require RPCs to contain a 'Content-Length' HTTP request header, thus enabling support for XHR with 'Transfer-Encoding: Chunked'. Review by: j...@google.com Please review this at http://gwt-code-reviews.appspot.com/727801/show Affected files: M

[gwt-contrib] Re: Partial commit towards making instance methods real. Merged the execution paths (issue726801)

2010-07-29 Thread Ray Ryan
LGTM On Wed, Jul 28, 2010 at 6:19 PM, amitman...@google.com wrote: Reviewers: Ray Ryan, Description: Partial commit towards making instance methods real. Merged the execution paths for the syncRequest and RequestObject. Patch by: amitmanjhi Review by: rjrjr (desk review) Please

[gwt-contrib] Re: No longer require RPCs to contain a 'Content-Length' HTTP request header, thus (issue727801)

2010-07-29 Thread jat
http://gwt-code-reviews.appspot.com/727801/diff/1/2 File user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java (right): http://gwt-code-reviews.appspot.com/727801/diff/1/2#newcode183 user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java:183: int byteCount = in.read(buffer); Does

[gwt-contrib] Re: Add two new ClientBundle annotations: (issue714801)

2010-07-29 Thread bobv
LGTM with minor changes. http://gwt-code-reviews.appspot.com/714801/diff/10001/11001 File user/src/com/google/gwt/resources/client/DataResource.java (right): http://gwt-code-reviews.appspot.com/714801/diff/10001/11001#newcode41 user/src/com/google/gwt/resources/client/DataResource.java:41:

[gwt-contrib] Re: Begin to convert DynaTableRF sample to using UiBinder. (issue698802)

2010-07-29 Thread bobv
http://gwt-code-reviews.appspot.com/698802/diff/1/5 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget.ui.xml (right): http://gwt-code-reviews.appspot.com/698802/diff/1/5#newcode17

[gwt-contrib] Re: Adds Java classes for JSON serialization/deserialization to complement (issue696801)

2010-07-29 Thread zundel
On 2010/07/19 14:26:03, zundel wrote: Thanks for all the feedback. My responses to the comments from the Rays, Thomas, John and Scott: - We need functionality in the compiler to create JSON output to create a performance analysis tool. We are just using JSON as an exported data format,

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

2010-07-29 Thread rice
http://gwt-code-reviews.appspot.com/710802/diff/1/3 File user/src/com/google/gwt/cell/client/Cell.java (right): http://gwt-code-reviews.appspot.com/710802/diff/1/3#newcode71 user/src/com/google/gwt/cell/client/Cell.java:71: boolean isEditing(Element element, Object key); Good idea. On

[gwt-contrib] Re: Begin to convert DynaTableRF sample to using UiBinder. (issue698802)

2010-07-29 Thread Ray Ryan
LGTM On Thu, Jul 29, 2010 at 6:22 AM, b...@google.com wrote: http://gwt-code-reviews.appspot.com/698802/diff/1/5 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget.ui.xml (right): http://gwt-code-reviews.appspot.com/698802/diff/1/5#newcode17

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

2010-07-29 Thread rjrjr
http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

2010-07-29 Thread rjrjr
Still not ready for review, just sharing the progress. Activities no longer have to clean up any event handlers they register, and ActivityManger should be exception proof. http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Ensure bridgeMethods is initialized, even when constructed from other subtypes, such as MissingT... (issue708802)

2010-07-29 Thread Scott Blum
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-07-29 Thread conroy
Reviewers: scottb, Description: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole optimizations R: scottb Please review this at http://gwt-code-reviews.appspot.com/728801/show Affected files: M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java D

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-07-29 Thread conroy
(rebase from superdevmode) http://gwt-code-reviews.appspot.com/728801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add two new ClientBundle annotations: (issue714801)

2010-07-29 Thread fredsa
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001 File user/src/com/google/gwt/resources/client/DataResource.java (right): http://gwt-code-reviews.appspot.com/714801/diff/10001/11001#newcode41 user/src/com/google/gwt/resources/client/DataResource.java:41: public @interface DoNotEmbed

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-07-29 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/728801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-07-29 Thread scottb
Nit: http://gwt-code-reviews.appspot.com/728801/diff/1/2 File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/728801/diff/1/2#newcode125 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:125: private final Styles styles = new Styles();; Extra

[gwt-contrib] Re: Split LogManager class into an set of Impl classes so that any LogManager calls (issue638802)

2010-07-29 Thread unnurg
http://gwt-code-reviews.appspot.com/638802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Split LogManager class into an set of Impl classes so that any LogManager calls (issue638802)

2010-07-29 Thread unnurg
http://gwt-code-reviews.appspot.com/638802/diff/1/2 File user/src/com/google/gwt/logging/LogImpl.gwt.xml (right): http://gwt-code-reviews.appspot.com/638802/diff/1/2#newcode11 user/src/com/google/gwt/logging/LogImpl.gwt.xml:11: replace-with

[gwt-contrib] Remove bogus @SuppressWarnings that eclipse wanted (issue729801)

2010-07-29 Thread rjrjr
Reviewers: tobyr, Description: Remove bogus @SuppressWarnings that eclipse wanted Review by: to...@google.com Please review this at http://gwt-code-reviews.appspot.com/729801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java Index:

[gwt-contrib] Re: Remove bogus @SuppressWarnings that eclipse wanted (issue729801)

2010-07-29 Thread tobyr
LGTM http://gwt-code-reviews.appspot.com/729801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adds a new CrossSiteIframeLinker. This linker works cross-site, (issue726802)

2010-07-29 Thread spoon
Reviewers: jgw, Description: Adds a new CrossSiteIframeLinker. This linker works cross-site, because it uses a script tag to download code instead of XHR. However, like the iframe linker, it still uses an iframe to hold all the installed code. Review by: j...@google.com Please review this at

[gwt-contrib] Re: Adds a new CrossSiteIframeLinker. This linker works cross-site, (issue726802)

2010-07-29 Thread spoon
This is ready for review. It's almost the same as this change: http://gwt-code-reviews.appspot.com/726802 The only difference is that this patch makes a new linker rather than updating the XS linker in place. The contents of the new linker are the same as what was in the previous patch.

[gwt-contrib] Re: Adds a new CrossSiteIframeLinker. This linker works cross-site, (issue726802)

2010-07-29 Thread spoon
Err, make that the following issue: http://gwt-code-reviews.appspot.com/674802 http://gwt-code-reviews.appspot.com/726802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Lazily generate LocaleInfoImpl (rebase from superdevmode) (issue619807)

2010-07-29 Thread conroy
Reviewers: scottb, Description: Lazily generate LocaleInfoImpl (rebase from superdevmode) Review by: sco...@google.com Please review this at http://gwt-code-reviews.appspot.com/619807/show Affected files: M user/src/com/google/gwt/i18n/client/LocaleInfo.java --

[gwt-contrib] Forgot to commit .classpath and .project for DynaTableRf due to (issue721802)

2010-07-29 Thread rjrjr
Reviewers: amitmanjhi, Description: Forgot to commit .classpath and .project for DynaTableRf due to .gitignore settings. Review by: amitman...@google.com Please review this at http://gwt-code-reviews.appspot.com/721802/show Affected files: A eclipse/samples/DynaTableRf/.classpath A

[gwt-contrib] [google-web-toolkit] r8439 committed - Remove bogus @SuppressWarnings that eclipse wanted...

2010-07-29 Thread codesite-noreply
Revision: 8439 Author: rj...@google.com Date: Thu Jul 29 09:21:20 2010 Log: Remove bogus @SuppressWarnings that eclipse wanted Review at http://gwt-code-reviews.appspot.com/729801 Review by: to...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8439 Modified:

[gwt-contrib] Re: Forgot to commit .classpath and .project for DynaTableRf due to (issue721802)

2010-07-29 Thread Amit Manjhi
LGTM On Thu, Jul 29, 2010 at 12:47 PM, rj...@google.com wrote: Reviewers: amitmanjhi, Description: Forgot to commit .classpath and .project for DynaTableRf due to .gitignore settings. Review by: amitman...@google.com Please review this at http://gwt-code-reviews.appspot.com/721802/show

Re: [gwt-contrib] Phasing in a new, unified linker

2010-07-29 Thread Matt Mastracci
On 2010-07-26, at 4:56 PM, John Tamplin wrote: Is the new linker designed to curtail extension, or to sanely encourage it? The existing primary linkers ended up getting extended in brittle ways. That's a good point. Let's make it a final class to start with, and open up extension points

[gwt-contrib] Re: Adds a new CrossSiteIframeLinker. This linker works cross-site, (issue726802)

2010-07-29 Thread Matt Mastracci
[manually forwarding to list due to subscription bug...] Wow, this looks great. This is exactly what I had imagined. Once dev mode is in place we should be able to switch dotspots over to this from our current custom linker. I was looking through the latest SelectionScriptLinker in trunk and

Re: [gwt-contrib] Phasing in a new, unified linker

2010-07-29 Thread Lex Spoon
I don't have a strong opinion about it. They can be non-final, with simply no particular effort to truly make them extensible. I think it might be possible to move the template JS files to GWT-translated code with extension points managed through rebinding and overriding. Until then, making

[gwt-contrib] [google-web-toolkit] r8441 committed - Refactoring to one top level class per .java file, since some...

2010-07-29 Thread codesite-noreply
Revision: 8441 Author: fabb...@google.com Date: Thu Jul 29 09:26:40 2010 Log: Refactoring to one top level class per .java file, since some tools don't understand more than that. Review by: jat Review at http://gwt-code-reviews.appspot.com/686801

[gwt-contrib] [google-web-toolkit] r8442 committed - Forgot to commit .classpath and .project for DynaTableRf due to...

2010-07-29 Thread codesite-noreply
Revision: 8442 Author: rj...@google.com Date: Thu Jul 29 09:50:39 2010 Log: Forgot to commit .classpath and .project for DynaTableRf due to .gitignore settings. Review at http://gwt-code-reviews.appspot.com/721802 Review by: amitman...@google.com

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

2010-07-29 Thread rjrjr
http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: No longer require RPCs to contain a 'Content-Length' HTTP request header, thus (issue727801)

2010-07-29 Thread fredsa
Thanks, Chris. I'll plan a separate patch for that. http://gwt-code-reviews.appspot.com/727801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: No longer require RPCs to contain a 'Content-Length' HTTP request header, thus (issue727801)

2010-07-29 Thread fredsa
http://gwt-code-reviews.appspot.com/727801/diff/1/2 File user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java (right): http://gwt-code-reviews.appspot.com/727801/diff/1/2#newcode183 user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java:183: int byteCount = in.read(buffer); The

[gwt-contrib] Re: Add two new ClientBundle annotations: (issue714801)

2010-07-29 Thread fredsa
http://gwt-code-reviews.appspot.com/714801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8443 committed - Re-introduces UiBinder parser for AbsolutePanel, now backward...

2010-07-29 Thread codesite-noreply
Revision: 8443 Author: gwt.mirror...@gmail.com Date: Thu Jul 29 11:09:15 2010 Log: Re-introduces UiBinder parser for AbsolutePanel, now backward compatible. Restores work introduced at r8430, rolled back at r8432. Patch by konstantin.scheg...@gmail.com Review by rj...@google.com

[gwt-contrib] DynatableRf refactoring in response to http://code.google.com/p/google-web-toolkit/source/detail... (issue674803)

2010-07-29 Thread amitmanjhi
Reviewers: Ray Ryan, Description: DynatableRf refactoring in response to http://code.google.com/p/google-web-toolkit/source/detail?r=8436 Patch by: amitmanjhi Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/674803/show Affected files: M

[gwt-contrib] Re: DynatableRf refactoring in response to http://code.google.com/p/google-web-toolkit/source/detail... (issue674803)

2010-07-29 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/674803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8444 committed - rollback of optimizations that caused problems for some projects...

2010-07-29 Thread codesite-noreply
Revision: 8444 Author: unn...@google.com Date: Thu Jul 29 12:27:21 2010 Log: rollback of optimizations that caused problems for some projects Review by: con...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8444 Added:

[gwt-contrib] Ensure that we give createTempFile at least 3 characters for the prefix (issue699804)

2010-07-29 Thread conroy
Reviewers: Lex, Description: Ensure that we give createTempFile at least 3 characters for the prefix See: http://code.google.com/p/google-weab-toolkit/issues/detail?id=5178 Review by: sp...@google.com Please review this at http://gwt-code-reviews.appspot.com/699804/show Affected files: M

[gwt-contrib] [google-web-toolkit] r8445 committed - DynatableRf refactoring in response to http://code.google.com/p/google...

2010-07-29 Thread codesite-noreply
Revision: 8445 Author: amitman...@google.com Date: Thu Jul 29 12:54:53 2010 Log: DynatableRf refactoring in response to http://code.google.com/p/google-web-toolkit/source/detail?r=8436 Patch by: amitmanjhi Review by: rjrjr Review at http://gwt-code-reviews.appspot.com/674803

[gwt-contrib] Re: Implement ROO-933 and ROO-935. Handle java.lang.{Byte/Short/Character/Integer/Long/BigDecimal/Bi... (issue700802)

2010-07-29 Thread amitmanjhi
I cursorily looked at the patch. It looks good but it seems you forgot to upload the changes to the files in the bikeshed dir. I also had a few minor comments, noted below. Let me know when you update the complete patch. http://gwt-code-reviews.appspot.com/700802/diff/2001/3004 File

[gwt-contrib] Change the way we include the User Auth files, keeping more of them (issue721803)

2010-07-29 Thread unnurg
Reviewers: Ray Ryan, Description: Change the way we include the User Auth files, keeping more of them checked into GWT code rather than generated by roo Please review this at http://gwt-code-reviews.appspot.com/721803/show Affected files: M