Re: [gwt-contrib] Sub entities not being filled in

2010-10-04 Thread Ray Cromwell
Thanks Sam, yeah, this is a big bad bug. On Sun, Oct 3, 2010 at 9:33 PM, Sam Gross colesb...@gmail.com wrote: I also ran into a bug today where sub entities were not always deserialized. The problem is in that entries in related objects may refer to entities that haven't been deserialized

Re: [gwt-contrib] Sub entities not being filled in

2010-10-04 Thread Patrick Julien
For the editor part, I can see in the generated code for my editor that public static void traverseEditor(com.*.client.ui.EditorContainer editor, String prefix, java.util.ListString paths) { } is completely empty but in this case, EditorContainer contains OfficeEditor because it's a

[gwt-contrib] Re: Changes in com.google.gwt.app land to catch up to the RequestFactory (issue946802)

2010-10-04 Thread t . broyer
http://gwt-code-reviews.appspot.com/946802/diff/8001/9005 File user/src/com/google/gwt/app/place/CreateAndEditProxy.java (right): http://gwt-code-reviews.appspot.com/946802/diff/8001/9005#newcode54 user/src/com/google/gwt/app/place/CreateAndEditProxy.java:54: display.setWidget(null); Er, really

[gwt-contrib] Re: Fixing a ConcurrentModificationException in JsonRequestProcessor that occurs when you use a sett... (issue945801)

2010-10-04 Thread jlabanca
committed as r8920 http://gwt-code-reviews.appspot.com/945801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Sub entities not being filled in

2010-10-04 Thread Patrick Julien
Bob, any suggestions for a work around for the moment? On Mon, Oct 4, 2010 at 9:41 AM, Patrick Julien pjul...@gmail.com wrote: For the editor part, I can see in the generated code for my editor that public static void traverseEditor(com.*.client.ui.EditorContainer editor, String prefix,

[gwt-contrib] Re: Making Showcase generate a hidden site map to Showcase to make it crawlable. Also ensuring that ... (issue952801)

2010-10-04 Thread kprobst
LGTM http://gwt-code-reviews.appspot.com/952801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix 'ant dist-dev' and 'ant-doc' builds: (issue953801)

2010-10-04 Thread rice
Reviewers: fabbott, Description: Fix 'ant dist-dev' and 'ant-doc' builds: 1) Add memory to java heap for 'gwt.javac' 2) Break up a line in JsonResults that caused javac to exit 3) Remove an annotation in SafeHtmlHostedModeUtils that caused javadoc to crash 4) Update the list of packages for

[gwt-contrib] Re: Fix 'ant dist-dev' and 'ant-doc' builds: (issue953801)

2010-10-04 Thread fabbott
http://gwt-code-reviews.appspot.com/953801/diff/1/5 File user/src/com/google/gwt/requestfactory/client/impl/messages/JsonResults.java (right): http://gwt-code-reviews.appspot.com/953801/diff/1/5#newcode28 user/src/com/google/gwt/requestfactory/client/impl/messages/JsonResults.java:28: // javac

[gwt-contrib] [google-web-toolkit] r8929 committed - Making Showcase generate a hidden site map to make it crawlable. Also ...

2010-10-04 Thread codesite-noreply
Revision: 8929 Author: gwt.mirror...@gmail.com Date: Mon Oct 4 13:22:55 2010 Log: Making Showcase generate a hidden site map to make it crawlable. Also ensuring that the select box used to select source code always contains at least one option to work around an HtmlUnit innerHtml bug that

[gwt-contrib] Fix Eclipse / Checkstyle / Javadoc warnings (issue954801)

2010-10-04 Thread rice
Reviewers: jat, Description: Fix Eclipse / Checkstyle / Javadoc warnings Please review this at http://gwt-code-reviews.appspot.com/954801/show Affected files: M dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java M dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java M

[gwt-contrib] [google-web-toolkit] r8930 committed - Fix exit on cancel from create activity. Wasn't going to a...

2010-10-04 Thread codesite-noreply
Revision: 8930 Author: rj...@google.com Date: Mon Oct 4 10:12:28 2010 Log: Fix exit on cancel from create activity. Wasn't going to a new place, so you couldn't try to create again. Also restore old behavior of not trying to save w/no changes, didn't mean to delete it. Review at

[gwt-contrib] Re: Public: First take at GWT validation that actually validates on the client side. (issue863801)

2010-10-04 Thread bobv
LGTM, just comment / documentation nits. http://gwt-code-reviews.appspot.com/863801/diff/32001/33004 File samples/common.ant.xml (right): http://gwt-code-reviews.appspot.com/863801/diff/32001/33004#newcode100 samples/common.ant.xml:100: /classpath Low priority: Can you extract this classpath

Re: [gwt-contrib] Add Support for server side script selection in linker (issue941802)

2010-10-04 Thread Arthur Kalmenson
Wow, this is great! I'm guessing this means we can cut the startup round trips to one? Is this going into GWT 2.1? Exciting stuff. -- Arthur Kalmenson On Fri, Oct 1, 2010 at 6:09 PM, unn...@google.com wrote: Reviewers: jgw, Description: Add Support for server side script selection in

[gwt-contrib] [google-web-toolkit] r8931 committed - Created a branch for the GWT 2.1 release.

2010-10-04 Thread codesite-noreply
Revision: 8931 Author: p...@google.com Date: Mon Oct 4 13:53:40 2010 Log: Created a branch for the GWT 2.1 release. http://code.google.com/p/google-web-toolkit/source/detail?r=8931 Added: /releases/2.1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Sub entities not being filled in

2010-10-04 Thread Patrick Julien
As an update to this issue, I can confirm that I have an editor working in another scenario where the depth level doesn't go beyond, well, 1 I guess. So I an editor, and it has a list in it but the list doesn't contain other EntityProxy's The two issues still remain: driver.getPath() isn't able

[gwt-contrib] Re: Fix verifyPositionStatic() to that RooPanel.get() is explicitly allowed, e.g. (issue931801)

2010-10-04 Thread fredsa
http://gwt-code-reviews.appspot.com/931801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Sub entities not being filled in

2010-10-04 Thread BobV
Your feedback has been very helpful in finding out where the weak points in our APIs and implementations are. driver.getPath() isn't able to completely scan an editor tree when it contains CompositeEditor's that, they themselves, have more editors in their hierarchy I'm thinking about how to

Re: [gwt-contrib] Sub entities not being filled in

2010-10-04 Thread Ray Cromwell
The following test case passes: public void testCollectionSubProperties() { delayTestFinish(DELAY_TEST_FINISH); simpleFooRequest().getSimpleFooWithSubPropertyCollection().with( selfOneToManyField.fooField).fire(new ReceiverSimpleFooProxy() { @Override public void

Re: [gwt-contrib] Sub entities not being filled in

2010-10-04 Thread Patrick Julien
On Mon, Oct 4, 2010 at 5:32 PM, BobV b...@google.com wrote: Your feedback has been very helpful in finding out where the weak points in our APIs and implementations are. driver.getPath() isn't able to completely scan an editor tree when it contains CompositeEditor's that, they themselves,

[gwt-contrib] attachevent.handler

2010-10-04 Thread Stephen Haberman
Hi, We just updated to trunk to use the new AttachEvent (good timing, thanks!), and a beginner GWT dev here expressed confusion at the Handler interface. I explained its actually AttachEvent.Handler, an inner interface. Which he then understood, but pointed at is not consistent with the rest of

[gwt-contrib] Re: Fixes to use Java 1.5 compatible JARs (issue939802)

2010-10-04 Thread Amit Manjhi
LGTM On Mon, Oct 4, 2010 at 3:11 PM, rchan...@google.com wrote: Reviewers: amitmanjhi, Description: Fixes to use Java 1.5 compatible JARs Fixed DynaTableRf eclipse .classpath to use json-1.5.jar Fixed build scripts and eclipse classpaths to use java 1.5 compatible StreamHtmlParser JAR

[gwt-contrib] Fixes to use Java 1.5 compatible JARs (issue939802)

2010-10-04 Thread rchandia
Reviewers: amitmanjhi, Description: Fixes to use Java 1.5 compatible JARs Fixed DynaTableRf eclipse .classpath to use json-1.5.jar Fixed build scripts and eclipse classpaths to use java 1.5 compatible StreamHtmlParser JAR Review by: amitman...@google.com Please review this at

[gwt-contrib] Re: Making Showcase generate a hidden site map to Showcase to make it crawlable. Also ensuring that ... (issue952801)

2010-10-04 Thread jlabanca
committed as r8929 http://gwt-code-reviews.appspot.com/952801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Changes the default row count of HasDataPresenter from Integer.MIN_VALUE to a more reasonable 0.... (issue950802)

2010-10-04 Thread jlabanca
Reviewers: rice, Description: Changes the default row count of HasDataPresenter from Integer.MIN_VALUE to a more reasonable 0. We use the boolean isRowCountExact to determine if we actually have 0 rows, or just think we do. Please review this at http://gwt-code-reviews.appspot.com/950802/show

[gwt-contrib] Adding examples for cell widgets and data providers. (issue955801)

2010-10-04 Thread jlabanca
Reviewers: rice, Description: Adding examples for cell widgets and data providers. Please review this at http://gwt-code-reviews.appspot.com/955801/show Affected files: A user/javadoc/com/google/gwt/examples/cell/CellExample.java A

[gwt-contrib] Fixed the serialization bug that the version numbers were not being sent back (issue930802)

2010-10-04 Thread amitmanjhi
Reviewers: robertvawter, Description: Fixed the serialization bug that the version numbers were not being sent back on an update (which impacts the event firing). Fixed the test and test harness (SimpleBar, SimpleFoo, SimpleFooString). The tests were only passing purely due to luck -- the

Re: [gwt-contrib] Sub entities not being filled in

2010-10-04 Thread Patrick Julien
OK, this also works for me, where it breaks down is more collections So I go back to practice, offices and phones class Practice { private ListOffice offices; } class Office { private ListPhone phones; } practive is unique and has a list of offices What I get back has all the practice seeded.

[gwt-contrib] Re: Fixed the serialization bug that the version numbers were not being sent back (issue930802)

2010-10-04 Thread amitmanjhi
http://gwt-code-reviews.appspot.com/930802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Changes the default row count of HasDataPresenter from Integer.MIN_VALUE to a more reasonable 0.... (issue950802)

2010-10-04 Thread rice
LGTM http://gwt-code-reviews.appspot.com/950802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix ROO-1488 where forward references were not correctly resolved. (issue958801)

2010-10-04 Thread bobv
Reviewers: cromwellian, rjrjr, Message: I realized that the server never actually sends diffs, it just sends a current snapshot of value fields, plus with() references for the return object. The problem just boils downs to ensuring that a canonical entity is used when constructing the