Revision: 9263
Author: b...@google.com
Date: Mon Nov 22 04:58:42 2010
Log: Edited wiki page RequestFactory_2_1_1 through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9263
Modified:
/wiki/RequestFactory_2_1_1.wiki
===
--- /wi
http://gwt-code-reviews.appspot.com/1123801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I handled those cases and added unit tests.
http://gwt-code-reviews.appspot.com/1123801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
While developing a medium-large scale app with GWT, I repeatedly
encountered the need to pass around UI objects that "can be hidden",
that is, have the interface:
interface Hideable {
public void setVisible(boolean isVisible);
}
GWT's UIObject already has such a method, but nowhere is such a
http://gwt-code-reviews.appspot.com/1116801/diff/1/6
File plugins/ie/installer/build.cmd (right):
http://gwt-code-reviews.appspot.com/1116801/diff/1/6#newcode8
plugins/ie/installer/build.cmd:8: echo IMPORTANT: Make sure
"%~dp0oophm.wsx" is checked out and writable!
On 2010/11/18 16:17:54, conroy
http://gwt-code-reviews.appspot.com/1116801/diff/1/11
File plugins/ie/installer/wix/candle.exe.config (right):
http://gwt-code-reviews.appspot.com/1116801/diff/1/11#newcode3
plugins/ie/installer/wix/candle.exe.config:3: Copyright (c) Microsoft
Corporation. All rights reserved.
On 2010/11/22 16:
Revision: 9264
Author: tomer...@google.com
Date: Mon Nov 22 06:12:51 2010
Log: Add SafeHtml support to DirectionEstimator
http://code.google.com/p/google-web-toolkit/source/detail?r=9264
Modified:
/trunk/tools/api-checker/config/gwt21_22userApi.conf
/trunk/user/src/com/google/gwt/i18n/shared/D
LGTM.
Nice! I would probably just add a test for empty strings.
http://gwt-code-reviews.appspot.com/1123801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Only cosmetic nits
http://gwt-code-reviews.appspot.com/1130801/diff/21001/4006
File user/src/com/google/gwt/autobean/shared/AutoBeanFactory.java
(right):
http://gwt-code-reviews.appspot.com/1130801/diff/21001/4006#newcode85
user/src/com/google/gwt/autobean/shared/AutoBeanFactory.java:85:
Reviewers: rchandia,
Description:
Making Column implement HasAlignment so users can specify the default
alignment of cells in a column. In the future, we may add a way to
specify the alignment of specific Cells.
Please review this at http://gwt-code-reviews.appspot.com/1134801/show
Affected f
Revision: 9265
Author: zun...@google.com
Date: Mon Nov 22 07:33:04 2010
Log: Makes part of the Compiler Report (SOYC) smaller by
replacing a flat HTML output with output
that is generated with JavaScript from a dictionary of
strings. This decreases the size of the dependency
reports by a factor o
LGTM. With nits.
http://gwt-code-reviews.appspot.com/1131801/diff/1/4
File
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTestValidator.java
(right):
http://gwt-code-reviews.appspot.com/1131801/diff/1/4#newcode39
samples/validationtck/test/com/google/g
Reviewers: rchandia, rjrjr,
Description:
Rework the way OperationMessages are processed to allow all domain
objects to be loaded at once.
http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1
Patch by: bobv
Review by: rchandia,rjrjr
Please review this at http://gwt-code-reviews.
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005
File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java
(right):
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005#newcode43
user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java:43:
RpcToken getRpcToken();
On
Reviewers: rchandia,
Description:
Fix covariant return types for methods declared in domain objects.
Issue 5512.
Patch by: bobv
Review by: rchandia
Please review this at http://gwt-code-reviews.appspot.com/1136801/show
Affected files:
M
user/src/com/google/gwt/requestfactory/server/Request
LGTM
http://gwt-code-reviews.appspot.com/1134801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat, jlabanca,
Description:
Bidi support for ListBox
Review by: aha...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1137801/show
Affected files:
M user/src/com/google/gwt/user/client/ui/ListBox.java
M user/test/com/google/gwt/user/client/ui/ListBoxTest.ja
http://gwt-code-reviews.appspot.com/1131801/diff/1/4
File
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTestValidator.java
(right):
http://gwt-code-reviews.appspot.com/1131801/diff/1/4#newcode39
samples/validationtck/test/com/google/gwt/sample/validati
Reviewers: rchandia,
Description:
Add a test for issue 5134 to ensure that RequestFactory interfaces can
be extended.
Patch by: bobv
Review by: rchandia
Reported by: pjulien
Please review this at http://gwt-code-reviews.appspot.com/1138801/show
Affected files:
A user/test/com/google/gwt/requ
http://gwt-code-reviews.appspot.com/1136801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9267
Author: b...@google.com
Date: Mon Nov 22 12:27:50 2010
Log: Edited wiki page RequestFactory_2_1_1 through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9267
Modified:
/wiki/RequestFactory_2_1_1.wiki
===
--- /wi
Revision: 9268
Author: gwt.mirror...@gmail.com
Date: Mon Nov 22 09:21:28 2010
Log: Public: Only process requested groups.
Review at http://gwt-code-reviews.appspot.com/1131801
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9268
Added:
/trunk/sample
Comment by sombr...@gmail.com:
please dudes do something about linux 64 bits and firefox 3.6. It's quite
annoying.
i'm on slackware64 13.1 and firefox 3.6.12, and plugin asks to get
installed again and again and again.
For more information:
http://code.google.com/p/google-web-toolkit/wiki
Comment by sombr...@gmail.com:
also, add a flag on configs to enable debug for plugin would be good.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: kathrin,
Description:
Reduces the size of the soyc report by combining many s
mall files into larger files. Reduces the number of
files generated by the report by up to a factor of 10
if you are using split points.
- Split Point Status reports are now one page
per permutation
- Left
Ray,
Good question, but yeah, that case will be handled too. Leaf types
don't get visited for arrays at all (thus the root cause of this
problem). I have added another test case with the Enum[][]
reference, I'll commit that and add to the patch shortly.
Jason
On Mon, Nov 22, 2010 at 3:15 PM,
LGTM
http://gwt-code-reviews.appspot.com/1136801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Comment by sombr...@gmail.com:
FYI using firefox 3.5.2 from slackware64 13.0 will get thing working. But
firebug is gone...
For more information:
http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9269
Author: jlaba...@google.com
Date: Mon Nov 22 10:20:59 2010
Log: Making Column implement HasAlignment so users can specify the default
alignment of cells in a column. In the future, we may add a way to specify
the alignment of specific Cells.
Issue: 5623
Review at http://gwt-c
committed as r9269
http://gwt-code-reviews.appspot.com/1134801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Fixes two DevMode issues:
1 - Generic SingleImplJso interfaces are now mapped by their
JGenericType in
TypeOracle instead of their JParameterizedType since lookups in DevMode
will use the generic type.
2 - Fixes a bug in CompilingClassLoader where SingleImplJso int
LGTM
Tested and everything works well.
http://gwt-code-reviews.appspot.com/1126801/diff/2002/6002
File
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTable.java
(right):
http://gwt-code-reviews.appspot.com/1126801/diff/2002/6002#newcode178
samples/showcase/src/co
LGTM
http://gwt-code-reviews.appspot.com/1135801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1133801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1140801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Fixing a few bugs in Cell widgets.
Issue 5625: Fixes a bug in CellBrowser where the first item in each list
is not clickable because we are too optimistic about not reselecting a
row that is already selected. Now we will reselect a row if the row
index changed OR
Revision: 9270
Author: gwt.mirror...@gmail.com
Date: Mon Nov 22 11:18:02 2010
Log: Fix covariant return types for methods declared in domain objects.
Issue 5512.
Patch by: bobv
Review by: rchandia
Review at http://gwt-code-reviews.appspot.com/1136801
http://code.google.com/p/google-web-toolkit/s
LGTM
http://gwt-code-reviews.appspot.com/1138801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1126801/diff/2002/6002
File
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTable.java
(right):
http://gwt-code-reviews.appspot.com/1126801/diff/2002/6002#newcode178
samples/showcase/src/com/google/gwt/sample/showcase/client/conte
Revision: 9271
Author: gwt.mirror...@gmail.com
Date: Mon Nov 22 14:41:45 2010
Log: Rework the way OperationMessages are processed to allow all domain
objects to be loaded at once.
http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1
Patch by: bobv
Review by: rchandia,rjrjr
Rev
LGTM
http://gwt-code-reviews.appspot.com/1137801/diff/1/3
File user/test/com/google/gwt/user/client/ui/ListBoxTest.java (right):
http://gwt-code-reviews.appspot.com/1137801/diff/1/3#newcode117
user/test/com/google/gwt/user/client/ui/ListBoxTest.java:117:
extra spaces
http://gwt-code-reviews.ap
Revision: 9272
Author: b...@google.com
Date: Mon Nov 22 11:42:05 2010
Log: Add a test for issue 5134 to ensure that RequestFactory interfaces can
be extended.
Patch by: bobv
Review by: rchandia
Reported by: pjulien
Review at http://gwt-code-reviews.appspot.com/1138801
http://code.google.com/p
LGTM
http://gwt-code-reviews.appspot.com/1141801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Public: Handle fields marked @Valid
Please review this at http://gwt-code-reviews.appspot.com/1142801/show
Affected files:
A
samples/validation/src/com/google/gwt/sample/validation/shared/Address.java
M
samples/validation/src/com/google/gwt/sample/vali
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005
File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java
(right):
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005#newcode43
user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java:43:
RpcToken getRpcToken();
On
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005
File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java
(right):
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005#newcode43
user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java:43:
RpcToken getRpcToken();
Ok
committed as r9274
http://gwt-code-reviews.appspot.com/1126801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
47 matches
Mail list logo
