What features in Java 6 would be so fundamental to GWT that 1.5 becomes
deprecated ?
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Today we're one step closer to shipping the Google Plugin for Eclipse and
GWT SDK 2.2. The first release candidates of both of these products are
ready for use, and can be installed and/or download via the links below.
Google Plugin for Eclipse 2.2 RC1 (including the GWT SDK)
Eclips
Reviewers: drfibonacci,
Description:
Bump samples/expenses/pom.xml version number
Please review this at http://gwt-code-reviews.appspot.com/1329803/show
Affected files:
M samples/expenses/pom.xml
M tools/scripts/maven_script.sh
Index: samples/expenses/pom.xml
Reviewers: jat,
Description:
Provide mechanism to suppress warning dialog when runtime and compile
time user.agent propert values disagree, i.e. via
Review by: j...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1344802/show
Affected files:
M user/src/com/google/gwt/us
Reviewers: cromwellian, knorton,
Message:
It turns out that there's a lot of infrastructure we built into SOYC
that is essentially unused today. Most of what I'm removing has no
impact on SOYC output.
There are slight changes that can be observed in detailedStories.xmls.
I got rid of literal tr
Revision: 9682
Author: sco...@google.com
Date: Mon Feb 7 12:59:41 2011
Log: Make SOYC produce consistent output.
http://gwt-code-reviews.appspot.com/1338805/show
Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9682
Modified:
/trunk/dev/core/src/c
Reviewers: pdr,
Description:
Adding a LoadingStateEvent to CellList and CellTable so users can
receive an event when the data is loaded. Previously, LoadingState was
a package protected enum used to show the loading indicator in CellTable
and empty list message in CellList. Now, LoadingState is
LGTM except for property name.
http://gwt-code-reviews.appspot.com/1336802/diff/8001/1009
File dev/core/src/com/google/gwt/dev/js/JsStringInterner.java (right):
http://gwt-code-reviews.appspot.com/1336802/diff/8001/1009#newcode150
dev/core/src/com/google/gwt/dev/js/JsStringInterner.java:150:
Sy
http://gwt-code-reviews.appspot.com/1336802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Should be fixed now (weird it didn't pick up changes)
http://gwt-code-reviews.appspot.com/1336802/diff/1/4
File dev/core/src/com/google/gwt/dev/js/JsStringInterner.java (right):
http://gwt-code-reviews.appspot.com/1336802/diff/1/4#newcode48
dev/core/src/com/google/gwt/dev/js/JsStringInterner.
From a maven perspective, this is a much better solution than bundling
validation classes in gwt-user.jar. However, will the changes to
.classpathsrc and/or the gwtc ant target affect the GWT compiler when
called from the maven plugin?
http://gwt-code-reviews.appspot.com/1342803/show
--
http://g
Thanks, done.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9681
Author: gwt.mirror...@gmail.com
Date: Mon Feb 7 14:42:21 2011
Log: Modifies CompiledClass to be serializable
Review at http://gwt-code-reviews.appspot.com/1329802
http://code.google.com/p/google-web-toolkit/source/detail?r=9681
Added:
/trunk/dev/core/test/com/google/gwt/dev/jav
Revision: 9680
Author: ncha...@google.com
Date: Mon Feb 7 10:54:02 2011
Log: Turn off a test because of issue 5882.
Review at http://gwt-code-reviews.appspot.com/1344801
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9680
Modified:
/trunk/user/tes
LGTM
http://gwt-code-reviews.appspot.com/1342803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On Mon, Feb 7, 2011 at 12:15 PM, Eric Ayers wrote:
> I don't have anything else.
>
> On Mon, Feb 7, 2011 at 2:24 PM, wrote:
> > Did you guys want to re-review, or having fixed the things you
> > mentioned, is this LGTM?
> >
> > http://gwt-code-reviews.appspot.com/1342801/show
> >
>
>
>
>
Revision: 9679
Author: zun...@google.com
Date: Mon Feb 7 09:56:00 2011
Log: Removes @Override annotation from implemented interface methods.
Review at http://gwt-code-reviews.appspot.com/1343802
Review by: jbrosenb...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9679
LGTM
On 2011/02/07 21:03:48, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1344801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/02/07 21:04:43, rchandia wrote:
LGTM
On 2011/02/07 21:03:48, Nick Chalko wrote:
>
LGTM
http://gwt-code-reviews.appspot.com/1344801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Turn off a test because of issue 5882.
Please review this at http://gwt-code-reviews.appspot.com/1344801/show
Affected files:
M user/test/org/hibernate/jsr303/tck/tests/validation/ValidateGwtTest.java
Index:
user/test/org/hibernate/jsr303/tck/tests/valid
LGTM, just change Range -> JsName in the javadoc.
http://gwt-code-reviews.appspot.com/1338805/diff/1/2
File dev/core/src/com/google/gwt/core/ext/soyc/impl/SizeMapRecorder.java
(right):
http://gwt-code-reviews.appspot.com/1338805/diff/1/2#newcode45
dev/core/src/com/google/gwt/core/ext/soyc/impl/
Reviewers: rjrjr, Nick Chalko, drfibonacci,
Description:
Added validation jars to all calls to GWTC to provide classes rquired by
client-side validation. Fixes Issue 5950.
Please review this at http://gwt-code-reviews.appspot.com/1342803/show
Affected files:
M distro-source/build.xml
M sam
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010
File user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode66
user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:66:
* reso
(as submitted)
http://gwt-code-reviews.appspot.com/1329802/diff/1004/6
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right):
http://gwt-code-reviews.appspot.com/1329802/diff/1004/6#newcode267
dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java:267: String
internalName = CharOp
http://gwt-code-reviews.appspot.com/1329802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I don't have anything else.
On Mon, Feb 7, 2011 at 2:24 PM, wrote:
> Did you guys want to re-review, or having fixed the things you
> mentioned, is this LGTM?
>
> http://gwt-code-reviews.appspot.com/1342801/show
>
--
Eric Z. Ayers
Google Web Toolkit, Atlanta, GA USA
--
http://groups.google
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Did you guys want to re-review, or having fixed the things you
mentioned, is this LGTM?
http://gwt-code-reviews.appspot.com/1342801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1329802/diff/1004/5
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right):
http://gwt-code-reviews.appspot.com/1329802/diff/1004/5#newcode47
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:47: private
transient long cacheToken;
I'm jus
LGTM
http://gwt-code-reviews.appspot.com/1343802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
Update getGeckoVersion() to support beta versions of Firefox.
Previously, gecko versions of the form 2.0b10 would cause the regex to
get mad because it is missing a second period. This change updates the
gecko version detector to support gecko versions such as 1
LGTM
http://gwt-code-reviews.appspot.com/1329802/diff/1004/6
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right):
http://gwt-code-reviews.appspot.com/1329802/diff/1004/6#newcode267
dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java:267: String
internalName = CharOperation.ch
Reviewers: jbrosenberg,
Description:
Removes @Override annotation from implemented interface methods.
Please review this at http://gwt-code-reviews.appspot.com/1343802/show
Affected files:
M dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java
M dev/core/src/com/google/gwt/
updated patch
http://gwt-code-reviews.appspot.com/1329802/diff/1/2
File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1329802/diff/1/2#newcode1
dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:1:
package com.google.
http://gwt-code-reviews.appspot.com/1329802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1343801/diff/1/8
File user/src/com/google/gwt/validation/rebind/Util.java (right):
http://gwt-code-reviews.appspot.com/1343801/diff/1/8#newcode93
user/src/com/google/gwt/validation/rebind/Util.java:93: * @return
On 2011/02/07 15:33:16, rchandia wrote:
Remove
I think I'll revert the changes to the existing tests (keeping only the
changes introducing the new ones exercizing SkipInterfaceValidation),
and make a second patch about fixing them.
http://gwt-code-reviews.appspot.com/1338807/diff/1/4
File
user/src/com/google/gwt/requestfactory/shared/SkipInt
You can't do these things yet, but we've been discussing them.
On Thu, Feb 3, 2011 at 5:08 AM, Krishna wrote:
> Hi,
>
> Does RequestFactory EntityProxy supports AutoBean Category (http://
> code.google.com/p/google-web-toolkit/wiki/AutoBean#Categories) ?
>
> i. e. Can I define a Category for an
Hi,
Does RequestFactory EntityProxy supports AutoBean Category (http://
code.google.com/p/google-web-toolkit/wiki/AutoBean#Categories) ?
i. e. Can I define a Category for an EnitityProxy? If yes, how can I
do that?
It would be nice to define a category direct as an annotated Entity
method... If
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010
File user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/110014/111010#newcode66
user/src/com/google/gwt/resources/ext/ClientBundleRequirements.java:66:
* reso
LGTM, with nits
http://gwt-code-reviews.appspot.com/1343801/diff/1/8
File user/src/com/google/gwt/validation/rebind/Util.java (right):
http://gwt-code-reviews.appspot.com/1343801/diff/1/8#newcode93
user/src/com/google/gwt/validation/rebind/Util.java:93: * @return
Remove empty tags
http://gwt-c
http://code.google.com/p/google-web-toolkit/issues/detail?id=5988
Since you have a set of clearly-articulated reasons, I think this is a
good idea.
http://gwt-code-reviews.appspot.com/1338807/diff/1/4
File
user/src/com/google/gwt/requestfactory/shared/SkipInterfaceValidation.java
(right):
http
42 matches
Mail list logo
