Hey, it looks like it would fix this issue, cool!
http://code.google.com/p/google-web-toolkit/issues/detail?id=4893
According to my tests at the time, it would enable pruning of most
getClass() methods (at a minimum all those for abstract classes, which
are always overridden in the concrete
LGTM
http://gwt-code-reviews.appspot.com/1425807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
It actually does fix the abstract getClass() problem, I was noticing in the
generated output. I'll mark my change as fixing this issue.
On Tue, Apr 26, 2011 at 4:03 AM, t.bro...@gmail.com wrote:
Hey, it looks like it would fix this issue, cool!
http://gwt-code-reviews.appspot.com/1422810/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java (right):
Reviewers: zundel,
Description:
Adds cache of CollectClassData to make refresh faster.
This gives about 10% performance gain on big projects.
Please review this at http://gwt-code-reviews.appspot.com/1420809/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
Reviewers: scottb,
Description:
Allow enum ordinalization to work correctly for enum classes with no
values (i.e. empty enums).
Please review this at http://gwt-code-reviews.appspot.com/1423809/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
M
High-level, it seems like we might want to think about how to tie the
lifecycle of the data to the lifecycle of the associated
CompilationUnit/CompiledClass. Maybe this should actually be moved into
a lazy-initialized transient field in CompiledClass instead of having to
use a map.
Also, now
LGTM
http://gwt-code-reviews.appspot.com/1428803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
committed as r10067
http://gwt-code-reviews.appspot.com/1427804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM w/ nits
http://gwt-code-reviews.appspot.com/1423809/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
(right):
Revision: 10068
Author: zun...@google.com
Date: Tue Apr 19 09:50:32 2011
Log: Cherry pick r10025 into gwt/releases/2.3
http://code.google.com/p/google-web-toolkit/source/detail?r=10068
Modified:
/releases/2.3/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java
Revision: 10069
Author: gwt.mirror...@gmail.com
Date: Tue Apr 26 09:33:54 2011
Log: Cherry picking r10017 into releases/2.3m1 for public issue
http://gwt-code-reviews.appspot.com/1423801/
http://code.google.com/p/google-web-toolkit/source/detail?r=10069
Modified:
LGTM
http://gwt-code-reviews.appspot.com/1423808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb, jbrosenberg,
Description:
Autoformats a few files before patch
Please review this at http://gwt-code-reviews.appspot.com/1425809/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
M
http://gwt-code-reviews.appspot.com/1426805/diff/1/user/src/com/google/gwt/uibinder/elementparsers/AttachableHTMLPanelParser.java
File
user/src/com/google/gwt/uibinder/elementparsers/AttachableHTMLPanelParser.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1425809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: tobyr,
Description:
Phase 1 of GWT Dashboard. This includes an interface in gwt-dev for
posting to a dashboard (default implementation is a no-op). Added calls
to this interface in a couple of places. Created factory class that can
provide the no-op implementation or a real
Reviewers: rjrjr, hermes,
Description:
Introduce the Attachable interface, and add support to UiBinder's
HTMLPanel parser.
Please review this at http://gwt-code-reviews.appspot.com/1426805/
Affected files:
A
user/src/com/google/gwt/uibinder/elementparsers/AttachableHTMLPanelParser.java
Thanks, guys. Another look?
http://gwt-code-reviews.appspot.com/1426805/diff/1/user/src/com/google/gwt/uibinder/elementparsers/AttachableHTMLPanelParser.java
File
user/src/com/google/gwt/uibinder/elementparsers/AttachableHTMLPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/1426805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10071
Author: gwt.mirror...@gmail.com
Date: Tue Apr 26 10:46:07 2011
Log: Introducing ServiceHelper, a inner class of RemoteServiceProxy
that
makes ProxyCreator generates less code.
Review at http://gwt-code-reviews.appspot.com/1423808
Review by: robertvaw...@google.com
http://gwt-code-reviews.appspot.com/1420809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Please hold reviewing this for a sec, I'm fixing a compile error I
introduced.
On Tue, Apr 26, 2011 at 2:39 PM, rdcas...@google.com wrote:
Thanks, guys. Another look?
Actually after initial cache filling all these units are used. I see
preparing new TypeData only for changed units, when I modify them and
hit Refresh in DevMode browser.
I've added lazy TypeData into CompiledClass and filling TypeData
information instead of cache. I'm not sure however if adding
Reviewers: rchandia,
Description:
Fixing a bug with ScrollImplTrident where it fires a synthetic scroll
event even if the browser fires a native scroll event when an element is
resized. We now delay firing the synthetic scroll event until the
browser has had a chance to fire a native scroll
LGTM with yet another TODO
Also, the very next patch will need to be an integration test.
http://gwt-code-reviews.appspot.com/1426805/diff/6001/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
File user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
(right):
Revision: 10072
Author: gwt.mirror...@gmail.com
Date: Tue Apr 26 10:55:15 2011
Log: Autoformats a few files before patch
Review at http://gwt-code-reviews.appspot.com/1425809
http://code.google.com/p/google-web-toolkit/source/detail?r=10072
Modified:
http://gwt-code-reviews.appspot.com/1426805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: unnurg,
Description:
Additional infrastructure for generating source code outside of a
GWT generator.
Review by: unn...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1421805/
Affected files:
A user/src/com/google/gwt/codegen/rebind/GwtCodeGenContext.java
http://gwt-code-reviews.appspot.com/1426805/diff/6001/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
File user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
(right):
Reviewers: rdcastro, rjrjr,
Description:
This fix a bug in WidgetPlaceholderInterpreter (missing convertField)
and create a new FieldWriterType to substitute the ugly
setBuildPrecedence().
It also make LazyDomElement used in more places. This saved a few bytes.
Please review this at
http://gwt-code-reviews.appspot.com/1426805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
In looking at EnumOrdinalizer now, I think there is some confusion wrt
the 2nd and 3rd visitors (ReplaceEnumTypesWithInteger
ReplaceOrdinalFieldAndMethodRefsWithOrdinal).
It seems that RETWI, which extends TypeRemapper, is already doing some
of the assignments (perhaps not completely
Revision: 10074
Author: mrruss...@google.com
Date: Tue Apr 26 11:49:09 2011
Log: create a tag for the gwt 2.3rc1 release
http://code.google.com/p/google-web-toolkit/source/detail?r=10074
Added:
/tags/2.3.0-rc1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM++
http://gwt-code-reviews.appspot.com/1426805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
You and Rafa are on a collision course around the field precedence
thing. Let the race begin!
http://gwt-code-reviews.appspot.com/1420810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10075
Author: gwt.mirror...@gmail.com
Date: Tue Apr 26 12:08:36 2011
Log: Fix build break introduced by previous change
http://code.google.com/p/google-web-toolkit/source/detail?r=10075
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
Scott, would you mind, for my own edification, outlining how this
improves the valid state of the AST after EnumOrdinalizer runs?
Thanks.
http://gwt-code-reviews.appspot.com/1426804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10076
Author: jlaba...@google.com
Date: Tue Apr 26 08:38:21 2011
Log: Fixing a bug with ScrollImplTrident where it fires a synthetic
scroll event even if the browser fires a native scroll event when an
element is resized. We now delay firing the synthetic scroll event
committed as r10076
http://gwt-code-reviews.appspot.com/1426806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2011/04/26 19:20:10, jlabanca wrote:
committed as r10076
http://gwt-code-reviews.appspot.com/1426806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10077
Author: ncha...@google.com
Date: Tue Apr 26 09:52:21 2011
Log: Include all needed javax.validation classes for the api checker.
Review at http://gwt-code-reviews.appspot.com/1425802
Review by: rchan...@google.com
Reviewers: rice,
Description:
Adding drag and drop support to the mobile web app. The desktop
TaskEditView now has a list of templates. Users can drag a template
over the edit form to populate the fields.
I found a few holes in the drag and drop API, which are also fixed in
this patch. I added
Based on your comments, I'm going to rework the patch. You're right, I was
totally confused about the difference between
ReplaceEnumTypesWithInteger ReplaceOrdinalFieldAndMethodRefsWithOrdinal.
I think the JField / JFieldRef replacements in the former are what threw
me. I'll rework the patch.
Revision: 10078
Author: mrruss...@google.com
Date: Tue Apr 26 13:27:11 2011
Log: new directory for 2.3 javadocs
http://code.google.com/p/google-web-toolkit/source/detail?r=10078
Added:
/javadoc/2.3
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb, jbrosenberg, tobyr,
Description:
Adds some diagnostics to an exception thrown in CompiledClass.
Please review this at http://gwt-code-reviews.appspot.com/1425810/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
M
This patch deserves some explanation: I saw a case where the
ClassFormatException that was formally caught in CompiledClass was
emitted from the compiler. Adding some missing source to the source
path fixed the problem. I was unable to reproduce the problem in a
small example.
I'm proposing
http://gwt-code-reviews.appspot.com/1420809/diff/5001/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
(right):
Drag n Drop doesn't work in ie8 (expected). Perhaps use deferred binding to
get rid of the templates portion for all versions of ie9. Otherwise
those templates are pretty useless.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10079
Author: mrruss...@google.com
Date: Tue Apr 26 13:57:14 2011
Log: copy the javadocs
http://code.google.com/p/google-web-toolkit/source/detail?r=10079
Added:
/javadoc/2.3/2.2
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1420809/diff/5001/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
(right):
Another possibility to consider top deal with this issue is to just
catch the ClassFormatException and return null. That's exactly what is
done at the bottom of JdtCompiler.INameEnvironment.findType(char[][])
http://gwt-code-reviews.appspot.com/1425810/
--
Revision: 10080
Author: mrruss...@google.com
Date: Tue Apr 26 14:00:10 2011
Log: remove bad copy
http://code.google.com/p/google-web-toolkit/source/detail?r=10080
Deleted:
/javadoc/2.3
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
High-level, the intent is that the JdtCompiler has only two failure
modes. Either there is an error with the input, in which case we report
a compilation problem on the unit itself, or else we encounter an error
so severe that we terminate. I would have thought this would fall
squarely into the
On Tue, Apr 26, 2011 at 4:57 PM, Jeff Larsen larse...@gmail.com wrote:
Drag n Drop doesn't work in ie8 (expected). Perhaps use deferred binding to
get rid of the templates portion for all versions of ie9. Otherwise
those templates are pretty useless.
DragEvent can implement PartialSupport and
Updated based on feedback.
http://gwt-code-reviews.appspot.com/1426804/diff/3002/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
(left):
http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/build.xml
File samples/mobilewebapp/build.xml (left):
http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/build.xml#oldcode12
samples/mobilewebapp/build.xml:12: include
http://gwt-code-reviews.appspot.com/1425810/diff/1/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right):
http://gwt-code-reviews.appspot.com/1425810/diff/1/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java#newcode309
Revision: 10081
Author: rdcas...@google.com
Date: Tue Apr 26 11:22:45 2011
Log: Introduce the Attachable interface, and add support to UiBinder's
HTMLPanel parser.
Review at http://gwt-code-reviews.appspot.com/1426805
Revision: 10082
Author: mrruss...@google.com
Date: Tue Apr 26 14:40:57 2011
Log: create javadoc directory for GWT 2.3 release
http://code.google.com/p/google-web-toolkit/source/detail?r=10082
Added:
/javadoc/2.3
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
File
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
(right):
http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
File
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
(right):
http://gwt-code-reviews.appspot.com/1420810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/04/26 22:11:30, hermes wrote:
Yes, Rafa won the race! The bug is already fixed and FieldWriterType
doesn't
bring any big gain. So I reverted the most of the files.
The only change here is the use of LazyDomElement to make all places
using the
same pattern.
LGTM
http://gwt-code-reviews.appspot.com/1420810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1420810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To recap f2f discussion, there are 2 issues here:
- The first is the problem I was trying to patch - in that
ClassFormatException are not handled the same way in findType().
- The second issue is that the app I was running actually has 2 modules
loading in hosted mode. We speculate the second
Reviewers: Frank,
Description:
Fixing a bug in CustomScrollPanel that leads to an infinite loop in
Safari 3 because the browser updates the scroll position of the outer
element, which triggers a scroll event, which repeats the loop. We now
check the scroll positions before updating them.
http://gwt-code-reviews.appspot.com/1409802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Still need to add some testing, but the other comments have been
addressed.
http://gwt-code-reviews.appspot.com/1409802/diff/3001/user/src/com/google/gwt/uibinder/elementparsers/ComputedAttributeInterpreter.java
File
Revision: 10084
Author: her...@google.com
Date: Tue Apr 26 12:50:53 2011
Log: This fix a bug in WidgetPlaceholderInterpreter (missing
convertField)
and create a new FieldWriterType to substitute the ugly
setBuildPrecedence().
It also make LazyDomElement used in more places. This
Revision: 10085
Author: jlaba...@google.com
Date: Tue Apr 26 12:54:13 2011
Log: Fixing a bug in CustomScrollPanel that leads to an infinite loop
in Safari 3 because the browser updates the scroll position of the outer
element, which triggers a scroll event, which repeats the loop.
Turns out the useLazyWidget stuff isn't passing all of the UiBinder tests
yet. Ignoring that path for now seems reasonable. Sorry for the flip flop.
On Mon, Apr 25, 2011 at 3:19 PM, rj...@google.com wrote:
Oh, the base class exists already:
com.google.gwt.text.shared.AbstractSafeHtmlRendererT
committed as r10085
http://gwt-code-reviews.appspot.com/1421806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1425808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/build.xml
File samples/mobilewebapp/build.xml (left):
http://gwt-code-reviews.appspot.com/1425808/diff/1/samples/mobilewebapp/build.xml#oldcode12
samples/mobilewebapp/build.xml:12: include
Reviewers: rdcastro, rjrjr,
Description:
Fixing setInnerHTML calls on attach/detach sections.
Please review this at http://gwt-code-reviews.appspot.com/1422811/
Affected files:
M
user/src/com/google/gwt/uibinder/elementparsers/WidgetPlaceholderInterpreter.java
M
Hi,
com.google.gwt.user.cellview.client.SimplePager doesn't disable the
fastForward button in setFastForwardDisabled so you can *always*
page forward many rows leading to display inconsistencies.
Original code:-
private void setFastForwardDisabled(boolean disabled) {
if (fastForward ==
http://gwt-code-reviews.appspot.com/1420811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hey GWTC folks,
We have a GWT SDK 2.3.0.RC1 build that we would love feedback on. A big
change since M1 is the move of AutoBean and RequestFactory to a new package,
com.google.web.bindery. The old locations of AutoBean and RequestFactory
should still work, but are deprecated. Fixing the
LGTM
On 2011/04/26 23:35:28, hermes wrote:
http://gwt-code-reviews.appspot.com/1422811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1426804/diff/3002/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
(right):
LGTM + nits
(I've run tests on some big compiles, and ordinalization results look
good)
http://gwt-code-reviews.appspot.com/1426804/diff/3002/dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
File dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
(right):
83 matches
Mail list logo
