[gwt-contrib] Re: Re-implement runAsync to improve code size. (issue1442807)

http://gwt-code-reviews.appspot.com/1442807/diff/5033/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java File user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java (right): http://gwt-code-reviews.appspot.com/1442807/diff/5033/user/src/com/google/gwt/core/client/impl/A

[gwt-contrib] [google-web-toolkit] r10231 committed - Changed method dependencies report to show method code sizes. Call sta...

Revision: 10231 Author: dconne...@google.com Date: Thu May 26 09:07:47 2011 Log: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown action under each method. Review at http://gwt-code-reviews.appspot.com/1443809 Review by: zun...@google.com

[gwt-contrib] [google-web-toolkit] r10229 committed - Misc GWT compiler bugfixes and cleanups....

Revision: 10229 Author: sco...@google.com Date: Thu May 26 06:00:55 2011 Log: Misc GWT compiler bugfixes and cleanups. http://gwt-code-reviews.appspot.com/1452802/ http://code.google.com/p/google-web-toolkit/source/detail?r=10229 Modified: /trunk/dev/core/src/com/google/gwt/dev/jjs/

[gwt-contrib] Re: RequestFactoryServlet

Here's the blog post and sample code. It's not "Spring-y", but it's "Guice-y"! http://wanderingcanadian.posterous.com/guiced-up-gwt-requestfactory You are right Andrés. I've noticed the same behavior. Not sure if it's a feature or an issue though. Either way, it's something useful to know! --

[gwt-contrib] Re: Removes CompileModule.java, retaining the unit test that depends on it. (issue1449806)

LGTM http://gwt-code-reviews.appspot.com/1449806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds ability to query the generator context whether a rebind rule exists for a given type (issue1450806)

http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java (left): http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindO

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/com/google/gwt/animation/client/AnimationImplMozilla.java File user/src/com/google/gwt/animation/client/AnimationImplMozilla.java (right): http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/com/google/gwt/animation/client/Anima

[gwt-contrib] Adds ability to query the generator context whether a rebind rule exists for a given type (issue1450806)

Reviewers: scottb, zundel, Description: Adds ability to query the generator context whether a rebind rule exists for a given type Please review this at http://gwt-code-reviews.appspot.com/1450806/ Affected files: M dev/core/src/com/google/gwt/core/ext/GeneratorContext.java M dev/core/src/c

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

http://gwt-code-reviews.appspot.com/1446812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-implement runAsync to improve code size. (issue1442807)

LGTM http://gwt-code-reviews.appspot.com/1442807/diff/5033/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java File user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java (right): http://gwt-code-reviews.appspot.com/1442807/diff/5033/user/src/com/google/gwt/core/client/

[gwt-contrib] Removes CompileModule.java, retaining the unit test that depends on it. (issue1449806)

Reviewers: scottb, jbrosenberg, Description: Removes CompileModule.java, retaining the unit test that depends on it. Please review this at http://gwt-code-reviews.appspot.com/1449806/ Affected files: D dev/core/src/com/google/gwt/dev/CompileModule.java A dev/core/src/com/google/gwt/dev/Gwt

[gwt-contrib] Re: Reformatting in advance of forthcoming patch (issue1446813)

LGTM http://gwt-code-reviews.appspot.com/1446813/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Reformatting in advance of forthcoming patch (issue1446813)

Reviewers: zundel, Description: Reformatting in advance of forthcoming patch Please review this at http://gwt-code-reviews.appspot.com/1446813/ Affected files: M dev/core/src/com/google/gwt/core/ext/GeneratorContext.java M dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.jav

[gwt-contrib] Re: Re-implement runAsync to improve code size. (issue1442807)

Hey guys, I fixed some bugs and optimized a few things. Looking to resubmit this. http://gwt-code-reviews.appspot.com/1442807/diff/5033/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java File user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java (right): http://gwt-co

[gwt-contrib] Re: Change the wrapElement API to receive the id and a parent element. I also ported some of the boo... (issue1446811)

http://gwt-code-reviews.appspot.com/1446811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change the wrapElement API to receive the id and a parent element. I also ported some of the boo... (issue1446811)

For the record: Rafa talked some sense into me offline. The Stamper notion really isn't practical given the limitations of SafeHtmlTemplates, so I'm backing off of most of this craziness. Instead we'll just delete the extends SafeHtmlRenderer thing. That will also allow backing away from the phas

Re: [gwt-contrib] Activities & Places

Thanks!! 2011/5/25 A. Stevko > Thanks. I like it. It makes clearer some of the relationships. > > > On Wed, May 25, 2011 at 11:43 AM, danieldietrich > wrote: > >> Hi, >> >> I've drawn an informal map about Activities & Places >> - perhaps it is helpful for someone... >> >> Greetings from Kiel/G

Re: [gwt-contrib] Dollar sign and binary types

Unfortunately, I tried removing the replace('$',".") and it failed miserably. Looking at it in the debugger, those really are binary names. e.g.: com.google.gwt.core.client.impl.AsyncFragmentLoader$LoadingStrategy On Thu, May 26, 2011 at 2:24 PM, John Tamplin wrote: > On Thu, May 26, 2011 at 2

[gwt-contrib] Re: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1443809)

LGTM. Updated report looks great! http://gwt-code-reviews.appspot.com/1443809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change the wrapElement API to receive the id and a parent element. I also ported some of the boo... (issue1446811)

http://gwt-code-reviews.appspot.com/1446811/diff/1/user/src/com/google/gwt/user/client/ui/IsRenderable.java File user/src/com/google/gwt/user/client/ui/IsRenderable.java (right): http://gwt-code-reviews.appspot.com/1446811/diff/1/user/src/com/google/gwt/user/client/ui/IsRenderable.java#newcode33

[gwt-contrib] Re: Change the wrapElement API to receive the id and a parent element. I also ported some of the boo... (issue1446811)

http://gwt-code-reviews.appspot.com/1446811/diff/1/user/src/com/google/gwt/user/client/ui/IsRenderable.java File user/src/com/google/gwt/user/client/ui/IsRenderable.java (right): http://gwt-code-reviews.appspot.com/1446811/diff/1/user/src/com/google/gwt/user/client/ui/IsRenderable.java#newcode29

Re: [gwt-contrib] Re: Creating a default Locator for RequestFactoryServlet

On Thu, May 26, 2011 at 2:23 PM, Thomas Broyer wrote: > How about simply using a ServiceLayerDecorator that overrides > resolveLocator, delegating to super.resolveLocator and, if it returns null > then return the "default locator" instead? > > If it were in a separate annotation, you could simply

Re: [gwt-contrib] Dollar sign and binary types

On Thu, May 26, 2011 at 2:03 PM, Grzegorz Kossakowski < grzegorz.kossakow...@gmail.com> wrote: > > The problematic place for me is ReplaceBindings.java, lines 154-155: > > > >// Rebinds are always on a source type name. > >String reqType = type.getName().replace('$', '.'); > > Any comment

[gwt-contrib] Re: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1443809)

http://gwt-code-reviews.appspot.com/1443809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Creating a default Locator for RequestFactoryServlet

How about simply using a ServiceLayerDecorator that overrides resolveLocator, delegating to super.resolveLocator and, if it returns null then return the "default locator" instead? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Dollar sign and binary types

2011/5/26 Grzegorz Kossakowski : > 2011/5/26 Eric Ayers : >> Hi again, >> >> Can you point out any of places where you saw this assumption?  The >> last time I was mucking around with binary type names I was told not >> to assume that $ could not appear in source names, so it might be >> unintentio

[gwt-contrib] Creating a default Locator for RequestFactoryServlet

@Bobv Thanks for committing the previous change, and I've got one more change that will make my, and probably a bunch of other people's, lives easier. By being able to setup a DefaultLocator, it would stop me from having to copy/paste @ServiceName(value="com.my.service.MyService" * locator="co

[gwt-contrib] Re: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1443809)

And, as you pointed out, there is no need for the class name headers to be clickable - could you remove that non-functioning clicking? http://gwt-code-reviews.appspot.com/1443809/diff/1/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java File dev/core/src/com/google/gwt/soyc/MakeTopLev

[gwt-contrib] Re: Add RequestContext.find() to support chained requests. (issue1448806)

LGTM http://gwt-code-reviews.appspot.com/1448806/diff/1/user/src/com/google/web/bindery/requestfactory/shared/RequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/RequestContext.java (right): http://gwt-code-reviews.appspot.com/1448806/diff/1/user/src/com/google/web/bi

[gwt-contrib] Re: Add BatchedRequestScope utility class to aggregate all requests made within a single tick of the... (issue1449804)

LGTM http://gwt-code-reviews.appspot.com/1449804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1443809)

Reviewers: zundel, Description: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown action under each method. Review by: zun...@google.com Please review this at http://gwt-code-reviews.appspot.com/1443809/ Affected files: M dev/core/src/com/google/gwt

[gwt-contrib] Re: A mechanical refactoring of the Precompile options as prep for further cleanup. (issue1452804)

LGTM http://gwt-code-reviews.appspot.com/1452804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Upgrading DynaTableRf and MobileWebApp to use DataGrid. The apps look identical, except that scr... (issue1452803)

Reviewers: rjrjr, Description: Upgrading DynaTableRf and MobileWebApp to use DataGrid. The apps look identical, except that scrolling the table no longer scrolls the column headers out of view. Please review this at http://gwt-code-reviews.appspot.com/1452803/ Affected files: A samples/dyn

[gwt-contrib] Re: A mechanical refactoring of the Precompile options as prep for further cleanup. (issue1452804)

Specifically, I used Eclipse refactoring to move Precompile.PrecompileOptions, Precompile.PrecompileOptionsImpl, Precompile.ArgProcessor, and GraphicsInitThread to top level classes. I updated one or two comments, and added @Override tags where eclipse highlighted them as being needed. http://gw

[gwt-contrib] A mechanical refactoring of the Precompile options as prep for further cleanup. (issue1452804)

Reviewers: jbrosenberg, scottb, Description: A mechanical refactoring of the Precompile options as prep for further cleanup. Added @Override annotations to satisfy the IDE warnings with Java 1.6 enabled. Please review this at http://gwt-code-reviews.appspot.com/1452804/ Affected files: M dev

[gwt-contrib] Re: AutoboxUtils cleanup (issue1443808)

http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java File dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java (right): http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java#new

[gwt-contrib] Re: AutoboxUtils cleanup (issue1443808)

http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java File dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java (right): http://gwt-code-reviews.appspot.com/1443808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/AutoboxUtils.java#new

[gwt-contrib] Re: Misc GWT compiler bugfixes and cleanups (issue1452802)

http://gwt-code-reviews.appspot.com/1452802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java File dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java (right): http://gwt-code-reviews.appspot.com/1452802/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper

[gwt-contrib] Re: Misc GWT compiler bugfixes and cleanups (issue1452802)

LGTM http://gwt-code-reviews.appspot.com/1452802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding new DataGrid widget. DataGrid is a variation of CellTable that supports a fixed header a... (issue1450805)

committed as r10228 http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java (right): http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt

[gwt-contrib] Re: Misc GWT compiler bugfixes and cleanups (issue1452802)

Reviewers: jbrosenberg, zundel, http://gwt-code-reviews.appspot.com/1452802/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java File dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java (right): http://gwt-code-reviews.appspot.com/1452802/diff/1/dev/core/src/com/google/gwt/dev/jjs

[gwt-contrib] Отг: Re: Broken editor type conversions in GWT trunk r10227

Ah my mistake. Sorry about that post, but I wasn't sure where the problem is with my usage or some GWT issue. Thats why I posted it on both groups. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1451803)

A NOOO On 2011/05/26 15:08:30, dconnelly wrote: http://gwt-code-reviews.appspot.com/1451803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Changed method dependencies report to show method code sizes. Call stacks are now a dropdown act... (issue1451803)

Reviewers: zundel, Description: Changed method dependencies report to show method code sizes. Call stacks are now a dropdown action under each method. Please review this at http://gwt-code-reviews.appspot.com/1451803/ Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptComp

[gwt-contrib] Re: Broken editor type conversions in GWT trunk r10227

TextBox is for editing String (it's a IsEditor>), use an IntegerBox for Integers (IsEditor>). (and this group is for contributors to GWT, use http://groups.google.com/group/google-web-toolkit for support questions) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Bugfixes in ControlFlowAnalyzer (issue1443807)

http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java (left): http://gwt-code-reviews.appspot.com/1443807/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/Co

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/com/google/gwt/animation/client/Animation.java File user/src/com/google/gwt/animation/client/Animation.java (right): http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode56 us

[gwt-contrib] Broken editor type conversions in GWT trunk r10227

Hello, I'm trying to use trunk version of GWT but I'm encountering some conversion issues with the Editor framework. Caused by: java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.String at com.google.gwt.text.shared.testing.PassthroughRenderer.render(PassthroughRendere

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/com/google/gwt/animation/Animation.gwt.xml File user/src/com/google/gwt/animation/Animation.gwt.xml (right): http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/com/google/gwt/animation/Animation.gwt.xml#newcode22 user/src/com/g

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

I only gave it a glance but here are a few comments: - while I like the public requestAnimationFrame API, I don't like the static methods - I don't quite like the ImplMozilla/ImplWebkit extends ImplTimer pattern See details inline. http://gwt-code-reviews.appspot.com/1446812/diff/1/user/src/c

Re: [gwt-contrib] Dollar sign and binary types

2011/5/26 Eric Ayers : > Hi again, > > Can you point out any of places where you saw this assumption?  The > last time I was mucking around with binary type names I was told not > to assume that $ could not appear in source names, so it might be > unintentional. Hi Eric, The problematic place for