Reviewers: jtamplin, cromwellian,
Message:
Follow-up to https://gwt-code-reviews.appspot.com/1820806
See http://code.google.com/p/google-web-toolkit/issues/detail?id=7386#c8
Description:
Add a getter for XHR's responseType.
Issue 7386
Please review this at
http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml
File samples/dynatablerf/pom.xml (right):
http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml#newcode55
samples/dynatablerf/pom.xml:55: !-- Doesn't yet work in eclipse. See
LGTM
Did you test it? It probably needs testing on IE6 if GWT still
officially supports it, since I recall some weirdness about getting
exceptions if you referenced properties that didn't exist on native
objects that were exposed to JS.
https://gwt-code-reviews.appspot.com/1830803/
--
On 2012/09/12 14:32:37, jtamplin wrote:
Did you test it? It probably needs testing on IE6 if GWT still
officially
supports it, since I recall some weirdness about getting exceptions if
you
referenced properties that didn't exist on native objects that were
exposed to
JS.
Just ran the
On 2012/09/12 16:03:13, tbroyer wrote:
I'll try on IE7, IE8 and IE9 next (currently downloading the VMs from
the MSDN).
Results from https://browserlab.adobe.com
IE7, IE8 and IE9: works as an expando (no error; prints undefined,
arraybuffer, dummy)
Chrome 18 / Windows: throws on setting to
I haven't looked at the changes (from the description, they should be
simple and straightforward) but what bothers me is that it introduces a
cyclic dependency: c.g.g.user depends on c.g.g.aria which now also
depends on c.g.g.user.
Also, that dependency isn't reflected in the .gwt.xml (so one
We've decided against this change for now (increases the size of the API
too much). A HasElement interface sounds somewhat reasonable but we can
add that later if needed.
I suppose if Element implemented HasElement, returning itself, we could
avoid doubling the number of methods, but this seems
On 2012/09/12 19:18:12, skybrian wrote:
We've decided against this change for now (increases the size of the
API too
much). A HasElement interface sounds somewhat reasonable but we can
add that
later if needed.
I suppose if Element implemented HasElement, returning itself, we
could avoid
Hmm, I'm inclined to skip this patch for GWT 2.5. The typo fix at least
makes it work on some browsers...
https://gwt-code-reviews.appspot.com/1830803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/09/12 20:47:20, skybrian wrote:
Hmm, I'm inclined to skip this patch for GWT 2.5. The typo fix at
least makes it
work on some browsers...
If I understand Thomas' test results, the getter works properly
everywhere -- it is the existing setter which fails on FF11+. So, this
patch
http://gwt-code-reviews.appspot.com/1828803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/09/12 22:50:12, rdayal wrote:
Ping...I'd like to get this into 2.5.
http://gwt-code-reviews.appspot.com/1829803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi Ray, hi John,
I haven`t had the time to track down why this got optimized in 2.4 but does not
in 2.5 anymore. We are seeing huge gains on many different mgwt apps with GWT
2.5.
@John
With mobile browsers you get a lot of small inconsistencies across many
different places. I initially went
Hi Rajeev,
what is the status here?
Can I help?
-Daniel
Am 19.08.2012 um 17:10 schrieb Robert Hanson iamroberthan...@gmail.com:
@Rajeev, you mentioned that you were going to post the plugin to the Chrome
store. Is that still the plan, or did you run into some issues there?
I'm working
Sorry, this totally fell off the plate.
Daniel, would you be able to submit it to the Chrome Webstore?
On Wed, Sep 12, 2012 at 7:07 PM, Daniel Kurka kurka.dan...@gmail.comwrote:
Hi Rajeev,
what is the status here?
Can I help?
-Daniel
Am 19.08.2012 um 17:10 schrieb Robert Hanson
I'm bogged down at the moment, but when I get free time, I can
probably figure this out via -Dgwt.jjs.traceMethod on the client
bundle in question. Probably will have to wait a few days.
On Wed, Sep 12, 2012 at 4:04 PM, Daniel Kurka kurka.dan...@gmail.com wrote:
Hi Ray, hi John,
I haven`t had
Hi Rajeev,
I just gave it a try and it seems that we need to do some actual changes to
make this work. The chrome web store is complaining about the manifest version
of the plugin:
An error occurred: Manifest version 1 is unsupported. Please upgrade to
manifest version 2.
I will give this
https://developers.google.com/web-toolkit/doc/latest/DevGuideServerCommunication#DevGuideDeRPC
says
about Direct-Eval RPC:
This feature did not work out as planned, and the GWT team strongly
discourages its use.
However, the classes RpcServlet, RpcService etc. are not marked as
Hmm. If it were named HasAriaElement, then it would make sense that
not all widgets implement it. Only those that need to be customized for
proper Aria support would have it.
http://gwt-code-reviews.appspot.com/1828804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
19 matches
Mail list logo
