John Ahlroos has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
..
Patch Set 5:
(3 comments)
Hi,
If you ask me, not serializing the final field was more a bug than a
feature. (I know, GWT RPC is not the same as Java serialization)
Do I need to enable something to get warnings on final fields not being
serialized in 2.5.1 or is that standard behaviour.
I am a very active user of the
Roberto Lublinerman has posted comments on this change.
Change subject: Fixes JRawType#getImplementedMethods to return correct
signature for inherited methods
..
Patch Set 1: Code-Review+2
--
To view, visit
Roberto Lublinerman has posted comments on this change.
Change subject: Fixes a NPE in RF when returning a null entity while the
client used .with().
..
Patch Set 1: Code-Review+1
--
To view, visit
Great!
Do you think that's something that should be run by default when
someone builds a GWT library? (integrated in the lifecycle of the
gwt-lib maven packaging) or it would be better left as an optional
additional feature?
Are you using it at Google? or are you rather relying on unit-tests?
(or
Hi Stephen,
I actually don't want to complicate the whole thing by throwing another
thing into the discussion, so feel free to tell me off, but here I go:
If we construct these interfaces along the lines of todays widgets how
would one add other things along them, like touch support?
Note:
I am very much in favor of moving things forward with breaking changes as
long as we can see most of the damage up front.
Let me check internally if we can find out if Johns concerns are valid so
we might be able to implement this much simpler.
On Thu, Jun 6, 2013 at 9:05 AM, David
Hello Leeroy Jenkins, Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2900
to look at the new patch set (#6).
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
Hello Leeroy Jenkins, Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2900
to look at the new patch set (#7).
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
Andrey Korzhevskiy has uploaded a new change for review.
https://gwt-review.googlesource.com/3187
Change subject: Wrong JavaDoc for MouseWheelEvent.getDeltaY()
..
Wrong JavaDoc for MouseWheelEvent.getDeltaY()
Fixes issue
John Ahlroos has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
..
Patch Set 2:
Subpixel values was first introduced by IE10 I believe, so it is a rather
Thomas Broyer has posted comments on this change.
Change subject: Wrong JavaDoc for MouseWheelEvent.getDeltaY()
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3187
To unsubscribe, visit
Daniel Kurka has posted comments on this change.
Change subject: Wrong JavaDoc for MouseWheelEvent.getDeltaY()
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3187
To unsubscribe, visit
Daniel Kurka has posted comments on this change.
Change subject: Wrong JavaDoc for MouseWheelEvent.getDeltaY()
..
Patch Set 1:
seems like leeroy is a sleep again
--
To view, visit https://gwt-review.googlesource.com/3187
To
Hi Daniel,
I actually don't want to complicate the whole thing by throwing
another thing into the discussion, so feel free to tell me off, but
here I go:
No problem, what's another tangent? :-)
If we construct these interfaces along the lines of todays widgets how
would one add other
On Wed, Jun 5, 2013 at 7:46 PM, Stephen Haberman
step...@exigencecorp.comwrote:
I don't have a good idea about what could break
I believe nothing would break--it's that final fields that were
previously not going over the wire would now go over the wire.
It's also possible that the newly
Let me check internally if we can find out if Johns concerns are
valid so we might be able to implement this much simpler.
Cool; if having a patch to run through the Google submit/test queue
thing would help, let me know and I can put something together.
- Stephen
--
Brian Slesinsky has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
..
Patch Set 2:
Thanks for the explanation. Is there any way to test this other than
Stephen Haberman has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
..
Patch Set 2:
Per needing IE10 to test this, this may be a naive question, but I
Goktug Gokdogan has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
..
Patch Set 2:
Basically it would be preferable for anyone to use the subpixel variants
Brian Slesinsky has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
..
Patch Set 7:
(4 comments)
Looking good.
Jens Nehlmeier has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
..
Patch Set 2:
Maybe we should just split this CL up into two. The first one actually
Brian Slesinsky has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
..
Patch Set 2:
Yeah I was afraid of that. If everyone should be using it, what then?
Brian Slesinsky has posted comments on this change.
Change subject: Update how columns are hidden in CellTable.
..
Patch Set 3:
(1 comment)
File
Brian Slesinsky has reverted this change.
Change subject: Revert Update how columns are hidden in CellTable.
..
Patch Set 3: Reverted
This patchset was reverted in change:
I6df575d6d1f5e8b5ec5bef54d5ede7ad2dfca104
--
To
Goktug Gokdogan has posted comments on this change.
Change subject: Revert Update how columns are hidden in CellTable.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3152
To unsubscribe,
Stephen Haberman has uploaded a new change for review.
https://gwt-review.googlesource.com/3280
Change subject: Remove unused, package-private FastStringMap.
..
Remove unused, package-private FastStringMap.
Change-Id:
Daniel Kurka has posted comments on this change.
Change subject: Remove unused, package-private FastStringMap.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3280
To unsubscribe, visit
Daniel Kurka has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 1:
(4 comments)
just a few nits so far
File
If nobody else has any other concerns, I recommend you to start with
an example interface to get early feedback and iterate from there.
So, I was going to start with just one, but copy/pasting them over and
changing the package name was pretty easy, so:
Brian Slesinsky has submitted this change and it was merged.
Change subject: Revert Update how columns are hidden in CellTable.
..
Revert Update how columns are hidden in CellTable.
This reverts commit
31 matches
Mail list logo
