Brian Slesinsky has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
......................................................................
Patch Set 2:
Yeah I was afraid of that. If everyone should be using it, what then?
Splitting this CL does make sense; let's do that. However, punting the
upgrade to 3.0 isn't a real solution for the subpixel problem. We still
need to upgrade all the callers and, at least at Google, that can't be done
by declaring a flag day and upgrading everyone at once.
So we would need two classes and this is looking like another Element
upgrade, but even worse because we can't just make the old class a
superclass of the new class like we did last time.
If we did have SubpixelElement then it's not pretty but it does provide a
mechanism for people who care about this. There are a lot of occurrences
of "Element" that would have to be changed. (I would want to call it "Elt"
so at least we get a shorter code when we're done. :-)
If we decide to go through the trouble of a major upgrade then we should
probably think about if we want to fix up and use Elemental.
--
To view, visit https://gwt-review.googlesource.com/3090
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e98f0ad3c1c236b2d85d24f197719fa4cd352a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <[email protected]>
Gerrit-Reviewer: Artur Signell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: John Ahlroos <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
