Thomas Broyer has posted comments on this change.
Change subject: Fix for 8188
(http://code.google.com/p/google-web-toolkit/issues/detail?id=8188)
..
Patch Set 1: Code-Review+1
(3 comments)
Daniel Kurka has posted comments on this change.
Change subject: Fix for 8188
(http://code.google.com/p/google-web-toolkit/issues/detail?id=8188)
..
Patch Set 1: Code-Review+1
LGTM to me, but please address Thomas
Thomas Broyer has posted comments on this change.
Change subject: Use correct return types for createFooInputBuilder()
methods in HtmlBuilderFactory. Also adjust the return types of affected
methods in HtmlBuilderImpl.
..
Thomas Broyer has submitted this change and it was merged.
Change subject: Fixes a NPE in RF when returning a null entity while the
client used .with().
..
Fixes a NPE in RF when returning a null entity while the client
Thomas Broyer has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(4 comments)
I've only looked at a few files.
File
Thomas Broyer has submitted this change and it was merged.
Change subject: Removes api-checker reference JARs from the source tree.
..
Removes api-checker reference JARs from the source tree.
Now expects them in GWT_TOOLS.
Thomas Broyer has submitted this change and it was merged.
Change subject: Make sure JUnit's host page run in UTF-8.
..
Make sure JUnit's host page run in UTF-8.
Bug: issue 8171
Change-Id:
Thomas Broyer has posted comments on this change.
Change subject: Cut circular dependency between c.g.g.core.linker and
c.g.g.dev.js
..
Patch Set 1:
(1 comment)
File
Thomas Broyer has submitted this change and it was merged.
Change subject: Use correct return types for createFooInputBuilder()
methods in HtmlBuilderFactory. Also adjust the return types of affected
methods in HtmlBuilderImpl.
Hello Manuel Carrasco Moñino, Matthew Dempsky, Roberto Lublinerman,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/1031
to look at the new patch set (#2).
Change subject: Cut circular dependency between c.g.g.core.linker and
c.g.g.dev.js
Thomas Broyer has posted comments on this change.
Change subject: Cut circular dependency between c.g.g.core.linker and
c.g.g.dev.js
..
Patch Set 2: Code-Review+2
Roberto gave a +2 on patchset 1, and patchset 2 is a simple
Thomas Broyer has submitted this change and it was merged.
Change subject: Cut circular dependency between c.g.g.core.linker and
c.g.g.dev.js
..
Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js
Change-Id:
Thomas Broyer has posted comments on this change.
Change subject: Bug: issue 8188 Log excluded resources in
DirectoryClassPathEntry the same way as ZipFileClassPathEntry
..
Patch Set 2:
(2 comments)
Sorry for being
Hello Leeroy Jenkins, Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3340
to look at the new patch set (#2).
Change subject: Add show relative to Element in PopupPanel
Thomas Broyer has posted comments on this change.
Change subject: Log excluded resources in DirectoryClassPathEntry the same
way as ZipFileClassPathEntry
..
Patch Set 3: Code-Review+2
--
To view, visit
Thomas Broyer has submitted this change and it was merged.
Change subject: Log excluded resources in DirectoryClassPathEntry the same
way as ZipFileClassPathEntry
..
Log excluded resources in DirectoryClassPathEntry the
Thomas Broyer has posted comments on this change.
Change subject: Log excluded resources in DirectoryClassPathEntry the same
way as ZipFileClassPathEntry
..
Patch Set 4:
Thanks!
--
To view, visit
Thomas Broyer has posted comments on this change.
Change subject: Real branched logger is passed to the
ResourceOracleImpl.refresh() method instead of TreeLogger.NULL
..
Patch Set 2:
(4 comments)
An alternative would be
Daniel Kurka has posted comments on this change.
Change subject: Adds Timer#isRunning().
..
Patch Set 2:
(3 comments)
File user/src/com/google/gwt/user/client/Timer.java
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
Tests are failing: http://build.gwtproject.org/job/gwt/261/testReport/
@Andrey: can you provide a patch quickly, or
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
Filed issue 8191. I think we need someone with a deep understanding of the
compiler internals; Ray maybe?
--
To
Daniel Kurka has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
Daniel Kurka has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
..
Patch Set 2:
Going forward this would be the right approach. Not sure though how we make
those permutation dependent.
Thomas Broyer has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
..
Patch Set 2:
We do have com.google.gwt.dom.client.DOMImpl already for
permutation-dependent implementations.
--
To
Daniel Kurka has posted comments on this change.
Change subject: Add methods to HasTreeItems
..
Patch Set 2:
I am very much in favor of deprecation, but I think we need some time to
get there.
We can include these changes
John A. Tamplin has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
Matthew Dempsky has submitted this change and it was merged.
Change subject: Fix module unloading with multiple modules on a page
..
Fix module unloading with multiple modules on a page
Currently, the GWT compiler in
Matthew Dempsky has posted comments on this change.
Change subject: Add show relative to Element in PopupPanel
..
Patch Set 2:
(2 comments)
File
Colin Alworth has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(4 comments)
File
Colin Alworth has uploaded a new change for review.
https://gwt-review.googlesource.com/3361
Change subject: Ensure clinits get called for JSO instance methods.
..
Ensure clinits get called for JSO instance methods.
In
John A. Tamplin has posted comments on this change.
Change subject: Ensure clinits get called for JSO instance methods.
..
Patch Set 1:
This seems a lot less than what you showed me at the Meet-up -- what did
you change?
Colin Alworth has posted comments on this change.
Change subject: Ensure clinits get called for JSO instance methods.
..
Patch Set 1:
Afraid not, this is the exact same patch we looked at - only difference was
that I pulled
Goktug Gokdogan has posted comments on this change.
Change subject: Adds Timer#isRunning().
..
Patch Set 2:
(3 comments)
File
Goktug Gokdogan has posted comments on this change.
Change subject: Add support for 'ImageResource' to @url substitution in
css. Only 'DataResource' used to be supported.
..
Patch Set 1:
(1 comment)
Goktug Gokdogan has posted comments on this change.
Change subject: Add methods to HasTreeItems
..
Patch Set 2:
Sorry, I didn't understand why we need some time to deprecate the older
methods in favor of new ones?
(About
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
@Thomas: I'll submit fixes for failing tests asap
--
To view, visit https://gwt-review.googlesource.com/3184
To
Goktug Gokdogan has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
John A. Tamplin has posted comments on this change.
Change subject: Ensure clinits get called for JSO instance methods.
..
Patch Set 1:
I think simply having a JSO with static initializers that don't work
without this patch
Stephen Haberman has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(1 comment)
Hey guys, thanks for the comments. I'm out of town for a few days, but so
far they all make
Andrey Korzhevskiy has uploaded a new change for review.
https://gwt-review.googlesource.com/3400
Change subject: Failing tests for java.util.Objects
..
Failing tests for java.util.Objects
Fixes issue 8193
Change-Id:
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
Filed
Goktug Gokdogan has posted comments on this change.
Change subject: Set display to none for table columns that should not be
visible.
..
Patch Set 1:
(3 comments)
File
Lazy parsing can be a performance win, but it also complicates the API in
the case of a parse error. Have you thought about how to report errors when
they happen later?
It might less confusing to solve this using a separate LazyBigDecimal
class. People can declare fields of this type in their
Have we evaluated why it is so slow on ie8? It might be easier to fix
that. The one thing it does is heavy use of StringBuffers so that could be
where the issue is.
On Jun 12, 2013 8:09 PM, Brian Slesinsky skybr...@google.com wrote:
Lazy parsing can be a performance win, but it also
Matthew Dempsky has posted comments on this change.
Change subject: Failing tests for java.util.Objects
..
Patch Set 1:
(1 comment)
File
Goktug Gokdogan has posted comments on this change.
Change subject: Add interfaces for widgets.
..
Patch Set 6:
(1 comment)
1. It is very important to use consistent naming convention throughout the
SDKs. IsXXX previously
Matthew Dempsky has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
@Thomas: I think it depends on how quickly we can resolve the issue and how
confident we are there won't still be
Goktug Gokdogan has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
A good rule of thumb is; if you can't fix it in 5 min, you should revert.
More time the trunk is left broken,
48 matches
Mail list logo
