[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

2013-06-14 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: Adding a DOM clear method to RootPanel .. Patch Set 7: Sorry if I come later to this change, but I am wondering if Should'nt it preserve gwt specific

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

2013-06-14 Thread David
Hi, Theoretically you are absolutely right. But practically is another discussion, I am talking about thousands of lines that need to change just for the GUI tier limitations. The GUI is just a fraction of the application because the same Request/Response objects are used internally as well (comma

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

2013-06-14 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: Adding a DOM clear method to RootPanel .. Patch Set 7: @Manuel good catch. We do not need to care about the History Frame (I looked it up before submitting th

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframei

2013-06-14 Thread Daniel Kurka
Daniel Kurka has uploaded a new change for review. https://gwt-review.googlesource.com/3430 Change subject: making RootPanel.clear(true) respects GWT loader iframei .. making RootPanel.clear(true) respects GWT loader iframei

[gwt-contrib] Manuel (google-web-toolkit-contributors@googlegroups.com)

2013-06-14 Thread Daniel Kurka (Google Drive)
I've shared an item with you: Manuel https://docs.google.com/document/d/1-y6jum0PO7rRqLu7IBtm1PKxJ21eGlIXl_XDjz2NNcc/edit?usp=sharing It's not an attachment -- it's stored online. To open this item, just click the link above. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframei

2013-06-14 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: making RootPanel.clear(true) respects GWT loader iframei .. Patch Set 1: (2 comments) File user/s

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframei

2013-06-14 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: making RootPanel.clear(true) respects GWT loader iframei .. Patch Set 1: (2 comments) File user/src/com/goo

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframei

2013-06-14 Thread Daniel Kurka
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3430 to look at the new patch set (#2). Change subject: making RootPanel.clear(true) respects GWT loader iframei .

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

2013-06-14 Thread Daniel Kurka
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3430 to look at the new patch set (#3). Change subject: making RootPanel.clear(true) respects GWT loader iframe ..

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

2013-06-14 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: making RootPanel.clear(true) respects GWT loader iframe .. Patch Set 1: (1 comment) File user/src/com/goog

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

2013-06-14 Thread Daniel Kurka
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3430 to look at the new patch set (#4). Change subject: making RootPanel.clear(true) respects GWT loader iframe ..

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

2013-06-14 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: making RootPanel.clear(true) respects GWT loader iframe .. Patch Set 4: Code-Review+1 (1 comment) File use

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

2013-06-14 Thread Daniel Kurka
Hello Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3430 to look at the new patch set (#5). Change subject: making RootPanel.clear(true) respects GWT loader iframe ...

[gwt-contrib] Change in gwt[master]: making RootPanel.clear(true) respects GWT loader iframe

2013-06-14 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: making RootPanel.clear(true) respects GWT loader iframe .. Patch Set 4: (1 comment) File user/src/com/googl

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

2013-06-14 Thread Brian Slesinsky
Okay, fair enough. Making BigDecimal deserialize faster would certainly be a good thing. I just don't want it to result in hard-to-diagnose errors if there's some kind of mismatch between client and server. If there's any difference then we should probably have a configuration property or an annota

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

2013-06-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. .

[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.

2013-06-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Ensure clinits get called for JSO instance methods. .. Patch Set 2: (3 comments) File user/test/com/goog

[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.

2013-06-14 Thread Colin Alworth
Colin Alworth has posted comments on this change. Change subject: Ensure clinits get called for JSO instance methods. .. Patch Set 2: (2 comments) File user/test/com/google

Re: [gwt-contrib] Work to do for bug 3042

2013-06-14 Thread Brian Slesinsky
Another possibility would be to develop a nicer GWT RichTextArea as a separate open source project. There's no reason it has to be in core GWT right away and you'll be able to work faster that way. With real-world usage, you'll probably learn a few things that will make it better quality if we do m

[gwt-contrib] Change in gwt[master]: Ensure clinits get called for JSO instance methods.

2013-06-14 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: Ensure clinits get called for JSO instance methods. .. Patch Set 2: Code-Review+1 (1 comment) File d

Re: [gwt-contrib] Work to do for bug 3042

2013-06-14 Thread Goktug Gokdogan
Agreed. We don't need to provide a complex RichTextArea for GWT out of the box. It makes sense to quickly iterate on it in a different open source project. In the meantime, if you end up having small patches to improve the existing one in GWT, feel free to send them. On Fri, Jun 14, 2013 at 3:34

[gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-06-14 Thread Goktug Gokdogan
I just wanted to give you a heads up that Roberto and I are working on a compiler patch so that catch statement will not break js originated exceptions. To give you some background, if you put any try/catch statement in Java, js originated exceptions will be converted into JavaScriptException even

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

2013-06-14 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. ..