On 2011/06/27 19:47:26, conroy wrote:
True, but I don't want that to be a listing of every version we ever
support. Instead, I'll just keep PPC marked as 3.x and the bifurcation
of
platform support can be inferred by the platforms that firefox
supports at
the various versions. I have re-expor
On 2011/06/01 22:05:56, conroy wrote:
On 2011/06/01 21:14:56, codefu wrote:
> On 2011/06/01 21:11:48, codefu wrote:
> Included are the binary files:
> gwt-dev-plugin.crx
> gwt-dev-plugin.xpi
> gwt-dev-plugin.dmg
> gwt-dev-plugin-x86.msi
> gwt-dev-plugin-x64.msi
While you're tweaking the Chrome
Reviewers: jgw, jlabanca,
Description:
GWT support for Chrome Frame
http://code.google.com/p/google-web-toolkit/issues/detail?id=5166
Please review this at http://gwt-code-reviews.appspot.com/1449808/
Affected files:
M user/src/com/google/gwt/user/rebind/UserAgentPropertyGenerator.java
Ind
http://gwt-code-reviews.appspot.com/1424803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1424803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
File dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
(right):
http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations
http://gwt-code-reviews.appspot.com/1424803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/04/18 19:09:21, fabiomfv wrote:
ping
http://gwt-code-reviews.appspot.com/1424803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca, rjrjr, robertvawter,
Description:
* Soft permutations fail to collapse. Collapse 'derived' properties
chain when 'parent' properties are collapsed.
http://code.google.com/p/google-web-toolkit/issues/detail?id=6258
* Default project template collapses older browsers (ie6[7] an
LGTM
http://gwt-code-reviews.appspot.com/1408802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1402802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1383809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
ie9 bug fixes.
Please review this at http://gwt-code-reviews.appspot.com/1383809/
Affected files:
M user/src/com/google/gwt/dom/client/DOMImplStandard.java
M user/src/com/google/gwt/user/client/ui/CheckBox.java
Index: user/src/com/google/gwt/dom/client/D
Reviewers: jlabanca,
Description:
ie9 richtexteditor event fix.
Please review this at http://gwt-code-reviews.appspot.com/1384808/
Affected files:
M user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.java
Index: user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.j
http://gwt-code-reviews.appspot.com/1387802/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(right):
http://gwt-code-reviews.appspot.com/1387802/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard
Reviewers: jlabanca,
Description:
non fatal js exception escapes in IE9 devmode.
http://code.google.com/p/google-web-toolkit/issues/detail?id=6135
Please review this at http://gwt-code-reviews.appspot.com/1387802/
Affected files:
M user/src/com/google/gwt/core/client/impl/Impl.java
M user/
LGTM
http://gwt-code-reviews.appspot.com/1380803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1383801/diff/6001/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
(right):
http://gwt-code-reviews.appspot.com/1383801/diff/6001/dev/core/src/com/google/gwt/dev/shell/Standard
http://gwt-code-reviews.appspot.com/1383801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca, rjrjr, jat,
Description:
IE9 support (BETA).
known issues:
IE9 devmode throws non fatal js exception.
Please review this at http://gwt-code-reviews.appspot.com/1383801/
Affected files:
M dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
M user/src/com/go
Reviewers: rjrjr, jlabanca, jat,
Description:
add ie9 user.agent with fallback binding to ie8. (in preparation for ie9
support).
Please review this at http://gwt-code-reviews.appspot.com/1369808/
Affected files:
M user/src/com/google/gwt/user/UserAgent.gwt.xml
Index: user/src/com/google/gw
http://gwt-code-reviews.appspot.com/1369807/diff/1/dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java
File dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java
(right):
http://gwt-code-reviews.appspot.com/1369807/diff/1/dev/core/src/com/google/gwt/core/ext/DefaultSe
I agree that less permutations is better, but I would add a twist to the
question: even if we could should we? if one could only predict all
issues we will have with IE9 and then would we fix on safariimpl based
on (is ua==msie)? fork then and implement implIE9 to fix something? I
don't know of an
Reviewers: rjrjr, jat, bobv, jlabanca, fredsa,
Description:
property fall back value evaluation scheme - enable fall back bindings.
Please review this at http://gwt-code-reviews.appspot.com/1369807/
Affected files:
M dev/core/src/com/google/gwt/core/ext/DefaultSelectionProperty.java
M dev/
Reviewers: bobv, rjrjr,
Description:
user.agent proposal.
Please review this at http://gwt-code-reviews.appspot.com/1354806/show
Affected files:
M user/src/com/google/gwt/user/UserAgent.gwt.xml
Index: user/src/com/google/gwt/user/UserAgent.gwt.xml
==
Reviewers: unnurg,
Description:
fix for IE devmode when using specific linker setting.
Please review this at http://gwt-code-reviews.appspot.com/1358801/show
Affected files:
M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
Index: dev/core/src/com/google/gwt/core/ext/linker/imp
LTGM
http://gwt-code-reviews.appspot.com/1323802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm
http://gwt-code-reviews.appspot.com/1322802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1311802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001
File plugins/npapi/NPVariantWrapper.h (right):
http://gwt-code-reviews.appspot.com/1277801/diff/5001/6001#newcode105
plugins/npapi/NPVariantWrapper.h:105: if (isInt(variant)) {
my concern with this is something I chatted with Jat a coupl
LGTM
http://gwt-code-reviews.appspot.com/1184801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The binaries are part of the CL. it seems that rietveld does not show
them, but you can see them in the internal tool.
Also, legal cleared the inclusion of wix binaries under third_party. I
added a README.txt under wix folder as suggested by legal (please
eyeball it to make sure I did not write a
http://gwt-code-reviews.appspot.com/1116801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
:40:40, fabiomfv wrote:
On 2010/11/18 16:17:54, conroy wrote:
> does this msft copyright need to be here?
>
> if anything, shouldn't all these new files be getting the standard
GWT
copyright
> notice?
this a MS tool licensed to OS. I believe removing the
copyright might be a
http://gwt-code-reviews.appspot.com/1116801/diff/1/6
File plugins/ie/installer/build.cmd (right):
http://gwt-code-reviews.appspot.com/1116801/diff/1/6#newcode8
plugins/ie/installer/build.cmd:8: echo IMPORTANT: Make sure
"%~dp0oophm.wsx" is checked out and writable!
On 2010/11/18 16:17:54, conroy
http://gwt-code-reviews.appspot.com/1084801/diff/57001/58022
File plugins/npapi/VisualStudio/npapi-plugin.sln (right):
http://gwt-code-reviews.appspot.com/1084801/diff/57001/58022#newcode3
plugins/npapi/VisualStudio/npapi-plugin.sln:3: # Visual Studio 2008
On 2010/11/18 22:02:02, jat wrote:
Are
Reviewers: jat, knorton, conroy,
Description:
IE devmode plugin: 64 bits support end-to-end, build fixes & cleanup,
other polishing items.
Please review this at http://gwt-code-reviews.appspot.com/1116801/show
Affected files:
A plugins/ie/README.txt
A plugins/ie/build.cmd
D plugins/ie/bu
Reviewers: jat, knorton, conroy,
Description:
IE devmode plugin: 64 bits support end-to-end, build fixes & cleanup,
other polishing items.
Please review this at http://gwt-code-reviews.appspot.com/1115801/show
Affected files:
A plugins/ie/README.txt
A plugins/ie/build.cmd
D plugins/ie/bu
20:50:38, fabiomfv wrote:
> not sure how you are building this project. I could not find any
targets in
> build.xml or any other reference to devenv.exe
>
> you may also want to double check that the bin is release flavor as
the
default
> is debug when you invoke vs build.
huh
http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020
File plugins/npapi/VisualStudio/npapi-plugin.vcproj (left):
http://gwt-code-reviews.appspot.com/1084801/diff/28001/29020#oldcode1
plugins/npapi/VisualStudio/npapi-plugin.vcproj:1:
not sure how you are building this project. I could n
ping.
On 2010/10/14 19:46:03, fabiomfv wrote:
+1.
there is the possibility of choosing incorrectly since we are not able
to
look at the parameter type 'passed in' (proposed fix 2 would work on
that
basis, but is a higher impact change). As Ray mentioned, the safe
workaro
e (right):
>>
>
>
http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47
>> plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX
>>
> -fshort-wchar
>
>> On 2010/10/20 19:31:06, fabiomfv wrote:
>> > out of curiosity, why are we defining XP_U
/20 19:31:06, fabiomfv wrote:
> out of curiosity, why are we defining XP_UNIX for a presumably mac
build?
Mac is a variant of Unix. The other npapi plugin code I looked at all
defined
XP_UNIX for both linux and mac builds.
I guess want I really meant was why we don't need XP_MACOSX ex
http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001
File plugins/npapi/Makefile (right):
http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47
plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX
-fshort-wchar
out of curiosity, why are we defining XP_UNIX for a pr
http://gwt-code-reviews.appspot.com/993801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/993801/diff/1/3
File
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java
(right):
http://gwt-code-reviews.appspot.com/993801/diff/1/3#newcode146
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java:146:
public void testCh
http://gwt-code-reviews.appspot.com/993801/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
(right):
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode46
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:46:
private static HashMap typeRan
Reviewers: rjrjr,
Description:
The proposed fix will disambiguate setter overloads by ranking them
according
to the 'cost' of conversion. Fewer arguments will be preferred over many
arguments (e.g. setValue(boolean) will be preferred over
setValue(boolean, boolean)). Within a group os setters wit
48 matches
Mail list logo
