This seems like the right model of behavior. I wonder if we could figure out
a way to tweak the API exposing the behavior though when you get back from
vacation? As a user, I think I might get confused by the interactions of
setAlwaysAutoHide(), setAutoHidePartner,
Actually, hold off on this review please. In my haste, forgot to update
MenuBar and SuggestBox to take advantage of the new alwaysAutoHide
boolean.
http://gwt-code-reviews.appspot.com/814
--~--~-~--~~~---~--~~
http://gwt-code-reviews.appspot.com/606/diff/1/7
File user/src/com/google/gwt/event/logical/shared/HasNativeEvent.java
(right):
http://gwt-code-reviews.appspot.com/606/diff/1/7#newcode32
Line 32: }
Should this interface be in gwt.event.dom.client instead?
Emily -
I replied to all your comments. I'll send out a new patch for review
soon that addresses all of your issues.
- John
http://gwt-code-reviews.appspot.com/805/diff/1/5
File user/src/com/google/gwt/event/shared/GwtEvent.java (right):
Cool, looking forward to seeing the new patch!
Per our conversation, onPreviewNativeEvent will be exposed, but will
only contain minimal code by default. The bulk of the code will be in a
new method previewNativeEvent()
Why expose onPreviewNativeEvent at all?
--
There are only 10 types
This review replaces:
http://gwt-code-reviews.appspot.com/805/show
http://gwt-code-reviews.appspot.com/606
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
