Yes, as soon as we get the build stabilized, I'll commit this.
Thanks,
John LaBanca
jlaba...@google.com
On Wed, Oct 14, 2009 at 3:20 PM, Bruce Johnson wrote:
> @John L: You taking this one?
>
>
> On Wed, Oct 14, 2009 at 12:08 PM, Pascal Muetschard <
> pmuetsch...@google.com> wrote:
>
>> I've u
@John L: You taking this one?
On Wed, Oct 14, 2009 at 12:08 PM, Pascal Muetschard
wrote:
> I've uploaded another patch set, which merges in the latest changes from
> the trunk.
>
>
> On Mon, Oct 12, 2009 at 2:34 AM, John Tamplin wrote:
>
>> On Mon, Oct 12, 2009 at 12:03 AM, John LaBanca wrote:
>
I've uploaded another patch set, which merges in the latest changes from the
trunk.
On Mon, Oct 12, 2009 at 2:34 AM, John Tamplin wrote:
> On Mon, Oct 12, 2009 at 12:03 AM, John LaBanca wrote:
>
>> @jat -
>> When do you think we'll merge the htmlunit branch into trunk so we can
>> check in this
On Mon, Oct 12, 2009 at 12:03 AM, John LaBanca wrote:
> @jat -
> When do you think we'll merge the htmlunit branch into trunk so we can
> check in this patch?
>
We are supposed to ship MS2 on Wednesday, so it has to be real soon.
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~--
@jat -
When do you think we'll merge the htmlunit branch into trunk so we can check
in this patch?
Thanks,
John LaBanca
jlaba...@google.com
On Fri, Oct 9, 2009 at 2:58 PM, Pascal Muetschard wrote:
> I have updated the patch set to also have the benchmark test cases use the
> new strategy. Pleas
I have updated the patch set to also have the benchmark test cases use the
new strategy. Please review it.
When do you think this will make it into the trunk?
Thanks.
On Fri, Sep 25, 2009 at 4:36 PM, Pascal Muetschard
wrote:
> FYI, I've uploaded another patch to
> http://gwt-code-reviews.appspot
FYI, I've uploaded another patch to
http://gwt-code-reviews.appspot.com/71801 with the rename. Thanks for the
feedback!
On Fri, Sep 25, 2009 at 2:09 PM, Bruce Johnson wrote:
> I dig @WithProperties to the max.
>
>
> On Fri, Sep 25, 2009 at 2:16 PM, Pascal Muetschard > wrote:
>
>> How about @Wit
I dig @WithProperties to the max.
On Fri, Sep 25, 2009 at 2:16 PM, Pascal Muetschard
wrote:
> How about @WithProperties or @WithModuleProperty? Since the module XML
> files use , , ,
> and .
>
> On Fri, Sep 25, 2009 at 11:01 AM, John LaBanca wrote:
>
>> @WithClientProperties is fine with me. I t
How about @WithProperties or @WithModuleProperty? Since the module XML files
use , , ,
and .
On Fri, Sep 25, 2009 at 11:01 AM, John LaBanca wrote:
> @WithClientProperties is fine with me. I thought we used the term binding
> somewhere, but creating a DeferredBinding doesn't actual require the us
@WithClientProperties is fine with me. I thought we used the term binding
somewhere, but creating a DeferredBinding doesn't actual require the use of
the term binding. The gwt.xml files just refer to these as properties.
Thanks,
John LaBanca
jlaba...@google.com
On Fri, Sep 25, 2009 at 1:57 PM,
On Fri, Sep 25, 2009 at 1:51 PM, John LaBanca wrote:
> I vote for @WithBindingProperties for the annotation name.
Is that a vote that we should start using the term "binding properties" in
general?
I think that's not quite the right term (perhaps this should be a separate
thread) because incre
I'll help Pascal with the changes, but it might be good to get a few more
comments before changing too much. It *might *not be trivial for Benchmark
to subclass the new Strategy because it does its own thing as well, but it
shouldn't be too difficult.
I agree that the annotation should override e
On Fri, Sep 25, 2009 at 1:19 PM, Pascal Muetschard
wrote:
> 1) What happens if the module returned by getModuleName() already specifies
> a fix value for a given property? More generally, how should one think about
> how these annotations dovetail with the settings in the module config?
>
> The an
Looks convenient, but I have a few questions/comments.
1) What happens if the module returned by getModuleName() already specifies
a fix value for a given property? More generally, how should one think about
how these annotations dovetail with the settings in the module config?
2) The terminology
14 matches
Mail list logo
