Fantastic!
On Thu, Jul 30, 2009 at 1:52 PM, Ray Ryan wrote:
> WAHOO!
>
>
> On Thu, Jul 30, 2009 at 1:48 PM, Amit Manjhi wrote:
>
>> Thanks Scott. Commited the changes at r5844 with a fix the first thing and
>> a TODO for the second thing.
>>
>> On Thu, Jul 30, 2009 at 10:48 AM, wrote:
>>
>>> L
WAHOO!
On Thu, Jul 30, 2009 at 1:48 PM, Amit Manjhi wrote:
> Thanks Scott. Commited the changes at r5844 with a fix the first thing and
> a TODO for the second thing.
>
> On Thu, Jul 30, 2009 at 10:48 AM, wrote:
>
>> LGTM with nits.
>>
>>
>> http://gwt-code-reviews.appspot.com/54809/diff/1096/
Thanks Scott. Commited the changes at r5844 with a fix the first thing and
a TODO for the second thing.
On Thu, Jul 30, 2009 at 10:48 AM, wrote:
> LGTM with nits.
>
>
> http://gwt-code-reviews.appspot.com/54809/diff/1096/1130
> File user/src/com/google/gwt/junit/JUnitShell.java (right):
>
> htt
The next patch I will upload contains the fixes I have indicated as
done.
I also did not review carefully all the broken tests. I mostly
mechanically put the annotation just to get the whole test suite to
pass.
Currently, batching will not work with htmlUnit because the batching
code does not ye
I did not review the tests that were blocked, but they don't seem that
bad in general. I am a bit surprised at a few of them, but we can
improve them later.
http://gwt-code-reviews.appspot.com/54809/diff/1/32
File user/src/com/google/gwt/junit/DoNotRunWith.java (right):
http://gwt-code-reviews
I'll trust that RunStyleHtmlUnit itself works as advertised.
I admit I'm a little dismayed at just how many tests have to be
disabled-- especially since they imply problems with user-written test
cases of their own code. StringTest is particularly distressing for me,
but I'm sure many of the oth
