On Sun, Jun 09, 2024 at 03:35:06PM -0400, Patrick Plenefisch wrote:
> lv matching must be done after processing the ignored feature
> indirections, as integrity volumes & caches may have several levels
> of indirection that the segments must be shifted through.
>
> pv matching must be completely
On Sun, Jun 09, 2024 at 03:34:58PM -0400, Patrick Plenefisch wrote:
> This patch isn't necessary by itself, but when combined with the next
> patch it enhances readability as ignored_features_lv is then used for
> multiple types of extra LV's, not just cache LV's
>
> Signed-off-by: Patrick
On Wed, Jun 12, 2024 at 04:57:03PM +0100, Mate Kukri wrote:
> Currently the patchset consists of:
> - Reworked Fedora NX patches to make GRUB itself work under NX.
> - Julian Andres Klode's loader framework patch (used in Debian and Ubuntu for
> the downstream loader).
> - Implemented shim loader
r the PE DLL Characteristics flag GRUB_PE32_NX_COMPAT
> - changes grub-mkimage to set that flag.
>
> Original-Author: Peter Jones
> Signed-off-by: Mate Kukri
If you fix nits mentioned above then you can add
Reviewed-by: Daniel Kiper ...
Daniel
_
On Wed, Jun 12, 2024 at 04:57:09PM +0100, Mate Kukri wrote:
> For NX, we need to set write and executable permissions on the sections
> of grub modules when we load them.
>
> On sections with SHF_ALLOC set, which is typically everything except
> .modname and the symbol and string tables, this
On Tue, Jun 25, 2024 at 02:42:31PM +0800, Gary Lin wrote:
> On Mon, Jun 24, 2024 at 07:28:14PM +0200, Daniel Kiper wrote:
> > On Thu, Mar 07, 2024 at 04:59:05PM +0800, Gary Lin via Grub-devel wrote:
> > > On Thu, Feb 08, 2024 at 08:58:43PM +0100, Daniel Kiper wrote:
> > &g
On Thu, Mar 07, 2024 at 04:59:05PM +0800, Gary Lin via Grub-devel wrote:
> On Thu, Feb 08, 2024 at 08:58:43PM +0100, Daniel Kiper wrote:
> > Hey,
> >
> --8<--
> >
> > And I have attached the Coverity report. All issues reported there have
> > to be fix
On Wed, Jun 12, 2024 at 04:57:08PM +0100, Mate Kukri wrote:
> For NX, we need to set the page access permission attributes for write
> and execute permissions.
>
> This patch adds two new primitives, grub_set_mem_attrs() and
> grub_clear_mem_attrs(), and associated constant definitions, to be used
On Wed, Jun 12, 2024 at 04:57:07PM +0100, Mate Kukri wrote:
> Currently we load module sections at whatever alignment gcc+ld happened
> to dump into the ELF section header, which is often less then the page
> size. Since NX protections are page based, this alignment must be
> rounded up to page
on, and
> makes the allocation computation loop skip empty sections as the loading
> loop does.
>
> Signed-off-by: Peter Jones
> Signed-off-by: Jan Setje-Eilers
> Signed-off-by: Mate Kukri
> Reviewed-By: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
_
eter Jones
> Signed-off-by: Jan Setje-Eilers
> Signed-off-by: Mate Kukri
> Reviewed-By: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
>
> This patch sets that data as "const", which causes that flag not to be
> set.
>
> Signed-off-by: Peter Jones
> Signed-off-by: Jan Setje-Eilers
> Signed-off-by: Mate Kukri
> Reviewed-By: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
_
Hi all,
I have great pleasure of informing you that the call for proposals is open for
Systems Boot and Security Microconference [1] which is a part of Linux Plumbers
Conference [2]. The conference will be held in Vienna, Austria between 18th and
20th of September.
If you want to discuss with us
On Thu, Jun 20, 2024 at 03:35:32PM +0800, Gary Lin wrote:
> On Wed, Jun 19, 2024 at 06:34:13PM +0200, Daniel Kiper wrote:
> > On Fri, Jun 14, 2024 at 02:45:44PM +0800, Gary Lin wrote:
> > > From: Hernan Gatta
> > >
> > > The TPM2 key protector is a module
On Thu, Jun 20, 2024 at 02:13:02PM +0800, Gary Lin wrote:
> On Wed, Jun 19, 2024 at 04:04:47PM +0200, Daniel Kiper wrote:
> > On Wed, Jun 19, 2024 at 02:41:13PM +0800, Gary Lin wrote:
> > > On Tue, Jun 18, 2024 at 03:30:03PM +0200, Daniel Kiper wrote:
> > > > On F
On Wed, Jun 12, 2024 at 03:28:41PM +0800, Yifan Zhao wrote:
> mkfs.erofs with version < 1.6 does not support the -L option.
> Let's detect the version of mkfs.erofs and skip the label tests
> if it is not supported.
>
> Signed-off-by: Yifan Zhao
Reviewed-by: Dan
On Mon, Jun 17, 2024 at 02:44:09PM +0300, Vladimir Serbinenko wrote:
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Mon, Jun 17, 2024 at 02:44:08PM +0300, Vladimir Serbinenko wrote:
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Mon, Jun 17, 2024 at 03:56:31PM +0300, Vladimir Serbinenko wrote:
> Current code works only if package matches binary name transformation rules.
> It's often true but is no waz guaranteed
>
> Fixes bug #64410
>
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Dan
On Mon, Jun 17, 2024 at 03:56:30PM +0300, Vladimir Serbinenko wrote:
> Fixes bug #64408.
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinf
On Mon, Jun 17, 2024 at 03:59:56PM +0300, Vladimir Serbinenko wrote:
> First they're use macros so they can't be translated as-is.
> Second there is no point in translating them as they're too technical.
>
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Ki
loading another device tree depend on the compatible or
> model values of the device tree provided by the firmware.
>
> For now only the root level properties of the dtb are exposed.
>
> Signed-off-by: Tobias Heider
Reviewed-by: Daniel Kiper
Daniel
incrementing it inside the loop which
> copies argv to argp_argv. Issue an error message similar to what older
> versions of grub-mkrescue did with a missing argument (e.g 2.02).
>
> Fixes: https://savannah.gnu.org/bugs/index.php?65880
> Signed-off-by: Thomas Schmitt
Reviewe
On Fri, Jun 14, 2024 at 02:45:44PM +0800, Gary Lin wrote:
> From: Hernan Gatta
>
> The TPM2 key protector is a module that enables the automatic retrieval
> of a fully-encrypted disk's unlocking key from a TPM 2.0.
>
> The theory of operation is such that the module accepts various
> arguments,
On Wed, Jun 19, 2024 at 02:41:13PM +0800, Gary Lin wrote:
> On Tue, Jun 18, 2024 at 03:30:03PM +0200, Daniel Kiper wrote:
> > On Fri, Jun 14, 2024 at 02:45:43PM +0800, Gary Lin wrote:
> > > From: Hernan Gatta
> > >
> > > A Trusted Platform Module (TPM)
On Wed, Jun 19, 2024 at 02:43:08PM +0800, Gary Lin wrote:
> On Tue, Jun 18, 2024 at 05:41:13PM +0200, Daniel Kiper wrote:
> > On Fri, Jun 14, 2024 at 02:45:43PM +0800, Gary Lin wrote:
> > > From: Hernan Gatta
> > >
> > > A Trusted Platform Module (TPM)
On Fri, Jun 14, 2024 at 02:45:43PM +0800, Gary Lin wrote:
> From: Hernan Gatta
>
> A Trusted Platform Module (TPM) Software Stack (TSS) provides logic to
> compose and submit TPM commands and parse reponses.
>
> A limited number of TPM commands may be accessed via the EFI TCG2
> protocol. This
On Fri, Jun 14, 2024 at 02:45:43PM +0800, Gary Lin wrote:
> From: Hernan Gatta
>
> A Trusted Platform Module (TPM) Software Stack (TSS) provides logic to
> compose and submit TPM commands and parse reponses.
>
> A limited number of TPM commands may be accessed via the EFI TCG2
> protocol. This
> Signed-off-by: Gary Lin
> Reviewed-by: Stefan Berger
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Fri, Jun 14, 2024 at 02:45:41PM +0800, Gary Lin wrote:
> Document libtasn1 in docs/grub-dev.texi and add the upgrade steps.
> Also add the patches to make libtasn1 compatible with grub code.
>
> Signed-off-by: Gary Lin
> Reviewed-by: Vladimir Serbinenko
> ---
> docs/grub-dev.texi | 33
On Fri, Jun 14, 2024 at 02:45:40PM +0800, Gary Lin wrote:
> From: Daniel Axtens
>
> Import tests from libtasn1 that don't use functionality we don't
> import. This test module is integrated into functional_test so that the
> user can run the test in grub shell.
>
> This doesn't test the full
rbinenko
Due to amount of changes to the patch I think this RB should be dropped now.
Though Reviewed-by: Daniel Kiper ...
Two nits below...
> ---
> autogen.sh | 16
> grub-core/Makefile.core.def| 15 +++
> gru
ducing a too large 'k'.
>
> This is a quick fix and may differ from the official upstream fix.
>
> libtasn1 issue: https://gitlab.com/gnutls/libtasn1/-/issues/49
This patch does not need Daniel Axtens SB of course. Sorry for
not being precise.
> Signed-off-by: Gary Lin
Reviewe
On Fri, Jun 14, 2024 at 02:45:37PM +0800, Gary Lin wrote:
> Based on the patch from "Daniel Axtens "
>
> Do a few things to make libtasn1 compile as part of grub:
>
> - remove _asn1_strcat and replace strcat with the bound-checked
>_asn1_str_cat except the one inside _asn1_str_cat. That
the difference between upstream and grub is smaller,
> which should make updating libtasn1 easier in the future.
>
> With these exclusions we also avoid the need for minmax.h,
> which is convenient because it means we don't have to
> import it from gnulib.
>
> Signed-o
libtasn1-4.19.0/lib/includes/libtasn1.h grub-core/lib/libtasn1/
> rm -rf libtasn1-4.19.0*
>
> Signed-off-by: Daniel Axtens
> Signed-off-by: Gary Lin
> Reviewed-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel
On Fri, Jun 14, 2024 at 06:26:00PM +0200, Tobias Heider wrote:
> On Fri, Jun 14, 2024 at 06:03:23PM +0200, Daniel Kiper wrote:
> > On Wed, Jun 12, 2024 at 01:12:28PM +0200, Tobias Heider wrote:
> > > The fdtdump command allows dumping arbitrary device tree properties
>
rd_packet should be
> effectively removed. According to test results, the delay has
> disappeared, and it is now much easier to use interactively.
>
> Signed-Off-by: Michael Chang
> Tested-by: Tony Jones
Reviewed-by: Daniel Kiper
Daniel
_
On Thu, May 16, 2024 at 09:43:46PM +0300, Vladimir Serbinenko wrote:
> In some cases like loading kernel from native disk (e.g. nvme) not
> supported by EFI in question efi stub is not an option. Allow
> user to disable efi stub and fallback to older protocol
I think this patch should be
On Thu, May 16, 2024 at 10:42:25PM +0300, Vladimir Serbinenko wrote:
> Signed-off-by: Vladimir Serbinenko
> ---
> grub-core/Makefile.core.def | 1 +
> grub-core/fs/zfs/zfs.c | 32
> include/grub/zfs/zio.h | 1 +
> 3 files changed, 34 insertions(+)
>
>
On Mon, Jun 10, 2024 at 11:35:11AM +0530, Mukesh Kumar Chaurasiya wrote:
> Sometimes, when booting from a very busy SAN, the access to the
> disk can fail and then GRUB will eventually drop to GRUB prompt.
> This scenario is more frequent when deploying many machines at
> the same time using the
On Mon, Jun 10, 2024 at 11:29:56AM +0530, Mukesh Kumar Chaurasiya wrote:
> The information about "vscsi-report-luns" data is a list of disk details
> with pairs of memory addresses and lengths.
>
> 8 bytes 8 bytes
> lun-addr ---> 8
On Wed, Jun 12, 2024 at 01:12:29PM +0200, Tobias Heider wrote:
> Signed-off-by: Tobias Heider
> ---
> docs/grub.texi | 26 ++
> 1 file changed, 26 insertions(+)
>
> diff --git a/docs/grub.texi b/docs/grub.texi
> index f3bdc2564..a050dc0fc 100644
> --- a/docs/grub.texi
>
On Wed, Jun 12, 2024 at 01:12:28PM +0200, Tobias Heider wrote:
> The fdtdump command allows dumping arbitrary device tree properties
> and saving them to a variable similar to the smbios command.
>
> This is useful in scripts where further actions such as selecting a
> kernel or loading another
On Thu, Jun 06, 2024 at 09:44:10PM +0530, Sudhakar Kuppusamy wrote:
> it reads the SBAT data from sbat.csv and create the ELF Note for it then
> store the SBAT data on it while generate image with -s option
May I ask you to use proper English sentences in the commit messages?
> Signed-off-by:
that exfatprogs is now needed and also
s/to not/to note/?
> exfat-fuse, which is needed do the fuse mount.
>
> Signed-off-by: Glenn Washburn
Otherwise Reviewed-by: Daniel Kiper ...
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
uksdiskfile. The first
> sets it to the header file if $detached_header is set, otherwise leave it
> unset. The second statement sets it to itself if it is already set,
> otherwise it is set to $luksfile.
>
> Fixes: a7b540e6e (tests: Add cryptomount functional test)
> Signed-off
o use system firmwares or is not on a Debian system.
>
> Glenn
>
> Glenn Washburn (2):
> tests/util/grub-shell: Use pflash instead of -bios to load UEFI
> firmware
> tests/util/grub-shell: Add flexibility in QEMU firmware handling
For both patches Revi
On Sat, Jun 08, 2024 at 09:22:31PM -0500, Glenn Washburn wrote:
> Allow using GDB to debug a failing QEMU test. This output does not cause
> issues for tests because it happens before the trim line, and so will be
> ignored.
>
> Signed-off-by: Glenn Washburn
Reviewed-by: Daniel
On Sat, Jun 08, 2024 at 05:44:15PM -0500, Glenn Washburn wrote:
> Signed-off-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
't have an issue
> applying it.
>
> Reviewed-by: Glenn Washburn
Though this time Reviewed-by: Daniel Kiper ...
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Tue, Jun 11, 2024 at 03:10:56PM +0800, Gary Lin via Grub-devel wrote:
> On Fri, Jun 07, 2024 at 04:14:54PM +0200, Daniel Kiper wrote:
> > On Fri, Jun 07, 2024 at 11:07:31AM +0800, Gary Lin wrote:
> > > On Wed, Jun 05, 2024 at 05:18:32PM +0200, Daniel Kiper wrote:
> >
nd thus keeping the whole block in the list and freeing it again
> at exit can lead to double frees.
>
> Signed-off-by: Mate Kukri
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
othing if the allocation it is asked to drop
> isn't on the list, but the call to it is obviously unnecessary here.
>
> Signed-off-by: Mate Kukri
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
e maps
> fit into 12K.
>
> This bug was trigerred on Project Mu firmware with a big memory map, and
> results in the heap getting trashed and the firmware ASSERTING on
> corrupted heap guard values when GRUB exits.
>
> Signed-off-by: Mate Kukri
R
On Fri, Jun 07, 2024 at 11:07:31AM +0800, Gary Lin wrote:
> On Wed, Jun 05, 2024 at 05:18:32PM +0200, Daniel Kiper wrote:
> > On Wed, May 15, 2024 at 01:06:55PM +0800, Gary Lin wrote:
> > > From: Daniel Axtens
> > >
> > > We don't expect to be able to write
On Thu, May 16, 2024 at 10:03:29PM +0300, Vladimir Serbinenko wrote:
> Signed-off-by: Vladimir Serbinenko
> ---
> configure.ac | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 84a202c6e..c76a29af4 100644
> --- a/configure.ac
> +++
On Wed, May 15, 2024 at 01:06:55PM +0800, Gary Lin wrote:
> From: Daniel Axtens
>
> We don't expect to be able to write ASN.1, only read it,
> so we can disable some code.
>
> Do that with #if 0/#endif, rather than deletion. This means
> that the difference between upstream and grub is smaller,
>
On Wed, May 15, 2024 at 01:06:54PM +0800, Gary Lin wrote:
> From: Daniel Axtens
>
> Import a very trimmed-down set of libtasn1 files:
I hope you merge the latest one...
> pushd /tmp
I would create tmp dir in the GRUB source code and extract libtasn1
there. Then I would remove the tmp dir.
>
e HAVE_STRTOUL here.
>
> - Implement c-ctype.h and the functions defined in the header.
>
> - Implement strncat in string.h.
>
> Cc: Vladimir Serbinenko
> Signed-off-by: Daniel Axtens
> Signed-off-by: Gary Lin
Reviewed-by: Daniel Kiper
A nit below...
> diff --git
On Wed, Jan 24, 2024 at 06:26:37AM +, Alec Brown wrote:
> Added functionality to disable command line interface access and editing of
> GRUB
> menu entries if GRUB image is built with --disable-cli.
>
> Signed-off-by: Alec Brown
Reviewed-by: Daniel
1
>
> Signed-off-by: Hector Cao
Reviewed-by: Daniel Kiper but a nit below...
> ---
> grub-core/commands/efi/tpm.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/grub-core/commands/efi/tpm.c b/grub-core/commands/efi/tpm.c
> index f250c30db..40845af7a 1006
On Fri, May 17, 2024 at 10:53:27AM +0300, Vladimir Serbinenko wrote:
> Current code in some codepaths neither discards nor reports
> errors. Properly surface the error
>
> While on it split 2 cases of unrelated variables both named err.
>
> Signed-off-by: Vladimir Serbinenko
R
On Mon, Jun 03, 2024 at 06:33:04PM +0200, Daniel Kiper wrote:
> On Thu, May 16, 2024 at 10:22:58PM +0300, Vladimir Serbinenko wrote:
> > Without them 0x80LL is 32-bit byte-swapped to 0x8000 instead
> > of correct 0x8000
I think it should be added "on 64-
On Thu, May 16, 2024 at 10:27:41PM +0300, Vladimir Serbinenko wrote:
> We don't need any actual adjustments as we don't use the affected
> structures
>
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel
On Thu, May 16, 2024 at 10:22:58PM +0300, Vladimir Serbinenko wrote:
> Without them 0x80LL is 32-bit byte-swapped to 0x8000 instead
> of correct 0x8000
>
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
On Thu, May 16, 2024 at 10:07:12PM +0300, Vladimir Serbinenko wrote:
> This allows to set up cross environment with just 3 parameters: target,
> platform and TARGET_CROSS
May I ask you to document this in the INSTALL file?
Daniel
___
Grub-devel
On Thu, May 16, 2024 at 10:03:29PM +0300, Vladimir Serbinenko wrote:
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Thu, May 16, 2024 at 09:37:49PM +0300, Vladimir Serbinenko wrote:
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Mon, May 27, 2024 at 08:42:04PM +0800, Tianjia Zhang wrote:
> Allocate memory if needed, while saving the corresponding release
> operation, reducing the amount of code and code complexity.
>
> Signed-off-by: Tianjia Zhang
Reviewed-by: Daniel Ki
On Fri, May 31, 2024 at 02:42:38PM +0200, Hector Cao wrote:
> The measurements for confidential computing has been introduced in the commit
> 4c76565b6 (efi/tpm: Add EFI_CC_MEASUREMENT_PROTOCOL support). Recently
> this patch 30708dfe3 (tpm: Disable the tpm verifier if the TPM device
> is not
Same comments as for earlier patches...
Thank you for moving this to separate patch.
On Fri, May 24, 2024 at 08:30:06PM +0300, Vladimir Serbinenko wrote:
> ---
> .../lib/libgcrypt-patches/02_keccak_sse.diff | 19 +++
> 1 file changed, 19 insertions(+)
> create mode 100644
Same comments as for earlier patches...
On Fri, May 24, 2024 at 08:30:05PM +0300, Vladimir Serbinenko wrote:
> ---
> grub-core/tests/dsa_sexp_test.c | 107
> grub-core/tests/rsa_sexp_test.c | 81
> 2 files changed, 188 insertions(+)
>
Again, missing commit message and SOB.
Could you add to the GRUB Developers Manual description how to upgrade
the libgcrypt?
On Fri, May 24, 2024 at 08:30:04PM +0300, Vladimir Serbinenko wrote:
> ---
> autogen.sh | 5 +
> conf/Makefile.common
Why this file is needed? From which GPG version this file come from?
And missing SOB...
On Fri, May 24, 2024 at 08:30:03PM +0300, Vladimir Serbinenko wrote:
> ---
> grub-core/lib/b64dec.c | 293 +
> 1 file changed, 293 insertions(+)
> create mode 100644
Could you add your SOB and a few words to the commit message explaining
why this patch is needed.
It would be nice if you add a cover letter to this patch set too.
Daniel
On Fri, May 24, 2024 at 08:30:02PM +0300, Vladimir Serbinenko wrote:
> ---
> grub-core/lib/libgcrypt/AUTHORS
boot failure.
>
> Signed-off-by: Avnish Chouhan
> Reviewed-by: Daniel Kiper
I am OK with this RB now. However, you should not add any tags on
behalf of anybody without their explicit permission.
Daniel
___
Grub-devel mailing list
Gru
On Mon, Dec 18, 2023 at 08:02:34PM +0530, Avnish Chouhan wrote:
> This patch adds support for Radix, Xive and Radix_gtse in Options
> vector5 which is required for KVM LPARs. KVM LPARs ONLY support
> Radix and not the Hash. Not enabling Radix on any PowerVM KVM LPARs
> will result in boot failure.
On Sun, May 19, 2024 at 05:50:10PM +0200, Pascal Hambourg wrote:
> This is required if the pathname contains spaces or grub shell
> metacharacters, else the generated config file check will fail.
>
> Signed-off-by: Pascal Hambourg
Reviewed-by: Daniel Ki
On Fri, Apr 26, 2024 at 08:59:21PM -0400, Patrick Plenefisch wrote:
> From 42252f253ac685bbc7cea1f5c89146eeeaa364f0 Mon Sep 17 00:00:00 2001
> From: Patrick Plenefisch
> Date: Sun, 18 Feb 2024 18:29:43 -0500
> Subject: [PATCH 1/2] disk/lvm: Make cache_lv more generic as
> ignored_feature_lv
On Fri, Apr 26, 2024 at 09:00:08PM -0400, Patrick Plenefisch wrote:
> From 8cfb6dbb011d3773b90a3cbb8561616a2fb5955f Mon Sep 17 00:00:00 2001
> From: Patrick Plenefisch
> Date: Sun, 18 Feb 2024 18:36:05 -0500
> Subject: [PATCH 2/2] lvm: Add support for cachevol and integrity lv
May I ask you to
On Fri, May 17, 2024 at 02:24:50PM +0300, Vladimir 'phcoder' Serbinenko wrote:
> Le ven. 17 mai 2024, 14:15, Daniel Kiper a écrit :
> Why is this patch needed? Should not we disable SSE using compiler
> flags?
> We do but the code in question uses SSE on every x64 platform
Hey,
On Sat, May 18, 2024 at 02:52:20PM +1000, Daniel Axtens wrote:
> Hi Daniel,
>
> > Reviewed-by: Daniel Kiper for both patches...
>
> Thank you!
>
> > I assume I can add your SOB on your behalf...
>
> Oh! Yes! Sorry, 2 years of closed source development have a
On Sun, May 19, 2024 at 11:48:24AM +0800, Gao Xiang wrote:
> The following EROFS patch will use this helper to handle overflow
> ALIGN_UP() cases.
>
> Signed-off-by: Gao Xiang
I think Vladimir is right.
Reviewed-by: Daniel Kiper
Please post v15 an I will merge it this week
On Mon, May 20, 2024 at 08:58:24AM +0100, Jonathan Davies wrote:
> Signed-off-by: Jonathan Davies
Reviewed-by: Daniel Kiper
Thank you for fixing these mistakes.
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mail
Why is this patch needed? Should not we disable SSE using compiler flags?
Daniel
On Thu, May 16, 2024 at 09:27:43PM +0300, Vladimir Serbinenko wrote:
> ---
> grub-core/lib/libgcrypt/cipher/keccak.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
Please add a commit message and SOB...
Additionally, please expand "Updating external code" in GRUB dev
documentation with a description how to update libgcrypt.
On Thu, May 16, 2024 at 09:27:42PM +0300, Vladimir Serbinenko wrote:
> ---
> autogen.sh | 1 +
Adding a few folks who are probably interested in this series...
May I ask you to add a few words to the commit message saying why this
change is needed? And please do not forget to add your SOB to this and
other patches.
Ah, and missing cover letter...
Daniel
any security
> implications
> of either change, and the gzip compression test still passes.
>
> Daniel Axtens (2):
> gzio: abort early when get_byte reads nothing
> gzio: Properly init a table
Reviewed-by: Daniel Kiper for both patches...
I assume I can add your
On Fri, May 17, 2024 at 12:40:53PM +0800, Gao Xiang wrote:
> From: Yifan Zhao
>
> EROFS [1] is a lightweight read-only filesystem designed for performance
> which has already been shipped in most Linux distributions as well as widely
> used in several scenarios, such as Android system partitions,
Patrick,
On Thu, May 16, 2024 at 03:38:17PM -0400, Patrick Plenefisch wrote:
> Daniel,
>
> I haven't heard any update about my patch from you since early February. Is
> there anything I need to do or is this good to go? I'm not too familiar with
> actually submitting patches to mailing-list based
Signed-off-by: Gao Xiang
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Fri, May 10, 2024 at 08:52:55AM +0800, Gao Xiang wrote:
> From: Yifan Zhao
>
> EROFS [1] is a lightweight read-only filesystem designed for performance
> which has already been shipped in most Linux distributions as well as widely
> used in several scenarios, such as Android system partitions,
Hey,
On Thu, May 02, 2024 at 03:01:37PM +0800, Yifan Zhao wrote:
> EROFS [1] is a lightweight read-only filesystem designed for performance
> which has already been shipped in most Linux distributions as well as widely
> used in several scenarios, such as Android system partitions, container
>
On Fri, Apr 26, 2024 at 12:13:21AM +0200, Marek Marczykowski-Górecki wrote:
> On Thu, Apr 25, 2024 at 11:27:53PM +0200, Daniel Kiper wrote:
> > Hey,
> >
> > On Tue, Mar 12, 2024 at 05:13:24AM +0100, Marek Marczykowski-Górecki wrote:
> > > Hi,
> > >
>
Your patch makes sens but the commit message is wrong. In general we
will be leaking memory for short time. Not big deal here but worth
fixing. The memory will not be freed twice as you say in the commit
message. May I ask you to fix the commit message?
On Tue, Apr 23, 2024 at 09:04:34AM +0800,
this RB does not make a lot of sens if we have your SOB below.
I will drop the RB.
> > Signed-off-by: Glenn Washburn
>
> Thanks for taking care of this.
Yeah, thanks a lot Glenn!
> I'd ack it but that would make the signoff chain look even weirder :-)
:-)
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
around 220 metadata changes to the VG.
>
> Fixes: 879c4a834 (lvm: Fix two more potential data-dependent alloc overflows)
> Fixes: https://savannah.gnu.org/bugs/?61620
>
> Signed-off-by: Rogier
> Signed-off-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Marta, may I ask you to te
up. A value in the
> cryptodisk_passphrase_tries environment variable will override this default.
>
> The user can give up early by entering an empty passphrase, just as they
> could before this patch.
>
> Signed-off-by: Forest
Reviewed-by: Daniel Kiper
Daniel
_
gment() -> grub_diskfilter_read_node() ->
> -> grub_disk_read() -> grub_disk_read_small() ->...
>
> The fix adds checks for both the superblock region and the data
> region when parsing the superblock metadata in grub_mdraid_detect().
>
> Signed-off-by: Lidong Chen
1 - 100 of 3160 matches
Mail list logo
