Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-14 Thread Christian Biere
Bill Pringlemeir wrote: > Some files like .ini, .xml, .dll, and .exe I am never interested in. Well, you could discard these from a global post- or pre-filter. > A configured filter for all browse hosts would be nice. Maybe. The filter is powerful but it's not very intuitive except for very simp

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-14 Thread Lloyd Bryant
>From: "Lloyd Bryant" <[EMAIL PROTECTED]> >To: gtk-gnutella-devel@lists.sourceforge.net >Subject: Re: [Gtk-gnutella-devel] Patch: Randomize search results >Date: Tue, 14 Nov 2006 03:08:37 -0700 > > > >Christian Biere wrote: > > > I wanted to

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-14 Thread Raphael Manfredi
Quoting Christian Biere <[EMAIL PROTECTED]> from ml.softs.gtk-gnutella.devel: :Raphael Manfredi wrote: :> Yes, it would be good to include and process GGEP PATH in query hits. : :It's now implemented in SVN. There's a switch in Preferences->Uploads: :Tick "Expose relative paths" to enable this feat

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-14 Thread Lloyd Bryant
>Christian Biere wrote: > > I wanted to sort the index by the modification time, so that browse host > > would show the newest files first. Maybe you want to implement this as >well? > >Actually, it should be newest last, at least the indices to keep them >stable. >The browse host output could o

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-13 Thread Christian Biere
Raphael Manfredi wrote: > Yes, it would be good to include and process GGEP PATH in query hits. It's now implemented in SVN. There's a switch in Preferences->Uploads: Tick "Expose relative paths" to enable this feature. > To make things easier on the b/w, I'd always include PATH on browse host, >

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-13 Thread Bill Pringlemeir
On 12 Nov 2006, [EMAIL PROTECTED] wrote: > Apart from that it is likely 20k Spam entries, I feel that "browse > host" - as cool as it is - becomes a pain as soon as the remote > shares more than a few hundred files, because no directories are > shown. Most times when you sort by name you end up wi

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-13 Thread Raphael Manfredi
Quoting Lloyd Bryant <[EMAIL PROTECTED]> from ml.softs.gtk-gnutella.devel: :I'll have to remember that. I keep bouncing from one extreme to the other :in that regard - professionally, I tend to add TONS of comments, as most :shops I've worked at required such, while in the OSS arena I keep getti

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-13 Thread Raphael Manfredi
Quoting Christian Biere <[EMAIL PROTECTED]> from ml.softs.gtk-gnutella.devel: :I have thought about this recently too. So I'd like to sent the relative :paths unconditionally in search results including browse host replies. It will :have to be enabled on a per shared-path-basis. So if you share : :

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-13 Thread Lloyd Bryant
>From: Jonas Sonntag <[EMAIL PROTECTED]> > >Apart from that it is likely 20k Spam entries, I feel that "browse host" - >as >cool as it is - becomes a pain as soon as the remote shares more than a few >hundred files, because no directories are shown. Most times when you sort >by >name you end up

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-13 Thread Christian Biere
Jonas Sonntag wrote: > Apart from that it is likely 20k Spam entries, I feel that "browse host" - as > cool as it is - becomes a pain as soon as the remote shares more than a few > hundred files, because no directories are shown. Most times when you sort by > name you end up with hundreds of fil

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-13 Thread Jonas Sonntag
On Sunday 12 November 2006 00:59, Christian Biere wrote: > Lloyd Bryant wrote: > > Let me take a look at that one.  The "browse host" feature has been > > giving me a ton of grief lately - most of the nodes I want to browse have > > it disabled, and the rest seem to have 20,000+ files.  Seems like

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-11 Thread Christian Biere
Lloyd Bryant wrote: > >Christian Biere wrote: > > > I wanted to sort the index by the modification time, so that browse host > > > would show the newest files first. Maybe you want to implement this as > >well? > >Actually, it should be newest last, at least the indices to keep them > >stable. >

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-11 Thread Lloyd Bryant
> >Christian Biere wrote: > > I wanted to sort the index by the modification time, so that browse host > > would show the newest files first. Maybe you want to implement this as >well? > >Actually, it should be newest last, at least the indices to keep them >stable. >The browse host output coul

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-11 Thread Lloyd Bryant
>From: [EMAIL PROTECTED] (Raphael Manfredi) > >This is very neat, and it has been in my TODO for a long time... > >One comment on your patch though: it lacks comments. I understand the >fix is simple, but when you read the code, nowhere does it say what it >does. > >I'd summarize what you said

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-11 Thread Raphael Manfredi
Quoting Lloyd Bryant <[EMAIL PROTECTED]> from ml.softs.gtk-gnutella.devel: :The attached patch (to "src/core/matching.c") implements this by generating :a random offset for the list of potential matches. This offset is added to :the index (and wrapped around if it hits the end). This way, a que

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-11 Thread Christian Biere
Christian Biere wrote: > I wanted to sort the index by the modification time, so that browse host > would show the newest files first. Maybe you want to implement this as well? Actually, it should be newest last, at least the indices to keep them stable. The browse host output could of course be u

Re: [Gtk-gnutella-devel] Patch: Randomize search results

2006-11-11 Thread Christian Biere
Lloyd Bryant wrote: > Scenario: A host has a large number of files that match a particular > query. As it stands, no matter how many times another nodes issues that > query, the host in question will respond with the same 50 responses. Excellent idea. I thought of something similar recently. I

[Gtk-gnutella-devel] Patch: Randomize search results

2006-11-11 Thread Lloyd Bryant
Scenario: A host has a large number of files that match a particular query. As it stands, no matter how many times another nodes issues that query, the host in question will respond with the same 50 responses. Ideally, if the user sees a large block of matching results from one node, he coul