[jira] [Commented] (HDFS-2638) Improve a blog recovery log

[ https://issues.apache.org/jira/browse/HDFS-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164026#comment-13164026 ] Eli Collins commented on HDFS-2638: --- Unit tests are running, earlier run was clean. test-

[jira] [Commented] (HDFS-2178) Contributing Hoop to HDFS, replacement for HDFS proxy with read/write capabilities

[ https://issues.apache.org/jira/browse/HDFS-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164023#comment-13164023 ] Eli Collins commented on HDFS-2178: --- Latest patch looks good, mostly small stuff: * In Te

[jira] [Commented] (HDFS-2178) Contributing Hoop to HDFS, replacement for HDFS proxy with read/write capabilities

[ https://issues.apache.org/jira/browse/HDFS-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163832#comment-13163832 ] Eli Collins commented on HDFS-2178: --- Per offline conversation with Tucu: # It makes sense

[jira] [Commented] (HDFS-2178) Contributing Hoop to HDFS, replacement for HDFS proxy with read/write capabilities

[ https://issues.apache.org/jira/browse/HDFS-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163753#comment-13163753 ] Eli Collins commented on HDFS-2178: --- bq. Hoop actually depends on the HDFS JAR. HDFS JAR

[jira] [Commented] (HDFS-2178) Contributing Hoop to HDFS, replacement for HDFS proxy with read/write capabilities

[ https://issues.apache.org/jira/browse/HDFS-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163694#comment-13163694 ] Eli Collins commented on HDFS-2178: --- bq. Technically we could move Hoop under common. But

[jira] [Commented] (HDFS-2430) The number of failed or low-resource volumes the NN can tolerate should be configurable

[ https://issues.apache.org/jira/browse/HDFS-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163144#comment-13163144 ] Eli Collins commented on HDFS-2430: --- +1 rebase on 1580 looks correct. >

[jira] [Commented] (HDFS-2627) HA: determine DN's view of which NN is active based on heartbeat responses

[ https://issues.apache.org/jira/browse/HDFS-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163139#comment-13163139 ] Eli Collins commented on HDFS-2627: --- +1 latest patch lgtm. Filed HDFS-2633 for the poor n

[jira] [Commented] (HDFS-2178) Contributing Hoop to HDFS, replacement for HDFS proxy with read/write capabilities

[ https://issues.apache.org/jira/browse/HDFS-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163129#comment-13163129 ] Eli Collins commented on HDFS-2178: --- Some feedback on latest patch: * The class and file

[jira] [Commented] (HDFS-2178) Contributing Hoop to HDFS, replacement for HDFS proxy with read/write capabilities

[ https://issues.apache.org/jira/browse/HDFS-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163108#comment-13163108 ] Eli Collins commented on HDFS-2178: --- Btw any idea why test-patch keeps failing? The patch

[jira] [Commented] (HDFS-2178) Contributing Hoop to HDFS, replacement for HDFS proxy with read/write capabilities

[ https://issues.apache.org/jira/browse/HDFS-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163106#comment-13163106 ] Eli Collins commented on HDFS-2178: --- Thanks. Will checkout the updated patch. bq. Regard

[jira] [Commented] (HDFS-2178) Contributing Hoop to HDFS, replacement for HDFS proxy with read/write capabilities

[ https://issues.apache.org/jira/browse/HDFS-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162942#comment-13162942 ] Eli Collins commented on HDFS-2178: --- @Tucu, Looking good. Sanjay's suggestion of having

[jira] [Commented] (HDFS-2627) HA: determine DN's view of which NN is active based on heartbeat responses

[ https://issues.apache.org/jira/browse/HDFS-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162905#comment-13162905 ] Eli Collins commented on HDFS-2627: --- Sorry I meant AND, ie BPOfferService#isAlive is not

[jira] [Commented] (HDFS-2627) HA: determine DN's view of which NN is active based on heartbeat responses

[ https://issues.apache.org/jira/browse/HDFS-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162544#comment-13162544 ] Eli Collins commented on HDFS-2627: --- Overall looks good. Per the TODO in updateActorStat

[jira] [Commented] (HDFS-1972) HA: Datanode fencing mechanism

[ https://issues.apache.org/jira/browse/HDFS-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162543#comment-13162543 ] Eli Collins commented on HDFS-1972: --- The proposed solution looks solid to me. Note that t

[jira] [Commented] (HDFS-2626) HA: BPOfferService.verifyAndSetNamespaceInfo needs to be synchronized

[ https://issues.apache.org/jira/browse/HDFS-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162518#comment-13162518 ] Eli Collins commented on HDFS-2626: --- +1 lgtm > HA: BPOfferService.verify

[jira] [Commented] (HDFS-2624) HA: ConfiguredFailoverProxyProvider doesn't correctly stop ProtocolTranslators

[ https://issues.apache.org/jira/browse/HDFS-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162515#comment-13162515 ] Eli Collins commented on HDFS-2624: --- +1 lgtm also > HA: ConfiguredFailov

[jira] [Commented] (HDFS-2625) HA: TestDfsOverAvroRpc failing after introduction of HeartbeatResponse type

[ https://issues.apache.org/jira/browse/HDFS-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162517#comment-13162517 ] Eli Collins commented on HDFS-2625: --- +1 > HA: TestDfsOverAvroRpc failing

[jira] [Commented] (HDFS-1108) Log newly allocated blocks

[ https://issues.apache.org/jira/browse/HDFS-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161744#comment-13161744 ] Eli Collins commented on HDFS-1108: --- Per above we can remove the conf option since we onl

[jira] [Commented] (HDFS-2612) HA: handle refreshNameNodes in federated HA clusters

[ https://issues.apache.org/jira/browse/HDFS-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161179#comment-13161179 ] Eli Collins commented on HDFS-2612: --- +1 lgtm > HA: handle refreshNameNo

[jira] [Commented] (HDFS-2622) HA: fix TestDFSUpgrade on HA branch

[ https://issues.apache.org/jira/browse/HDFS-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161081#comment-13161081 ] Eli Collins commented on HDFS-2622: --- +1 lgtm > HA: fix TestDFSUpgrade on

[jira] [Commented] (HDFS-2619) Remove my personal email address from the libhdfs build file.

[ https://issues.apache.org/jira/browse/HDFS-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161014#comment-13161014 ] Eli Collins commented on HDFS-2619: --- +1 > Remove my personal email addre

[jira] [Commented] (HDFS-2430) The number of failed or low-resource volumes the NN can tolerate should be configurable

[ https://issues.apache.org/jira/browse/HDFS-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160535#comment-13160535 ] Eli Collins commented on HDFS-2430: --- bq. It only throws an RTE if the configured number o

[jira] [Commented] (HDFS-1975) HA: Support for sharing the namenode state from active to standby.

[ https://issues.apache.org/jira/browse/HDFS-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159955#comment-13159955 ] Eli Collins commented on HDFS-1975: --- Delta lgtm > HA: Support for sharin

[jira] [Commented] (HDFS-2570) Add descriptions for dfs.*.https.address in hdfs-default.xml

[ https://issues.apache.org/jira/browse/HDFS-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159883#comment-13159883 ] Eli Collins commented on HDFS-2570: --- Committed the delta, thanks for reviewing. Filed HDF

[jira] [Commented] (HDFS-2601) Proposal to store edits and checkpoints inside HDFS itself for namenode HA

[ https://issues.apache.org/jira/browse/HDFS-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159874#comment-13159874 ] Eli Collins commented on HDFS-2601: --- There are also non-shared storage approaches (eg HDF

[jira] [Commented] (HDFS-1975) HA: Support for sharing the namenode state from active to standby.

[ https://issues.apache.org/jira/browse/HDFS-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159872#comment-13159872 ] Eli Collins commented on HDFS-1975: --- +1 to the latest patch. Nit: you can remove the diff

[jira] [Commented] (HDFS-2591) HA: MiniDFSCluster support to mix and match federation with HA

[ https://issues.apache.org/jira/browse/HDFS-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159633#comment-13159633 ] Eli Collins commented on HDFS-2591: --- +1 the delta lgtm > HA: MiniDFSClus

[jira] [Commented] (HDFS-1975) HA: Support for sharing the namenode state from active to standby.

[ https://issues.apache.org/jira/browse/HDFS-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159117#comment-13159117 ] Eli Collins commented on HDFS-1975: --- Agree, let's get this one in and have a separate jir

[jira] [Commented] (HDFS-2591) HA: MiniDFSCluster support to mix and match federation with HA

[ https://issues.apache.org/jira/browse/HDFS-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159100#comment-13159100 ] Eli Collins commented on HDFS-2591: --- +1 lgtm > HA: MiniDFSCluster suppor

[jira] [Commented] (HDFS-1108) Log newly allocated blocks

[ https://issues.apache.org/jira/browse/HDFS-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158156#comment-13158156 ] Eli Collins commented on HDFS-1108: --- Doesn't the test need to enable HA and shared edits

[jira] [Commented] (HDFS-2582) Scope dfs.ha.namenodes config by nameservice

[ https://issues.apache.org/jira/browse/HDFS-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158061#comment-13158061 ] Eli Collins commented on HDFS-2582: --- +1 to v4, the fix in the delta lgtm

[jira] [Commented] (HDFS-2291) HA: Checkpointing in an HA setup

[ https://issues.apache.org/jira/browse/HDFS-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158060#comment-13158060 ] Eli Collins commented on HDFS-2291: --- Agree that the SBN should be able to do checkpoints

[jira] [Commented] (HDFS-2591) HA: MiniDFSCluster support to mix and match federation with HA

[ https://issues.apache.org/jira/browse/HDFS-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158024#comment-13158024 ] Eli Collins commented on HDFS-2591: --- What you have so far looks good. If we end up creat

[jira] [Commented] (HDFS-2582) Scope dfs.ha.namenodes config by nameservice

[ https://issues.apache.org/jira/browse/HDFS-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158019#comment-13158019 ] Eli Collins commented on HDFS-2582: --- lgtm, +1 with the follow-on jiras. The code that us

[jira] [Commented] (HDFS-2582) Scope dfs.ha.namenodes config by nameservice

[ https://issues.apache.org/jira/browse/HDFS-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156260#comment-13156260 ] Eli Collins commented on HDFS-2582: --- You're proposed scheme makes sense to me. Perhaps t

[jira] [Commented] (HDFS-2577) HA: NN fails to start since it tries to start secret manager in safemode

[ https://issues.apache.org/jira/browse/HDFS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155704#comment-13155704 ] Eli Collins commented on HDFS-2577: --- +1 looks great. Need to do the LM change on trunk to

[jira] [Commented] (HDFS-2575) DFSTestUtil may create empty files

[ https://issues.apache.org/jira/browse/HDFS-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154058#comment-13154058 ] Eli Collins commented on HDFS-2575: --- +1 lgtm > DFSTestUtil may create em

[jira] [Commented] (HDFS-2572) Unnecessary double-check in DN#getHostName

[ https://issues.apache.org/jira/browse/HDFS-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153744#comment-13153744 ] Eli Collins commented on HDFS-2572: --- +1 nit: you can put the assignment and declaration

[jira] [Commented] (HDFS-2567) When 0 DNs are available, show a proper error when trying to browse DFS via web UI

[ https://issues.apache.org/jira/browse/HDFS-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153725#comment-13153725 ] Eli Collins commented on HDFS-2567: --- +1 Not sure the other methods need to check if we'

[jira] [Commented] (HDFS-2282) Semi-harmless race between block reports and block invalidation

[ https://issues.apache.org/jira/browse/HDFS-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153709#comment-13153709 ] Eli Collins commented on HDFS-2282: --- Looks like this was fixed in HDFS-2379.

[jira] [Commented] (HDFS-2541) For a sufficiently large value of blocks, the DN Scanner may request a random number with a negative seed value.

[ https://issues.apache.org/jira/browse/HDFS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153692#comment-13153692 ] Eli Collins commented on HDFS-2541: --- Good idea, please open a new ticket.

[jira] [Commented] (HDFS-2536) Remove unused imports

[ https://issues.apache.org/jira/browse/HDFS-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153675#comment-13153675 ] Eli Collins commented on HDFS-2536: --- I've committed this to trunk, leaving open for the p

[jira] [Commented] (HDFS-2567) When 0 DNs are available, show a proper error when trying to browse DFS via web UI

[ https://issues.apache.org/jira/browse/HDFS-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153673#comment-13153673 ] Eli Collins commented on HDFS-2567: --- Why not explicitly check if there are any available

[jira] [Commented] (HDFS-2430) The number of failed or low-resource volumes the NN can tolerate should be configurable

[ https://issues.apache.org/jira/browse/HDFS-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153672#comment-13153672 ] Eli Collins commented on HDFS-2430: --- Per HDFS-208 might be worth considering other warnin

[jira] [Commented] (HDFS-2502) hdfs-default.xml should include dfs.name.dir.restore

[ https://issues.apache.org/jira/browse/HDFS-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153657#comment-13153657 ] Eli Collins commented on HDFS-2502: --- Btw I removed the last bit of the comment about requ

[jira] [Commented] (HDFS-2502) hdfs-default.xml should include dfs.name.dir.restore

[ https://issues.apache.org/jira/browse/HDFS-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153656#comment-13153656 ] Eli Collins commented on HDFS-2502: --- +1test failure is unrelated > h

[jira] [Commented] (HDFS-2246) Shortcut a local client reads to a Datanodes files directly

[ https://issues.apache.org/jira/browse/HDFS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153387#comment-13153387 ] Eli Collins commented on HDFS-2246: --- What 205.1 deadline are you referring to? According

[jira] [Commented] (HDFS-2430) The number of failed or low-resource volumes the NN can tolerate should be configurable

[ https://issues.apache.org/jira/browse/HDFS-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153363#comment-13153363 ] Eli Collins commented on HDFS-2430: --- The api for NNResourcePolicy#areResourcesAvailable i

[jira] [Commented] (HDFS-2566) Move BPOfferService to be a non-inner class

[ https://issues.apache.org/jira/browse/HDFS-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153355#comment-13153355 ] Eli Collins commented on HDFS-2566: --- +1 lgtm > Move BPOfferService to be

[jira] [Commented] (HDFS-2559) Clean up Storage/StorageInfo classes after federation

[ https://issues.apache.org/jira/browse/HDFS-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153317#comment-13153317 ] Eli Collins commented on HDFS-2559: --- Maybe something more descriptive here? =) {code} i

[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts

[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153311#comment-13153311 ] Eli Collins commented on HDFS-2564: --- * Why not just remove the catch clause entirely from

[jira] [Commented] (HDFS-2563) Some cleanup in BPOfferService

[ https://issues.apache.org/jira/browse/HDFS-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153290#comment-13153290 ] Eli Collins commented on HDFS-2563: --- +1 lgtm Nit: lines 846 and 1267 can fold onto the p

[jira] [Commented] (HDFS-2562) Refactor DN configuration variables out of DataNode class

[ https://issues.apache.org/jira/browse/HDFS-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152581#comment-13152581 ] Eli Collins commented on HDFS-2562: --- Looks good. +1 pending hudson > Re

[jira] [Commented] (HDFS-2560) Refactor BPOfferService to be a static inner class

[ https://issues.apache.org/jira/browse/HDFS-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152505#comment-13152505 ] Eli Collins commented on HDFS-2560: --- Nope. Modulo removing the log, +1.

[jira] [Commented] (HDFS-2316) webhdfs: a complete FileSystem implementation for accessing HDFS over HTTP

[ https://issues.apache.org/jira/browse/HDFS-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152503#comment-13152503 ] Eli Collins commented on HDFS-2316: --- Nicholas / Tucu - see HADOOP-6585 for the rationale.

[jira] [Commented] (HDFS-2560) Refactor BPOfferService to be a static inner class

[ https://issues.apache.org/jira/browse/HDFS-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152193#comment-13152193 ] Eli Collins commented on HDFS-2560: --- +1 lgtm. Kick jenkins again? > Ref

[jira] [Commented] (HDFS-2541) For a sufficiently large value of blocks, the DN Scanner may request a random number with a negative seed value.

[ https://issues.apache.org/jira/browse/HDFS-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144741#comment-13144741 ] Eli Collins commented on HDFS-2541: --- +1 lgtm > For a sufficiently large

[jira] [Commented] (HDFS-2477) Optimize computing the diff between a block report and the namenode state.

[ https://issues.apache.org/jira/browse/HDFS-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143335#comment-13143335 ] Eli Collins commented on HDFS-2477: --- Hi Hairong, TestBlockInfo is in the patch but missi

[jira] [Commented] (HDFS-2533) Remove needless synchronization on FSDataSet.getBlockFile

[ https://issues.apache.org/jira/browse/HDFS-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142733#comment-13142733 ] Eli Collins commented on HDFS-2533: --- +1 new patch looks good. > Remove

[jira] [Commented] (HDFS-2129) Simplify BlockReader to not inherit from FSInputChecker

[ https://issues.apache.org/jira/browse/HDFS-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142713#comment-13142713 ] Eli Collins commented on HDFS-2129: --- +1 latest patch looks great > Sim

[jira] [Commented] (HDFS-2130) Switch default checksum to CRC32C

[ https://issues.apache.org/jira/browse/HDFS-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142693#comment-13142693 ] Eli Collins commented on HDFS-2130: --- Update looks good. > Switch default

[jira] [Commented] (HDFS-2129) Simplify BlockReader to not inherit from FSInputChecker

[ https://issues.apache.org/jira/browse/HDFS-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142651#comment-13142651 ] Eli Collins commented on HDFS-2129: --- @Todd, Spectacular! Patch looks good - comments fo

[jira] [Commented] (HDFS-2533) Remove needless synchronization on FSDataSet.getBlockFile

[ https://issues.apache.org/jira/browse/HDFS-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142522#comment-13142522 ] Eli Collins commented on HDFS-2533: --- +1 > Remove needless synchronizatio

[jira] [Commented] (HDFS-2525) Race between BlockPoolSliceScanner and append

[ https://issues.apache.org/jira/browse/HDFS-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142512#comment-13142512 ] Eli Collins commented on HDFS-2525: --- This patch should also update TestAppendDifferentChe

[jira] [Commented] (HDFS-2130) Switch default checksum to CRC32C

[ https://issues.apache.org/jira/browse/HDFS-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142476#comment-13142476 ] Eli Collins commented on HDFS-2130: --- After paging in the relevant info I think approach #

[jira] [Commented] (HDFS-2130) Switch default checksum to CRC32C

[ https://issues.apache.org/jira/browse/HDFS-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142445#comment-13142445 ] Eli Collins commented on HDFS-2130: --- Never mind, I see from looking at the patch that the

[jira] [Commented] (HDFS-2130) Switch default checksum to CRC32C

[ https://issues.apache.org/jira/browse/HDFS-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142438#comment-13142438 ] Eli Collins commented on HDFS-2130: --- Is the problem made simpler by disallowing appenders

[jira] [Commented] (HDFS-2526) (Client)NamenodeProtocolTranslatorR23 do not need to keep a reference to rpcProxyWithoutRetry

[ https://issues.apache.org/jira/browse/HDFS-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141359#comment-13141359 ] Eli Collins commented on HDFS-2526: --- +1 looks great. Test failures are unrelated.

[jira] [Commented] (HDFS-2308) NamenodeProtocol.endCheckpoint is vestigial and can be removed

[ https://issues.apache.org/jira/browse/HDFS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140816#comment-13140816 ] Eli Collins commented on HDFS-2308: --- New patch attached. > NamenodeProto

[jira] [Commented] (HDFS-2521) Remove custom checksum headers from data transfer protocol

[ https://issues.apache.org/jira/browse/HDFS-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140680#comment-13140680 ] Eli Collins commented on HDFS-2521: --- +1 pending hudson, patch looks great

[jira] [Commented] (HDFS-2512) Add textual error message to data transfer protocol responses

[ https://issues.apache.org/jira/browse/HDFS-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140549#comment-13140549 ] Eli Collins commented on HDFS-2512: --- +1 looks good > Add textual error

[jira] [Commented] (HDFS-2308) NamenodeProtocol.endCheckpoint is vestigial and can be removed

[ https://issues.apache.org/jira/browse/HDFS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140337#comment-13140337 ] Eli Collins commented on HDFS-2308: --- Test failures are unrelated, TestHDFSCLI locally yie

[jira] [Commented] (HDFS-2514) Link resolution bug for intermediate symlinks with relative targets

[ https://issues.apache.org/jira/browse/HDFS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139692#comment-13139692 ] Eli Collins commented on HDFS-2514: --- There's a bug in getResolvedPath for fully qualified

[jira] [Commented] (HDFS-2514) Link resolution bug for intermediate symlinks with relative targets

[ https://issues.apache.org/jira/browse/HDFS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139518#comment-13139518 ] Eli Collins commented on HDFS-2514: --- Here's a description of how link resolution works wh

[jira] [Commented] (HDFS-2465) Add HDFS support for fadvise readahead and drop-behind

[ https://issues.apache.org/jira/browse/HDFS-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138840#comment-13138840 ] Eli Collins commented on HDFS-2465: --- +1 latest patch lgtm > Add HDFS su

[jira] [Commented] (HDFS-2430) The number of failed or low-resource volumes the NN can tolerate should be configurable

[ https://issues.apache.org/jira/browse/HDFS-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137734#comment-13137734 ] Eli Collins commented on HDFS-2430: --- Agree that option #1 is better. The notion of a NN "

[jira] [Commented] (HDFS-2465) Add HDFS support for fadvise readahead and drop-behind

[ https://issues.apache.org/jira/browse/HDFS-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137718#comment-13137718 ] Eli Collins commented on HDFS-2465: --- bq. I don't think so. HDFS doesn't really do readahe

[jira] [Commented] (HDFS-2418) Change ConfiguredFailoverProxyProvider to take advantage of HDFS-2231

[ https://issues.apache.org/jira/browse/HDFS-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137692#comment-13137692 ] Eli Collins commented on HDFS-2418: --- +1 lgtm Nit: I'd include "RPC" in the method name o

[jira] [Commented] (HDFS-2507) HA: Allow saveNamespace operations to be canceled

[ https://issues.apache.org/jira/browse/HDFS-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137595#comment-13137595 ] Eli Collins commented on HDFS-2507: --- +1 looks great. Nit: no need to pass null to dirIt

[jira] [Commented] (HDFS-2465) Add HDFS support for fadvise readahead and drop-behind

[ https://issues.apache.org/jira/browse/HDFS-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137374#comment-13137374 ] Eli Collins commented on HDFS-2465: --- Looked at the patch, think this is a reasonable firs

[jira] [Commented] (HDFS-1900) Use the block size key defined by common

[ https://issues.apache.org/jira/browse/HDFS-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136166#comment-13136166 ] Eli Collins commented on HDFS-1900: --- I agree with Konst, we should remove the overlap bet

[jira] [Commented] (HDFS-2471) Add Federation feature, configuration and tools documentation

[ https://issues.apache.org/jira/browse/HDFS-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130853#comment-13130853 ] Eli Collins commented on HDFS-2471: --- This patch is all MR side changes, intentional?

[jira] [Commented] (HDFS-2472) Extend UnderReplicatedBlocks queue to give blocks whose existing copies are all on a single rack priority over multi-rack blocks

[ https://issues.apache.org/jira/browse/HDFS-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130846#comment-13130846 ] Eli Collins commented on HDFS-2472: --- Note that the code isn't toally un-rack aware, Unde

[jira] [Commented] (HDFS-1779) After NameNode restart , Clients can not read partial files even after client invokes Sync.

[ https://issues.apache.org/jira/browse/HDFS-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130805#comment-13130805 ] Eli Collins commented on HDFS-1779: --- Thanks Uma. I committed the fix to allow tests to ru

<    1   2   3   4