[jira] [Commented] (HDFS-3273) Refactor BackupImage and FSEditLog

2012-04-13 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253869#comment-13253869 ] Suresh Srinivas commented on HDFS-3273: --- +1 for the patch. Refactor

[jira] [Commented] (HDFS-119) logSync() may block NameNode forever.

2012-04-12 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253022#comment-13253022 ] Suresh Srinivas commented on HDFS-119: -- +1 for the patch. logSync()

[jira] [Commented] (HDFS-3196) Implement JournalListener for writing journal to local disk

2012-04-12 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253062#comment-13253062 ] Suresh Srinivas commented on HDFS-3196: --- Comments: # JournalDiskWriter #* Looks like

[jira] [Commented] (HDFS-3256) HDFS considers blocks under-replicated if topology script is configured with only 1 rack

2012-04-11 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252046#comment-13252046 ] Suresh Srinivas commented on HDFS-3256: --- Aaron, could you please describe the

[jira] [Commented] (HDFS-3257) Fix synchronization issues with journal service

2012-04-11 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252079#comment-13252079 ] Suresh Srinivas commented on HDFS-3257: --- Hari, JournalService RPC server runs using a

[jira] [Commented] (HDFS-3121) hdfs tests for HADOOP-8014

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247394#comment-13247394 ] Suresh Srinivas commented on HDFS-3121: --- I should wait for HADOOP-8014 to be

[jira] [Commented] (HDFS-3121) hdfs tests for HADOOP-8014

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247391#comment-13247391 ] Suresh Srinivas commented on HDFS-3121: --- +1 for the patch. I will commit it soon.

[jira] [Commented] (HDFS-3136) Multiple SLF4J binding warning

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247397#comment-13247397 ] Suresh Srinivas commented on HDFS-3136: --- +1. I will commit the patch soon.

[jira] [Commented] (HDFS-3202) NamespaceInfo PB translation drops build version

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247400#comment-13247400 ] Suresh Srinivas commented on HDFS-3202: --- bq. Suresh, if you feel strongly about

[jira] [Commented] (HDFS-3185) Setup configuration for Journal Manager and Journal Services

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247640#comment-13247640 ] Suresh Srinivas commented on HDFS-3185: --- +1 for the patch. I will commit this soon.

[jira] [Commented] (HDFS-3211) JournalProtocol changes required for introducing epoch and fencing

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247798#comment-13247798 ] Suresh Srinivas commented on HDFS-3211: --- bq. Hi Suresh. Have you looked at HDFS-3189?

[jira] [Commented] (HDFS-3211) JournalProtocol changes required for introducing epoch and fencing

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247814#comment-13247814 ] Suresh Srinivas commented on HDFS-3211: --- bq. You need to store the epoch persistently

[jira] [Commented] (HDFS-3212) Persist the epoch received by the JournalService

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247836#comment-13247836 ] Suresh Srinivas commented on HDFS-3212: --- There is some discussion in HDFS-3077 about

[jira] [Commented] (HDFS-3211) JournalProtocol changes required for introducing epoch and fencing

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247838#comment-13247838 ] Suresh Srinivas commented on HDFS-3211: --- Created HDFS-3212 for persisting epoch.

[jira] [Commented] (HDFS-3212) Persist the epoch received by the JournalService

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247880#comment-13247880 ] Suresh Srinivas commented on HDFS-3212: --- bq. I don't think it's reasonable to put the

[jira] [Commented] (HDFS-3178) Add states for journal synchronization in journal daemon

2012-04-05 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248068#comment-13248068 ] Suresh Srinivas commented on HDFS-3178: --- Yes. JournalService initial code was already

[jira] [Commented] (HDFS-3178) Add states for journal synchronization in journal daemon

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246058#comment-13246058 ] Suresh Srinivas commented on HDFS-3178: --- Nicholas, if you are going to check for all

[jira] [Commented] (HDFS-3192) Active NN should exit when it has not received a getServiceStatus() rpc from ZKFC for timeout secs

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246059#comment-13246059 ] Suresh Srinivas commented on HDFS-3192: --- Hari, agree with Aaron that this should not

[jira] [Commented] (HDFS-3121) hdfs tests for HADOOP-8014

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246724#comment-13246724 ] Suresh Srinivas commented on HDFS-3121: --- Comments: # Not very clear THis test is test

[jira] [Commented] (HDFS-3178) Add states for journal synchronization in journal daemon

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246832#comment-13246832 ] Suresh Srinivas commented on HDFS-3178: --- Adding it to the design document is a good

[jira] [Commented] (HDFS-3202) NamespaceInfo PB translation drops build version

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246936#comment-13246936 ] Suresh Srinivas commented on HDFS-3202: --- +1 for the patch. I think this is trivial

[jira] [Commented] (HDFS-3178) Add states for journal synchronization in journal daemon

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246969#comment-13246969 ] Suresh Srinivas commented on HDFS-3178: --- Minor comments: # For started state, RPC

[jira] [Commented] (HDFS-3178) Add states for journal synchronization in journal daemon

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246995#comment-13246995 ] Suresh Srinivas commented on HDFS-3178: --- bya = by a Add states for

[jira] [Commented] (HDFS-3199) TestValidateConfigurationSettings is failing

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247011#comment-13247011 ] Suresh Srinivas commented on HDFS-3199: --- Eli, can you add link to where this test is

[jira] [Commented] (HDFS-3150) Add option for clients to contact DNs via hostname in branch-1

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247020#comment-13247020 ] Suresh Srinivas commented on HDFS-3150: --- Given there are some discussions happening

[jira] [Commented] (HDFS-3199) TestValidateConfigurationSettings is failing

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247038#comment-13247038 ] Suresh Srinivas commented on HDFS-3199: --- Cool. Here is a failing test link:

[jira] [Commented] (HDFS-2998) OfflineImageViewer and ImageVisitor should be annotated public

2012-04-04 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247040#comment-13247040 ] Suresh Srinivas commented on HDFS-2998: --- I am not sure why these classes should be

[jira] [Commented] (HDFS-3148) The client should be able to use multiple local interfaces for data transfer

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245314#comment-13245314 ] Suresh Srinivas commented on HDFS-3148: --- Hey guys, can you do this work in a separate

[jira] [Commented] (HDFS-3092) Enable journal protocol based editlog streaming for standby namenode

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245346#comment-13245346 ] Suresh Srinivas commented on HDFS-3092: --- bq. Your design does not seem to consider

[jira] [Commented] (HDFS-3092) Enable journal protocol based editlog streaming for standby namenode

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245523#comment-13245523 ] Suresh Srinivas commented on HDFS-3092: --- bq. When you say three JDs, that's the

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245588#comment-13245588 ] Suresh Srinivas commented on HDFS-3077: --- Thanks for posting the design. Now I

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245771#comment-13245771 ] Suresh Srinivas commented on HDFS-3077: --- bq. Suresh seemed to think doing it on a

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245847#comment-13245847 ] Suresh Srinivas commented on HDFS-3077: --- bq. How can step 3 in section 2.4 be

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245850#comment-13245850 ] Suresh Srinivas commented on HDFS-3077: --- bq. so all nodes are now taking part in the

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245910#comment-13245910 ] Suresh Srinivas commented on HDFS-3077: --- For section 2.5.x, the document posted needs

[jira] [Commented] (HDFS-3148) The client should be able to use multiple local interfaces for data transfer

2012-04-03 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245954#comment-13245954 ] Suresh Srinivas commented on HDFS-3148: --- Eli, given it might be a few jiras, I agree

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-04-02 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244310#comment-13244310 ] Suresh Srinivas commented on HDFS-3077: --- I have posted a design document to

[jira] [Commented] (HDFS-3092) Enable journal protocol based editlog streaming for standby namenode

2012-04-02 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244361#comment-13244361 ] Suresh Srinivas commented on HDFS-3092: --- bq. Hi Suresh. I took a look at the design

[jira] [Commented] (HDFS-3092) Enable journal protocol based editlog streaming for standby namenode

2012-04-02 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244405#comment-13244405 ] Suresh Srinivas commented on HDFS-3092: --- bq. The situation here is at the beginning

[jira] [Commented] (HDFS-3092) Enable journal protocol based editlog streaming for standby namenode

2012-04-02 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1324#comment-1324 ] Suresh Srinivas commented on HDFS-3092: --- bq. Could I request that this work be done

[jira] [Commented] (HDFS-3092) Enable journal protocol based editlog streaming for standby namenode

2012-04-02 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244503#comment-13244503 ] Suresh Srinivas commented on HDFS-3092: --- bq. Could I request that this work be done

[jira] [Commented] (HDFS-3155) Clean up FSDataset implemenation related code.

2012-03-27 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240167#comment-13240167 ] Suresh Srinivas commented on HDFS-3155: --- Minor comment - weird formatting in

[jira] [Commented] (HDFS-3134) harden edit log loader against malformed or malicious input

2012-03-27 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240181#comment-13240181 ] Suresh Srinivas commented on HDFS-3134: --- bq. It's clear that we want these exceptions

[jira] [Commented] (HDFS-3125) Add a service that enables JournalDaemon

2012-03-26 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238611#comment-13238611 ] Suresh Srinivas commented on HDFS-3125: --- bq. The new patch needs to check state in

[jira] [Commented] (HDFS-3125) Add a service that enables JournalDaemon

2012-03-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236828#comment-13236828 ] Suresh Srinivas commented on HDFS-3125: --- Findbugs warning is unrelated to this change

[jira] [Commented] (HDFS-3125) Add a service that enable JournalDaemon

2012-03-21 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235018#comment-13235018 ] Suresh Srinivas commented on HDFS-3125: --- Yes. I plan to use this for BackupNode as

[jira] [Commented] (HDFS-3107) HDFS truncate

2012-03-20 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233768#comment-13233768 ] Suresh Srinivas commented on HDFS-3107: --- bq. I must have missed a smiley Thats okay.

[jira] [Commented] (HDFS-3086) Change Datanode not to send storage list in registration - it will be sent in block report

2012-03-20 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234080#comment-13234080 ] Suresh Srinivas commented on HDFS-3086: --- Patch looks good. +1.

[jira] [Commented] (HDFS-3105) Add DatanodeStorage information to block recovery

2012-03-19 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232737#comment-13232737 ] Suresh Srinivas commented on HDFS-3105: --- Comments: # Not sure how

[jira] [Commented] (HDFS-3105) Add DatanodeStorage information to block recovery

2012-03-19 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232873#comment-13232873 ] Suresh Srinivas commented on HDFS-3105: --- +1 for the patch. Add

[jira] [Commented] (HDFS-3107) HDFS truncate

2012-03-19 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233134#comment-13233134 ] Suresh Srinivas commented on HDFS-3107: --- bq. if a user mistakenly starts to append

[jira] [Commented] (HDFS-3087) Decomissioning on NN restart can complete without blocks being replicated

2012-03-15 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230357#comment-13230357 ] Suresh Srinivas commented on HDFS-3087: --- Kihwal, this is a good bug find. We should

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-03-15 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230629#comment-13230629 ] Suresh Srinivas commented on HDFS-3077: --- bq. but like Einstein said, no simpler! Its

[jira] [Commented] (HDFS-3077) Quorum-based protocol for reading and writing edit logs

2012-03-14 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229196#comment-13229196 ] Suresh Srinivas commented on HDFS-3077: --- Todd, as indicated yesterday, I have created

[jira] [Commented] (HDFS-1623) High Availability Framework for HDFS NN

2012-03-14 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229325#comment-13229325 ] Suresh Srinivas commented on HDFS-1623: --- Minutes from HDFS Namenode HA - Next Steps

[jira] [Commented] (HDFS-1623) High Availability Framework for HDFS NN

2012-03-14 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229715#comment-13229715 ] Suresh Srinivas commented on HDFS-1623: --- BTW in the meeting minutes, in list of

[jira] [Commented] (HDFS-3005) ConcurrentModificationException in FSDataset$FSVolume.getDfsUsed(..)

2012-03-14 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229811#comment-13229811 ] Suresh Srinivas commented on HDFS-3005: --- FSVolume is synchronized by FSDataset.

[jira] [Commented] (HDFS-3005) ConcurrentModificationException in FSDataset$FSVolume.getDfsUsed(..)

2012-03-14 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229838#comment-13229838 ] Suresh Srinivas commented on HDFS-3005: --- +1 for the change

[jira] [Commented] (HDFS-3056) Add an interface for DataBlockScanner logging

2012-03-09 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226701#comment-13226701 ] Suresh Srinivas commented on HDFS-3056: --- +1 for the patch. Add an

[jira] [Commented] (HDFS-3021) Use generic type to declare FSDatasetInterface

2012-03-01 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220243#comment-13220243 ] Suresh Srinivas commented on HDFS-3021: --- Comments (some unrelated to the changes made

[jira] [Commented] (HDFS-3034) Remove the deprecated Syncable.sync() method

2012-03-01 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220247#comment-13220247 ] Suresh Srinivas commented on HDFS-3034: --- +1 for the patch. Remove

[jira] [Commented] (HDFS-1623) High Availability Framework for HDFS NN

2012-02-28 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218397#comment-13218397 ] Suresh Srinivas commented on HDFS-1623: --- The difference between HA-on and HA-off is

[jira] [Commented] (HDFS-3004) Create Offline NameNode recovery tool

2012-02-28 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218416#comment-13218416 ] Suresh Srinivas commented on HDFS-3004: --- Colin, good writeup. Lets consider two

[jira] [Commented] (HDFS-3020) Auto-logSync based on edit log buffer size broken

2012-02-28 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218859#comment-13218859 ] Suresh Srinivas commented on HDFS-3020: --- Sounds good Auto-logSync

[jira] [Commented] (HDFS-3008) Negative caching of local addrs doesn't work

2012-02-24 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13215630#comment-13215630 ] Suresh Srinivas commented on HDFS-3008: --- +1 for the patch. Negative

[jira] [Commented] (HDFS-3009) DFSclient islocaladdress() can use similar routine in netutils

2012-02-24 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13215832#comment-13215832 ] Suresh Srinivas commented on HDFS-3009: --- +1. The code in method replacing the code is

[jira] [Commented] (HDFS-2978) The NameNode should expose name dir statuses via JMX

2012-02-24 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216101#comment-13216101 ] Suresh Srinivas commented on HDFS-2978: --- Minor comment - In NameNodeMXBean.java can

[jira] [Commented] (HDFS-3006) Webhdfs SETOWNER call returns incorrect content-type

2012-02-24 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216142#comment-13216142 ] Suresh Srinivas commented on HDFS-3006: --- Minor comment: One line in

[jira] [Commented] (HDFS-2978) The NameNode should expose name dir statuses via JMX

2012-02-24 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216221#comment-13216221 ] Suresh Srinivas commented on HDFS-2978: --- Exposing Strings and primitives is straight

[jira] [Commented] (HDFS-2995) start-dfs.sh tries to start 2NN everywhere

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214801#comment-13214801 ] Suresh Srinivas commented on HDFS-2995: --- Could this be related to HDFS-2893?

[jira] [Commented] (HDFS-2998) OfflineImageViewer and ImageVisitor should be annotated public

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214830#comment-13214830 ] Suresh Srinivas commented on HDFS-2998: --- bq. It's intended for subclassing, so it

[jira] [Commented] (HDFS-2998) OfflineImageViewer and ImageVisitor should be annotated public

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214885#comment-13214885 ] Suresh Srinivas commented on HDFS-2998: --- We could consider it making public. We

[jira] [Commented] (HDFS-3002) TestNameNodeMetrics need not wait for metrics update with new metrics framework

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214890#comment-13214890 ] Suresh Srinivas commented on HDFS-3002: --- In that jira, we are still adding wait time.

[jira] [Commented] (HDFS-2966) TestNameNodeMetrics tests can fail under load

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214891#comment-13214891 ] Suresh Srinivas commented on HDFS-2966: --- Steve, please see HDFS-3002 - comment

[jira] [Commented] (HDFS-3002) TestNameNodeMetrics need not wait for metrics update with new metrics framework

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214894#comment-13214894 ] Suresh Srinivas commented on HDFS-3002: --- After looking at the patch on HDFS-2966,

[jira] [Commented] (HDFS-2987) DNA_SHUTDOWN command is never sent by the NN

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214930#comment-13214930 ] Suresh Srinivas commented on HDFS-2987: --- I did consider removing it earlier but

[jira] [Commented] (HDFS-2978) The NameNode should expose name dir statuses as metrics

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214933#comment-13214933 ] Suresh Srinivas commented on HDFS-2978: --- One of the things that was done in 0.23

[jira] [Commented] (HDFS-3005) ConcurrentModificationException in FSDataset$FSVolume.getDfsUsed(..)

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13215048#comment-13215048 ] Suresh Srinivas commented on HDFS-3005: --- I added that comment when doing Federation

[jira] [Commented] (HDFS-2971) some improvements to the manual NN metadata recovery tools

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13215057#comment-13215057 ] Suresh Srinivas commented on HDFS-2971: --- bq. programmer using a hex editor, which is

[jira] [Commented] (HDFS-2987) DNA_SHUTDOWN command is never sent by the NN

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13215059#comment-13215059 ] Suresh Srinivas commented on HDFS-2987: --- It is fairly simple code and should work.

[jira] [Commented] (HDFS-3002) TestNameNodeMetrics need not wait for metrics update with new metrics framework

2012-02-23 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13215061#comment-13215061 ] Suresh Srinivas commented on HDFS-3002: --- The Thread.sleep() part and

[jira] [Commented] (HDFS-2971) some improvements to the manual NN metadata recovery tools

2012-02-22 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213870#comment-13213870 ] Suresh Srinivas commented on HDFS-2971: --- Sorry, I still have hard time understanding

[jira] [Commented] (HDFS-2971) some improvements to the manual NN metadata recovery tools

2012-02-22 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213943#comment-13213943 ] Suresh Srinivas commented on HDFS-2971: --- bq. The highest gen stamp in an image or log

[jira] [Commented] (HDFS-2978) The NameNode should expose name dir statuses as metrics

2012-02-21 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212680#comment-13212680 ] Suresh Srinivas commented on HDFS-2978: --- There is already JMX and HTTP based access

[jira] [Commented] (HDFS-2907) Make FSDataset in Datanode Pluggable

2012-02-21 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213082#comment-13213082 ] Suresh Srinivas commented on HDFS-2907: --- Comments: # DFSConfigKeys.java - move the

[jira] [Commented] (HDFS-2971) some improvements to the manual NN metadata recovery tools

2012-02-21 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213362#comment-13213362 ] Suresh Srinivas commented on HDFS-2971: --- Colin, can you please add little more

[jira] [Commented] (HDFS-2955) HA: IllegalStateException during standby startup in getCurSegmentTxId

2012-02-16 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209555#comment-13209555 ] Suresh Srinivas commented on HDFS-2955: --- @aaron - can you please add the test - which

[jira] [Commented] (HDFS-2938) Recursive delete of a large directory makes namenode unresponsive

2012-02-15 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208827#comment-13208827 ] Suresh Srinivas commented on HDFS-2938: --- Thanks for taking care of the nits - from

[jira] [Commented] (HDFS-2937) HA: TestDFSHAAdmin needs tests with MiniDFSCluster

2012-02-14 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207967#comment-13207967 ] Suresh Srinivas commented on HDFS-2937: --- Brandon, Mockito tests are testing client

[jira] [Commented] (HDFS-2815) Namenode is not coming out of safemode when we perform ( NN crash + restart ) . Also FSCK report shows blocks missed.

2012-02-13 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207463#comment-13207463 ] Suresh Srinivas commented on HDFS-2815: --- Changes only required for this issue, though

[jira] [Commented] (HDFS-2815) Namenode is not coming out of safemode when we perform ( NN crash + restart ) . Also FSCK report shows blocks missed.

2012-02-11 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206257#comment-13206257 ] Suresh Srinivas commented on HDFS-2815: --- bq. Linking HDFS-173, the patch that added

[jira] [Commented] (HDFS-2815) Namenode is not coming out of safemode when we perform ( NN crash + restart ) . Also FSCK report shows blocks missed.

2012-02-11 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206259#comment-13206259 ] Suresh Srinivas commented on HDFS-2815: --- Uma, +1 for the patch. Please do remove

[jira] [Commented] (HDFS-2586) Add protobuf service and implementation for HAServiceProtocol

2012-02-11 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206341#comment-13206341 ] Suresh Srinivas commented on HDFS-2586: --- Created a related jira HDFS-2937.

[jira] [Commented] (HDFS-2586) Add protobuf service and implementation for HAServiceProtocol

2012-02-10 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205777#comment-13205777 ] Suresh Srinivas commented on HDFS-2586: --- Aaron, if we cannot commit based on unit

[jira] [Commented] (HDFS-2586) Add protobuf service and implementation for HAServiceProtocol

2012-02-10 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205875#comment-13205875 ] Suresh Srinivas commented on HDFS-2586: --- Was that with security enabled or not?

[jira] [Commented] (HDFS-2802) Support for RW/RO snapshots in HDFS

2012-02-10 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206019#comment-13206019 ] Suresh Srinivas commented on HDFS-2802: --- Jeff, that is the reason why hdfs-233 is

[jira] [Commented] (HDFS-2887) Define a FSVolume interface

2012-02-08 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203941#comment-13203941 ] Suresh Srinivas commented on HDFS-2887: --- Change make the code much cleaner. Comments:

[jira] [Commented] (HDFS-2887) Define a FSVolume interface

2012-02-08 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203953#comment-13203953 ] Suresh Srinivas commented on HDFS-2887: --- +1 for the patch. Define a

[jira] [Commented] (HDFS-2911) Gracefully handle OutOfMemoryErrors

2012-02-08 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204235#comment-13204235 ] Suresh Srinivas commented on HDFS-2911: --- bq. @Eli ... as Todd points out not all OOMs

[jira] [Commented] (HDFS-2922) HA: close out operation categories

2012-02-08 Thread Suresh Srinivas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204273#comment-13204273 ] Suresh Srinivas commented on HDFS-2922: --- I agree with Todd. We should treat

  1   2   3   >