[jira] [Commented] (HDFS-4882) Namenode LeaseManager checkLeases() runs into infinite loop

2014-11-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215089#comment-14215089 ] Jing Zhao commented on HDFS-4882: - bq. Is there any reason we can't simply recover the leas

[jira] [Comment Edited] (HDFS-4882) Namenode LeaseManager checkLeases() runs into infinite loop

2014-11-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215089#comment-14215089 ] Jing Zhao edited comment on HDFS-4882 at 11/17/14 8:04 PM: --- bq. I

[jira] [Commented] (HDFS-4882) Namenode LeaseManager checkLeases() runs into infinite loop

2014-11-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215486#comment-14215486 ] Jing Zhao commented on HDFS-4882: - For the scenario 3 I think we can keep the current behav

[jira] [Commented] (HDFS-7413) Some unit tests should use NameNodeProtocols instead of FSNameSystem

2014-11-19 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218863#comment-14218863 ] Jing Zhao commented on HDFS-7413: - Thanks for the cleanup, Haohui! +1. But looks like the

[jira] [Commented] (HDFS-7413) Some unit tests should use NameNodeProtocols instead of FSNameSystem

2014-11-20 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219716#comment-14219716 ] Jing Zhao commented on HDFS-7413: - +1 for the latest patch. > Some unit tests should use N

[jira] [Commented] (HDFS-7420) Delegate permission checks to FSDirectory

2014-11-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221224#comment-14221224 ] Jing Zhao commented on HDFS-7420: - Thanks for working on this, [~wheat9]! And thanks for th

[jira] [Commented] (HDFS-7420) Delegate permission checks to FSDirectory

2014-11-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221254#comment-14221254 ] Jing Zhao commented on HDFS-7420: - Since the change is small, I guess we can skip another J

[jira] [Commented] (HDFS-7412) Move RetryCache to NameNodeRpcServer

2014-11-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221340#comment-14221340 ] Jing Zhao commented on HDFS-7412: - Looks like in our current implementation we have two pat

[jira] [Commented] (HDFS-7412) Move RetryCache to NameNodeRpcServer

2014-11-24 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223270#comment-14223270 ] Jing Zhao commented on HDFS-7412: - The latest patch looks good to me. +1 > Move RetryCache

[jira] [Commented] (HDFS-7435) PB encoding of block reports is very inefficient

2014-11-24 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223314#comment-14223314 ] Jing Zhao commented on HDFS-7435: - Can we also use some blocked arrays (and each block with

[jira] [Commented] (HDFS-7435) PB encoding of block reports is very inefficient

2014-11-24 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223560#comment-14223560 ] Jing Zhao commented on HDFS-7435: - I've seen some cluster generating block report each cont

[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class

2014-11-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225094#comment-14225094 ] Jing Zhao commented on HDFS-7440: - The patch looks good to me. One small suggestion is that

[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class

2014-11-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225363#comment-14225363 ] Jing Zhao commented on HDFS-7440: - With the change now FSNamesystem#removeBlocks is moved i

[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class

2014-11-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225608#comment-14225608 ] Jing Zhao commented on HDFS-7440: - The latest patch looks good to me. +1 pending Jenkins.

[jira] [Updated] (HDFS-7435) PB encoding of block reports is very inefficient

2014-11-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7435: Attachment: HDFS-7435.000.patch Uploading a demo patch (based on Daryn's patch) for chunking. Still need to d

[jira] [Commented] (HDFS-7435) PB encoding of block reports is very inefficient

2014-11-26 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226567#comment-14226567 ] Jing Zhao commented on HDFS-7435: - In the current demo patch the max chunk size is not enco

[jira] [Commented] (HDFS-7444) convertToBlockUnderConstruction should preserve BlockCollection

2014-11-26 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226584#comment-14226584 ] Jing Zhao commented on HDFS-7444: - +1. Thanks for the fix, [~wheat9]! > convertToBlockUnde

[jira] [Commented] (HDFS-7310) Mover can give first priority to local DN if it has target storage type available in local DN

2014-11-26 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226665#comment-14226665 ] Jing Zhao commented on HDFS-7310: - Oops sorry I missed this jira... Thanks Uma for the revi

[jira] [Updated] (HDFS-7435) PB encoding of block reports is very inefficient

2014-11-26 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7435: Attachment: HDFS-7435.001.patch Fix a bug in the demo patch. > PB encoding of block reports is very ineffici

[jira] [Commented] (HDFS-7438) Consolidate implementation of rename()

2014-12-01 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230689#comment-14230689 ] Jing Zhao commented on HDFS-7438: - Thanks for working on this, [~wheat9]! and thanks for th

[jira] [Commented] (HDFS-7450) Consolidate GetFileInfo, GetListings and GetContentSummary into a single class

2014-12-01 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230840#comment-14230840 ] Jing Zhao commented on HDFS-7450: - Looks like the latest patch misses the comment from [~cl

[jira] [Created] (HDFS-7474) Avoid resolve path in FSPermissionChecker

2014-12-04 Thread Jing Zhao (JIRA)
Jing Zhao created HDFS-7474: --- Summary: Avoid resolve path in FSPermissionChecker Key: HDFS-7474 URL: https://issues.apache.org/jira/browse/HDFS-7474 Project: Hadoop HDFS Issue Type: Improvement

[jira] [Updated] (HDFS-7474) Avoid resolve path in FSPermissionChecker

2014-12-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7474: Status: Patch Available (was: Open) > Avoid resolve path in FSPermissionChecker > --

[jira] [Updated] (HDFS-7474) Avoid resolve path in FSPermissionChecker

2014-12-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7474: Attachment: HDFS-7474.000.patch Initial patch. Also include some changes to avoid unnecessary path resolving

[jira] [Updated] (HDFS-7474) Avoid resolve path in FSPermissionChecker

2014-12-05 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7474: Attachment: HDFS-7474.001.patch Rebase the patch. > Avoid resolve path in FSPermissionChecker >

[jira] [Updated] (HDFS-7474) Avoid resolving path in FSPermissionChecker

2014-12-05 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7474: Summary: Avoid resolving path in FSPermissionChecker (was: Avoid resolve path in FSPermissionChecker) > Avo

[jira] [Updated] (HDFS-7474) Avoid resolving path in FSPermissionChecker

2014-12-05 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7474: Resolution: Fixed Fix Version/s: 2.7.0 Hadoop Flags: Reviewed Status: Resolved (was: P

[jira] [Commented] (HDFS-7459) Consolidate cache-related implementation in FSNamesystem into a single class

2014-12-05 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236271#comment-14236271 ] Jing Zhao commented on HDFS-7459: - Thanks for working on this, Haohui! And thanks for the r

[jira] [Commented] (HDFS-7486) Consolidate XAttr-related implementation into a single class

2014-12-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238344#comment-14238344 ] Jing Zhao commented on HDFS-7486: - The patch looks good to me. +1 One minor is that with a

[jira] [Created] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-08 Thread Jing Zhao (JIRA)
Jing Zhao created HDFS-7498: --- Summary: Simplify the logic in INodesInPath Key: HDFS-7498 URL: https://issues.apache.org/jira/browse/HDFS-7498 Project: Hadoop HDFS Issue Type: Improvement

[jira] [Updated] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7498: Attachment: HDFS-7498.000.patch Initial patch. > Simplify the logic in INodesInPath > --

[jira] [Updated] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7498: Attachment: (was: HDFS-7498.000.patch) > Simplify the logic in INodesInPath > ---

[jira] [Updated] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7498: Component/s: namenode > Simplify the logic in INodesInPath > -- > >

[jira] [Updated] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7498: Target Version/s: 2.7.0 Status: Patch Available (was: Open) > Simplify the logic in INodesInPa

[jira] [Updated] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7498: Attachment: HDFS-7498.000.patch > Simplify the logic in INodesInPath > -- > >

[jira] [Commented] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-09 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239807#comment-14239807 ] Jing Zhao commented on HDFS-7498: - Looks like the test failures of TestRenameWithSnapshots

[jira] [Commented] (HDFS-7463) Simplify FSNamesystem#getBlockLocationsUpdateTimes

2014-12-09 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239881#comment-14239881 ] Jing Zhao commented on HDFS-7463: - The patch looks good to me. Some comments: # {{resolvePa

[jira] [Commented] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-09 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239896#comment-14239896 ] Jing Zhao commented on HDFS-7498: - Thanks for the review, Haohui! bq. Is it accidental? N

[jira] [Updated] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-09 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7498: Resolution: Fixed Fix Version/s: 2.7.0 Hadoop Flags: Reviewed Status: Resolved (was: P

[jira] [Updated] (HDFS-6376) Distcp data between two HA clusters requires another configuration

2014-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-6376: Assignee: Dave Marion (was: Michael Wall) > Distcp data between two HA clusters requires another configurati

[jira] [Commented] (HDFS-5578) [JDK8] Fix Javadoc errors caused by incorrect or illegal tags in doc comments

2014-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241880#comment-14241880 ] Jing Zhao commented on HDFS-5578: - +1 for the rebased patch. > [JDK8] Fix Javadoc errors c

[jira] [Commented] (HDFS-7463) Simplify FSNamesystem#getBlockLocationsUpdateTimes

2014-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241997#comment-14241997 ] Jing Zhao commented on HDFS-7463: - +1 for the latest patch. > Simplify FSNamesystem#getBlo

[jira] [Created] (HDFS-7508) Clean up path resolving in FSNamesystem/FSDirectory

2014-12-10 Thread Jing Zhao (JIRA)
Jing Zhao created HDFS-7508: --- Summary: Clean up path resolving in FSNamesystem/FSDirectory Key: HDFS-7508 URL: https://issues.apache.org/jira/browse/HDFS-7508 Project: Hadoop HDFS Issue Type: Impro

[jira] [Updated] (HDFS-7474) Avoid resolving path in FSPermissionChecker

2014-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7474: Issue Type: Sub-task (was: Improvement) Parent: HDFS-7508 > Avoid resolving path in FSPermissionChec

[jira] [Updated] (HDFS-7498) Simplify the logic in INodesInPath

2014-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7498: Issue Type: Sub-task (was: Improvement) Parent: HDFS-7508 > Simplify the logic in INodesInPath > ---

[jira] [Created] (HDFS-7509) Avoid resolving path multiple times in rename/mkdir

2014-12-10 Thread Jing Zhao (JIRA)
Jing Zhao created HDFS-7509: --- Summary: Avoid resolving path multiple times in rename/mkdir Key: HDFS-7509 URL: https://issues.apache.org/jira/browse/HDFS-7509 Project: Hadoop HDFS Issue Type: Sub-t

[jira] [Updated] (HDFS-7509) Avoid resolving path multiple times in rename/mkdir

2014-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7509: Attachment: HDFS-7509.000.patch Initial patch for review. The patch mainly avoids redundant path resolving fo

[jira] [Updated] (HDFS-7509) Avoid resolving path multiple times in rename/mkdir

2014-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7509: Status: Patch Available (was: Open) > Avoid resolving path multiple times in rename/mkdir >

[jira] [Updated] (HDFS-7509) Avoid resolving path multiple times in rename/mkdir

2014-12-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7509: Attachment: HDFS-7509.001.patch Thanks for the comments [~clamb] and [~wheat9]! Update the patch to fix test

[jira] [Commented] (HDFS-7509) Avoid resolving path multiple times in rename/mkdir

2014-12-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243386#comment-14243386 ] Jing Zhao commented on HDFS-7509: - bq. In #unprotectedRenameTo, why tx.dstIIP instead of ju

[jira] [Updated] (HDFS-7509) Avoid resolving path multiple times in rename/mkdir

2014-12-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7509: Attachment: HDFS-7509.002.patch Thanks again for the review, Charles! Update the patch to fix the typo. > Av

[jira] [Commented] (HDFS-7506) Consolidate implementation of setting inode attributes into a single class

2014-12-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1420#comment-1420 ] Jing Zhao commented on HDFS-7506: - The patch looks pretty good to me. One minor comment is

[jira] [Commented] (HDFS-7517) Remove redundant non-null checks in {{FSNamesystem#getBlockLocations}}

2014-12-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244465#comment-14244465 ] Jing Zhao commented on HDFS-7517: - +1 > Remove redundant non-null checks in {{FSNamesystem

[jira] [Updated] (HDFS-7509) Avoid resolving path multiple times in rename/mkdir

2014-12-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7509: Attachment: HDFS-7509.003.patch Actually I just found that there are not a lot of remaining places that still

[jira] [Updated] (HDFS-7509) Avoid resolving path multiple times

2014-12-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7509: Summary: Avoid resolving path multiple times (was: Avoid resolving path multiple times in rename/mkdir) > A

[jira] [Updated] (HDFS-7509) Avoid resolving path multiple times

2014-12-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7509: Resolution: Fixed Fix Version/s: 2.7.0 Hadoop Flags: Reviewed Status: Resolved (was: P

[jira] [Commented] (HDFS-7506) Consolidate implementation of setting inode attributes into a single class

2014-12-15 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246975#comment-14246975 ] Jing Zhao commented on HDFS-7506: - +1 > Consolidate implementation of setting inode attrib

[jira] [Assigned] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-15 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao reassigned HDFS-7484: --- Assignee: Jing Zhao (was: Haohui Mai) > Simplify the workflow of calculating permission in mkdirs() >

[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-15 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Attachment: HDFS-7484.004.patch Continue the work of Haohui. Based on the 003 patch, add a new method {{INod

[jira] [Created] (HDFS-7535) Utilize Snapshot diff report for distcp

2014-12-16 Thread Jing Zhao (JIRA)
Jing Zhao created HDFS-7535: --- Summary: Utilize Snapshot diff report for distcp Key: HDFS-7535 URL: https://issues.apache.org/jira/browse/HDFS-7535 Project: Hadoop HDFS Issue Type: Improvement

[jira] [Commented] (HDFS-7535) Utilize Snapshot diff report for distcp

2014-12-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248896#comment-14248896 ] Jing Zhao commented on HDFS-7535: - A typical scenario using snapshot for distcp can be like

[jira] [Updated] (HDFS-7535) Utilize Snapshot diff report for distcp

2014-12-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7535: Attachment: HDFS-7535.000.patch Upload a very initial patch to demo the functionality. The patch adds new op

[jira] [Updated] (HDFS-7535) Utilize Snapshot diff report for distcp

2014-12-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7535: Component/s: snapshots distcp > Utilize Snapshot diff report for distcp > --

[jira] [Commented] (HDFS-7543) Avoid path resolution when getting FileStatus for audit logs

2014-12-18 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252079#comment-14252079 ] Jing Zhao commented on HDFS-7543: - Thanks for working on this, Haohui! The patch looks good

[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-18 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Attachment: HDFS-7484.005.patch Update the patch to fix bugs. In general the current patch also contains cha

[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-18 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Attachment: HDFS-7484.006.patch Refactor the code more to let {{FSDirectory#addINode}} return an INodesInPath

[jira] [Commented] (HDFS-3107) HDFS truncate

2014-12-18 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252766#comment-14252766 ] Jing Zhao commented on HDFS-3107: - Yeah, I will review the latest patch in HDFS-7056 today

[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-19 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Attachment: HDFS-7484.007.patch > Simplify the workflow of calculating permission in mkdirs() > -

[jira] [Commented] (HDFS-7056) Snapshot support for truncate

2014-12-19 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254385#comment-14254385 ] Jing Zhao commented on HDFS-7056: - Some comments so far. I will continue reviewing this wee

[jira] [Comment Edited] (HDFS-7056) Snapshot support for truncate

2014-12-19 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254385#comment-14254385 ] Jing Zhao edited comment on HDFS-7056 at 12/20/14 12:57 AM: Som

[jira] [Commented] (HDFS-7056) Snapshot support for truncate

2014-12-19 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254471#comment-14254471 ] Jing Zhao commented on HDFS-7056: - maybe something like the following? I wrote it in a hur

[jira] [Updated] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-22 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Attachment: HDFS-7484.008.patch > Simplify the workflow of calculating permission in mkdirs() > -

[jira] [Commented] (HDFS-7484) Simplify the workflow of calculating permission in mkdirs()

2014-12-22 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256057#comment-14256057 ] Jing Zhao commented on HDFS-7484: - Now the patch's mainly focusing on making {{FSDirectory#

[jira] [Updated] (HDFS-7484) Make FSDirectory#addINode take existing INodes as its parameter

2014-12-22 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Summary: Make FSDirectory#addINode take existing INodes as its parameter (was: Simplify the workflow of calc

[jira] [Updated] (HDFS-7484) Make FSDirectory#addINode take existing INodes as its parameter

2014-12-22 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Description: Currently {{FSDirectory#addLastINode}} takes an INodesInPath instance, which uses null elements

[jira] [Updated] (HDFS-7484) Make FSDirectory#addINode take existing INodes as its parameter

2014-12-22 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Attachment: HDFS-7484.009.patch > Make FSDirectory#addINode take existing INodes as its parameter > -

[jira] [Commented] (HDFS-7056) Snapshot support for truncate

2014-12-22 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256374#comment-14256374 ] Jing Zhao commented on HDFS-7056: - Some further comments: # In {{FileDiffList#combineAndCol

[jira] [Updated] (HDFS-7484) Make FSDirectory#addINode take existing INodes as its parameter

2014-12-22 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7484: Resolution: Fixed Fix Version/s: 2.7.0 Hadoop Flags: Reviewed Status: Resolved (was: P

[jira] [Commented] (HDFS-7567) Potential null dereference in FSEditLogLoader#applyEditLogOp()

2014-12-23 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257753#comment-14257753 ] Jing Zhao commented on HDFS-7567: - Normally we will not hit any QuotaExceededException whil

[jira] [Updated] (HDFS-3689) Add support for variable length block

2014-12-23 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-3689: Assignee: Jing Zhao (was: Suresh Srinivas) Status: Patch Available (was: Open) > Add support for vari

[jira] [Updated] (HDFS-3689) Add support for variable length block

2014-12-23 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-3689: Attachment: HDFS-3689.002.patch Rebase the patch. > Add support for variable length block >

[jira] [Commented] (HDFS-7435) PB encoding of block reports is very inefficient

2015-03-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357666#comment-14357666 ] Jing Zhao commented on HDFS-7435: - Thanks for updating the patch, Daryn. The latest patch l

[jira] [Commented] (HDFS-7435) PB encoding of block reports is very inefficient

2015-03-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357734#comment-14357734 ] Jing Zhao commented on HDFS-7435: - nit-pick: # s/blocksBuffer/blocksBuf/ in the javadoc {co

[jira] [Commented] (HDFS-7369) Erasure coding: distribute block recovery work to DataNode

2015-03-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357774#comment-14357774 ] Jing Zhao commented on HDFS-7369: - Thanks for working on this, Zhe! The patch looks good to

[jira] [Commented] (HDFS-7285) Erasure Coding Support inside HDFS

2015-03-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357832#comment-14357832 ] Jing Zhao commented on HDFS-7285: - Thanks for the summary, Zhe! One question for the EC po

[jira] [Commented] (HDFS-7068) Support multiple block placement policies

2015-03-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357845#comment-14357845 ] Jing Zhao commented on HDFS-7068: - I'm also +1 for #1. > Support multiple block placement

[jira] [Commented] (HDFS-7854) Separate class DataStreamer out of DFSOutputStream

2015-03-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358106#comment-14358106 ] Jing Zhao commented on HDFS-7854: - Thanks for the response, Bo. For 5&6, after separating D

[jira] [Comment Edited] (HDFS-7854) Separate class DataStreamer out of DFSOutputStream

2015-03-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358106#comment-14358106 ] Jing Zhao edited comment on HDFS-7854 at 3/12/15 5:14 AM: -- Thanks

[jira] [Updated] (HDFS-7898) Change TestAppendSnapshotTruncate to fail-fast

2015-03-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7898: Affects Version/s: 2.7.0 > Change TestAppendSnapshotTruncate to fail-fast > -

[jira] [Commented] (HDFS-7936) Erasure coding: resolving conflicts when merging with HDFS-7903 and HDFS-7435

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363949#comment-14363949 ] Jing Zhao commented on HDFS-7936: - Hi Zhe, let me know if you need any help on this. > Era

[jira] [Commented] (HDFS-7936) Erasure coding: resolving conflicts when merging with HDFS-7903 and HDFS-7435

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363950#comment-14363950 ] Jing Zhao commented on HDFS-7936: - Sure. I will assign the jira to me. > Erasure coding: r

[jira] [Assigned] (HDFS-7936) Erasure coding: resolving conflicts when merging with HDFS-7903 and HDFS-7435

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao reassigned HDFS-7936: --- Assignee: Jing Zhao (was: Zhe Zhang) > Erasure coding: resolving conflicts when merging with HDFS-790

[jira] [Resolved] (HDFS-7936) Erasure coding: resolving conflicts when merging with HDFS-7903 and HDFS-7435

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved HDFS-7936. - Resolution: Fixed Fix Version/s: HDFS-7285 Hadoop Flags: Reviewed I've committed this. > Erasu

[jira] [Commented] (HDFS-7936) Erasure coding: resolving conflicts when merging with HDFS-7903 and HDFS-7435

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363984#comment-14363984 ] Jing Zhao commented on HDFS-7936: - Hi Zhe, your patch looks good to me. Thanks for the fix!

[jira] [Updated] (HDFS-7936) Erasure coding: resolving conflicts when merging with HDFS-7903 and HDFS-7435

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-7936: Assignee: Zhe Zhang (was: Jing Zhao) > Erasure coding: resolving conflicts when merging with HDFS-7903 and H

[jira] [Commented] (HDFS-7878) API - expose an unique file identifier

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364067#comment-14364067 ] Jing Zhao commented on HDFS-7878: - bq. Colin wrote: if the client makes two different call

[jira] [Comment Edited] (HDFS-7827) Erasure Coding: support striped blocks in non-protobuf fsimage

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364100#comment-14364100 ] Jing Zhao edited comment on HDFS-7827 at 3/16/15 10:31 PM: --- Curre

[jira] [Commented] (HDFS-7827) Erasure Coding: support striped blocks in non-protobuf fsimage

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364100#comment-14364100 ] Jing Zhao commented on HDFS-7827: - Currently we still have non-protobuf image for offline p

[jira] [Commented] (HDFS-7829) Code clean up for LocatedBlock

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364144#comment-14364144 ] Jing Zhao commented on HDFS-7829: - Sorry for the late response, [~tasanuma0829]. For {{Loc

[jira] [Commented] (HDFS-7826) Erasure Coding: Update INodeFile quota computation for striped blocks

2015-03-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364171#comment-14364171 ] Jing Zhao commented on HDFS-7826: - Thanks Kai! Only one comment remaining: In {{storagespac

<    6   7   8   9   10   11   12   13   14   15   >