[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Wednesday 09 September 2009 schrieb Ryan Sleevi: Ok, so a sleepless night later, and I've got a rough-and-tumble feels-like-a-hack just-learned-cmake build on Win32 going up. Lots of CMake hacking. Makes me miss SCons, Gyp, and qmake, all of which I find less frustrating :) Much

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Ryan Sleevi
-Original Message- From: hugin-ptx@googlegroups.com [mailto:hugin-...@googlegroups.com] On Behalf Of Kornel Benko Sent: Wednesday, September 09, 2009 9:02 AM To: hugin-ptx@googlegroups.com Subject: [hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Ryan Sleevi: I try to correct Kornel The flag OpenMP_FOUND doesn't really matter as much, at least not in the code. Not in the code, but you introduced it in src/CMakeLists.txt. And there it matters. All that matters is whether or not _OPENMP

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Ryan Sleevi
Hrm... The flow is supposed to go: CMakeLists.txt IF(ENABLE_OPENMP) find_package(OpenMP REQUIRED) add_definitions(${OpenMP_CXX_FLAGS}) ENDIF(ENABLE_OPENMP) This calls CMakeModules/FindOpenMP.cmake, which as the second-to-last execution, runs

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Ryan Sleevi: This calls CMakeModules/FindPackageHandleStandardArgs.cmake, which will set OpenMP_FOUND if both OpenMP_C_FLAGS and OpenMP_CXX_FLAGS are defined. And exactly here seems something not correct. I have this code: find_package(OpenMP REQUIRED)

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Found it. The package defines OPENMP_FOUND. Should have known ... Kornel -- Kornel Benko kornel.be...@berlin.de signature.asc Description: This is a digitally signed message part.

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Harry van der Wolf
Hi all, Here are the results from the OSX jury. OpenMP is not an issue as it is not available on OSX (apart from some extremely bleeding edge source packages) enblend via cmake compiles and works now too on OSX. however, on doing some tests I had some shocking results. enblend pre 4.0 via

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Harry van der Wolf: Hi all, Here are the results from the OSX jury. OpenMP is not an issue as it is not available on OSX (apart from some extremely bleeding edge source packages) enblend via cmake compiles and works now too on OSX. however, on doing

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Harry van der Wolf
2009/9/9 Kornel Benko kornel.be...@berlin.de Am Mittwoch 09 September 2009 schrieb Harry van der Wolf: The autoconf version is almost 10X faster! Harry I see. 1.) In this version we are not optimizing 2.) We are using FindLibraryWithDebug.cmake Kornel Well, Some debugging

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Harry van der Wolf: Well, Some debugging statement was exactly what I was looking for but I couldn't find it so I assumed (incorrectly) that I was in Release mode or so. Where is this being set? I am searching too ... Kornel -- Kornel Benko

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Kornel Benko: Am Mittwoch 09 September 2009 schrieb Harry van der Wolf: Well, Some debugging statement was exactly what I was looking for but I couldn't find it so I assumed (incorrectly) that I was in Release mode or so. Where is this being set? I

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Ryan Sleevi
FindLibraryWithDebug is safe for Release calls. It's just a special handler for Windows platforms that tend to have libraries with debug file suffices (and with my modifications, also handles situations where x86 and x64 libs are side-by-side, sharing 1 include dir, but having their own unique

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Ryan Sleevi: FindLibraryWithDebug is safe for Release calls. It's just a special handler for Windows platforms that tend to have libraries with debug file suffices (and with my modifications, also handles situations where x86 and x64 libs are side-by-side,

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Harry van der Wolf
What is missing now, is the control from command line for this. Since we don't have the same cmake-base we should search for some way to exchage changes only. The version here is mostly your modified version with corrections from me. Should we really be forced to send each time all the

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Ryan Sleevi
Seconded - any further modifications should happen in the repo. I'm holding off on my 'cleanup' of my additions/macros until the code can at least be based there From: hugin-ptx@googlegroups.com [mailto:hugin-...@googlegroups.com] On Behalf Of Harry van der Wolf Sent: Wednesday, September

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Harry van der Wolf
2009/9/9 Harry van der Wolf hvdw...@gmail.com Hi all, Here are the results from the OSX jury. OpenMP is not an issue as it is not available on OSX (apart from some extremely bleeding edge source packages) enblend via cmake compiles and works now too on OSX. however, on doing some tests I

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Harry van der Wolf
2009/9/9 Harry van der Wolf hvdw...@gmail.com Soory: should say. Now the results are slightly better than the previous autoconf version. /usr/local/bin/enblend --version enblend 4.0-11ca5b567bc9 And: should say. /usr/bin/time /usr/local/bin/enblend --gpu -o pipo.jpg 1222-02*.tif enblend:

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Ryan Sleevi: Seconded - any further modifications should happen in the repo. I'm holding off on my 'cleanup' of my additions/macros until the code can at least be based there Thanks, so will I. Having a base, it will easy to check if someone's

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Harry van der Wolf: 2009/9/9 Harry van der Wolf hvdw...@gmail.com Soory: should say. Now the results are slightly better than the previous autoconf version. At least not shocking anymore :) Kornel -- Kornel Benko kornel.be...@berlin.de

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Pablo d'Angelo
Kornel Benko wrote: Am Mittwoch 09 September 2009 schrieb Ryan Sleevi: As you indicated in your follow-up, the CMAKE_BUILD_TYPE is what controls whether or not the compiler is set to be optimized for release mode. For the Windows platforms, all the build types are exported into a

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Pablo d'Angelo: What is missing now, is the control from command line for this. Do you mean: cmake -DCMAKE_BUILD_TYPE=Release Yes, I know. But I prefer something which will be more recognised. And which will print some suggestions. Like this one (in

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Yuval Levy
Ryan Sleevi wrote: Seconded - any further modifications should happen in the repo. I'm holding off the time-out is over. thanks to Andrew who has changed the way the project is administered. Full steam ahead! Yuv --~--~-~--~~~---~--~~ You received this

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Ryan Sleevi
Kornel, At the lowest level, you can always MESSAGE(STATUS Message) so IF(${SOME_FLAG}) MESSAGE(STATUS Project will be built with some_flag disabled. If you prefer to build without some_flag support, you

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Harry van der Wolf
2009/9/9 Yuval Levy goo...@levy.ch Harry van der Wolf wrote: OpenMP is not an issue as it is not available on OSX (apart from some extremely bleeding edge source packages) bummer! I guess you know about http://hpc.sourceforge.net/ ? Yuv Yes, I know it. He does a good job but it

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Kornel Benko
Am Mittwoch 09 September 2009 schrieb Ryan Sleevi: Kornel, At the lowest level, you can always MESSAGE(STATUS Message) Ryan, I knew all of this. I only said, its missing at the moment. And as we agreed, no change until all things are in the repo. so

[hugin-ptx] Re: cmake compilation of enblend [was: Enblend bug tracker and developer mailing list]

2009-09-09 Thread Yuval Levy
Harry van der Wolf wrote: Fortunately there is a great community of enblend builders on OSX :-( (I think I'm currently the only one as others use my builds also in their bundles/plugins and so on.). no intention to put pressure on you. you actually laid out a pretty nice and clear plan. I